[jira] [Commented] (THRIFT-4364) Website contributing guide erroneously recommends submitting patches in JIRA

2017-10-19 Thread Jens Geyer (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211572#comment-16211572
 ] 

Jens Geyer commented on THRIFT-4364:


The term "errorneously" is probably a bit too strong. I don't remember that we 
agreed upon forbidding patches via JIRA by law, consensus or any other method. 
So although PRs are preferred, patches are still an option, not an "error".

> Website contributing guide erroneously recommends submitting patches in JIRA
> 
>
> Key: THRIFT-4364
> URL: https://issues.apache.org/jira/browse/THRIFT-4364
> Project: Thrift
>  Issue Type: Bug
>  Components: Documentation, Website
>Reporter: Neia Neutuladh
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> https://thrift.apache.org/docs/HowToContribute
> The first recommended way to submit patches is through JIRA. I've been told 
> to resubmit patches as pull requests.
> CONTRIBUTING.md seems to be more thorough and up to date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (THRIFT-4364) Website contributing guide erroneously recommends submitting patches in JIRA

2017-10-19 Thread James E. King, III (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211292#comment-16211292
 ] 

James E. King, III commented on THRIFT-4364:


I went through the whole process and published but it isn't live yet.  I'm sure 
it'll pop up soon.
There's a new language feature matrix in the docs section.

> Website contributing guide erroneously recommends submitting patches in JIRA
> 
>
> Key: THRIFT-4364
> URL: https://issues.apache.org/jira/browse/THRIFT-4364
> Project: Thrift
>  Issue Type: Bug
>  Components: Documentation, Website
>Reporter: Neia Neutuladh
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> https://thrift.apache.org/docs/HowToContribute
> The first recommended way to submit patches is through JIRA. I've been told 
> to resubmit patches as pull requests.
> CONTRIBUTING.md seems to be more thorough and up to date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (THRIFT-4364) Website contributing guide erroneously recommends submitting patches in JIRA

2017-10-19 Thread James E. King, III (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211241#comment-16211241
 ] 

James E. King, III commented on THRIFT-4364:


If you look at CONTRIBUTING.md in the repo it recommends pull requests, however 
I cannot get the web site generator to regenerate this file.  I've tried 3 
times. :/

> Website contributing guide erroneously recommends submitting patches in JIRA
> 
>
> Key: THRIFT-4364
> URL: https://issues.apache.org/jira/browse/THRIFT-4364
> Project: Thrift
>  Issue Type: Bug
>  Components: Documentation, Website
>Reporter: Neia Neutuladh
>
> https://thrift.apache.org/docs/HowToContribute
> The first recommended way to submit patches is through JIRA. I've been told 
> to resubmit patches as pull requests.
> CONTRIBUTING.md seems to be more thorough and up to date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (THRIFT-4364) Website contributing guide erroneously recommends submitting patches in JIRA

2017-10-19 Thread Konrad Grochowski (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211249#comment-16211249
 ] 

Konrad Grochowski commented on THRIFT-4364:
---

try adding space to the page which includes `CONTRIBUTING.md` ;)

> Website contributing guide erroneously recommends submitting patches in JIRA
> 
>
> Key: THRIFT-4364
> URL: https://issues.apache.org/jira/browse/THRIFT-4364
> Project: Thrift
>  Issue Type: Bug
>  Components: Documentation, Website
>Reporter: Neia Neutuladh
>
> https://thrift.apache.org/docs/HowToContribute
> The first recommended way to submit patches is through JIRA. I've been told 
> to resubmit patches as pull requests.
> CONTRIBUTING.md seems to be more thorough and up to date.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)