[jira] [Commented] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397369#comment-16397369
 ] 

ASF GitHub Bot commented on THRIFT-4429:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1485


> Make TThreadPoolServer.executorService_ available in inherited classes and 
> refactor methods to be able customization
> 
>
> Key: THRIFT-4429
> URL: https://issues.apache.org/jira/browse/THRIFT-4429
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.11.0
>Reporter: Dmitry Volodin
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.12.0
>
>
> In some cases (for example in Apache Camel component for Thrift) there is a 
> requirement, when it is necessary not only to transfer executorService from 
> the external system through the Args in TThreadPoolServer , but to organize 
> control them from outside. In this case, it's possible to create a class 
> which is inherited from TThreadPoolServer, but not possible to access invoker 
> in overloaded method.
> Also a good approach to split main execution code to the several methods to 
> be able to invoke them separately in appropriate sequence.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397365#comment-16397365
 ] 

ASF GitHub Bot commented on THRIFT-4429:


Github user dmvolod commented on the issue:

https://github.com/apache/thrift/pull/1485
  
Thanks a lot for review.


> Make TThreadPoolServer.executorService_ available in inherited classes and 
> refactor methods to be able customization
> 
>
> Key: THRIFT-4429
> URL: https://issues.apache.org/jira/browse/THRIFT-4429
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.11.0
>Reporter: Dmitry Volodin
>Priority: Minor
>
> In some cases (for example in Apache Camel component for Thrift) there is a 
> requirement, when it is necessary not only to transfer executorService from 
> the external system through the Args in TThreadPoolServer , but to organize 
> control them from outside. In this case, it's possible to create a class 
> which is inherited from TThreadPoolServer, but not possible to access invoker 
> in overloaded method.
> Also a good approach to split main execution code to the several methods to 
> be able to invoke them separately in appropriate sequence.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378172#comment-16378172
 ] 

ASF GitHub Bot commented on THRIFT-4429:


Github user dmvolod commented on the issue:

https://github.com/apache/thrift/pull/1485
  
@jeking3 , could you please to look at this PR.
Thanks in advance.


> Make TThreadPoolServer.executorService_ available in inherited classes and 
> refactor methods to be able customization
> 
>
> Key: THRIFT-4429
> URL: https://issues.apache.org/jira/browse/THRIFT-4429
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.11.0
>Reporter: Dmitry Volodin
>Priority: Minor
>
> In some cases (for example in Apache Camel component for Thrift) there is a 
> requirement, when it is necessary not only to transfer executorService from 
> the external system through the Args in TThreadPoolServer , but to organize 
> control them from outside. In this case, it's possible to create a class 
> which is inherited from TThreadPoolServer, but not possible to access invoker 
> in overloaded method.
> Also a good approach to split main execution code to the several methods to 
> be able to invoke them separately in appropriate sequence.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344718#comment-16344718
 ] 

ASF GitHub Bot commented on THRIFT-4429:


GitHub user dmvolod opened a pull request:

https://github.com/apache/thrift/pull/1485

THRIFT-4429: Make TThreadPoolServer.executorService_ available in inherited 
classes and refactor methods to be able customization

Plus some classes cleanup from unused imports

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dmvolod/thrift THRIFT-4429

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1485


commit 63d30a0f4882ad60a399481e168759b7d293c33e
Author: Dmitry Volodin 
Date:   2018-01-30T09:09:36Z

THRIFT-4429: Make TThreadPoolServer.executorService_ available in
inherited classes and refactor methods to be able customization




> Make TThreadPoolServer.executorService_ available in inherited classes and 
> refactor methods to be able customization
> 
>
> Key: THRIFT-4429
> URL: https://issues.apache.org/jira/browse/THRIFT-4429
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.11.0
>Reporter: Dmitry Volodin
>Priority: Minor
>
> In some cases (for example in Apache Camel component for Thrift) there is a 
> requirement, when it is necessary not only to transfer executorService from 
> the external system through the Args in TThreadPoolServer , but to organize 
> control them from outside. In this case, it's possible to create a class 
> which is inherited from TThreadPoolServer, but not possible to access invoker 
> in overloaded method.
> Also a good approach to split main execution code to the several methods to 
> be able to invoke them separately in appropriate sequence.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)