[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383968#comment-16383968
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1412


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383963#comment-16383963
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
I updated the ubuntu-artful image to SBCL 1.4.4 and it seems to be stable.  
Merging.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381460#comment-16381460
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Best I can tell there seems to be some sort of timing or logic error.  
Builds will randomly fail after writing a fasl, apparently renaming it, then 
being unable to find it.  This is the "ubsan" build job which runs "make 
precross":

https://api.travis-ci.org/v3/job/347498508/log.txt

```
; compiling (DEF-STRUCT "structb" ...)
; compiling (DEF-SERVICE "ThriftTest" ...)
; compiling (DEF-SERVICE "SecondService" ...)
; 
/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl
 written
; compilation finished in 0:00:06.905
```

then immediately after:
```
Unhandled SB-INT:SIMPLE-FILE-ERROR in thread #:
  Failed to find the TRUENAME of 
/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl:
No such file or directory

Backtrace for: #
0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK #" {1002AFF8E3}> #)
1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #" {1002AFF8E3}>)
2: (INVOKE-DEBUGGER #" 
{1002AFF8E3}>)
3: (ERROR SB-INT:SIMPLE-FILE-ERROR :PATHNAME 
#P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl"
 :FORMAT-CONTROL "~@<~?: ~2I~_~A~:>" :FORMAT-ARGUMENTS ("Failed to find the 
TRUENAME of ~A" 
(#P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl")
 "No such file or directory"))
4: ((LABELS SB-IMPL::RESOLVE-PROBLEMATIC-SYMLINK :IN 
SB-IMPL::QUERY-FILE-SYSTEM) NIL)
5: (SB-IMPL::QUERY-FILE-SYSTEM 
#P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl"
 :TRUENAME T)
6: (TRUENAME 
#P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl")
7: (RENAME-FILE 
#P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types-TMP.fasl"
 
#P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types.fasl")
8: (UIOP/LISP-BUILD:COMPILE-FILE* 
#P"/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types.lisp" :OUTPUT-FILE 
#P"/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/test/cl/gen-cl/ThriftTest/ThriftTest-types.fasl"
 :EXTERNAL-FORMAT :UTF-8 :WARNINGS-FILE NIL)
9: (ASDF/LISP-ACTION:PERFORM-LISP-COMPILATION # #)
10: ((SB-PCL::EMF ASDF/ACTION:PERFORM) # 
# # 
#)
11: ((:METHOD ASDF/ACTION:PERFORM-WITH-RESTARTS :AROUND (T T)) 
# #) [fast-method]
12: ((:METHOD ASDF/PLAN:PERFORM-PLAN (LIST)) 
((#1=# . #) (#1# . 
#) (#1# . #) (#1# . #) (#1# . 
#) (#1# . #) (#1# . #) (#1# . 
#) (#2=# . 
#) (#2# . 
#4=#) (#1# . #4#) 
(# . #4#) ...) :FORCE NIL) [fast-method]
13: ((FLET SB-C::WITH-IT :IN SB-C::%WITH-COMPILATION-UNIT))
14: ((:METHOD ASDF/PLAN:PERFORM-PLAN :AROUND (T)) 
((#1=# . #) (#1# . 
#) (#1# . #) (#1# . #) (#1# . 
#) (#1# . #) (#1# . #) (#1# . 
#) (#2=# . 
#) (#2# . 
#4=#) (#1# . #4#) 
(# . #4#) ...)) [fast-method]
15: ((FLET SB-C::WITH-IT :IN SB-C::%WITH-COMPILATION-UNIT))
16: ((:METHOD ASDF/PLAN:PERFORM-PLAN :AROUND (T)) 
#) [fast-method]
17: ((:METHOD ASDF/OPERATE:OPERATE (ASDF/OPERATION:OPERATION 
ASDF/COMPONENT:COMPONENT)) # #) [fast-method]
18: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) # # # #)
19: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
20: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) 
# #) 
[fast-method]
21: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) # # ASDF/LISP-ACTION:LOAD-OP :THRIFT-GEN-THRIFTTEST)
22: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
23: (ASDF/CACHE:CALL-WITH-ASDF-CACHE # :OVERRIDE NIL :KEY NIL)
24: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP 
:THRIFT-GEN-THRIFTTEST) [fast-method]
25: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP 
:THRIFT-GEN-THRIFTTEST) [fast-method]
26: (ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST)
27: (SB-INT:SIMPLE-EVAL-IN-LEXENV (ASDF/OPERATE:LOAD-SYSTEM 
:THRIFT-GEN-THRIFTTEST) #)
28: (EVAL-TLF (ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST) 6 NIL)
29: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE) 
(ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST) 6)
30: ((LAMBDA (SB-KERNEL:FORM  :CURRENT-INDEX ) :IN 
SB-INT:LOAD-AS-SOURCE) (ASDF/OPERATE:LOAD-SYSTEM :THRIFT-GEN-THRIFTTEST) 
:CURRENT-INDEX 6)
31: (SB-C::%DO-FORMS-FROM-INFO # 
# SB-C::INPUT-ERROR-IN-LOAD)
32: (SB-INT:LOAD-AS-SOURCE # :VERBOSE NIL :PRINT 
NIL :CONTEXT 

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381082#comment-16381082
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
I ran the cross test in ubuntu-artful using your PR and only ttwo 
unexpected failures occurred:
```

===
*** Following 2 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.

===
server-client:  protocol: transport:   result:
d-clbinarybuffered-ip  
failure(1)
d-clbinaryframed-ip
failure(1)
```

I think we're good to go.  I will change the cross test to use the artful 
image (and disable those two tests explicitly for now), now that artful has 
haxe enabled again, it has as many languages as the xenial image does.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380974#comment-16380974
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Thanks, I am working on running this in my local docker container and 
checking the "make cross" results.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361928#comment-16361928
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Rebased.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343539#comment-16343539
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Sorry I have been working on some other things - I will try to get back 
around to this as soon as I can.  It's important to the project to have as many 
languages supported as possible.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343221#comment-16343221
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Rebased.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343185#comment-16343185
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Basically SBCL 1.3.14 (artful) works fine locally on Docker (and 1.3.1 had 
a bug with base strings according to SBCL devs - xenial). So the problem is 
probably something on environment hosting docker. I've noticed that some 
languages doesn't have docker tests enabled at all, if this problem persists is 
it acceptable to skip it for CL too?

@jeking3 can you try running tests on Docker on your host locally to 
confirm that? What steps do you suggest in order to move forward?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335997#comment-16335997
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
* Fixed an issue with UTF-8 encoded `.lisp` files in docker
* Updated `LANGUAGES.md`
* Tested with SBCL 1.3.14 thoroughly - it should work. SBCL 1.3.1 probably 
still won't, though.
* Added tests that fail against CL to known tests
* Squashed and rebased


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335616#comment-16335616
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Could it be that `docker` sets a "fresh" environment for each command? SBCL 
keeps its cache files in ~/.cache/common-lisp and it looks like docker either 
runs commands as different users or that it wipes / fakes the home directory as 
a fresh one.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335611#comment-16335611
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@jeking3 I managed to find other problems while trying to run this stuff on 
my local machine in the docker, regardless of SBCL version. I'm trying to look 
into that for now. I'll let you know if I have anything. There's probably no 
sense having you do what you described until then.

Right now Xenial succeeds because apparently @dkochmanski removed SBCL from 
the dockerfile for it.

Curiously, I don't locally have the problem you can see in the [failed 
Artful job](https://travis-ci.org/apache/thrift/jobs/328740544). Do you have 
any idea how to debug this? Looks like compiler first writes a file and then is 
unable to open it.

```
; 
/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/tutorial/cl/gen-cl/shared/shared-types-TMP.fasl
 written
; compilation finished in 0:00:00.188
Unhandled SB-INT:SIMPLE-FILE-ERROR in thread #:
  Failed to find the TRUENAME of 
/root/.cache/common-lisp/sbcl-1.3.14.debian-linux-x64/thrift/src/tutorial/cl/gen-cl/shared/shared-types-TMP.fasl:
No such file or directory
```


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334636#comment-16334636
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Currently "make cross" builds on Xenial and it will probably stay that way 
for a while.

It would be acceptable to use a different version, either from an ubuntu 
PPA or just downloading and building it as part of the docker image setup.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326970#comment-16326970
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@dkochmanski I confirmed I get the issue locally on SBCL 1.3.1, but 1.3.14 
works fine.

@jeking3 I don't think we can fix the issue with SBCL 1.3.1 (easily), as it 
seems like either Quicklisp or one of the library it pulls causes that, not the 
code we maintain. Would it be fine to just use Artful? Or do you need it to 
build on Xenial specifically for Travis integration?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326408#comment-16326408
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Okay if we need to then let's have the docker build pull down the latest 
SBCL, build and install it into /usr/local?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326277#comment-16326277
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@dkochmanski I think it might be, sadly, compiler specific. I don't know 
about you, but I only ever ran this on a newer version of SBCL. But the 
warnings SBCL gives in Docker can probably be ignored.

While I think there was some kind of file transport (or UDS?), I never 
tested it. I wouldn't put it down unless we know it works. We don't have the 
compact protocol. We have simple server, not non-blocking.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325496#comment-16325496
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
It seems that SBCL has some problems when ran in docker (investigating that 
– sadly I can't reproduce this problem on my local machine). I'll install SBCL 
1.3.1 on my machine to make 100% sure it is docker-specific. I'll let you know 
when I know more (and/or resolve the issue).


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325288#comment-16325288
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
and one more change: ensure-externals uses `[[` syntax, so it must be run 
with bash (not sh) – modified makefile and script to take this requirement into 
account.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325284#comment-16325284
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@jeking3 Thanks for the pointers. I've added requested info and updated 
Dockerfiles. Also rebased against master.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324523#comment-16324523
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@dkochmanski 

Need the following things to happen:

1. resolve the merge conflict
2. install sbcl in the ubuntu-xenial and ubuntu-artful Dockerfiles
3. update LANGUAGES.md
4. update build/docker/README.md with the versions that are in the 
distributions.  Xenial uses SBCL 1.3.1 and Artful has 1.3.14
5. we need to see a clean build so I would recommend rebasing on the 
current master before you push

Once lisp is part of the docker images then "make check" and "make cross" 
will exercise it with every build.

Thanks,

Jim


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324147#comment-16324147
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Let me know what the commands are to add lisp to an Ubuntu Xenial system.  
We need to update the Dockerfile to include Common Lisp so that it actually 
runs in the build system.  This has to happen before we commit.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311422#comment-16311422
 ] 

James E. King, III commented on THRIFT-82:
--

I am going to start the process of committing this.  I need to discover the 
versions of lisp we test with so the LANGUAGES.md file can be updated.

> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[Jens Geyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282353#comment-16282353
 ] 

Jens Geyer commented on THRIFT-82:
--

Bad timing, but there will be a 0.12.0. I'm happy enough we have this one this 
far.

> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280882#comment-16280882
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
I won't lie, this feels good! Thanks a lot for the extensive support.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280363#comment-16280363
 ] 

James E. King, III commented on THRIFT-82:
--

The 0.11.0 release cycle started before this was ready; I would love to see 
this get into 0.11.0 but I think it might be too late, so I am marking it for 
0.12.0.  We're going to go more frequent releases than we have in the past few 
years however, given we've added one more release manager.

[~jensg] if there's a way to pull this into 0.11.0, please consider it.  I've 
marked it as 0.12.0 planned for now.

> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Fix For: 0.12.0
>
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279721#comment-16279721
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Of course. Squashed.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278618#comment-16278618
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
I will take another look.  Can you squash this into a single commit to 
prepare it for inclusion if it looks good?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278531#comment-16278531
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@jeking3 I'm really sorry, I only noticed there were suggested changes 
attached to your comment after I did a force push. I can't see them anymore. Do 
you remember if there was anything important there?

I removed the CL Thrift library and made it so that it's downloaded during 
the building process. I think all the code that is left is either written by us 
(cross-tests, tutorial, build integration, etc.) or isn't an issue (code 
generator).

Currently we download the library from our fork of Anderson's work by 
downloading (curl) the zip file from github and unzipping it. The long-term 
goal, though, is to merge our fork with upstream and get it added to quicklisp. 
After that we can just download the library in a similar way we download all 
the dependencies.

I used that suggested bash snippet from the closed PR. It worked nicely.

What do you think? Is this PR fine in its current shape?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278308#comment-16278308
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint commented on the issue:

https://github.com/apache/thrift/pull/1412
  
* Rebased and resolved merge conflicts
* Fixed some minor issues with `make clean` and dependencies
* Added (newly) failing tests to `known_failures_Linux.json`


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272059#comment-16272059
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
I have sent an email to the two participants for which permission is needed 
to move copyright statements in order to comply with the Apache licensing 
requirements.  I asked them to each post either acceptance or rejection here 
for the record.

Once we have their answers we can proceed to whatever the next step will 
be.  Without permission the bulk of the code may have to live in some other 
repository, untouched, and downloaded as part of the build process.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265356#comment-16265356
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@dkochmanski still waiting for @jfarrell to chime in since he was going to 
take some actions.  I provided him with an email that could be used to contact 
the author(s) involved, but I haven't heard anything since that.  My preference 
would be to get permission to build the cl implementation for thrift into the 
thrift project rather than have it sitting external.

If the cl part of the project is going to sit external then we'll likely 
need to consider it a "contrib/" type of submission where it is maintained 
external to the project.  That doesn't sound like a good long term solution for 
adding a language to the collection.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265047#comment-16265047
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
any update on this? I'm fine with both options (given all parties agree on 
them) and have time to work on code forward.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253439#comment-16253439
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@jfarrell was going to take action either on contacting individuals or 
making decisions on this, so I'm waiting to see what the result of those 
efforts is.  I would much prefer the cl code for thrift be in the thrift 
project itself and not hosted somewhere else.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251919#comment-16251919
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user adxpx commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Just confirming that I'm  here and excited to see this make progress. 
Thanks!


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251917#comment-16251917
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
Good news, I have consent from @pc to change the header of the generator to 
match contributor guidelines. So next steps are:

- merge changes to de.setf.thrift repository (so missing protocols are 
implemented)
- publish de.setf.thrift on Quicklisp
- adjust this pull request for Common Lisp inclusion

should I close this pull request for now, or leave it as is until then?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251348#comment-16251348
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
After email exchange with Mr. Anderson I've came to conclusion that we 
should first put thrift CL library in Quicklisp (we already download 
dependencies from there) and pull the library from there. In this scenario 
lib/cl will have only Makefile and some tests. That way there is no problem 
with copyrights. As of tutorial part and cross tests, they are written by us, 
so there shouldn't be any issue with that.

Tutorial code is written by us, same goes for cross tests. My only concern 
is about t_cl_generator.cc file from compiler/ module, which has yet another 
copyright owner, original PR THRIFT-82 issuer 
(https://issues.apache.org/jira/browse/THRIFT-82) Mr. Patrick Collison: 
https://issues.apache.org/jira/secure/attachment/12386027/thrift-cl.patch . 
Should I write to him? His GH handle is @pc, but he doesn't seem to be very 
active here lately.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248135#comment-16248135
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
My take on the Apache licensing rules is that we cannot accept this if it 
has other copyrights in it:
```
If the source file is submitted with a copyright notice included in it, the 
copyright owner (or owner's agent) must either:
* remove such notices, or
* move them to the NOTICE file associated with each applicable project 
release, or
* provide written permission for the ASF to make such removal or relocation 
of the notices.
```
If Mr. Anderson would provide the ASF with written permission to move the 
copyright statements into a NOTICE.md file within lib/cl that would be 
sufficient for inclusion in the project.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244193#comment-16244193
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
The bottom line is this: under the law of where mr. Anderson lives he can't 
yield the IP rights nor he sees a reason to do so, so we can't remove the 
copyrights put by him there. Code is licensed under the same license as the 
Thrift code though.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244154#comment-16244154
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1410
  
Hello, I've send you an email a few hours ago with a question, if we can 
remove your "copyright" headers from the code found in de.setf.thrift, because 
that is what is required by Thrift team (I have included details in the email). 
Plese see: https://github.com/apache/thrift/pull/1410#discussion_r149655532 .


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244139#comment-16244139
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user lisp commented on the issue:

https://github.com/apache/thrift/pull/1410
  
good evening; this popped up in my mail due to  mr kochmanski's reference.
what are you waiting for from me?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244096#comment-16244096
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1412
  
squashed and rebased on top of the thrift master head.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244120#comment-16244120
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1410
  
see https://github.com/apache/thrift/pull/1412


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244094#comment-16244094
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

GitHub user dkochmanski opened a pull request:

https://github.com/apache/thrift/pull/1412

[THRIFT-82] Add Common Lisp support

There's framed and buffered socket transport, binary protocol, multiplex, 
simple
server, cross-tests, self-tests, tutorial, CL library, CL code generator. 
Only
SBCL is supported for now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TurtleWarePL/thrift develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1412


commit c5f8973b32bcf251fa2cc9a83fedd01000148ef8
Author: Tomek Kurcz 
Date:   2017-09-19T07:16:43Z

[THRIFT-82] Add Common Lisp support

There's framed and buffered socket transport, binary protocol, multiplex, 
simple
server, cross-tests, self-tests, tutorial, CL library, CL code generator. 
Only
SBCL is supported for now.




> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244086#comment-16244086
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user uint closed the pull request at:

https://github.com/apache/thrift/pull/1410


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244084#comment-16244084
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1410
  
closing, will reopen with squashed commits.



> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244047#comment-16244047
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1410
  
Let's follow @jfarrell 's lead.  Whatever he says, he's managing the travis 
interaction.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244007#comment-16244007
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1410
  
@jfarrell logged into travis a moment ago for the first time.

@jeking3 I'm waiting for a response from @lisp if we can remove his 
copyright strings (we've removed ours). Should I close the PR and issue a new 
one before I receive a reply?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243993#comment-16243993
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1410
  
Why don't we close this PR and open a new one free of any copyright issues 
or inclusion of third party code.  That should resolve the issue?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243989#comment-16243989
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jfarrell commented on the issue:

https://github.com/apache/thrift/pull/1410
  
@dkochmanski Travis support responded saying that no one from TurtleWarePL 
has logged into https://travis-ci.org/ ever and this is the reason this PR is 
not getting run within travis. 

From Travis support:

> do you think one of their members could try to log into Travis CI at 
least once at https://travis-ci.org/ and try closing and reopen one of the 
rejected Pull Requests?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243842#comment-16243842
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149660082
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

I've send an email to Mr. Anderson – will let you know when / if I receive 
a reply. No, it is not possible, our work takes his repository[1] as base for 
further adjustments to meet the contribution requirements (missing protocols 
etc).

[1] https://github.com/lisp/de.setf.thrift


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243811#comment-16243811
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jfarrell commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149655532
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

That would be great. is it possible fetch his work as a third party 
downloadable dependency or was it used as the basis for work you did on top of 
it?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243490#comment-16243490
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149592614
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

Right, thank you for pointing me to the document. Last commit removes all 
copyrights added by us. Note though, that files in lib/cl/ are based on work by 
James Anderson (and have copyrights as well) and I don't think I can remove 
them. Should I contact him and ask whenever we can remove his copyright stings 
too?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242918#comment-16242918
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jfarrell commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149508723
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

@dkochmanski thank you for working on this and contributing it back the the 
Apache Thrift. The Apache license header on this should not contain a copyright 
to Rigetti Computing, details available at 
https://www.apache.org/legal/src-headers.html#headers part 2


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242884#comment-16242884
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149504639
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

Well, the term "sponsored" is a bit broad to derive that particular 
conclusion from it. So I asked for further clarification.  



> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242791#comment-16242791
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149489770
  
--- Diff: lib/cl/server.lisp ---
@@ -0,0 +1,230 @@
+(in-package #:org.apache.thrift.implementation)
--- End diff --

it is a common practice in Common Lisp to have a package dedicated for 
usage by a programmer (which exports the protocol symbols - library API that 
is) and having no other symbols of its own and an implementation package which 
may have other internal symbols and interfaces. This allows avoiding for 
instance symbol name conflicts (for instance list vs list).


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242788#comment-16242788
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149489004
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

Rigetti hired us to implement (and possibly merge) CL support to Thrift. 
All software under this delivery has to have license required by the project we 
are contributing to (that is Thrift). Not sure what is strange about that.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242803#comment-16242803
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149491753
  
--- Diff: lib/cl/ensure-externals.sh ---
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+set -e
+
+if [ ! -d "externals/" ] ; then
--- End diff --

it is possible. Fixed in the pushed commit (some extra eval forms are 
explained in the commit message.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242696#comment-16242696
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1410
  
@jfarrell: What's your opinion re the (c) things above?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242692#comment-16242692
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149475953
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

> Our work on Thrift is sponsored by Rigetti, so there is no need for that.

That sounds ... strange.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242506#comment-16242506
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jfarrell commented on the issue:

https://github.com/apache/thrift/pull/1410
  
Travis requests show an error with "Abuse detected". I've emailed Travis 
support asking them to look into the issue


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242484#comment-16242484
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149446200
  
--- Diff: lib/cl/ensure-externals.sh ---
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+set -e
+
+if [ ! -d "externals/" ] ; then
--- End diff --

What happens if externals are partially populated due to a crash?  Can one 
run the same quicklisp command idempotently?  If so, I would remove this if 
statement and just always run quicklisp to make sure externals are correct.  
You could perhaps make the curl command smarter to only update the file if it 
has changed - I suspect curl has an option for that, but I don't know...


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242486#comment-16242486
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1410
  
Without a linux build, won't be able to do any merges...


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242483#comment-16242483
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149446453
  
--- Diff: lib/cl/server.lisp ---
@@ -0,0 +1,230 @@
+(in-package #:org.apache.thrift.implementation)
--- End diff --

Does one need the ".implementation" in the namespace?


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240969#comment-16240969
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user dkochmanski commented on the issue:

https://github.com/apache/thrift/pull/1410
  
Hey, removed all externals and added `ensure-externals.sh` script. Also 
squashed all commits.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238938#comment-16238938
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1410
  
I think it would be better to make a shell script that downloads quicklisp 
and runs it to install the dependencies, and make the local build in lib/cl 
depend on successful execution of the shell script.  This makes it similar to 
the nodejs build which runs npm to do something similar, however the only 
difference is that npm is installed as part of the docker build.
.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
>Priority: Major
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237642#comment-16237642
 ] 

James E. King, III commented on THRIFT-82:
--

[~jfarrell] consider adding "Common Lisp - Compiler" and "Common Lisp - 
Library" to the components list when finished.

> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Priority: Major
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237624#comment-16237624
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1410
  
Some initial thoughts, before I review all of the files individually:

1. Please squash.
2. Please add [THRIFT-82] at the beginning of the commit description and 
the pull request description.
3. Please review https://thrift.apache.org/docs/HowToContribute.

I resurrected https://issues.apache.org/jira/browse/THRIFT-82 upon seeing 
this.  I'll start going through the files.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Priority: Major
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-82) Common Lisp support

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237622#comment-16237622
 ] 

James E. King, III commented on THRIFT-82:
--

A pull request was submitted today implementing Common Lisp support so I am 
reopening this.
https://github.com/apache/thrift/pull/1410

> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Priority: Major
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)