[jira] [Updated] (THRIFT-1769) unions can't have required fields (C++)

2012-12-21 Thread Jens Geyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-1769:
---

Attachment: (was: 
THRIFT-1769_unions_cant_have_required_fields_CPP.patch)

 unions can't have required fields (C++)
 ---

 Key: THRIFT-1769
 URL: https://issues.apache.org/jira/browse/THRIFT-1769
 Project: Thrift
  Issue Type: Bug
  Components: C++ - Compiler
Affects Versions: 0.8, 0.9
Reporter: Jens Geyer
Assignee: Jens Geyer
 Fix For: 1.0


 Required fields within unions should be treaten as optional, the union 
 construct would not make much sense otherwise. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (THRIFT-1769) unions can't have required fields (C++)

2012-12-04 Thread Jens Geyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-1769:
---

Patch Info:   (was: Patch Available)

Patch may need revision - postponed. 

 unions can't have required fields (C++)
 ---

 Key: THRIFT-1769
 URL: https://issues.apache.org/jira/browse/THRIFT-1769
 Project: Thrift
  Issue Type: Bug
  Components: C++ - Compiler
Affects Versions: 0.8, 0.9
Reporter: Jens Geyer
Assignee: Jens Geyer
 Fix For: 1.0

 Attachments: THRIFT-1769_unions_cant_have_required_fields_CPP.patch


 Required fields within unions should be treaten as optional, the union 
 construct would not make much sense otherwise. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (THRIFT-1769) unions can't have required fields (C++)

2012-11-29 Thread Jens Geyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-1769:
---

Component/s: (was: Delphi - Compiler)
 C++ - Compiler

 unions can't have required fields (C++)
 ---

 Key: THRIFT-1769
 URL: https://issues.apache.org/jira/browse/THRIFT-1769
 Project: Thrift
  Issue Type: Bug
  Components: C++ - Compiler
Affects Versions: 0.8, 0.9
Reporter: Jens Geyer
Assignee: Jens Geyer
 Fix For: 1.0


 Required fields within unions should be treaten as optional, the union 
 construct would not make much sense otherwise. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (THRIFT-1769) unions can't have required fields (C++)

2012-11-29 Thread Jens Geyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-1769:
---

Attachment: THRIFT-1769_unions_cant_have_required_fields_CPP.patch

Proposed patch. 

Some more testing required, I did not perform much testing beyond my 
handcrafted testcase (which of course works well).

 unions can't have required fields (C++)
 ---

 Key: THRIFT-1769
 URL: https://issues.apache.org/jira/browse/THRIFT-1769
 Project: Thrift
  Issue Type: Bug
  Components: C++ - Compiler
Affects Versions: 0.8, 0.9
Reporter: Jens Geyer
Assignee: Jens Geyer
 Fix For: 1.0

 Attachments: THRIFT-1769_unions_cant_have_required_fields_CPP.patch


 Required fields within unions should be treaten as optional, the union 
 construct would not make much sense otherwise. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira