[jira] [Commented] (THRIFT-2520) cpp:cob_style generates incorrect .tcc file
[ https://issues.apache.org/jira/browse/THRIFT-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031795#comment-14031795 ] Nobuaki Sukegawa commented on THRIFT-2520: -- It was caused by nodist_libtestgencpp_la build target inside test/cpp/Makefile.am not having ThriftTest.cpp file. Since this .cpp file was effectively empty up until now, this has never been an issue. I updated the pull request with the fix. cpp:cob_style generates incorrect .tcc file --- Key: THRIFT-2520 URL: https://issues.apache.org/jira/browse/THRIFT-2520 Project: Thrift Issue Type: Bug Components: C++ - Compiler Affects Versions: 1.0 Environment: Linux gcc Reporter: Nobuaki Sukegawa With cob_style switch, thrift compiler generates non-template method definitions into .tcc files, which results in link errors whenever you include a service header from multiple implementation files. Moving non-template methods to .cpp file resolves the problem. This problem is present only in recent master branch. pull request url: https://github.com/apache/thrift/pull/118 -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] thrift pull request: THRIFT-2576 Implement Thrift.Protocol.prototy...
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/141#issuecomment-46114247 THRIFT-2576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2576) Implement Thrift.Protocol.prototype.skip method in JavaScript library
[ https://issues.apache.org/jira/browse/THRIFT-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031860#comment-14031860 ] ASF GitHub Bot commented on THRIFT-2576: Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/141#issuecomment-46114247 THRIFT-2576 Implement Thrift.Protocol.prototype.skip method in JavaScript library - Key: THRIFT-2576 URL: https://issues.apache.org/jira/browse/THRIFT-2576 Project: Thrift Issue Type: Bug Reporter: Hyungsul Kim -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (THRIFT-2576) Implement Thrift.Protocol.prototype.skip method in JavaScript library
[ https://issues.apache.org/jira/browse/THRIFT-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2576: -- Assignee: Jens Geyer Implement Thrift.Protocol.prototype.skip method in JavaScript library - Key: THRIFT-2576 URL: https://issues.apache.org/jira/browse/THRIFT-2576 Project: Thrift Issue Type: Bug Reporter: Hyungsul Kim Assignee: Jens Geyer -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2576) Implement Thrift.Protocol.prototype.skip method in JavaScript library
[ https://issues.apache.org/jira/browse/THRIFT-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031861#comment-14031861 ] Jens Geyer commented on THRIFT-2576: GitHub user hyungsul opened a pull request: https://github.com/apache/thrift/pull/141 Thrift 2576 Implement Thrift.Protocol.prototype.skip method Thrift.Protocol.prototype.skip was not implemented yet. Due to the exception that the previous implementation throws, Thrift client in JavaScript has issues on backward compatibility. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyungsul/thrift THRIFT-2576 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/141.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #141 Implement Thrift.Protocol.prototype.skip method in JavaScript library - Key: THRIFT-2576 URL: https://issues.apache.org/jira/browse/THRIFT-2576 Project: Thrift Issue Type: Bug Reporter: Hyungsul Kim Assignee: Jens Geyer -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (THRIFT-2577) TFileTransport missuse of closesocket on windows platform
suuyaoo created THRIFT-2577: --- Summary: TFileTransport missuse of closesocket on windows platform Key: THRIFT-2577 URL: https://issues.apache.org/jira/browse/THRIFT-2577 Project: Thrift Issue Type: Bug Components: C++ - Library Reporter: suuyaoo Fix For: 1.2 On windows platform , TFileTransport opens a file using the _open function, but close it using THRIFT_CLOSESOCKET(closesocket), and this may cause a TTransportException being throwed, which is not expected. -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] thrift pull request: TFileTransport missuse of closesocket on wind...
GitHub user suuyaoo opened a pull request: https://github.com/apache/thrift/pull/142 TFileTransport missuse of closesocket on windows platform https://issues.apache.org/jira/browse/THRIFT-2577 You can merge this pull request into a Git repository by running: $ git pull https://github.com/suuyaoo/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit 809ee5e0c1148a914537d3857c011fb0d73ade1f Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T06:59:25Z Update PlatformSocket.h commit a2ebfdd35a2f3b80669b21b86d1a4b653723529c Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T07:29:40Z Update TFileTransport.cpp commit e45364d4f3713ecfc365bbd21675b7dc7ef09052 Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T14:37:29Z fix windows filetransport --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2577) TFileTransport missuse of closesocket on windows platform
[ https://issues.apache.org/jira/browse/THRIFT-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031984#comment-14031984 ] ASF GitHub Bot commented on THRIFT-2577: GitHub user suuyaoo opened a pull request: https://github.com/apache/thrift/pull/142 TFileTransport missuse of closesocket on windows platform https://issues.apache.org/jira/browse/THRIFT-2577 You can merge this pull request into a Git repository by running: $ git pull https://github.com/suuyaoo/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit 809ee5e0c1148a914537d3857c011fb0d73ade1f Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T06:59:25Z Update PlatformSocket.h commit a2ebfdd35a2f3b80669b21b86d1a4b653723529c Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T07:29:40Z Update TFileTransport.cpp commit e45364d4f3713ecfc365bbd21675b7dc7ef09052 Author: suuyaoo suuy...@gmail.com Date: 2014-06-15T14:37:29Z fix windows filetransport TFileTransport missuse of closesocket on windows platform -- Key: THRIFT-2577 URL: https://issues.apache.org/jira/browse/THRIFT-2577 Project: Thrift Issue Type: Bug Components: C++ - Library Reporter: suuyaoo Fix For: 1.2 On windows platform , TFileTransport opens a file using the _open function, but close it using THRIFT_CLOSESOCKET(closesocket), and this may cause a TTransportException being throwed, which is not expected. -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] thrift pull request: TFileTransport missuse of closesocket on wind...
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/142#issuecomment-46124882 Hi, Thanks for the request. It looks good but does TFDTransportTest work for you? It seems to still be failing on destructor even after your patch: https://travis-ci.org/apache/thrift/builds/27626952#L4047 Cheers, Henrique --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-2520 Compiler:put non-template method ...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-2520) cpp:cob_style generates incorrect .tcc file
[ https://issues.apache.org/jira/browse/THRIFT-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-2520. - Resolution: Fixed Assignee: Roger Meier thanks! cpp:cob_style generates incorrect .tcc file --- Key: THRIFT-2520 URL: https://issues.apache.org/jira/browse/THRIFT-2520 Project: Thrift Issue Type: Bug Components: C++ - Compiler Affects Versions: 1.0 Environment: Linux gcc Reporter: Nobuaki Sukegawa Assignee: Roger Meier With cob_style switch, thrift compiler generates non-template method definitions into .tcc files, which results in link errors whenever you include a service header from multiple implementation files. Moving non-template methods to .cpp file resolves the problem. This problem is present only in recent master branch. pull request url: https://github.com/apache/thrift/pull/118 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2520) cpp:cob_style generates incorrect .tcc file
[ https://issues.apache.org/jira/browse/THRIFT-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032008#comment-14032008 ] ASF GitHub Bot commented on THRIFT-2520: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/118 cpp:cob_style generates incorrect .tcc file --- Key: THRIFT-2520 URL: https://issues.apache.org/jira/browse/THRIFT-2520 Project: Thrift Issue Type: Bug Components: C++ - Compiler Affects Versions: 1.0 Environment: Linux gcc Reporter: Nobuaki Sukegawa With cob_style switch, thrift compiler generates non-template method definitions into .tcc files, which results in link errors whenever you include a service header from multiple implementation files. Moving non-template methods to .cpp file resolves the problem. This problem is present only in recent master branch. pull request url: https://github.com/apache/thrift/pull/118 -- This message was sent by Atlassian JIRA (v6.2#6252)
Build failed in Jenkins: Thrift #1181
See https://builds.apache.org/job/Thrift/1181/changes Changes: [roger] THRIFT-2520 cpp:cob_style generates incorrect .tcc file -- [...truncated 8608 lines...] OK: Finilocalhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - ..localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:10] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 20:20:11] POST / HTTP/1.0 200 - .. -- Ran 19 tests in 0.710s OK shed (includes gen-py-dynamicslots) THttpServer / binary proto / zlib=False / SSL=False. 395 combinations tested. Test run #396: (includes gen-py-dynamicslots) Server=THttpServer, Proto=compact, zlib=False, SSL=False Testing server THttpServer: /usr/bin/python ./TestServer.py --genpydir=gen-py-dynamicslots --protocol=compact --port=9090 THttpServer Testing client: /usr/bin/python ./TestClient.py --genpydir=gen-py-dynamicslots --protocol=compact --port=9090 --transport=buffered --http=/ OK: Finished (includes gen-py-dynamicslots) THttpServer / compact proto / zlib=False / SSL=False. 396 combinations tested. PASS: RunClientServer.py = 1 test passed = make[3]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/Thrift/test/py' make[2]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/Thrift/test/py' Making check in py.twisted make[2]: Entering directory `/x1/jenkins/jenkins-slave/workspace/Thrift/test/py.twisted' ../../compiler/cpp/thrift --gen py:twisted ../ThriftTest.thrift [WARNING:/x1/jenkins/jenkins-slave/workspace/Thrift/test/ThriftTest.thrift:42] No generator named 'noexist' could be found! [WARNING:/x1/jenkins/jenkins-slave/workspace/Thrift/test/ThriftTest.thrift:43] cpp generator does not accept 'noexist' as sub-namespace! ../../compiler/cpp/thrift --gen py:twisted ../SmallTest.thrift [WARNING:/x1/jenkins/jenkins-slave/workspace/Thrift/test/SmallTest.thrift:27] senum is deprecated and will be removed in a future compiler version. This type should be replaced with string. [WARNING:/x1/jenkins/jenkins-slave/workspace/Thrift/test/SmallTest.thrift:27] senum is deprecated and will be removed in a future compiler version. This type should be replaced with string. /usr/bin/trial test_suite.py test_suite ThriftTestCase testByte ... [OK] testDouble ... [OK] testException ... [OK] testI32 ...[OK] testI64 ...[OK] testOneway ... [OK] testString ... [OK] testStruct ... [OK] testVoid ... [OK] --- Ran 9 tests in 2.039s PASSED (successes=9) make[2]: Leaving directory `/x1/jenkins/jenkins-slave/workspace/Thrift/test/py.twisted' Making check in py.tornado make[2]: Entering directory `/x1/jenkins/jenkins-slave/workspace/Thrift/test/py.tornado' ../../compiler/cpp/thrift --gen py:tornado ../ThriftTest.thrift [WARNING:/x1/jenkins/jenkins-slave/workspace/Thrift/test/ThriftTest.thrift:42] No generator named 'noexist' could be found! [WARNING:/x1/jenkins/jenkins-slave/workspace/Thrift/test/ThriftTest.thrift:43] cpp
[jira] [Commented] (THRIFT-2520) cpp:cob_style generates incorrect .tcc file
[ https://issues.apache.org/jira/browse/THRIFT-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032014#comment-14032014 ] Hudson commented on THRIFT-2520: FAILURE: Integrated in Thrift #1181 (See [https://builds.apache.org/job/Thrift/1181/]) THRIFT-2520 cpp:cob_style generates incorrect .tcc file (roger: rev 63fcb7e756a88adca994111e1d9bc0c3c5186c36) * compiler/cpp/src/generate/t_cpp_generator.cc * lib/cpp/test/Makefile.am * lib/cpp/test/link/LinkTest.cpp * .gitignore * test/cpp/Makefile.am * lib/cpp/test/link/TemplatedService2.cpp * lib/cpp/test/link/TemplatedService1.cpp cpp:cob_style generates incorrect .tcc file --- Key: THRIFT-2520 URL: https://issues.apache.org/jira/browse/THRIFT-2520 Project: Thrift Issue Type: Bug Components: C++ - Compiler Affects Versions: 1.0 Environment: Linux gcc Reporter: Nobuaki Sukegawa Assignee: Roger Meier With cob_style switch, thrift compiler generates non-template method definitions into .tcc files, which results in link errors whenever you include a service header from multiple implementation files. Moving non-template methods to .cpp file resolves the problem. This problem is present only in recent master branch. pull request url: https://github.com/apache/thrift/pull/118 -- This message was sent by Atlassian JIRA (v6.2#6252)
Build failed in Jenkins: Thrift #1182
See https://builds.apache.org/job/Thrift/1182/ -- [...truncated 8590 lines...] Testing client: /usr/bin/python ./TestClient.py --genpydir=gen-py-dynamicslots --protocol=binary --port=9090 --transport=buffered --http=/ OK: Finilocalhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - ..localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:14] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:15] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:15] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:15] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:15] POST / HTTP/1.0 200 - localhost - - [15/Jun/2014 23:51:15] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:15] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:15] POST / HTTP/1.0 200 - .localhost - - [15/Jun/2014 23:51:15] POST / HTTP/1.0 200 - .. -- Ran 19 tests in 0.709s OK shed (includes gen-py-dynamicslots) THttpServer / binary proto / zlib=False / SSL=False. 395 combinations tested. Test run #396: (includes gen-py-dynamicslots) Server=THttpServer, Proto=compact, zlib=False, SSL=False Testing server THttpServer: /usr/bin/python ./TestServer.py --genpydir=gen-py-dynamicslots --protocol=compact --port=9090 THttpServer Testing client: /usr/bin/python ./TestClient.py --genpydir=gen-py-dynamicslots --protocol=compact --port=9090 --transport=buffered --http=/ OK: Finished (includes gen-py-dynamicslots) THttpServer / compact proto / zlib=False / SSL=False. 396 combinations tested. PASS: RunClientServer.py = 1 test passed = make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/test/py' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/test/py' Making check in py.twisted make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/test/py.twisted' ../../compiler/cpp/thrift --gen py:twisted ../ThriftTest.thrift [WARNING:https://builds.apache.org/job/Thrift/ws/test/ThriftTest.thrift:42] No generator named 'noexist' could be found! [WARNING:https://builds.apache.org/job/Thrift/ws/test/ThriftTest.thrift:43] cpp generator does not accept 'noexist' as sub-namespace! ../../compiler/cpp/thrift --gen py:twisted ../SmallTest.thrift [WARNING:https://builds.apache.org/job/Thrift/ws/test/SmallTest.thrift:27] senum is deprecated and will be removed in a future compiler version. This type should be replaced with string. [WARNING:https://builds.apache.org/job/Thrift/ws/test/SmallTest.thrift:27] senum is deprecated and will be removed in a future compiler version. This type should be replaced with string. /usr/bin/trial test_suite.py test_suite ThriftTestCase testByte ... [OK] testDouble ... [OK] testException ... [OK] testI32 ...[OK] testI64 ...[OK] testOneway ... [OK] testString ... [OK] testStruct ... [OK] testVoid ... [OK] --- Ran 9 tests in 2.031s PASSED (successes=9) make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/test/py.twisted' Making check in py.tornado make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/test/py.tornado' ../../compiler/cpp/thrift --gen py:tornado ../ThriftTest.thrift [WARNING:https://builds.apache.org/job/Thrift/ws/test/ThriftTest.thrift:42] No generator named 'noexist' could be found!
