[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293940#comment-14293940 ] Hudson commented on TIKA-1530: -- UNSTABLE: Integrated in tika-trunk-jdk1.7 #455 (See [https://builds.apache.org/job/tika-trunk-jdk1.7/455/]) Use a locale-consistent DecimalFormat to set the mp4 duration, avoiding rounding issues TIKA-1530 (nick: http://svn.apache.org/viewvc/tika/trunk/?view=revrev=1655100) * /tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java * /tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mp4/MP4ParserTest.java MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Assignee: Chris A. Mattmann Priority: Minor Fix For: 1.8 See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293664#comment-14293664 ] ASF GitHub Bot commented on TIKA-1530: -- Github user asfgit closed the pull request at: https://github.com/apache/tika/pull/25 MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Priority: Minor See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293669#comment-14293669 ] Chris A. Mattmann commented on TIKA-1530: - Thanks Oskar, patch committed to trunk in r1655063 and #25 pull request closed. Thanks! Nick would you like me to leave this one open until the MP3 or Ogg Vorbis parser has the same code? MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Assignee: Chris A. Mattmann Priority: Minor See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293696#comment-14293696 ] Hudson commented on TIKA-1530: -- UNSTABLE: Integrated in tika-trunk-jdk1.7 #454 (See [https://builds.apache.org/job/tika-trunk-jdk1.7/454/]) fix for TIKA-1530: Include parsed mp4 duration in metadata contributed by Oskar Wickström oskar.wickst...@live.com This closes #25. (mattmann: http://svn.apache.org/viewvc/tika/trunk/?view=revrev=1655063) * /tika/trunk/CHANGES.txt * /tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java * /tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mp4/MP4ParserTest.java MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Assignee: Chris A. Mattmann Priority: Minor See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293720#comment-14293720 ] Hudson commented on TIKA-1530: -- UNSTABLE: Integrated in tika-trunk-jdk1.6 #439 (See [https://builds.apache.org/job/tika-trunk-jdk1.6/439/]) fix for TIKA-1530: Include parsed mp4 duration in metadata contributed by Oskar Wickström oskar.wickst...@live.com This closes #25. (mattmann: http://svn.apache.org/viewvc/tika/trunk/?view=revrev=1655063) * /tika/trunk/CHANGES.txt * /tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java * /tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mp4/MP4ParserTest.java MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Assignee: Chris A. Mattmann Priority: Minor See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293883#comment-14293883 ] Hudson commented on TIKA-1530: -- UNSTABLE: Integrated in tika-trunk-jdk1.6 #440 (See [https://builds.apache.org/job/tika-trunk-jdk1.6/440/]) Use a locale-consistent DecimalFormat to set the mp4 duration, avoiding rounding issues TIKA-1530 (nick: http://svn.apache.org/viewvc/tika/trunk/?view=revrev=1655100) * /tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java * /tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/mp4/MP4ParserTest.java MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Assignee: Chris A. Mattmann Priority: Minor Fix For: 1.8 See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292081#comment-14292081 ] Oskar Wickström commented on TIKA-1530: --- Sure, I'll look into it tomorrow. :) MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Priority: Minor See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293120#comment-14293120 ] ASF GitHub Bot commented on TIKA-1530: -- GitHub user owickstrom opened a pull request: https://github.com/apache/tika/pull/25 TIKA-1530: Include parsed mp4 duration in metadata Note that I couldn't get all tests working in the project (https://issues.apache.org/jira/browse/TIKA-1521?focusedCommentId=14288719page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14288719) so I have only run `org.apache.tika.parser.mp4.MP4ParserTest`. If someone else with a working build could try this perhaps? You can merge this pull request into a Git repository by running: $ git pull https://github.com/owickstrom/tika trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tika/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 5300d22e6c7f71c353ad84a7cf4534a8efff85da Author: Oskar Wickström oskar.wickst...@live.com Date: 2015-01-27T07:28:00Z TIKA-1530: Include parsed mp4 duration in metadata MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Priority: Minor See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TIKA-1530) MP4Parser parses duration but does not set it
[ https://issues.apache.org/jira/browse/TIKA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293124#comment-14293124 ] Oskar Wickström commented on TIKA-1530: --- https://github.com/apache/tika/pull/25 MP4Parser parses duration but does not set it -- Key: TIKA-1530 URL: https://issues.apache.org/jira/browse/TIKA-1530 Project: Tika Issue Type: Improvement Components: parser Reporter: Oskar Wickström Priority: Minor See the TODO comment at https://github.com/apache/tika/blob/trunk/tika-parsers/src/main/java/org/apache/tika/parser/mp4/MP4Parser.java#L167 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
