[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358067#comment-15358067
 ] 

ASF GitHub Bot commented on TINKERPOP-1352:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/352
  
Just pushed a fix. It was more a problem with the configuration of the 
client in the test than a bug. I think the recent fixes in this branch made 
some things suddenly "work" and it caused these side cases to start squeezing 
out problems. I've had several successful runs at this point with no troubles 
so I think that both tests might be solid now.

While I was in the debugger, I noticed one final thing that I don't really 
like that I'd like to resolved, so reviewers may want to hang on to their votes 
for a little bit longer for this one.


> Connection Pool doesn't always grow 
> 
>
> Key: TINKERPOP-1352
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1352
> Project: TinkerPop
>  Issue Type: Bug
>  Components: driver
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.1.3, 3.2.1
>
>
> With certain configurations (that aren't terribly intuitive) of the driver, 
> the connection pool won't grow properly - this includes the default 
> configuration. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/352
  
wow - now this one is failing:

```text
GremlinDriverIntegrateTest.shouldBeThreadSafeToUseOneClient:994
```

only fails when run in maven - works in intellij on its own - wonderful. i 
fixed one non-deterministic test and ended up with a new one for my troubles.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1351) Number of connections going beyond the pool max size

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357888#comment-15357888
 ] 

stephen mallette commented on TINKERPOP-1351:
-

I'm going to add your change on the TINKERPOP-1352 branch so that we can have 
one pull request to represent all these bug fixes related to the connection 
pool.  It would be great if you could test that branch out if you get a chance. 
You can see the PR here:

https://github.com/apache/tinkerpop/pull/352

Running tests over these changes now and should be pushing shortly.

> Number of connections going beyond the pool max size
> 
>
> Key: TINKERPOP-1351
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1351
> Project: TinkerPop
>  Issue Type: Bug
>  Components: driver
>Affects Versions: 3.1.2-incubating
> Environment: RESTful web service using gremlin driver to send request 
> to a Gremlin Server
>Reporter: Ramzi Oueslati
>Assignee: stephen mallette
> Fix For: 3.1.3, 3.2.1
>
>
> When the gremlin driver is used with an important number of concurrent 
> requests, sockets are opened far beyond the max pool size.
> At some point, the connections are destroyed, the pool is empty and then the 
> borrowConnection process goes through :
> {code:java}
> if (connections.isEmpty()) {
> logger.debug("Tried to borrow connection but the pool was empty 
> for {} - scheduling pool creation and waiting for connection", host);
> for (int i = 0; i < minPoolSize; i++) {
> scheduledForCreation.incrementAndGet();
> newConnection();
> }
> return waitForConnection(timeout, unit);
> }
> {code}
> If many connections are borrowed at the same time then this code will 
> schedule as many connections for creation.
> I added a check :
> {code:java}
> for (int i = 0; i < minPoolSize; i++) {
> if (scheduledForCreation.get() < minPoolSize) {
> scheduledForCreation.incrementAndGet();
> logger.debug("borrowConnection: [inc] 
> scheduledForCreation=" + scheduledForCreation.get());
> newConnection();
> }
> }
> {code}
> It seems to solve the problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TINKERPOP-1351) Number of connections going beyond the pool max size

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1351:

Summary: Number of connections going beyond the pool max size  (was: Nb of 
connections going beyond the pool max size)

> Number of connections going beyond the pool max size
> 
>
> Key: TINKERPOP-1351
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1351
> Project: TinkerPop
>  Issue Type: Bug
>  Components: driver
>Affects Versions: 3.1.2-incubating
> Environment: RESTful web service using gremlin driver to send request 
> to a Gremlin Server
>Reporter: Ramzi Oueslati
>Assignee: stephen mallette
> Fix For: 3.1.3, 3.2.1
>
>
> When the gremlin driver is used with an important number of concurrent 
> requests, sockets are opened far beyond the max pool size.
> At some point, the connections are destroyed, the pool is empty and then the 
> borrowConnection process goes through :
> {code:java}
> if (connections.isEmpty()) {
> logger.debug("Tried to borrow connection but the pool was empty 
> for {} - scheduling pool creation and waiting for connection", host);
> for (int i = 0; i < minPoolSize; i++) {
> scheduledForCreation.incrementAndGet();
> newConnection();
> }
> return waitForConnection(timeout, unit);
> }
> {code}
> If many connections are borrowed at the same time then this code will 
> schedule as many connections for creation.
> I added a check :
> {code:java}
> for (int i = 0; i < minPoolSize; i++) {
> if (scheduledForCreation.get() < minPoolSize) {
> scheduledForCreation.incrementAndGet();
> logger.debug("borrowConnection: [inc] 
> scheduledForCreation=" + scheduledForCreation.get());
> newConnection();
> }
> }
> {code}
> It seems to solve the problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1354) Include all static enum imports in request validation for bindings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357887#comment-15357887
 ] 

ASF GitHub Bot commented on TINKERPOP-1354:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/354
  
BUILD SUCCESS


> Include all static enum imports in request validation for bindings
> --
>
> Key: TINKERPOP-1354
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1354
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.1.3, 3.2.1
>
>
> Gremlin Server validates the bindings of incoming requests and returns an 
> error for any reserved terms. The list of reserved terms only includes {{T}} 
> but should also include others like {{Order}} and {{Scope}} so that users 
> don't inadvertently override them with a request binding. When that happens 
> Gremlin Server throws a not so easy to understand error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #354: TINKERPOP-1354 Added more invalid binding keys to Grem...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/354
  
BUILD SUCCESS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357870#comment-15357870
 ] 

ASF GitHub Bot commented on TINKERPOP-1352:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/352
  
@robertdale i think i fixed the problem. i've been hunting that issue 
forever, but have never been able to witness it with any kind of consistent 
nature to unravel the problem. i guess my earlier changes in this branch 
allowed me to see semi-consistently (once every few runs) which was painful but 
good enough to get to the bottom of it. it would be great if you could try the 
build again - thanks for testing it out.


> Connection Pool doesn't always grow 
> 
>
> Key: TINKERPOP-1352
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1352
> Project: TinkerPop
>  Issue Type: Bug
>  Components: driver
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.1.3, 3.2.1
>
>
> With certain configurations (that aren't terribly intuitive) of the driver, 
> the connection pool won't grow properly - this includes the default 
> configuration. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/352
  
@robertdale i think i fixed the problem. i've been hunting that issue 
forever, but have never been able to witness it with any kind of consistent 
nature to unravel the problem. i guess my earlier changes in this branch 
allowed me to see semi-consistently (once every few runs) which was painful but 
good enough to get to the bottom of it. it would be great if you could try the 
build again - thanks for testing it out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #343: restructured gremlin-python package

[okram]

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/343
  
Yea -- its a little crazy on that branch right now. It will stabilize (be 
near the end) by the end of next week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1352) Connection Pool doesn't always grow

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357601#comment-15357601
 ] 

ASF GitHub Bot commented on TINKERPOP-1352:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/352
  
hmm - you're right - i'm getting that now too. i wonder why i didn't see 
that yesterday. investigating now.


> Connection Pool doesn't always grow 
> 
>
> Key: TINKERPOP-1352
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1352
> Project: TinkerPop
>  Issue Type: Bug
>  Components: driver
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
> Fix For: 3.1.3, 3.2.1
>
>
> With certain configurations (that aren't terribly intuitive) of the driver, 
> the connection pool won't grow properly - this includes the default 
> configuration. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/351
  
yeah - we tend to bump heads on master a little bit on the CHANGELOG - not 
a big deal - i can resolve that conflict when the time comes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357513#comment-15357513
 ] 

ASF GitHub Bot commented on TINKERPOP-1274:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/351
  
yeah - we tend to bump heads on master a little bit on the CHANGELOG - not 
a big deal - i can resolve that conflict when the time comes.


> GraphSON Version 2.0
> 
>
> Key: TINKERPOP-1274
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1274
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Priority: Minor
> Fix For: 3.2.1
>
>
> Develop a revised version of GraphSON that provides better support for 
> non-JVM languages that consume it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1354) Include all static enum imports in request validation for bindings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357505#comment-15357505
 ] 

ASF GitHub Bot commented on TINKERPOP-1354:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/354

TINKERPOP-1354 Added more invalid binding keys to Gremlin Server validation

https://issues.apache.org/jira/browse/TINKERPOP-1354

These "invalid" keys are reserved terms for Gremlin Server as they are 
statically imported enums and shouldn't be used as binding keys. You get some 
less than easy to understand error messages if those keys are used. 

I would have CTR'd but wanted to see if anyone had other suggestions for 
additional validations at play. Also, this change is "breaking" in the sense 
that users who were somehow successfully using some of these newly reserved 
keys on previous versions (not fully sure if that was even possible) will have 
to update their code. I don't think this is a massive problem for someone to 
fix, so while "breaking" it doesn't seem massively detrimental and shouldn't be 
widely problematic.

Builds with `mvn clean install -DskipTests && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1354

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #354


commit c37c3016bd05b3caeb09084f5469c606c439bfe5
Author: Stephen Mallette 
Date:   2016-06-30T17:07:44Z

Added more invalid binding keys to Gremlin Server OpProcessor validation.

These "invalid" keys are reserved terms for Gremlin Server as they are 
statically imported enums and shouldn't be used as binding keys. You get some 
less than easy to understand error messages if those keys are used.




> Include all static enum imports in request validation for bindings
> --
>
> Key: TINKERPOP-1354
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1354
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.1.3, 3.2.1
>
>
> Gremlin Server validates the bindings of incoming requests and returns an 
> error for any reserved terms. The list of reserved terms only includes {{T}} 
> but should also include others like {{Order}} and {{Scope}} so that users 
> don't inadvertently override them with a request binding. When that happens 
> Gremlin Server throws a not so easy to understand error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TINKERPOP-1354) Include all static enum imports in request validation for bindings

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1354:

Labels: breaking  (was: )

> Include all static enum imports in request validation for bindings
> --
>
> Key: TINKERPOP-1354
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1354
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.1.3, 3.2.1
>
>
> Gremlin Server validates the bindings of incoming requests and returns an 
> error for any reserved terms. The list of reserved terms only includes {{T}} 
> but should also include others like {{Order}} and {{Scope}} so that users 
> don't inadvertently override them with a request binding. When that happens 
> Gremlin Server throws a not so easy to understand error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357479#comment-15357479
 ] 

ASF GitHub Bot commented on TINKERPOP-1274:
---

Github user newkek commented on the issue:

https://github.com/apache/tinkerpop/pull/351
  
Re-conflicts with Changelog against master..


> GraphSON Version 2.0
> 
>
> Key: TINKERPOP-1274
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1274
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Priority: Minor
> Fix For: 3.2.1
>
>
> Develop a revised version of GraphSON that provides better support for 
> non-JVM languages that consume it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.

[newkek]

Github user newkek commented on the issue:

https://github.com/apache/tinkerpop/pull/351
  
Re-conflicts with Changelog against master..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357466#comment-15357466
 ] 

ASF GitHub Bot commented on TINKERPOP-1320:
---

Github user pluradj commented on the issue:

https://github.com/apache/tinkerpop/pull/336
  
@spmallette I'll get this finished up before the weekend


> GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
> --
>
> Key: TINKERPOP-1320
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1320
> Project: TinkerPop
>  Issue Type: Bug
>  Components: test-suite
>Affects Versions: 3.2.0-incubating, 3.1.2-incubating
>Reporter: Jason Plurad
>Assignee: Jason Plurad
>Priority: Minor
> Fix For: 3.1.3, 3.2.1
>
>
> This is similar to TINKERPOP-1317. The differences here are
> * The {{TestHelper.generateTempFileFromResource()}} call to load the resource 
> is happening from the {{public static void init()}} method before a graph 
> instance is available.
> * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still 
> required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFileSandbo...

[pluradj]

Github user pluradj commented on the issue:

https://github.com/apache/tinkerpop/pull/336
  
@spmallette I'll get this finished up before the weekend


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #343: restructured gremlin-python package

[davebshow]

Github user davebshow closed the pull request at:

https://github.com/apache/tinkerpop/pull/343


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #352: TINKERPOP-1352 Fixed logic in ConnectionPool that was ...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/352
  
Using (have to ignore hadoop/spark)  mvn clean install -pl 
gremlin-shaded,gremlin-core,gremlin-test,gremlin-groovy,gremlin-groovy-test,tinkergraph-gremlin,neo4j-gremlin,gremlin-driver,gremlin-console,gremlin-server,gremlin-archetype
 && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j

GremlinServerSessionIntegrateTest.shouldEnsureSessionBindingsAreThreadSafe 
consistently fails for me.  The tp31 tip does not fail.

No such property: a for class: Script2

I added a get() where the vars are set to ensure it happens before the rest 
of the threads. Does not appear to be a race condition.

[console.txt](https://github.com/apache/tinkerpop/files/341746/console.txt)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #342: TINKERPOP-1063 TinkerGraph Performance

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/342


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1341) UnshadedKryoAdapter fails to deserialize StarGraph when SparkConf sets spark.rdd.compress=true whereas GryoSerializer works

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357254#comment-15357254
 ] 

ASF GitHub Bot commented on TINKERPOP-1341:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/353
  
Crazy. I never new `void.class` existing in Java. ?!


> UnshadedKryoAdapter fails to deserialize StarGraph when SparkConf sets 
> spark.rdd.compress=true whereas GryoSerializer works
> ---
>
> Key: TINKERPOP-1341
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1341
> Project: TinkerPop
>  Issue Type: Bug
>  Components: io
>Affects Versions: 3.2.1, 3.3.0
>Reporter: Dylan Bethune-Waddell
>Priority: Minor
>
> When trying to bulk load a large dataset into Titan I was running into OOM 
> errors and decided to try tweaking some spark configuration settings - 
> although I am having trouble bulk loading with the new 
> GryoRegistrator/UnshadedKryo serialization shim stuff in master whereby a few 
> hundred tasks into the edge loading stage (stage 5) exceptions are thrown 
> complaining about the need to explicitly register CompactBuffer[].class with 
> Kryo, this approach with spark.rdd.compress=true fails a few hundred tasks 
> into the vertex loading stage (stage 1) of BulkLoaderVertexProgram. 
> GryoSerializer instead of KryoSerializer with GryoRegistrator does not fail 
> and successfully loads the data with this compression flag flipped on whereas 
> before I would just get OOM errors until eventually the job was set back so 
> far that it just failed. So it would seem it is desirable in some instances 
> to use this setting, and the new Serialization stuff seems to break it. Could 
> be a Spark upstream issue based on this open JIRA ticket 
> (https://issues.apache.org/jira/browse/SPARK-3630). Here is the exception 
> that is thrown with the middle bits cut out:
> com.esotericsoftware.kryo.KryoException: java.io.IOException: PARSING_ERROR(2)
> at com.esotericsoftware.kryo.io.Input.fill(Input.java:142)
> at com.esotericsoftware.kryo.io.Input.require(Input.java:169)
> at com.esotericsoftware.kryo.io.Input.readLong_slow(Input.java:715)
> at com.esotericsoftware.kryo.io.Input.readLong(Input.java:665)
> at 
> com.esotericsoftware.kryo.serializers.DefaultSerializers$LongSerializer.read(DefaultSerializers.java:113)
> at 
> com.esotericsoftware.kryo.serializers.DefaultSerializers$LongSerializer.read(DefaultSerializers.java:103)
> at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:729)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readClassAndObject(UnshadedKryoAdapter.java:48)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readClassAndObject(UnshadedKryoAdapter.java:30)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.readEdges(StarGraphSerializer.java:134)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.read(StarGraphSerializer.java:91)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.read(StarGraphSerializer.java:45)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedSerializerAdapter.read(UnshadedSerializerAdapter.java:55)
> at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:626)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readObject(UnshadedKryoAdapter.java:42)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readObject(UnshadedKryoAdapter.java:30)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.VertexWritableSerializer.read(VertexWritableSerializer.java:46)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.VertexWritableSerializer.read(VertexWritableSerializer.java:36)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedSerializerAdapter.read(UnshadedSerializerAdapter.java:55)
> at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:729)
> at 
> org.apache.spark.serializer.KryoDeserializationStream.readObject(KryoSerializer.scala:228)
>  and so on 
> .
> Caused by: java.io.IOException: PARSING_ERROR(2)
> at org.xerial.snappy.SnappyNative.throw_error(SnappyNative.java:84)
> at org.xerial.snappy.SnappyNative.uncompressedLength(Native Method)
> at 

[jira] [Commented] (TINKERPOP-1341) UnshadedKryoAdapter fails to deserialize StarGraph when SparkConf sets spark.rdd.compress=true whereas GryoSerializer works

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357251#comment-15357251
 ] 

ASF GitHub Bot commented on TINKERPOP-1341:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/353
  
VOTE +1.


> UnshadedKryoAdapter fails to deserialize StarGraph when SparkConf sets 
> spark.rdd.compress=true whereas GryoSerializer works
> ---
>
> Key: TINKERPOP-1341
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1341
> Project: TinkerPop
>  Issue Type: Bug
>  Components: io
>Affects Versions: 3.2.1, 3.3.0
>Reporter: Dylan Bethune-Waddell
>Priority: Minor
>
> When trying to bulk load a large dataset into Titan I was running into OOM 
> errors and decided to try tweaking some spark configuration settings - 
> although I am having trouble bulk loading with the new 
> GryoRegistrator/UnshadedKryo serialization shim stuff in master whereby a few 
> hundred tasks into the edge loading stage (stage 5) exceptions are thrown 
> complaining about the need to explicitly register CompactBuffer[].class with 
> Kryo, this approach with spark.rdd.compress=true fails a few hundred tasks 
> into the vertex loading stage (stage 1) of BulkLoaderVertexProgram. 
> GryoSerializer instead of KryoSerializer with GryoRegistrator does not fail 
> and successfully loads the data with this compression flag flipped on whereas 
> before I would just get OOM errors until eventually the job was set back so 
> far that it just failed. So it would seem it is desirable in some instances 
> to use this setting, and the new Serialization stuff seems to break it. Could 
> be a Spark upstream issue based on this open JIRA ticket 
> (https://issues.apache.org/jira/browse/SPARK-3630). Here is the exception 
> that is thrown with the middle bits cut out:
> com.esotericsoftware.kryo.KryoException: java.io.IOException: PARSING_ERROR(2)
> at com.esotericsoftware.kryo.io.Input.fill(Input.java:142)
> at com.esotericsoftware.kryo.io.Input.require(Input.java:169)
> at com.esotericsoftware.kryo.io.Input.readLong_slow(Input.java:715)
> at com.esotericsoftware.kryo.io.Input.readLong(Input.java:665)
> at 
> com.esotericsoftware.kryo.serializers.DefaultSerializers$LongSerializer.read(DefaultSerializers.java:113)
> at 
> com.esotericsoftware.kryo.serializers.DefaultSerializers$LongSerializer.read(DefaultSerializers.java:103)
> at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:729)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readClassAndObject(UnshadedKryoAdapter.java:48)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readClassAndObject(UnshadedKryoAdapter.java:30)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.readEdges(StarGraphSerializer.java:134)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.read(StarGraphSerializer.java:91)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.read(StarGraphSerializer.java:45)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedSerializerAdapter.read(UnshadedSerializerAdapter.java:55)
> at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:626)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readObject(UnshadedKryoAdapter.java:42)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readObject(UnshadedKryoAdapter.java:30)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.VertexWritableSerializer.read(VertexWritableSerializer.java:46)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.VertexWritableSerializer.read(VertexWritableSerializer.java:36)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedSerializerAdapter.read(UnshadedSerializerAdapter.java:55)
> at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:729)
> at 
> org.apache.spark.serializer.KryoDeserializationStream.readObject(KryoSerializer.scala:228)
>  and so on 
> .
> Caused by: java.io.IOException: PARSING_ERROR(2)
> at org.xerial.snappy.SnappyNative.throw_error(SnappyNative.java:84)
> at org.xerial.snappy.SnappyNative.uncompressedLength(Native Method)
> at org.xerial.snappy.Snappy.uncompressedLength(Snappy.java:594)
>

[GitHub] tinkerpop issue #353: TINKERPOP-1341 Add missing classes to GryoRegistrator

[okram]

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/353
  
VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #353: TINKERPOP-1341 Add missing classes to GryoRegistrator

[okram]

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/353
  
Crazy. I never new `void.class` existing in Java. ?!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1341) UnshadedKryoAdapter fails to deserialize StarGraph when SparkConf sets spark.rdd.compress=true whereas GryoSerializer works

[Dan LaRocque (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357229#comment-15357229
 ] 

Dan LaRocque commented on TINKERPOP-1341:
-

I made a PR: https://github.com/apache/tinkerpop/pull/353

> UnshadedKryoAdapter fails to deserialize StarGraph when SparkConf sets 
> spark.rdd.compress=true whereas GryoSerializer works
> ---
>
> Key: TINKERPOP-1341
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1341
> Project: TinkerPop
>  Issue Type: Bug
>  Components: io
>Affects Versions: 3.2.1, 3.3.0
>Reporter: Dylan Bethune-Waddell
>Priority: Minor
>
> When trying to bulk load a large dataset into Titan I was running into OOM 
> errors and decided to try tweaking some spark configuration settings - 
> although I am having trouble bulk loading with the new 
> GryoRegistrator/UnshadedKryo serialization shim stuff in master whereby a few 
> hundred tasks into the edge loading stage (stage 5) exceptions are thrown 
> complaining about the need to explicitly register CompactBuffer[].class with 
> Kryo, this approach with spark.rdd.compress=true fails a few hundred tasks 
> into the vertex loading stage (stage 1) of BulkLoaderVertexProgram. 
> GryoSerializer instead of KryoSerializer with GryoRegistrator does not fail 
> and successfully loads the data with this compression flag flipped on whereas 
> before I would just get OOM errors until eventually the job was set back so 
> far that it just failed. So it would seem it is desirable in some instances 
> to use this setting, and the new Serialization stuff seems to break it. Could 
> be a Spark upstream issue based on this open JIRA ticket 
> (https://issues.apache.org/jira/browse/SPARK-3630). Here is the exception 
> that is thrown with the middle bits cut out:
> com.esotericsoftware.kryo.KryoException: java.io.IOException: PARSING_ERROR(2)
> at com.esotericsoftware.kryo.io.Input.fill(Input.java:142)
> at com.esotericsoftware.kryo.io.Input.require(Input.java:169)
> at com.esotericsoftware.kryo.io.Input.readLong_slow(Input.java:715)
> at com.esotericsoftware.kryo.io.Input.readLong(Input.java:665)
> at 
> com.esotericsoftware.kryo.serializers.DefaultSerializers$LongSerializer.read(DefaultSerializers.java:113)
> at 
> com.esotericsoftware.kryo.serializers.DefaultSerializers$LongSerializer.read(DefaultSerializers.java:103)
> at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:729)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readClassAndObject(UnshadedKryoAdapter.java:48)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readClassAndObject(UnshadedKryoAdapter.java:30)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.readEdges(StarGraphSerializer.java:134)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.read(StarGraphSerializer.java:91)
> at 
> org.apache.tinkerpop.gremlin.structure.util.star.StarGraphSerializer.read(StarGraphSerializer.java:45)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedSerializerAdapter.read(UnshadedSerializerAdapter.java:55)
> at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:626)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readObject(UnshadedKryoAdapter.java:42)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoAdapter.readObject(UnshadedKryoAdapter.java:30)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.VertexWritableSerializer.read(VertexWritableSerializer.java:46)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.VertexWritableSerializer.read(VertexWritableSerializer.java:36)
> at 
> org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedSerializerAdapter.read(UnshadedSerializerAdapter.java:55)
> at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:729)
> at 
> org.apache.spark.serializer.KryoDeserializationStream.readObject(KryoSerializer.scala:228)
>  and so on 
> .
> Caused by: java.io.IOException: PARSING_ERROR(2)
> at org.xerial.snappy.SnappyNative.throw_error(SnappyNative.java:84)
> at org.xerial.snappy.SnappyNative.uncompressedLength(Native Method)
> at org.xerial.snappy.Snappy.uncompressedLength(Snappy.java:594)
> at 
> 

[jira] [Commented] (TINKERPOP-1349) RepeatUnrollStrategy should unroll loops while maintaining equivalent semantics.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357063#comment-15357063
 ] 

ASF GitHub Bot commented on TINKERPOP-1349:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/349


> RepeatUnrollStrategy should unroll loops while maintaining equivalent 
> semantics.
> 
>
> Key: TINKERPOP-1349
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1349
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.1
>
>
> Create {{RepeatUnrollStrategy}} that will unroll patterns such as:
> {code}
> repeat(out()).times(3)
> // ->
> out().barrier().out().barrier().out().barrier()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (TINKERPOP-1349) RepeatUnrollStrategy should unroll loops while maintaining equivalent semantics.

[Marko A. Rodriguez (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez closed TINKERPOP-1349.
-
Resolution: Implemented

> RepeatUnrollStrategy should unroll loops while maintaining equivalent 
> semantics.
> 
>
> Key: TINKERPOP-1349
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1349
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.1
>
>
> Create {{RepeatUnrollStrategy}} that will unroll patterns such as:
> {code}
> repeat(out()).times(3)
> // ->
> out().barrier().out().barrier().out().barrier()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop pull request #349: TINKERPOP-1349: RepeatUnrollStrategy should unr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/349


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (TINKERPOP-1091) Get KryoSerializer to work natively.

[Marko A. Rodriguez (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez closed TINKERPOP-1091.
-
Resolution: Fixed
  Assignee: Dan LaRocque

> Get KryoSerializer to work natively.
> 
>
> Key: TINKERPOP-1091
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1091
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: hadoop
>Affects Versions: 3.1.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Dan LaRocque
>  Labels: breaking
> Fix For: 3.2.1
>
>
> Right now, if you use SparkServer (cluster mode) then you need to have 
> {{GryoSerializer}} on all the machines in the cluster. That is, 
> {{SparkContext.addJar()}} does NOT work for {{spark.serializer}}. This is 
> really lame.
> I know we want to get make {{GryoSerializer}} able to work more generally 
> ([~dalaro]). Lets see if we can't get {{KryoSerializer}} with custom added 
> TinkerPop3 classes to work. This way, we don't have to copy jars to machines 
> and can rely on {{loadJars()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1063) TinkerGraph performance enhancements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357049#comment-15357049
 ] 

ASF GitHub Bot commented on TINKERPOP-1063:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/342
  
Cool stuff. `Stream` is evil. It lurks throughout the codebase... Its 
funny, we were all gun ho for Java8, but we barely use it :(  VOTE +1.


> TinkerGraph performance enhancements
> 
>
> Key: TINKERPOP-1063
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1063
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: tinkergraph
>Affects Versions: 3.1.0-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.1.3
>
>
> Improve TinkerGraph performance in relation to the Ferma Benchmark which 
> shows a reasonably wide gap between TP2 and TP3.  We probably won't achieve 
> parity with Blueprints but it would be nice to carve away some time to lessen 
> the gap.
> https://github.com/Syncleus/Ferma-benchmark



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #342: TINKERPOP-1063 TinkerGraph Performance

[okram]

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/342
  
Cool stuff. `Stream` is evil. It lurks throughout the codebase... Its 
funny, we were all gun ho for Java8, but we barely use it :(  VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/346
  
no need to start over - maybe not an issue. i'll see what happens when i 
merge. thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/346
  
Normally that's what I would do but tried doing it the 'github way' - 
https://help.github.com/articles/syncing-a-fork/

So let me know what you want me to do now.  I can start over, creating the 
JIRA ticket, branch, etc.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/346
  
You could just use `git rebase` to update your branch rather than `git 
merge` - in that way the commit history doesn't get weird. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/346
  
I merged your master into my fork. Commit 
0787e46097cc09bb278ac1c787c4a50ece81cdb0
I didn't realize it would affect the pull request. Next time I'll create a 
branch.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.

[newkek]

Github user newkek commented on the issue:

https://github.com/apache/tinkerpop/pull/351
  
@spmallette 
- I've written all the docs, please don't hesitate to correct them if 
they're not written well.
- Updated the tests, parameterized them as much as possible, and focused 
the 2.0 tests on the 2.0 specific functionalities.
- Rebased on current `master`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1063) TinkerGraph performance enhancements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356855#comment-15356855
 ] 

ASF GitHub Bot commented on TINKERPOP-1063:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/342
  
VOTE: +1


> TinkerGraph performance enhancements
> 
>
> Key: TINKERPOP-1063
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1063
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: tinkergraph
>Affects Versions: 3.1.0-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.1.3
>
>
> Improve TinkerGraph performance in relation to the Ferma Benchmark which 
> shows a reasonably wide gap between TP2 and TP3.  We probably won't achieve 
> parity with Blueprints but it would be nice to carve away some time to lessen 
> the gap.
> https://github.com/Syncleus/Ferma-benchmark



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #342: TINKERPOP-1063 TinkerGraph Performance

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/342
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1091) Get KryoSerializer to work natively.

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356851#comment-15356851
 ] 

stephen mallette commented on TINKERPOP-1091:
-

[~okram] can we close this one now based on the gryo work that dan did?

> Get KryoSerializer to work natively.
> 
>
> Key: TINKERPOP-1091
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1091
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: hadoop
>Affects Versions: 3.1.0-incubating
>Reporter: Marko A. Rodriguez
>  Labels: breaking
> Fix For: 3.2.1
>
>
> Right now, if you use SparkServer (cluster mode) then you need to have 
> {{GryoSerializer}} on all the machines in the cluster. That is, 
> {{SparkContext.addJar()}} does NOT work for {{spark.serializer}}. This is 
> really lame.
> I know we want to get make {{GryoSerializer}} able to work more generally 
> ([~dalaro]). Lets see if we can't get {{KryoSerializer}} with custom added 
> TinkerPop3 classes to work. This way, we don't have to copy jars to machines 
> and can rely on {{loadJars()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #342: TINKERPOP-1063 TinkerGraph Performance

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/342
  
@dkuppitz I'd forgotten to implement that change you suggested on this one 
- all done now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1274) GraphSON Version 2.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356821#comment-15356821
 ] 

ASF GitHub Bot commented on TINKERPOP-1274:
---

Github user newkek commented on the issue:

https://github.com/apache/tinkerpop/pull/351
  
Yes that was introduced by the ce19704 (reference docs and Changelog)


> GraphSON Version 2.0
> 
>
> Key: TINKERPOP-1274
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1274
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Priority: Minor
> Fix For: 3.2.1
>
>
> Develop a revised version of GraphSON that provides better support for 
> non-JVM languages that consume it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #349: TINKERPOP-1349: RepeatUnrollStrategy should unroll loo...

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/349
  
Same here, `docker/build.sh -t -i -n` reported success over night. All 
changes after my first vote were included in this test run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/346
  
@robertdale when we get the final vote for this PR to be merged, i expect 
to merge it to tp31 and then master as I'd like the 3.1.x line of code to get 
this fix. i only mention this because i see that you now have what looks like 
an empty merge commit on this PR at this point. Do you know what that is? Is 
that something you can clean up from your end?

note to the final voter - i will update changelog on merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TINKERPOP-1349) RepeatUnrollStrategy should unroll loops while maintaining equivalent semantics.

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1349:

Fix Version/s: (was: 3.2.0-incubating)
   3.2.1

> RepeatUnrollStrategy should unroll loops while maintaining equivalent 
> semantics.
> 
>
> Key: TINKERPOP-1349
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1349
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.1
>
>
> Create {{RepeatUnrollStrategy}} that will unroll patterns such as:
> {code}
> repeat(out()).times(3)
> // ->
> out().barrier().out().barrier().out().barrier()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TINKERPOP-1345) Unrolling of collection for ids

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1345:

Affects Version/s: 3.2.0-incubating
  Component/s: process

> Unrolling of collection for ids
> ---
>
> Key: TINKERPOP-1345
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1345
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Matthias Broecheler
>
> In GraphStep, TinkerPop does this:
> {code}
> this.ids = (ids.length == 1 && ids[0] instanceof Collection) ? ((Collection) 
> ids[0]).toArray(new Object[((Collection) ids[0]).size()]) : ids;
> {code}
> which means that collections are automatically unrolled when there is only 
> one element. This breaks TP implementations that use collections to represent 
> ids, for instance, because their id representation has multiple components 
> (like a primary key in an RDMBS).  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)