[GitHub] tinkerpop issue #393: Add pytest-runner in order to properly build gremlin-p...
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/393 @spmallette I think when you run the tests in the virtualenv you may have trouble with the site-package test suites being invoked (specifically wheel). To remedy this, I added lib/lib64 to the patterns that should be avoided in test discovery. Because setting the norecursedirs option resets the defaults, I included the standard defaults as well. Hopefully this will avoid further problems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1230) Serialising lambdas for RemoteGraph
[ https://issues.apache.org/jira/browse/TINKERPOP-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446794#comment-15446794 ] Marko A. Rodriguez commented on TINKERPOP-1230: --- What does the GLV tutorial need updating with? Please see 3.2.2-SNAPSHOT tutorial. > Serialising lambdas for RemoteGraph > --- > > Key: TINKERPOP-1230 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1230 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.1.1-incubating >Reporter: Michael Pollmeier >Assignee: Marko A. Rodriguez >Priority: Minor > Fix For: 3.2.2 > > > I just made an attempt to serialise lambdas and send them via the > RemoteGraph. I didn't quite get there, but wanted to share my findings: > * it's possible to serialise lambdas on the jvm by just extending > `Serializable`: > http://stackoverflow.com/questions/22807912/how-to-serialize-a-lambda/22808112#22808112 > * sending a normal predicate doesn't work (this is a Scala REPL but it should > be pretty easy to convert this to java/groovy) > val g = RemoteGraph.open("conf/remote-graph.properties").traversal() > val pred1 = new java.util.function.Predicate[Traverser[Vertex]] { def > test(v: Traverser[Vertex]) = true } > g.V().filter(pred1).toList > // java.lang.RuntimeException: java.io.NotSerializableException: $anon$1 > // on server: nothing > > * simply adding Serializable let's us send it over the wire, but the server > doesn't deserialise it > val pred2 = new java.util.function.Predicate[Traverser[Vertex]] with > Serializable { def test(v: Traverser[Vertex]) = true } > g.V().filter(pred2).toList > // on server: [WARN] OpExecutorHandler - Could not deserialize the > Traversal instance > org.apache.tinkerpop.gremlin.server.op.OpProcessorException: Could > not deserialize the Traversal instance > at > org.apache.tinkerpop.gremlin.server.op.traversal.TraversalOpProcessor.iterateOp(TraversalOpProcessor.java:135) > at > org.apache.tinkerpop.gremlin.server.handler.OpExecutorHandler.channelRead0(OpExecutorHandler.java:68) > // on client: > org.apache.tinkerpop.gremlin.driver.exception.ResponseException: $anon$1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TINKERPOP-1422) Remove deprecated RemoteGraph and RemoteStrategy
[ https://issues.apache.org/jira/browse/TINKERPOP-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1422: Labels: breaking deprecation (was: ) > Remove deprecated RemoteGraph and RemoteStrategy > > > Key: TINKERPOP-1422 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1422 > Project: TinkerPop > Issue Type: Improvement > Components: driver >Affects Versions: 3.2.1 >Reporter: stephen mallette >Priority: Minor > Labels: breaking, deprecation > > {{RemoteGraph}} was replaced by {{GraphTraversalSource.withRemote()}} and > {{RemoteStrategy}} was replaced by {{RemoteTraversalStrategy}}. Technically, > the current deprecated {{RemoteStrategy}} should be deleted and > {{RemoteTraversalStrategy}} could become the "new" {{RemoteStrategy}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TINKERPOP-1422) Remove deprecated RemoteGraph and RemoteStrategy
stephen mallette created TINKERPOP-1422: --- Summary: Remove deprecated RemoteGraph and RemoteStrategy Key: TINKERPOP-1422 URL: https://issues.apache.org/jira/browse/TINKERPOP-1422 Project: TinkerPop Issue Type: Improvement Components: driver Affects Versions: 3.2.1 Reporter: stephen mallette Priority: Minor {{RemoteGraph}} was replaced by {{GraphTraversalSource.withRemote()}} and {{RemoteStrategy}} was replaced by {{RemoteTraversalStrategy}}. Technically, the current deprecated {{RemoteStrategy}} should be deleted and {{RemoteTraversalStrategy}} could become the "new" {{RemoteStrategy}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TINKERPOP-1421) Remove deprecated ControlOps
stephen mallette created TINKERPOP-1421: --- Summary: Remove deprecated ControlOps Key: TINKERPOP-1421 URL: https://issues.apache.org/jira/browse/TINKERPOP-1421 Project: TinkerPop Issue Type: Improvement Components: server Affects Versions: 3.2.1 Reporter: stephen mallette Priority: Minor {{ControlOps}} were never really documented or used - shouldn't affect too much to remove them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TINKERPOP-1420) Remove deprecated ConcurrentBindings in gremlin-groovy
[ https://issues.apache.org/jira/browse/TINKERPOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1420: Summary: Remove deprecated ConcurrentBindings in gremlin-groovy (was: Remote deprecated ConcurrentBindings in gremlin-groovy) > Remove deprecated ConcurrentBindings in gremlin-groovy > -- > > Key: TINKERPOP-1420 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1420 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.2.1 >Reporter: stephen mallette >Priority: Minor > Labels: breaking, deprecation > > {{ConcurrentBindings}} were moved to to {{gremlin-core}} - the old class in > {{gremlin-groovy}} was deprecated and can be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TINKERPOP-1420) Remote deprecated ConcurrentBindings in gremlin-groovy
[ https://issues.apache.org/jira/browse/TINKERPOP-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1420: Labels: breaking deprecation (was: ) > Remote deprecated ConcurrentBindings in gremlin-groovy > -- > > Key: TINKERPOP-1420 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1420 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.2.1 >Reporter: stephen mallette >Priority: Minor > Labels: breaking, deprecation > > {{ConcurrentBindings}} were moved to to {{gremlin-core}} - the old class in > {{gremlin-groovy}} was deprecated and can be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (TINKERPOP-1419) Wrong exception when a SessionedClient is initialized with no available host
[ https://issues.apache.org/jira/browse/TINKERPOP-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1419. --- Resolution: Fixed Assignee: stephen mallette Fix Version/s: 3.2.2 3.1.4 > Wrong exception when a SessionedClient is initialized with no available host > > > Key: TINKERPOP-1419 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1419 > Project: TinkerPop > Issue Type: Bug > Components: driver >Affects Versions: 3.2.1 >Reporter: David Clement >Assignee: stephen mallette >Priority: Trivial > Fix For: 3.1.4, 3.2.2 > > > When a SessionedClient is initialized and no host is available in the cluster, > We got an indexOutOfBoundsException instead of a proper Exception like when > we try to contact a closed client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop pull request #392: TINKERPOP-1419 : Throw a proper exception when ...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1419) Wrong exception when a SessionedClient is initialized with no available host
[ https://issues.apache.org/jira/browse/TINKERPOP-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446403#comment-15446403 ] ASF GitHub Bot commented on TINKERPOP-1419: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/392 Thanks for this. Merged via CTR to tp31 and then master. > Wrong exception when a SessionedClient is initialized with no available host > > > Key: TINKERPOP-1419 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1419 > Project: TinkerPop > Issue Type: Bug > Components: driver >Affects Versions: 3.2.1 >Reporter: David Clement >Priority: Trivial > > When a SessionedClient is initialized and no host is available in the cluster, > We got an indexOutOfBoundsException instead of a proper Exception like when > we try to contact a closed client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop issue #392: TINKERPOP-1419 : Throw a proper exception when no avai...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/392 Thanks for this. Merged via CTR to tp31 and then master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Building gremlin-python
Wow Stephen thanks for all your hard work! This will really make driver development a lot easier. On Sun, Aug 28, 2016 at 6:48 PM, Stephen Mallettewrote: > Took me half of my Sunday, but I just got Gremlin Server to start up and > shutdown in the standard maven integration-test phase of gremlin-python. > That means we can now write native python tests that round-trip to Gremlin > Server in addition to the regular unit tests with pytest we already have! I > actual Note that I actually start two gremlin servers one with auth on and > one without (ports 8183/8182 respectively) so that we can test > authentication features. Further note that native tests are bound to the > integration-test phase of maven and run automatically on -glvPython. that's > a bit different from our other projects where integration test phases only > run if you -DskipIntegrationTests=false. gremlin-python won't obey that > setting. > > > > On Sat, Aug 27, 2016 at 6:05 AM, Stephen Mallette > wrote: > >> Now that gremlin-python has been merged to master, you might wonder about >> what this has done to our build/release process. Well, not very much. If >> you do your standard >> >> mvn clean install >> >> on master right now you should see that everything builds and is good to >> go - even gremlin-python. So, everything is good, right? right? well, yes >> and no. >> >> The "yes" aspect here is that the entire project still builds with maven >> which keeps our build toolchain simple. Users can just have java installed >> as they always did and still get a clean build of TinkerPop. The "no" >> aspect is that native python tests (and if you were deploy, >> packaging/deployment tasks) did not execute. >> >> What's good however is that even the native python build tasks are still >> just part of the maven toolchain. You just need to have python 2.x >> installed and, if you do, build with: >> >> mvn clean install -DglvPython >> >> You will now see in your output the results of native pytest execution. I >> think this approach almost sets the basic pattern for future GLVs. I'd >> prefer to not have -glvPython to some degree and simply detect python on >> the system and then execute natively if it can, but then i think about what >> happens as we add more GLVs and then i sorta like the idea of having the >> specific option to turn things on and off. >> >> >> -- David M. Brown R.A. CulturePlex Lab, Western University
[jira] [Closed] (TINKERPOP-1274) GraphSON Version 2.0
[ https://issues.apache.org/jira/browse/TINKERPOP-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1274. --- Resolution: Done Assignee: stephen mallette > GraphSON Version 2.0 > > > Key: TINKERPOP-1274 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1274 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.1.2-incubating >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Minor > Fix For: 3.2.2 > > > Develop a revised version of GraphSON that provides better support for > non-JVM languages that consume it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1419) Wrong exception when a SessionedClient is initialized with no available host
[ https://issues.apache.org/jira/browse/TINKERPOP-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445371#comment-15445371 ] ASF GitHub Bot commented on TINKERPOP-1419: --- GitHub user davidclement90 opened a pull request: https://github.com/apache/tinkerpop/pull/392 TINKERPOP-1419 : Throw a proper exception when no available host in a SessionedClient When a SessionedClient is initialized and no host is available in the cluster, A proper exception is thrown instead of an IndexOutOfBoundsException You can merge this pull request into a Git repository by running: $ git pull https://github.com/davidclement90/tinkerpop TINKERPOP-1419 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/392.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #392 commit a50546397d05f53a64717e7c4ed9535c27dd3eed Author: davidclement90Date: 2016-08-29T09:30:49Z Throw a proper exception when no available host When a SessionedClient is initialized and no host is available in the cluster, A proper exception is thrown instead of an IndexOutOfBoundsException > Wrong exception when a SessionedClient is initialized with no available host > > > Key: TINKERPOP-1419 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1419 > Project: TinkerPop > Issue Type: Bug > Components: driver >Affects Versions: 3.2.1 >Reporter: David Clement >Priority: Trivial > > When a SessionedClient is initialized and no host is available in the cluster, > We got an indexOutOfBoundsException instead of a proper Exception like when > we try to contact a closed client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] tinkerpop pull request #392: TINKERPOP-1419 : Throw a proper exception when ...
GitHub user davidclement90 opened a pull request: https://github.com/apache/tinkerpop/pull/392 TINKERPOP-1419 : Throw a proper exception when no available host in a SessionedClient When a SessionedClient is initialized and no host is available in the cluster, A proper exception is thrown instead of an IndexOutOfBoundsException You can merge this pull request into a Git repository by running: $ git pull https://github.com/davidclement90/tinkerpop TINKERPOP-1419 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/392.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #392 commit a50546397d05f53a64717e7c4ed9535c27dd3eed Author: davidclement90Date: 2016-08-29T09:30:49Z Throw a proper exception when no available host When a SessionedClient is initialized and no host is available in the cluster, A proper exception is thrown instead of an IndexOutOfBoundsException --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (TINKERPOP-1419) Wrong exception when a SessionedClient is initialized with no available host
David Clement created TINKERPOP-1419: Summary: Wrong exception when a SessionedClient is initialized with no available host Key: TINKERPOP-1419 URL: https://issues.apache.org/jira/browse/TINKERPOP-1419 Project: TinkerPop Issue Type: Bug Components: driver Affects Versions: 3.2.1 Reporter: David Clement Priority: Trivial When a SessionedClient is initialized and no host is available in the cluster, We got an indexOutOfBoundsException instead of a proper Exception like when we try to contact a closed client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)