[jira] [Commented] (TINKERPOP-1493) Groovy project doesn't build on Windows
[
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15638373#comment-15638373
]
ASF GitHub Bot commented on TINKERPOP-1493:
---
Github user pluradj commented on the issue:
https://github.com/apache/tinkerpop/pull/457
any update on your Docker build @spmallette? still works ok for me.
> Groovy project doesn't build on Windows
> ---
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
> Issue Type: Bug
> Components: groovy
>Affects Versions: 3.2.2
>Reporter: Paul Jackson
>Assignee: Jason Plurad
>Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir
> is creating a path consisting of two full paths concatenated together. The
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new
> File(System.getProperty("user.dir"),
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is
> because some instances of JarFile are created on it but not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/457 any update on your Docker build @spmallette? still works ok for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1542) Add Path.isEmpty() with a default implementation.
[
https://issues.apache.org/jira/browse/TINKERPOP-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15638172#comment-15638172
]
ASF GitHub Bot commented on TINKERPOP-1542:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/480
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
> Add Path.isEmpty() with a default implementation.
> -
>
> Key: TINKERPOP-1542
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1542
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.3
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
>
> We have lots of {{path.size() == 0}} which for {{ImmutablePath}} is a
> recursion. A {{path.isEmpty()}} is a O(1) call. Given how heavily used
> {{ImmutablePath}} is, we should provide {{Path.isEmpty()}} with the following
> default implementation.
> {code}
> public default boolean isEmpty() {
> return this.size() == 0;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #480: TINKERPOP-1542: Add Path.isEmpty() with a default impl...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/480 All tests pass with `docker/build.sh -t -n -i` VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1473) Given PathRetractionStrategy, PathProcessorStrategy can be extended to support partial where() inlining.
[
https://issues.apache.org/jira/browse/TINKERPOP-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637277#comment-15637277
]
ASF GitHub Bot commented on TINKERPOP-1473:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/477
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
> Given PathRetractionStrategy, PathProcessorStrategy can be extended to
> support partial where() inlining.
>
>
> Key: TINKERPOP-1473
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1473
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.2
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
>
> {{PathProcessorStrategy}} has a big chunk of code commented out in it that
> says: "todo: need to be able to drop path labels for this to work."
> Given {{PathRetractionStrategy}}, we can now support:
> {code}
> where(as('a').out().as('b')) => select('a').where(out().as('b'))
> {code}
> This is useful for OLAP when you can only process the local star graph and
> thus, if {{where()}} selects arbitrarily from a path, this rewrite will
> ensure that the {{where()}} starts at a local star graph and not a "reference
> element" in the path object.
> Note that {{PathProcessorStrategy}} already has test cases for this too
> (commented out). Just uncomment stuff and go!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #477: TINKERPOP-1473: Given PathRetractionStrategy, PathProc...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/477 All tests pass with `docker/build.sh -t -n -i` VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (TINKERPOP-1292) TinkerGraphComputer VertexProgramInterceptors
[
https://issues.apache.org/jira/browse/TINKERPOP-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez closed TINKERPOP-1292.
-
Resolution: Fixed
Assignee: Marko A. Rodriguez
> TinkerGraphComputer VertexProgramInterceptors
> -
>
> Key: TINKERPOP-1292
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1292
> Project: TinkerPop
> Issue Type: Improvement
> Components: process, tinkergraph
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.4
>
>
> Create {{TinkerGraphInterceptorStrategy}} for {{TinkerGraphComputer}} and
> grow it starting with the two simple patterns below:
> {code}
> g.V().count() -> tinkerGraph.vertices.size()
> g.E().count() -> tinkerGraph.edges.size()
> {code}
> In fact, perhaps even create {{TinkerGraphCountStep}} for OLTP as well that
> does the above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1211) UnfoldStep should unfold arrays.
[
https://issues.apache.org/jira/browse/TINKERPOP-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636205#comment-15636205
]
ASF GitHub Bot commented on TINKERPOP-1211:
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/475#discussion_r86534725
--- Diff: CHANGELOG.asciidoc ---
@@ -26,6 +26,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET)
~~~
+* `UnfoldStep` now supports unfolding of arrays. (*breaking*)
--- End diff --
I don't really like the use of "breaking" in the CHANGELOG for our manual
entries. The JIRA ticket will have that when we generate that list on release.
Also, we've not done that consistently from the start of CHANGELOG. If
something is "breaking" the better way to call attention to it is in the
upgrade docs where we can better describe and demonstrate the change for users
rather than a single one-liner in CHANGELOG.
> UnfoldStep should unfold arrays.
>
>
> Key: TINKERPOP-1211
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1211
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.1.1-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Labels: breaking
> Fix For: 3.3.0
>
>
> Currently {{UnfoldStep}} does not unfold arrays as an array does not
> implement {{Iterable}} or {{Iterator}}. We simply need to check if the
> current object is an array, and if so, set the flatMap-iterator to
> {{ArrayIterator}}.
> This would be breaking, but I doubt anyone ever uses arrays or would find
> this a problem. I'm sure anyone who wanted to {{unfold}} an array was like:
> "wha?"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop pull request #475: TINKERPOP-1211: UnfoldStep should unfold arrays...
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/475#discussion_r86534725 --- Diff: CHANGELOG.asciidoc --- @@ -26,6 +26,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET) ~~~ +* `UnfoldStep` now supports unfolding of arrays. (*breaking*) --- End diff -- I don't really like the use of "breaking" in the CHANGELOG for our manual entries. The JIRA ticket will have that when we generate that list on release. Also, we've not done that consistently from the start of CHANGELOG. If something is "breaking" the better way to call attention to it is in the upgrade docs where we can better describe and demonstrate the change for users rather than a single one-liner in CHANGELOG. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1292) TinkerGraphComputer VertexProgramInterceptors
[
https://issues.apache.org/jira/browse/TINKERPOP-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636173#comment-15636173
]
ASF GitHub Bot commented on TINKERPOP-1292:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/476
> TinkerGraphComputer VertexProgramInterceptors
> -
>
> Key: TINKERPOP-1292
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1292
> Project: TinkerPop
> Issue Type: Improvement
> Components: process, tinkergraph
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
> Fix For: 3.2.4
>
>
> Create {{TinkerGraphInterceptorStrategy}} for {{TinkerGraphComputer}} and
> grow it starting with the two simple patterns below:
> {code}
> g.V().count() -> tinkerGraph.vertices.size()
> g.E().count() -> tinkerGraph.edges.size()
> {code}
> In fact, perhaps even create {{TinkerGraphCountStep}} for OLTP as well that
> does the above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop pull request #476: TINKERPOP-1292: TinkerGraphComputer VertexProgr...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1211) UnfoldStep should unfold arrays.
[
https://issues.apache.org/jira/browse/TINKERPOP-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636166#comment-15636166
]
ASF GitHub Bot commented on TINKERPOP-1211:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/475
> UnfoldStep should unfold arrays.
>
>
> Key: TINKERPOP-1211
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1211
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.1.1-incubating
>Reporter: Marko A. Rodriguez
> Labels: breaking
> Fix For: 3.3.0
>
>
> Currently {{UnfoldStep}} does not unfold arrays as an array does not
> implement {{Iterable}} or {{Iterator}}. We simply need to check if the
> current object is an array, and if so, set the flatMap-iterator to
> {{ArrayIterator}}.
> This would be breaking, but I doubt anyone ever uses arrays or would find
> this a problem. I'm sure anyone who wanted to {{unfold}} an array was like:
> "wha?"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (TINKERPOP-1211) UnfoldStep should unfold arrays.
[
https://issues.apache.org/jira/browse/TINKERPOP-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marko A. Rodriguez reassigned TINKERPOP-1211:
-
Assignee: Marko A. Rodriguez
> UnfoldStep should unfold arrays.
>
>
> Key: TINKERPOP-1211
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1211
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.1.1-incubating
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Labels: breaking
> Fix For: 3.3.0
>
>
> Currently {{UnfoldStep}} does not unfold arrays as an array does not
> implement {{Iterable}} or {{Iterator}}. We simply need to check if the
> current object is an array, and if so, set the flatMap-iterator to
> {{ArrayIterator}}.
> This would be breaking, but I doubt anyone ever uses arrays or would find
> this a problem. I'm sure anyone who wanted to {{unfold}} an array was like:
> "wha?"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1292) TinkerGraphComputer VertexProgramInterceptors
[
https://issues.apache.org/jira/browse/TINKERPOP-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635914#comment-15635914
]
ASF GitHub Bot commented on TINKERPOP-1292:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/476
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
> TinkerGraphComputer VertexProgramInterceptors
> -
>
> Key: TINKERPOP-1292
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1292
> Project: TinkerPop
> Issue Type: Improvement
> Components: process, tinkergraph
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
> Fix For: 3.2.4
>
>
> Create {{TinkerGraphInterceptorStrategy}} for {{TinkerGraphComputer}} and
> grow it starting with the two simple patterns below:
> {code}
> g.V().count() -> tinkerGraph.vertices.size()
> g.E().count() -> tinkerGraph.edges.size()
> {code}
> In fact, perhaps even create {{TinkerGraphCountStep}} for OLTP as well that
> does the above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] tinkerpop issue #476: TINKERPOP-1292: TinkerGraphComputer VertexProgramInter...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/476 All tests pass with `docker/build.sh -t -n -i` VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
