[jira] [Commented] (TINKERPOP-1493) Groovy project doesn't build on Windows

2016-11-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700354#comment-15700354
 ] 

ASF GitHub Bot commented on TINKERPOP-1493:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
@pauljackson It's all good. It's only the history here in the PR that looks 
weird. Since it's just the one commit, it'll be right in git history when it's 
actually merged.


> Groovy project doesn't build on Windows
> ---
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
>  Issue Type: Bug
>  Components: groovy
>Affects Versions: 3.2.2
>Reporter: Paul Jackson
>Assignee: Jason Plurad
>Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir 
> is creating a path consisting of two full paths concatenated together. The 
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new 
> File(System.getProperty("user.dir"), 
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is 
> because some instances of JarFile are created on it but not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

2016-11-27 Thread robertdale 
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
@pauljackson It's all good. It's only the history here in the PR that looks 
weird. Since it's just the one commit, it'll be right in git history when it's 
actually merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

2016-11-27 Thread pauljackson 
Github user pauljackson commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
It didn’t look intuitively correct, but I didn’t know what was normal. 
What’s the easiest way to make this right, right, right? Just start over and 
create a new pull request?

Thanks,
-Paul


From: Robert Dale [mailto:notificati...@github.com]
Sent: Sunday, November 27, 2016 8:41 AM
To: apache/tinkerpop
Cc: Paul A. Jackson; Mention
Subject: Re: [apache/tinkerpop] TINKERPOP-1493 Groovy project doesn't build 
on Windows (#457)


I didn't consider that your remote branch was behind. Duh. What should have 
been done is a forced push git push -f origin tp31 to replace your remote 
branch with your local branch. Instead git ended up doing a merge and the 
history here looks a little weird because it pulled in all the changes since 
your changes. But git does the right thing and it merges cleanly on tp31.

Build passes on Linux. Can't test on windows.

VOTE: +0.5

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1493) Groovy project doesn't build on Windows

2016-11-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700217#comment-15700217
 ] 

ASF GitHub Bot commented on TINKERPOP-1493:
---

Github user pauljackson commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
It didn’t look intuitively correct, but I didn’t know what was normal. 
What’s the easiest way to make this right, right, right? Just start over and 
create a new pull request?

Thanks,
-Paul


From: Robert Dale [mailto:notificati...@github.com]
Sent: Sunday, November 27, 2016 8:41 AM
To: apache/tinkerpop
Cc: Paul A. Jackson; Mention
Subject: Re: [apache/tinkerpop] TINKERPOP-1493 Groovy project doesn't build 
on Windows (#457)


I didn't consider that your remote branch was behind. Duh. What should have 
been done is a forced push git push -f origin tp31 to replace your remote 
branch with your local branch. Instead git ended up doing a merge and the 
history here looks a little weird because it pulled in all the changes since 
your changes. But git does the right thing and it merges cleanly on tp31.

Build passes on Linux. Can't test on windows.

VOTE: +0.5

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.






> Groovy project doesn't build on Windows
> ---
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
>  Issue Type: Bug
>  Components: groovy
>Affects Versions: 3.2.2
>Reporter: Paul Jackson
>Assignee: Jason Plurad
>Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir 
> is creating a path consisting of two full paths concatenated together. The 
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new 
> File(System.getProperty("user.dir"), 
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is 
> because some instances of JarFile are created on it but not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TINKERPOP-1493) Groovy project doesn't build on Windows

2016-11-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15699706#comment-15699706
 ] 

ASF GitHub Bot commented on TINKERPOP-1493:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
I didn't consider that your remote branch was behind. Duh. What should have 
been done is a forced push `git push -f origin tp31` to replace your remote 
branch with your local branch.  Instead git ended up doing a merge and the 
history here looks a little weird because it pulled in all the changes since 
your changes. But git does the right thing and it merges cleanly on tp31.

Build passes on Linux. Can't test on windows.

VOTE: +0.5



> Groovy project doesn't build on Windows
> ---
>
> Key: TINKERPOP-1493
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1493
> Project: TinkerPop
>  Issue Type: Bug
>  Components: groovy
>Affects Versions: 3.2.2
>Reporter: Paul Jackson
>Assignee: Jason Plurad
>Priority: Minor
>
> Builds on Windows fail for two reasons. First the line to create extTestDir 
> is creating a path consisting of two full paths concatenated together. The 
> second drive letter is seen as an illegal character:
> {code}private static final File extTestDir = new 
> File(System.getProperty("user.dir"), 
> TestHelper.makeTestDataDirectory(DependencyGrabberTest.class));{code}
> Second, when it comes time to delete the directory it is locked. This is 
> because some instances of JarFile are created on it but not closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

2016-11-27 Thread robertdale 
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
I didn't consider that your remote branch was behind. Duh. What should have 
been done is a forced push `git push -f origin tp31` to replace your remote 
branch with your local branch.  Instead git ended up doing a merge and the 
history here looks a little weird because it pulled in all the changes since 
your changes. But git does the right thing and it merges cleanly on tp31.

Build passes on Linux. Can't test on windows.

VOTE: +0.5



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1493) Groovy project doesn't build on Windows

2016-11-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15699625#comment-15699625
 ] 

ASF GitHub Bot commented on TINKERPOP-1493:
---

Github user pauljackson commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
Thank you Robert. This was adequate, I think, to give me some things to 
Google.

I’ve run these commands from my local clone of my fork. It looks like that 
was all that was necessary. No new pull request. When I look at the status of 
the old pull request in the main repo it has incorporated 24 other commits 
since Oct 12 and the status of the request is that the Travis build is pending. 
Here’s the commands, if someone would be kind to review and confirm. Thanks. 
–Paul

D:\Data\TEMP\@Other\tinkerpop>git fetch --all
Fetching origin
Fetching apache
remote: Counting objects: 8094, done.
remote: Compressing objects: 100% (823/823), done.
remote: Total 8094 (delta 1986), reused 1680 (delta 1678), pack-reused 5064
Receiving objects: 100% (8094/8094), 11.66 MiB | 1.53 MiB/s, done.
Resolving deltas: 100% (3030/3030), completed with 560 local objects.
From https://github.com/apache/tinkerpop
* [new branch]  TINKERPOP-1211  -> apache/TINKERPOP-1211
* [new branch]  TINKERPOP-1235  -> apache/TINKERPOP-1235
* [new branch]  TINKERPOP-1292  -> apache/TINKERPOP-1292
* [new branch]  TINKERPOP-1363  -> apache/TINKERPOP-1363
* [new branch]  TINKERPOP-1372  -> apache/TINKERPOP-1372
+ 302df7c...69877a2 TINKERPOP-1389  -> apache/TINKERPOP-1389  
(forced update)
* [new branch]  TINKERPOP-1399  -> apache/TINKERPOP-1399
* [new branch]  TINKERPOP-1420  -> apache/TINKERPOP-1420
* [new branch]  TINKERPOP-1428  -> apache/TINKERPOP-1428
* [new branch]  TINKERPOP-1434  -> apache/TINKERPOP-1434
* [new branch]  TINKERPOP-1471  -> apache/TINKERPOP-1471
* [new branch]  TINKERPOP-1473  -> apache/TINKERPOP-1473
* [new branch]  TINKERPOP-1485  -> apache/TINKERPOP-1485
* [new branch]  TINKERPOP-1490  -> apache/TINKERPOP-1490
* [new branch]  TINKERPOP-1502  -> apache/TINKERPOP-1502
* [new branch]  TINKERPOP-1506  -> apache/TINKERPOP-1506
* [new branch]  TINKERPOP-1507  -> apache/TINKERPOP-1507
* [new branch]  TINKERPOP-1508  -> apache/TINKERPOP-1508
* [new branch]  TINKERPOP-1520  -> apache/TINKERPOP-1520
* [new branch]  TINKERPOP-1527  -> apache/TINKERPOP-1527
* [new branch]  TINKERPOP-1529  -> apache/TINKERPOP-1529
* [new branch]  TINKERPOP-1529-variant2 -> 
apache/TINKERPOP-1529-variant2
* [new branch]  TINKERPOP-1530  -> apache/TINKERPOP-1530
* [new branch]  TINKERPOP-1534  -> apache/TINKERPOP-1534
* [new branch]  TINKERPOP-1538  -> apache/TINKERPOP-1538
* [new branch]  TINKERPOP-1538-master   -> apache/TINKERPOP-1538-master
* [new branch]  TINKERPOP-1538-tp32 -> apache/TINKERPOP-1538-tp32
* [new branch]  TINKERPOP-1541  -> apache/TINKERPOP-1541
* [new branch]  TINKERPOP-1542  -> apache/TINKERPOP-1542
* [new branch]  TINKERPOP-1543  -> apache/TINKERPOP-1543
* [new branch]  TINKERPOP-1545  -> apache/TINKERPOP-1545
* [new branch]  TINKERPOP-1545-tp32 -> apache/TINKERPOP-1545-tp32
* [new branch]  TINKERPOP-1547  -> apache/TINKERPOP-1547
* [new branch]  TINKERPOP-1548  -> apache/TINKERPOP-1548
* [new branch]  TINKERPOP-1557  -> apache/TINKERPOP-1557
* [new branch]  TINKERPOP-1561  -> apache/TINKERPOP-1561
* [new branch]  TINKERPOP-1562  -> apache/TINKERPOP-1562
* [new branch]  TINKERPOP-1564  -> apache/TINKERPOP-1564
* [new branch]  TINKERPOP-919   -> apache/TINKERPOP-919
* [new branch]  TINKERPOP-932   -> apache/TINKERPOP-932
* [new branch]  example_python_promise  -> apache/example_python_promise
   227b85c..16180e1  master  -> apache/master
   4a4c526..4745fe1  tp31-> apache/tp31
* [new branch]  tp32-> apache/tp32
* [new tag] 3.1.5   -> 3.1.5
* [new tag] 3.2.3   -> 3.2.3

D:\Data\TEMP\@Other\tinkerpop>git checkout tp31
Already on 'tp31'
Your branch is up-to-date with 'origin/tp31'.

D:\Data\TEMP\@Other\tinkerpop>git rebase upstream/tp31
fatal: Needed a single revision
invalid upstream upstream/tp31

D:\Data\TEMP\@Other\tinkerpop>git status
On branch tp31
Your

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

2016-11-27 Thread pauljackson 
Github user pauljackson commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
Thank you Robert. This was adequate, I think, to give me some things to 
Google.

I’ve run these commands from my local clone of my fork. It looks like 
that was all that was necessary. No new pull request. When I look at the status 
of the old pull request in the main repo it has incorporated 24 other commits 
since Oct 12 and the status of the request is that the Travis build is pending. 
Here’s the commands, if someone would be kind to review and confirm. Thanks. 
–Paul

D:\Data\TEMP\@Other\tinkerpop>git fetch --all
Fetching origin
Fetching apache
remote: Counting objects: 8094, done.
remote: Compressing objects: 100% (823/823), done.
remote: Total 8094 (delta 1986), reused 1680 (delta 1678), pack-reused 5064
Receiving objects: 100% (8094/8094), 11.66 MiB | 1.53 MiB/s, done.
Resolving deltas: 100% (3030/3030), completed with 560 local objects.
From https://github.com/apache/tinkerpop
* [new branch]  TINKERPOP-1211  -> apache/TINKERPOP-1211
* [new branch]  TINKERPOP-1235  -> apache/TINKERPOP-1235
* [new branch]  TINKERPOP-1292  -> apache/TINKERPOP-1292
* [new branch]  TINKERPOP-1363  -> apache/TINKERPOP-1363
* [new branch]  TINKERPOP-1372  -> apache/TINKERPOP-1372
+ 302df7c...69877a2 TINKERPOP-1389  -> apache/TINKERPOP-1389  
(forced update)
* [new branch]  TINKERPOP-1399  -> apache/TINKERPOP-1399
* [new branch]  TINKERPOP-1420  -> apache/TINKERPOP-1420
* [new branch]  TINKERPOP-1428  -> apache/TINKERPOP-1428
* [new branch]  TINKERPOP-1434  -> apache/TINKERPOP-1434
* [new branch]  TINKERPOP-1471  -> apache/TINKERPOP-1471
* [new branch]  TINKERPOP-1473  -> apache/TINKERPOP-1473
* [new branch]  TINKERPOP-1485  -> apache/TINKERPOP-1485
* [new branch]  TINKERPOP-1490  -> apache/TINKERPOP-1490
* [new branch]  TINKERPOP-1502  -> apache/TINKERPOP-1502
* [new branch]  TINKERPOP-1506  -> apache/TINKERPOP-1506
* [new branch]  TINKERPOP-1507  -> apache/TINKERPOP-1507
* [new branch]  TINKERPOP-1508  -> apache/TINKERPOP-1508
* [new branch]  TINKERPOP-1520  -> apache/TINKERPOP-1520
* [new branch]  TINKERPOP-1527  -> apache/TINKERPOP-1527
* [new branch]  TINKERPOP-1529  -> apache/TINKERPOP-1529
* [new branch]  TINKERPOP-1529-variant2 -> 
apache/TINKERPOP-1529-variant2
* [new branch]  TINKERPOP-1530  -> apache/TINKERPOP-1530
* [new branch]  TINKERPOP-1534  -> apache/TINKERPOP-1534
* [new branch]  TINKERPOP-1538  -> apache/TINKERPOP-1538
* [new branch]  TINKERPOP-1538-master   -> apache/TINKERPOP-1538-master
* [new branch]  TINKERPOP-1538-tp32 -> apache/TINKERPOP-1538-tp32
* [new branch]  TINKERPOP-1541  -> apache/TINKERPOP-1541
* [new branch]  TINKERPOP-1542  -> apache/TINKERPOP-1542
* [new branch]  TINKERPOP-1543  -> apache/TINKERPOP-1543
* [new branch]  TINKERPOP-1545  -> apache/TINKERPOP-1545
* [new branch]  TINKERPOP-1545-tp32 -> apache/TINKERPOP-1545-tp32
* [new branch]  TINKERPOP-1547  -> apache/TINKERPOP-1547
* [new branch]  TINKERPOP-1548  -> apache/TINKERPOP-1548
* [new branch]  TINKERPOP-1557  -> apache/TINKERPOP-1557
* [new branch]  TINKERPOP-1561  -> apache/TINKERPOP-1561
* [new branch]  TINKERPOP-1562  -> apache/TINKERPOP-1562
* [new branch]  TINKERPOP-1564  -> apache/TINKERPOP-1564
* [new branch]  TINKERPOP-919   -> apache/TINKERPOP-919
* [new branch]  TINKERPOP-932   -> apache/TINKERPOP-932
* [new branch]  example_python_promise  -> apache/example_python_promise
   227b85c..16180e1  master  -> apache/master
   4a4c526..4745fe1  tp31-> apache/tp31
* [new branch]  tp32-> apache/tp32
* [new tag] 3.1.5   -> 3.1.5
* [new tag] 3.2.3   -> 3.2.3

D:\Data\TEMP\@Other\tinkerpop>git checkout tp31
Already on 'tp31'
Your branch is up-to-date with 'origin/tp31'.

D:\Data\TEMP\@Other\tinkerpop>git rebase upstream/tp31
fatal: Needed a single revision
invalid upstream upstream/tp31

D:\Data\TEMP\@Other\tinkerpop>git status
On branch tp31
Your branch is up-to-date with 'origin/tp31'.
nothing to commit, working tree clean

D:\Data\TEMP\@Other\tinkerpop>git remote -v
apache  https://github.com/apache/tinkerpop.git (fetch)
apache

Re: [DISCUSS] Graph.addVertex(Map)

2016-11-27 Thread pieter-gmail 
Hi,

I saw this
http://iteratrlearning.com/java9/2016/11/09/java9-collection-factory-methods
Creating maps will become easier (less typing) in java 9.

Cheers
Pieter

On 20/09/2016 18:49, Stephen Mallette wrote:
> Anyone interested in seeing a Graph.addVertex(Map) overload?
>
> https://issues.apache.org/jira/browse/TINKERPOP-1174
>
> I don't imagine there would be any change to addV() in this case. I'm
> thinking that we wouldn't likely use this method internally and so it would
> more be something for user convenience, in which case, it seems to
> encourage more use of the Graph API which we're typically trying to do less
> of.
>