[GitHub] tinkerpop issue #595: TINKERPOP-1608 XSLT for converting GraphSON
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/595 Thanks @pluradj - cleaned up the couple odds/ends you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1608) TP2-to-TP3 GraphML XSLT
[
https://issues.apache.org/jira/browse/TINKERPOP-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961353#comment-15961353
]
ASF GitHub Bot commented on TINKERPOP-1608:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/595
Thanks @pluradj - cleaned up the couple odds/ends you mentioned.
> TP2-to-TP3 GraphML XSLT
> ---
>
> Key: TINKERPOP-1608
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1608
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.1.5, 3.2.3
>Reporter: Jason Plurad
>
> There were some changes in the GraphML format between TinkerPop 2 and
> TinkerPop 3. [~joshsh] has [started
> work|https://github.com/apache/tinkerpop/pull/501] on an XSLT to transform
> between the two formats.
> I performed an initial test of the transform using this code within the
> Gremlin Console.
> {noformat}
> import javax.xml.parsers.DocumentBuilderFactory
> import javax.xml.transform.TransformerFactory
> import javax.xml.transform.dom.DOMSource
> import javax.xml.transform.stream.StreamSource
> import javax.xml.transform.stream.StreamResult
> stylesheet = new File('/tmp/tp-graphml-convert.xslt')
> datafile = new File('/tmp/tp2-graphml.xml')
> outfile = new File('/tmp/tp3-graphml.xml')
> tFactory = TransformerFactory.newInstance()
> stylesource = new StreamSource(stylesheet)
> transformer = tFactory.newTransformer(stylesource)
> source = new StreamSource(datafile)
> result = new StreamResult(new FileWriter(outfile))
> transformer.transform(source, result)
> {noformat}
> Example TinkerPop 2 GraphML:
> https://github.com/tinkerpop/gremlin/blob/master/data/graph-example-1.xml
> Example TinkerPop 3 GraphML:
> https://github.com/apache/tinkerpop/blob/3.1.5/data/tinkerpop-classic.xml
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] tinkerpop pull request #595: TINKERPOP-1608 XSLT for converting GraphSON
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/595#discussion_r110463999
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java
---
@@ -286,6 +289,34 @@ public void shouldReadWriteSelfLoopingEdges() throws
Exception {
assertEquals(IteratorUtils.count(source.vertices()),
IteratorUtils.count(target.vertices()));
assertEquals(IteratorUtils.count(source.edges()),
IteratorUtils.count(target.edges()));
}
+
+@Test
+@FeatureRequirement(featureClass =
Graph.Features.EdgeFeatures.class, feature =
Graph.Features.EdgeFeatures.FEATURE_ADD_EDGES)
+@FeatureRequirement(featureClass =
Graph.Features.VertexFeatures.class, feature =
Graph.Features.VertexFeatures.FEATURE_ADD_VERTICES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_STRING_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_INTEGER_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_FLOAT_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_BOOLEAN_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_LONG_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_DOUBLE_VALUES)
--- End diff --
only need `String` and `Integer` vertex properties.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TINKERPOP-1608) TP2-to-TP3 GraphML XSLT
[
https://issues.apache.org/jira/browse/TINKERPOP-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961339#comment-15961339
]
ASF GitHub Bot commented on TINKERPOP-1608:
---
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/595#discussion_r110464956
--- Diff: docs/src/reference/the-graph.asciidoc ---
@@ -444,6 +444,32 @@ try (final InputStream stream = new
FileInputStream("tinkerpop-modern.xml")) {
}
+GraphML was a supported format in TinkerPop 2.x, but there were several
issues that made it inconsistent with the
+specification that were corrected for 3.x. As a result, attempting to read
a GraphML file generated by 2.x with the
+3.x `GraphMLReader` will result in error. To help with this problem, an
XSLT file is provided as a resource in
+`gremlin-core` which will transform 2.x GraphML to 3.x GraphML. It can be
used as follows:
+
+[source,java]
--- End diff --
If this doc is Java rather than Groovy, the syntax needs to be tidied up a
bit with semicolons and double quoted strings.
> TP2-to-TP3 GraphML XSLT
> ---
>
> Key: TINKERPOP-1608
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1608
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.1.5, 3.2.3
>Reporter: Jason Plurad
>
> There were some changes in the GraphML format between TinkerPop 2 and
> TinkerPop 3. [~joshsh] has [started
> work|https://github.com/apache/tinkerpop/pull/501] on an XSLT to transform
> between the two formats.
> I performed an initial test of the transform using this code within the
> Gremlin Console.
> {noformat}
> import javax.xml.parsers.DocumentBuilderFactory
> import javax.xml.transform.TransformerFactory
> import javax.xml.transform.dom.DOMSource
> import javax.xml.transform.stream.StreamSource
> import javax.xml.transform.stream.StreamResult
> stylesheet = new File('/tmp/tp-graphml-convert.xslt')
> datafile = new File('/tmp/tp2-graphml.xml')
> outfile = new File('/tmp/tp3-graphml.xml')
> tFactory = TransformerFactory.newInstance()
> stylesource = new StreamSource(stylesheet)
> transformer = tFactory.newTransformer(stylesource)
> source = new StreamSource(datafile)
> result = new StreamResult(new FileWriter(outfile))
> transformer.transform(source, result)
> {noformat}
> Example TinkerPop 2 GraphML:
> https://github.com/tinkerpop/gremlin/blob/master/data/graph-example-1.xml
> Example TinkerPop 3 GraphML:
> https://github.com/apache/tinkerpop/blob/3.1.5/data/tinkerpop-classic.xml
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1608) TP2-to-TP3 GraphML XSLT
[
https://issues.apache.org/jira/browse/TINKERPOP-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961338#comment-15961338
]
ASF GitHub Bot commented on TINKERPOP-1608:
---
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/595#discussion_r110463999
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java
---
@@ -286,6 +289,34 @@ public void shouldReadWriteSelfLoopingEdges() throws
Exception {
assertEquals(IteratorUtils.count(source.vertices()),
IteratorUtils.count(target.vertices()));
assertEquals(IteratorUtils.count(source.edges()),
IteratorUtils.count(target.edges()));
}
+
+@Test
+@FeatureRequirement(featureClass =
Graph.Features.EdgeFeatures.class, feature =
Graph.Features.EdgeFeatures.FEATURE_ADD_EDGES)
+@FeatureRequirement(featureClass =
Graph.Features.VertexFeatures.class, feature =
Graph.Features.VertexFeatures.FEATURE_ADD_VERTICES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_STRING_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_INTEGER_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_FLOAT_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_BOOLEAN_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_LONG_VALUES)
+@FeatureRequirement(featureClass = VertexPropertyFeatures.class,
feature = FEATURE_DOUBLE_VALUES)
--- End diff --
only need `String` and `Integer` vertex properties.
> TP2-to-TP3 GraphML XSLT
> ---
>
> Key: TINKERPOP-1608
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1608
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.1.5, 3.2.3
>Reporter: Jason Plurad
>
> There were some changes in the GraphML format between TinkerPop 2 and
> TinkerPop 3. [~joshsh] has [started
> work|https://github.com/apache/tinkerpop/pull/501] on an XSLT to transform
> between the two formats.
> I performed an initial test of the transform using this code within the
> Gremlin Console.
> {noformat}
> import javax.xml.parsers.DocumentBuilderFactory
> import javax.xml.transform.TransformerFactory
> import javax.xml.transform.dom.DOMSource
> import javax.xml.transform.stream.StreamSource
> import javax.xml.transform.stream.StreamResult
> stylesheet = new File('/tmp/tp-graphml-convert.xslt')
> datafile = new File('/tmp/tp2-graphml.xml')
> outfile = new File('/tmp/tp3-graphml.xml')
> tFactory = TransformerFactory.newInstance()
> stylesource = new StreamSource(stylesheet)
> transformer = tFactory.newTransformer(stylesource)
> source = new StreamSource(datafile)
> result = new StreamResult(new FileWriter(outfile))
> transformer.transform(source, result)
> {noformat}
> Example TinkerPop 2 GraphML:
> https://github.com/tinkerpop/gremlin/blob/master/data/graph-example-1.xml
> Example TinkerPop 3 GraphML:
> https://github.com/apache/tinkerpop/blob/3.1.5/data/tinkerpop-classic.xml
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] tinkerpop pull request #595: TINKERPOP-1608 XSLT for converting GraphSON
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/595#discussion_r110464956
--- Diff: docs/src/reference/the-graph.asciidoc ---
@@ -444,6 +444,32 @@ try (final InputStream stream = new
FileInputStream("tinkerpop-modern.xml")) {
}
+GraphML was a supported format in TinkerPop 2.x, but there were several
issues that made it inconsistent with the
+specification that were corrected for 3.x. As a result, attempting to read
a GraphML file generated by 2.x with the
+3.x `GraphMLReader` will result in error. To help with this problem, an
XSLT file is provided as a resource in
+`gremlin-core` which will transform 2.x GraphML to 3.x GraphML. It can be
used as follows:
+
+[source,java]
--- End diff --
If this doc is Java rather than Groovy, the syntax needs to be tidied up a
bit with semicolons and double quoted strings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TINKERPOP-1010) Remove deprecated credentialsDbLocation for SimpleAuthenticator
[ https://issues.apache.org/jira/browse/TINKERPOP-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961310#comment-15961310 ] ASF GitHub Bot commented on TINKERPOP-1010: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/592 Successful build with `docker/build.sh -t -i -n`. Doc updates look good. VOTE: +1 > Remove deprecated credentialsDbLocation for SimpleAuthenticator > --- > > Key: TINKERPOP-1010 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1010 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.1.1-incubating >Reporter: stephen mallette >Priority: Minor > Labels: breaking, deprecation > > This setting was deprecated for 3.1.1-incubating given: > https://issues.apache.org/jira/browse/TINKERPOP3-981 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #592: TINKERPOP-1010 Remove deprecated methods around Gremli...
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/592 Successful build with `docker/build.sh -t -i -n`. Doc updates look good. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1657) Provide abstraction to easily allow different HttpAuth schemes
[ https://issues.apache.org/jira/browse/TINKERPOP-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961195#comment-15961195 ] ASF GitHub Bot commented on TINKERPOP-1657: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/583 Did a successful `docker/build.sh -t -i -n`. Reviewed the code, docs, and test case. Solid PR @krlohnes VOTE: +1 > Provide abstraction to easily allow different HttpAuth schemes > -- > > Key: TINKERPOP-1657 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1657 > Project: TinkerPop > Issue Type: Improvement > Components: server >Reporter: Keith Lohnes > > The current HttpChannelizer allows for extension through an Authenticator > class supplied through the authorization settings. There isn't, however, an > extension point for an authentication handler. Currently the choice is > between the `AllowAllAuthenticator` or the `HttpBasicAuthenticationHandler`. > One would need to create a new channelizer where the HttpChannelizer would > suffice. Creating an abstract class that can be extended would make it easier > to extend Authentication for things like token authentication schemes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #583: TINKERPOP-1657 Provide abstraction to easily allow dif...
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/583 Did a successful `docker/build.sh -t -i -n`. Reviewed the code, docs, and test case. Solid PR @krlohnes VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (TINKERPOP-1361) Better extract logic for invalid binding keys
[
https://issues.apache.org/jira/browse/TINKERPOP-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1361.
---
Resolution: Won't Fix
I had thought that the logic for dealing with these would have been more
complex than what it ended up being - I don't think there's anything that needs
to be done here.
> Better extract logic for invalid binding keys
> -
>
> Key: TINKERPOP-1361
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1361
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.1.2-incubating
>Reporter: stephen mallette
>Priority: Minor
>
> Maybe invalid binding keys would be be better managed in a separate class as
> opposed to being in {{AbstractEvalOpProcessor}}. It could then be
> independently tested and managed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1664: Affects Version/s: (was: 3.2.4) 3.1.6 > StarVertexProperty#property should throw an NPE if the value is null > > > Key: TINKERPOP-1664 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1664 > Project: TinkerPop > Issue Type: Improvement > Components: structure >Affects Versions: 3.1.6 >Reporter: Bryn Cooke > Fix For: 3.1.7 > > > Currently properties are checked for nullness but meta-properties arenot. > This leads to NPEs further down the line. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1664. --- Resolution: Fixed Assignee: stephen mallette Fix Version/s: 3.1.7 > StarVertexProperty#property should throw an NPE if the value is null > > > Key: TINKERPOP-1664 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1664 > Project: TinkerPop > Issue Type: Improvement > Components: structure >Affects Versions: 3.1.6 >Reporter: Bryn Cooke >Assignee: stephen mallette > Fix For: 3.1.7 > > > Currently properties are checked for nullness but meta-properties arenot. > This leads to NPEs further down the line. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960808#comment-15960808 ] ASF GitHub Bot commented on TINKERPOP-1664: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/590 > StarVertexProperty#property should throw an NPE if the value is null > > > Key: TINKERPOP-1664 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1664 > Project: TinkerPop > Issue Type: Improvement > Components: structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke > > Currently properties are checked for nullness but meta-properties arenot. > This leads to NPEs further down the line. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960748#comment-15960748 ] ASF GitHub Bot commented on TINKERPOP-1664: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/590 VOTE: +1 - i'll handle the merge > StarVertexProperty#property should throw an NPE if the value is null > > > Key: TINKERPOP-1664 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1664 > Project: TinkerPop > Issue Type: Improvement > Components: structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke > > Currently properties are checked for nullness but meta-properties arenot. > This leads to NPEs further down the line. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/590 VOTE: +1 - i'll handle the merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1664) StarVertexProperty#property should throw an NPE if the value is null
[ https://issues.apache.org/jira/browse/TINKERPOP-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960745#comment-15960745 ] ASF GitHub Bot commented on TINKERPOP-1664: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/590 VOTE: +1 And just like the Java compiler I really don't care whether it's `null == propertyKeyValues[i+1]` or `propertyKeyValues[i+1] == null`. > StarVertexProperty#property should throw an NPE if the value is null > > > Key: TINKERPOP-1664 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1664 > Project: TinkerPop > Issue Type: Improvement > Components: structure >Affects Versions: 3.2.4 >Reporter: Bryn Cooke > > Currently properties are checked for nullness but meta-properties arenot. > This leads to NPEs further down the line. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/590 VOTE: +1 And just like the Java compiler I really don't care whether it's `null == propertyKeyValues[i+1]` or `propertyKeyValues[i+1] == null`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1044) ResponseMessage should contain server-side exception name.
[ https://issues.apache.org/jira/browse/TINKERPOP-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960693#comment-15960693 ] ASF GitHub Bot commented on TINKERPOP-1044: --- GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/599 TinkerPop-1044 master https://issues.apache.org/jira/browse/TINKERPOP-1044 Companion pull request for #598 since there were some conflicts that needed resolution that were somewhat non-trivial. All tests pass with `docker/build.sh -t -n -i` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1044-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/599.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #599 commit b29bab0acada54aa525184935d96b41f9cf0854b Author: Stephen Mallette Date: 2017-04-06T21:55:39Z TINKERPOP-1044 Additional error data to Gremlin Server responses Applies to all protocols: http, nio, and websocket. Added stack trace and exception hierarchy. Deprecated the "Exception-Class" in the http protocol. commit c33069cecd227dff664a02330a8462efce32e121 Author: Stephen Mallette Date: 2017-04-06T22:10:08Z TINKERPOP-1044 Added documentation for additional error info in ResponseMessage commit 92eceb4e620409be2c9ee810cc4132b7ae2dafc7 Author: Stephen Mallette Date: 2017-04-07T12:22:31Z Merge branch 'TINKERPOP-1044' into TINKERPOP-1044-master Conflicts: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerHttpIntegrateTest.java > ResponseMessage should contain server-side exception name. > -- > > Key: TINKERPOP-1044 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1044 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.1.0-incubating >Reporter: Bob Briody >Assignee: stephen mallette >Priority: Minor > > When an exception occurs during execution by gremlin server, the > ResponseMessage currently contains the Exception message, but it would also > be helpful to include the Exception class name. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop pull request #599: TinkerPop-1044 master
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/599 TinkerPop-1044 master https://issues.apache.org/jira/browse/TINKERPOP-1044 Companion pull request for #598 since there were some conflicts that needed resolution that were somewhat non-trivial. All tests pass with `docker/build.sh -t -n -i` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1044-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/599.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #599 commit b29bab0acada54aa525184935d96b41f9cf0854b Author: Stephen Mallette Date: 2017-04-06T21:55:39Z TINKERPOP-1044 Additional error data to Gremlin Server responses Applies to all protocols: http, nio, and websocket. Added stack trace and exception hierarchy. Deprecated the "Exception-Class" in the http protocol. commit c33069cecd227dff664a02330a8462efce32e121 Author: Stephen Mallette Date: 2017-04-06T22:10:08Z TINKERPOP-1044 Added documentation for additional error info in ResponseMessage commit 92eceb4e620409be2c9ee810cc4132b7ae2dafc7 Author: Stephen Mallette Date: 2017-04-07T12:22:31Z Merge branch 'TINKERPOP-1044' into TINKERPOP-1044-master Conflicts: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerHttpIntegrateTest.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TINKERPOP-1044) ResponseMessage should contain server-side exception name.
[ https://issues.apache.org/jira/browse/TINKERPOP-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960687#comment-15960687 ] ASF GitHub Bot commented on TINKERPOP-1044: --- GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/598 TINKERPOP-1044 Include more error information in remote exceptions https://issues.apache.org/jira/browse/TINKERPOP-1044 Adds both the remote stacktrace and exception hierarchy to `ResponseException` for the driver and to the JSON payload in the HTTP protocol. Deprecates the "Exception-Class" in the HTTP protocol. All tests pass with `docker/build.sh -t -n -i` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1044 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/598.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #598 commit b29bab0acada54aa525184935d96b41f9cf0854b Author: Stephen Mallette Date: 2017-04-06T21:55:39Z TINKERPOP-1044 Additional error data to Gremlin Server responses Applies to all protocols: http, nio, and websocket. Added stack trace and exception hierarchy. Deprecated the "Exception-Class" in the http protocol. commit c33069cecd227dff664a02330a8462efce32e121 Author: Stephen Mallette Date: 2017-04-06T22:10:08Z TINKERPOP-1044 Added documentation for additional error info in ResponseMessage > ResponseMessage should contain server-side exception name. > -- > > Key: TINKERPOP-1044 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1044 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.1.0-incubating >Reporter: Bob Briody >Assignee: stephen mallette >Priority: Minor > > When an exception occurs during execution by gremlin server, the > ResponseMessage currently contains the Exception message, but it would also > be helpful to include the Exception class name. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] tinkerpop pull request #598: TINKERPOP-1044 Include more error information i...
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/598 TINKERPOP-1044 Include more error information in remote exceptions https://issues.apache.org/jira/browse/TINKERPOP-1044 Adds both the remote stacktrace and exception hierarchy to `ResponseException` for the driver and to the JSON payload in the HTTP protocol. Deprecates the "Exception-Class" in the HTTP protocol. All tests pass with `docker/build.sh -t -n -i` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1044 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/598.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #598 commit b29bab0acada54aa525184935d96b41f9cf0854b Author: Stephen Mallette Date: 2017-04-06T21:55:39Z TINKERPOP-1044 Additional error data to Gremlin Server responses Applies to all protocols: http, nio, and websocket. Added stack trace and exception hierarchy. Deprecated the "Exception-Class" in the http protocol. commit c33069cecd227dff664a02330a8462efce32e121 Author: Stephen Mallette Date: 2017-04-06T22:10:08Z TINKERPOP-1044 Added documentation for additional error info in ResponseMessage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (TINKERPOP-1666) NPE in FileSandboxExtension if staticVariableTypes is empty in supplied YAML file
[ https://issues.apache.org/jira/browse/TINKERPOP-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1666: Fix Version/s: (was: 3.2.4) Component/s: groovy > NPE in FileSandboxExtension if staticVariableTypes is empty in supplied YAML > file > - > > Key: TINKERPOP-1666 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1666 > Project: TinkerPop > Issue Type: Bug > Components: groovy >Affects Versions: 3.2.4 >Reporter: David Pitera >Priority: Minor > > Currently, we have code that assumes that this variable is not empty in the > supplied YAML file: > 1. > https://github.com/apache/tinkerpop/blob/tp32/gremlin-groovy/src/main/groovy/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/FileSandboxExtension.groovy#L66 > (We get an NPE if we call collectEntries() on a null object) > 2. > https://github.com/apache/tinkerpop/blob/tp32/gremlin-groovy/src/main/groovy/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/AbstractSandboxExtension.groovy#L54 > (need to check if staticVariableTyping is null or we throw NPE trying to > call containsKey() on a null object) > I propose to add some null checks here so that users who do not wish to > statically type any variables can now do so. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
