[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 hmm, since I introduced a dependency from gremlin-core:test to tinkergraph-gremlin the build complains about a cyclic dependency. I thought that would have been fine, given that it's just a test dependency. Any suggestions how to best resolve that without scrapping the test? ---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 Ok gents, next iteration is ready for review: * addressed stephen's comments, rebased and changed target to tp32 * moved the impl to GraphHelper which lives next to ElementHelper in org.apache.tinkerpop.gremlin.structure.util. Note: I added a dependency with scope `test` to gremlin-core * updated CHANGELOG and upgrade docs ---
[jira] [Commented] (TINKERPOP-1772) "Getting started" page not correct leading to difficulties to start with console
[
https://issues.apache.org/jira/browse/TINKERPOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160438#comment-16160438
]
Robert Dale commented on TINKERPOP-1772:
In the first case, you are simply exhibiting the behavior of TINKERPOP-1771 .
In the second case, I'm not sure what directory structure you have but it's not
"starting with unzipping the console distribution".
I've attached a screenshot demonstrating PowerShell on Windows 2012R2. Works in
DOS shell and double-clicking from file manager.
!Screenshot_2017-09-10_14-37-12.png|thumbnail!
I'll need some repeatable steps in order to reproduce and fix the problem.
> "Getting started" page not correct leading to difficulties to start with
> console
> -
>
> Key: TINKERPOP-1772
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1772
> Project: TinkerPop
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.3.0
> Environment: Windows
>Reporter: Cédric L. Charlier
> Attachments: 001-without-edit-of-gremlin-bat.png,
> 002-with-edit-of-gremlin-bat.png, Screenshot_2017-09-10_14-37-12.png
>
>
> The [getting started
> page](http://tinkerpop.apache.org/docs/current/tutorials/getting-started/) is
> assuming that when you start the console the plugin
> ```tinkerpop.tinkergraph``` is activated. It's confirmed by the first "screen
> shot" of the console.
> Unfortunately, it's not the case and when later you start to write your first
> command
> {code:java}
> graph = TinkerFactory.createModern()
> {code}
> you'll receive an exception. It's really difficult for newbies to understand
> that they need to load the tinkerpop.tinkergraph plugin and could stop them
> in their progress with TinkerPop.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (TINKERPOP-1772) "Getting started" page not correct leading to difficulties to start with console
[
https://issues.apache.org/jira/browse/TINKERPOP-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Dale updated TINKERPOP-1772:
---
Attachment: Screenshot_2017-09-10_14-37-12.png
> "Getting started" page not correct leading to difficulties to start with
> console
> -
>
> Key: TINKERPOP-1772
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1772
> Project: TinkerPop
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.3.0
> Environment: Windows
>Reporter: Cédric L. Charlier
> Attachments: 001-without-edit-of-gremlin-bat.png,
> 002-with-edit-of-gremlin-bat.png, Screenshot_2017-09-10_14-37-12.png
>
>
> The [getting started
> page](http://tinkerpop.apache.org/docs/current/tutorials/getting-started/) is
> assuming that when you start the console the plugin
> ```tinkerpop.tinkergraph``` is activated. It's confirmed by the first "screen
> shot" of the console.
> Unfortunately, it's not the case and when later you start to write your first
> command
> {code:java}
> graph = TinkerFactory.createModern()
> {code}
> you'll receive an exception. It's really difficult for newbies to understand
> that they need to load the tinkerpop.tinkergraph plugin and could stop them
> in their progress with TinkerPop.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (TINKERPOP-1771) gremlin.bat doesn't support paths containing spaces
[
https://issues.apache.org/jira/browse/TINKERPOP-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Dale closed TINKERPOP-1771.
--
Resolution: Fixed
Assignee: Robert Dale
> gremlin.bat doesn't support paths containing spaces
> ---
>
> Key: TINKERPOP-1771
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1771
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.3.0
> Environment: Windows operating system
>Reporter: Cédric L. Charlier
>Assignee: Robert Dale
>Priority: Trivial
> Fix For: 3.2.7
>
>
> If you copy the TinkerPop Gremlin Console to the folder
> {noformat}
> C:\Program Files\Apache TinkerPop
> {noformat}
> then it would be impossible to start the console with the gremlin.bat file
> provided with the solution.
> The issue is that the space of the folder name will not be correctly handled
> when defining the CLASSPATH.
> It's possible to easily fix this issue by replacing the line
> {code:java}
> java %JAVA_OPTIONS% %JAVA_ARGS% -cp %LIBDIR%\*;%EXTDIR%;
> org.apache.tinkerpop.gremlin.console.Console %*
> {code}
> by
> {code:java}
> java %JAVA_OPTIONS% %JAVA_ARGS% -cp "%LIBDIR%\*;%EXTDIR%;"
> org.apache.tinkerpop.gremlin.console.Console %*
> {code}
> (the value provided for the -cp argument must be surrounded by double quotes).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (TINKERPOP-1771) gremlin.bat doesn't support paths containing spaces
[
https://issues.apache.org/jira/browse/TINKERPOP-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Dale updated TINKERPOP-1771:
---
Fix Version/s: 3.2.7
> gremlin.bat doesn't support paths containing spaces
> ---
>
> Key: TINKERPOP-1771
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1771
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.3.0
> Environment: Windows operating system
>Reporter: Cédric L. Charlier
>Priority: Trivial
> Fix For: 3.2.7
>
>
> If you copy the TinkerPop Gremlin Console to the folder
> {noformat}
> C:\Program Files\Apache TinkerPop
> {noformat}
> then it would be impossible to start the console with the gremlin.bat file
> provided with the solution.
> The issue is that the space of the folder name will not be correctly handled
> when defining the CLASSPATH.
> It's possible to easily fix this issue by replacing the line
> {code:java}
> java %JAVA_OPTIONS% %JAVA_ARGS% -cp %LIBDIR%\*;%EXTDIR%;
> org.apache.tinkerpop.gremlin.console.Console %*
> {code}
> by
> {code:java}
> java %JAVA_OPTIONS% %JAVA_ARGS% -cp "%LIBDIR%\*;%EXTDIR%;"
> org.apache.tinkerpop.gremlin.console.Console %*
> {code}
> (the value provided for the -cp argument must be surrounded by double quotes).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
