[jira] [Closed] (TINKERPOP-1835) Bump Netty 4.0.53
[ https://issues.apache.org/jira/browse/TINKERPOP-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale closed TINKERPOP-1835. -- Resolution: Fixed > Bump Netty 4.0.53 > - > > Key: TINKERPOP-1835 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1835 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Assignee: Robert Dale > Fix For: 3.2.7, 3.3.1 > > > https://netty.io/news/2017/11/08/4-0-53-Final-4-1-17-Final.html > The most important changes for 4.0.53.Final and 4.1.17.Final are: > * OpenSslEngine support unwrap plaintext greater than 214 and avoid infinite > loop (#7352) > * java.lang.NullPointerException: ssl at > ReferenceCountedOpenSslEngine.rejectRemoteInitiatedRenegotiation (#7353) > * Don't disable HttpObjectDecoder on upgrade from HTTP/1.x to HTTP/1.x over > TLS (#7298) > * Support running Netty (in particular netty-tcnative) in the bootstrap class > loader (#7345) > * SslHandler.setHandshakeTimeout*(...) should also been enforced on the > server (#7277) > * ResourceLeakDetector sampling changes (#7232) > * Do not treat errors as decoder exception (redux) (#7279) > * Do not treat errors as decoder exception (#7276) > * Propagate all exceptions when loading native code (#7250) > * Optimistically update ref counts (#7248) > * Fix Java9SslEngine implementation of ApplicationProtocolAccessor and so fix > ApplicationProtocolNegationHandler (#7258) > * Upgrade Conscrypt to 1.0.0.RC11 (#7235) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (TINKERPOP-1835) Bump Netty 4.0.53
[ https://issues.apache.org/jira/browse/TINKERPOP-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Dale updated TINKERPOP-1835: --- Fix Version/s: 3.3.1 3.2.7 > Bump Netty 4.0.53 > - > > Key: TINKERPOP-1835 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1835 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Assignee: Robert Dale > Fix For: 3.2.7, 3.3.1 > > > https://netty.io/news/2017/11/08/4-0-53-Final-4-1-17-Final.html > The most important changes for 4.0.53.Final and 4.1.17.Final are: > * OpenSslEngine support unwrap plaintext greater than 214 and avoid infinite > loop (#7352) > * java.lang.NullPointerException: ssl at > ReferenceCountedOpenSslEngine.rejectRemoteInitiatedRenegotiation (#7353) > * Don't disable HttpObjectDecoder on upgrade from HTTP/1.x to HTTP/1.x over > TLS (#7298) > * Support running Netty (in particular netty-tcnative) in the bootstrap class > loader (#7345) > * SslHandler.setHandshakeTimeout*(...) should also been enforced on the > server (#7277) > * ResourceLeakDetector sampling changes (#7232) > * Do not treat errors as decoder exception (redux) (#7279) > * Do not treat errors as decoder exception (#7276) > * Propagate all exceptions when loading native code (#7250) > * Optimistically update ref counts (#7248) > * Fix Java9SslEngine implementation of ApplicationProtocolAccessor and so fix > ApplicationProtocolNegationHandler (#7258) > * Upgrade Conscrypt to 1.0.0.RC11 (#7235) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop pull request #750: TINKERPOP-1835 Bump Netty 4.0.53
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/750 ---
[jira] [Commented] (TINKERPOP-1835) Bump Netty 4.0.53
[ https://issues.apache.org/jira/browse/TINKERPOP-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271766#comment-16271766 ] ASF GitHub Bot commented on TINKERPOP-1835: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/750 > Bump Netty 4.0.53 > - > > Key: TINKERPOP-1835 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1835 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Assignee: Robert Dale > > https://netty.io/news/2017/11/08/4-0-53-Final-4-1-17-Final.html > The most important changes for 4.0.53.Final and 4.1.17.Final are: > * OpenSslEngine support unwrap plaintext greater than 214 and avoid infinite > loop (#7352) > * java.lang.NullPointerException: ssl at > ReferenceCountedOpenSslEngine.rejectRemoteInitiatedRenegotiation (#7353) > * Don't disable HttpObjectDecoder on upgrade from HTTP/1.x to HTTP/1.x over > TLS (#7298) > * Support running Netty (in particular netty-tcnative) in the bootstrap class > loader (#7345) > * SslHandler.setHandshakeTimeout*(...) should also been enforced on the > server (#7277) > * ResourceLeakDetector sampling changes (#7232) > * Do not treat errors as decoder exception (redux) (#7279) > * Do not treat errors as decoder exception (#7276) > * Propagate all exceptions when loading native code (#7250) > * Optimistically update ref counts (#7248) > * Fix Java9SslEngine implementation of ApplicationProtocolAccessor and so fix > ApplicationProtocolNegationHandler (#7258) > * Upgrade Conscrypt to 1.0.0.RC11 (#7235) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1811) Improve error reporting for serialization errors between gremlin-python and gremlin-server
[ https://issues.apache.org/jira/browse/TINKERPOP-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271655#comment-16271655 ] ASF GitHub Bot commented on TINKERPOP-1811: --- Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/753#discussion_r153933994 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/JavaTranslator.java --- @@ -173,6 +173,12 @@ private Object invokeMethod(final Object delegate, final Class returnType, final for (int i = 0; i < arguments.length; i++) { argumentsCopy[i] = translateObject(arguments[i]); } + +// without this initial check iterating an invalid methodName will lead to a null pointer and a less than +// great error message for the user. +if (!methodCache.containsKey(methodName)) +throw new IllegalStateException("Could not locate method: " + delegate.getClass().getSimpleName() + "." + methodName + "(" + Arrays.toString(argumentsCopy) + ")"); --- End diff -- Maybe I'm a bit too nit-picky here, but I think the empty square brackets (in case of no args) could confuse some people. I would prefer: ``` final String methodArgs = argumentsCopy.length() > 0 ? Arrays.toString(argumentsCopy) : ""; throw new IllegalStateException("Could not locate method: " + delegate.getClass().getSimpleName() + "." + methodName + "(" + methodArgs + ")"); ``` Besides that, VOTE: +1 > Improve error reporting for serialization errors between gremlin-python and > gremlin-server > -- > > Key: TINKERPOP-1811 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1811 > Project: TinkerPop > Issue Type: Improvement > Components: python, server >Affects Versions: 3.2.6 >Reporter: Hugo Arts >Priority: Minor > > We ran into an issue while attempting to add a PartitionStrategy to our > traversals. This is a small example of a traversal I tried: > {code:none} > remote = DriverRemoteConnection('ws://localhost:8182/gremlin', > 'DSE_GRAPH_QUICKSTART.g') > strategy = PartitionStrategy('community_id', '2097442560', 2097442560) > g = Graph().traversal().withRemote(remote).withStrategies(strategy) > print(g.V().toList()) > {code} > The third argument of PartitionStrategy should be a list. However, the > traversal strategies in gremlin-python do not do any kind of argument/type > checking, and any mistake you make results in the following error from > gremlin server: > {noformat} > ERROR [gremlin-server-worker-1] 2017-10-25 10:15:53,285 GREMLIN > TraversalOpProcessor.java:365 - Could not deserialize the Traversal instance > {noformat} > I've omitted the [full > traceback|https://gist.github.com/anonymous/2ad6541d0169256afb1a23fbdc376009] > for brevity. There is not much indication as to what has gone wrong. > gremlin-python gives this error: > {noformat} > gremlin_python.driver.protocol.GremlinServerError: 599: None > {noformat} > Which is also unhelpful. We were eventually able to figure out what we were > doing wrong, but it would be very nice to have either some input validation > on the gremlin-python side, or have gremlin-server be more specific about the > nature of the deserialisation error (or both). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop pull request #753: TINKERPOP-1811 Fixed bytecode deserialization e...
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/753#discussion_r153933994 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/JavaTranslator.java --- @@ -173,6 +173,12 @@ private Object invokeMethod(final Object delegate, final Class returnType, final for (int i = 0; i < arguments.length; i++) { argumentsCopy[i] = translateObject(arguments[i]); } + +// without this initial check iterating an invalid methodName will lead to a null pointer and a less than +// great error message for the user. +if (!methodCache.containsKey(methodName)) +throw new IllegalStateException("Could not locate method: " + delegate.getClass().getSimpleName() + "." + methodName + "(" + Arrays.toString(argumentsCopy) + ")"); --- End diff -- Maybe I'm a bit too nit-picky here, but I think the empty square brackets (in case of no args) could confuse some people. I would prefer: ``` final String methodArgs = argumentsCopy.length() > 0 ? Arrays.toString(argumentsCopy) : ""; throw new IllegalStateException("Could not locate method: " + delegate.getClass().getSimpleName() + "." + methodName + "(" + methodArgs + ")"); ``` Besides that, VOTE: +1 ---
[jira] [Commented] (TINKERPOP-1835) Bump Netty 4.0.53
[ https://issues.apache.org/jira/browse/TINKERPOP-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271633#comment-16271633 ] ASF GitHub Bot commented on TINKERPOP-1835: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/750 VOTE: +1 > Bump Netty 4.0.53 > - > > Key: TINKERPOP-1835 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1835 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.0, 3.2.6 >Reporter: Robert Dale >Assignee: Robert Dale > > https://netty.io/news/2017/11/08/4-0-53-Final-4-1-17-Final.html > The most important changes for 4.0.53.Final and 4.1.17.Final are: > * OpenSslEngine support unwrap plaintext greater than 214 and avoid infinite > loop (#7352) > * java.lang.NullPointerException: ssl at > ReferenceCountedOpenSslEngine.rejectRemoteInitiatedRenegotiation (#7353) > * Don't disable HttpObjectDecoder on upgrade from HTTP/1.x to HTTP/1.x over > TLS (#7298) > * Support running Netty (in particular netty-tcnative) in the bootstrap class > loader (#7345) > * SslHandler.setHandshakeTimeout*(...) should also been enforced on the > server (#7277) > * ResourceLeakDetector sampling changes (#7232) > * Do not treat errors as decoder exception (redux) (#7279) > * Do not treat errors as decoder exception (#7276) > * Propagate all exceptions when loading native code (#7250) > * Optimistically update ref counts (#7248) > * Fix Java9SslEngine implementation of ApplicationProtocolAccessor and so fix > ApplicationProtocolNegationHandler (#7258) > * Upgrade Conscrypt to 1.0.0.RC11 (#7235) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop issue #750: TINKERPOP-1835 Bump Netty 4.0.53
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/750 VOTE: +1 ---
[jira] [Commented] (TINKERPOP-1734) DSL for Gremlin .NET
[ https://issues.apache.org/jira/browse/TINKERPOP-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271609#comment-16271609 ] ASF GitHub Bot commented on TINKERPOP-1734: --- GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/758 TINKERPOP-1734 DSL for Gremlin .NET https://issues.apache.org/jira/browse/TINKERPOP-1734 Provided tests and documentation for implementing DSLs in .Net. No changes were needed to the code base for this - just used C# extension methods as suggested by @jorgebay . Only downside was anonymous traversals are a little weird because C# doesn't let you extend static classes and extensions methods can't be used on them either. The only recourse is to wrap static methods in the extending class which is a lot of extra boilerplate. I opted to just recommend that users create their own class for spawning anonymous traversals that just works independently of `__`. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1734 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/758.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #758 commit 3811e31c05a77cf78abb7b2ecf3d0fa40983f51a Author: Stephen MalletteDate: 2017-11-29T20:17:26Z TINKERPOP-1734 Test for DSLs with .NET commit d0520bfac978cfd08ea3448f75f2ac91a5caac7e Author: Stephen Mallette Date: 2017-11-29T20:45:41Z TINKERPOP-1734 Added DSL tests for anonymous traversals Can't extend __ with extension methods and can't extend static classes in C# so not sure what else to do here. The only thing you can do is write wrapper methods in your DSL for the __ methods which kinda stinks. I guess we could do code generation here, but doesn't seem worth it. Not sure. commit 36b84af97cc0a435cda2e1e5368b9ae960ab7fae Author: Stephen Mallette Date: 2017-11-29T20:47:44Z TINKERPOP-1734 Updated changelog commit def2b66abc198aa6c492c8cf6de9fac902448a9e Author: Stephen Mallette Date: 2017-11-29T21:15:24Z TINKERPOP-1734 Documentation for DSLs in .Net commit f766cca834099a2b6f99800393b39b12bf08c7e4 Author: Stephen Mallette Date: 2017-11-29T21:16:28Z TINKERPOP-1734 Fixed up c# formatting > DSL for Gremlin .NET > > > Key: TINKERPOP-1734 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1734 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Affects Versions: 3.2.5 >Reporter: stephen mallette > > This may just be a documentation issue, but we need to determine the approach > to building DSLs with .NET. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop pull request #758: TINKERPOP-1734 DSL for Gremlin .NET
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/758 TINKERPOP-1734 DSL for Gremlin .NET https://issues.apache.org/jira/browse/TINKERPOP-1734 Provided tests and documentation for implementing DSLs in .Net. No changes were needed to the code base for this - just used C# extension methods as suggested by @jorgebay . Only downside was anonymous traversals are a little weird because C# doesn't let you extend static classes and extensions methods can't be used on them either. The only recourse is to wrap static methods in the extending class which is a lot of extra boilerplate. I opted to just recommend that users create their own class for spawning anonymous traversals that just works independently of `__`. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1734 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/758.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #758 commit 3811e31c05a77cf78abb7b2ecf3d0fa40983f51a Author: Stephen MalletteDate: 2017-11-29T20:17:26Z TINKERPOP-1734 Test for DSLs with .NET commit d0520bfac978cfd08ea3448f75f2ac91a5caac7e Author: Stephen Mallette Date: 2017-11-29T20:45:41Z TINKERPOP-1734 Added DSL tests for anonymous traversals Can't extend __ with extension methods and can't extend static classes in C# so not sure what else to do here. The only thing you can do is write wrapper methods in your DSL for the __ methods which kinda stinks. I guess we could do code generation here, but doesn't seem worth it. Not sure. commit 36b84af97cc0a435cda2e1e5368b9ae960ab7fae Author: Stephen Mallette Date: 2017-11-29T20:47:44Z TINKERPOP-1734 Updated changelog commit def2b66abc198aa6c492c8cf6de9fac902448a9e Author: Stephen Mallette Date: 2017-11-29T21:15:24Z TINKERPOP-1734 Documentation for DSLs in .Net commit f766cca834099a2b6f99800393b39b12bf08c7e4 Author: Stephen Mallette Date: 2017-11-29T21:16:28Z TINKERPOP-1734 Fixed up c# formatting ---
[jira] [Updated] (TINKERPOP-1845) Update List of Graph Systems with Amazon Neptune
[ https://issues.apache.org/jira/browse/TINKERPOP-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1845: Issue Type: Improvement (was: Task) I started a discussion on the dev list for this: https://lists.apache.org/thread.html/b303e1b1484d2bdf1febb3b5e85d2b96f80b107a71f56febf72fe53c@%3Cdev.tinkerpop.apache.org%3E I can't imagine any objection except that it doesn't appear to have a general release yet? I think a "preview" release is fine for the listing in this case imho. > Update List of Graph Systems with Amazon Neptune > > > Key: TINKERPOP-1845 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1845 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Reporter: Brad Bebee > > Hello, > AWS announced a Preview of Amazon Neptune today with support Apache TinkerPop > 3.3. This ticket is to request that Amazon Neptune be added to the list of > Graph Systems that support Apache TinkerPop: https://aws.amazon.com/neptune/. > Thanks, --Brad -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[DISCUSS] Adding Amazon Neptune to Provider Listing
Amazon just announced it's new graph database called Neptune: https://aws.amazon.com/neptune/ Unless there are objections in the next 72 hours I will assume lazy consensus and get this added to the provider index.
[jira] [Created] (TINKERPOP-1845) Update List of Graph Systems with Amazon Neptune
Brad Bebee created TINKERPOP-1845: - Summary: Update List of Graph Systems with Amazon Neptune Key: TINKERPOP-1845 URL: https://issues.apache.org/jira/browse/TINKERPOP-1845 Project: TinkerPop Issue Type: Task Components: documentation Reporter: Brad Bebee Hello, AWS announced a Preview of Amazon Neptune today with support Apache TinkerPop 3.3. This ticket is to request that Amazon Neptune be added to the list of Graph Systems that support Apache TinkerPop: https://aws.amazon.com/neptune/. Thanks, --Brad -- This message was sent by Atlassian JIRA (v6.4.14#64029)