[jira] [Commented] (TINKERPOP-1861) VertexProgram create with varargs for Graphs

2018-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336752#comment-16336752
 ] 

ASF GitHub Bot commented on TINKERPOP-1861:
---

Github user PBGraff commented on the issue:

https://github.com/apache/tinkerpop/pull/772
  
@spmallette That might have occurred with my attempt to rebase on the 
forked project. It ended up having to do a merge from my local into my remote 
branch, so those commits are probably (hopefully) already on the `tp32` branch. 
If it's really messed up, I can close this and apply the commits to a fresh 
branch off of the current `tp32`. The same goes for #770 .


> VertexProgram create with varargs for Graphs
> 
>
> Key: TINKERPOP-1861
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1861
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.7
>Reporter: Philip Graff
>Priority: Minor
>
> VertexProgram.Builder.create(Graph) can be modified to 
> VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs 
> is naturally handled. The current state of passing in null when no graph is 
> needed is bad practice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-23 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette reopened TINKERPOP-1870:
-

[~artem.aliev] as soon as I merged this, I noticed something that looked like 
it needed some more work. I'm going to re-open this and submit an additional 
pull request. I will supply details with that pull request - if you could 
review that when I issue the pull request to be sure I captured your original 
intent, I would appreciate it.

> n^2 synchronious operation in OLAP WorkerExecutor.execute() method
> --
>
> Key: TINKERPOP-1870
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1870
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Artem Aliev
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.2.8, 3.3.2
>
> Attachments: findTraverser1.png, findTraverser2.png, 
> findTraverserFixed.png
>
>
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/WorkerExecutor.java#L80-L93]
> This block of code iterates over all remote traverses to select one related 
> to the current vertex and remove it. This operation is repeated for the next 
> vertex and so one. For following example query it means n^2 operations (n is 
> number of vertices). All of them in sync block. multi core spark executor 
> will do this operations serial. 
> {code}
> g.V().emit().repeat(both().dedup()).count().next()
> {code}
> See jvisualvm screenshot. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV

2018-01-23 Thread jbmusso
Github user jbmusso commented on the issue:

https://github.com/apache/tinkerpop/pull/695
  
All good to me!

VOTE +1




---


[jira] [Commented] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335782#comment-16335782
 ] 

ASF GitHub Bot commented on TINKERPOP-1870:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/778


> n^2 synchronious operation in OLAP WorkerExecutor.execute() method
> --
>
> Key: TINKERPOP-1870
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1870
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Artem Aliev
>Priority: Major
> Fix For: 3.2.8, 3.3.2
>
> Attachments: findTraverser1.png, findTraverser2.png, 
> findTraverserFixed.png
>
>
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/WorkerExecutor.java#L80-L93]
> This block of code iterates over all remote traverses to select one related 
> to the current vertex and remove it. This operation is repeated for the next 
> vertex and so one. For following example query it means n^2 operations (n is 
> number of vertices). All of them in sync block. multi core spark executor 
> will do this operations serial. 
> {code}
> g.V().emit().repeat(both().dedup()).count().next()
> {code}
> See jvisualvm screenshot. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tinkerpop pull request #778: TINKERPOP-1870: Extends TraverserSet to have Ve...

2018-01-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/778


---


[jira] [Closed] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-23 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1870.
---
   Resolution: Implemented
 Assignee: stephen mallette
Fix Version/s: 3.3.2
   3.2.8

> n^2 synchronious operation in OLAP WorkerExecutor.execute() method
> --
>
> Key: TINKERPOP-1870
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1870
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Artem Aliev
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.2.8, 3.3.2
>
> Attachments: findTraverser1.png, findTraverser2.png, 
> findTraverserFixed.png
>
>
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/WorkerExecutor.java#L80-L93]
> This block of code iterates over all remote traverses to select one related 
> to the current vertex and remove it. This operation is repeated for the next 
> vertex and so one. For following example query it means n^2 operations (n is 
> number of vertices). All of them in sync block. multi core spark executor 
> will do this operations serial. 
> {code}
> g.V().emit().repeat(both().dedup()).count().next()
> {code}
> See jvisualvm screenshot. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-1870) n^2 synchronious operation in OLAP WorkerExecutor.execute() method

2018-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335767#comment-16335767
 ] 

ASF GitHub Bot commented on TINKERPOP-1870:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/778
  
VOTE +1


> n^2 synchronious operation in OLAP WorkerExecutor.execute() method
> --
>
> Key: TINKERPOP-1870
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1870
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Artem Aliev
>Priority: Major
> Attachments: findTraverser1.png, findTraverser2.png, 
> findTraverserFixed.png
>
>
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/WorkerExecutor.java#L80-L93]
> This block of code iterates over all remote traverses to select one related 
> to the current vertex and remove it. This operation is repeated for the next 
> vertex and so one. For following example query it means n^2 operations (n is 
> number of vertices). All of them in sync block. multi core spark executor 
> will do this operations serial. 
> {code}
> g.V().emit().repeat(both().dedup()).count().next()
> {code}
> See jvisualvm screenshot. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tinkerpop issue #781: Tinkerpop 1870 master

2018-01-23 Thread robertdale
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/781
  
VOTE +1


---


[GitHub] tinkerpop issue #778: TINKERPOP-1870: Extends TraverserSet to have Vertex in...

2018-01-23 Thread robertdale
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/778
  
VOTE +1


---


[jira] [Closed] (TINKERPOP-1871) Exception handling is slow in element ReferenceElement creation

2018-01-23 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1871.
---
Resolution: Implemented

> Exception handling is slow in element  ReferenceElement creation
> 
>
> Key: TINKERPOP-1871
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.1
>Reporter: Artem Aliev
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.3.2
>
>
> Following exception happen for each vertex in OLAP and takes ~10% of 
> execution time.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceElement.java#L48]
> The exception is always thrown for ComputerGraph.ComputerAdjacentVertex class.
> So the check could be added to improve performance. This is 3.3.x issue only, 
> 3.2 has no this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (TINKERPOP-1871) Exception handling is slow in element ReferenceElement creation

2018-01-23 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1871:

Component/s: structure

> Exception handling is slow in element  ReferenceElement creation
> 
>
> Key: TINKERPOP-1871
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.1
>Reporter: Artem Aliev
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.3.2
>
>
> Following exception happen for each vertex in OLAP and takes ~10% of 
> execution time.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceElement.java#L48]
> The exception is always thrown for ComputerGraph.ComputerAdjacentVertex class.
> So the check could be added to improve performance. This is 3.3.x issue only, 
> 3.2 has no this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (TINKERPOP-1871) Exception handling is slow in element ReferenceElement creation

2018-01-23 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1871.
---
   Resolution: Implemented
 Assignee: stephen mallette
Fix Version/s: 3.3.2

> Exception handling is slow in element  ReferenceElement creation
> 
>
> Key: TINKERPOP-1871
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.1
>Reporter: Artem Aliev
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.3.2
>
>
> Following exception happen for each vertex in OLAP and takes ~10% of 
> execution time.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceElement.java#L48]
> The exception is always thrown for ComputerGraph.ComputerAdjacentVertex class.
> So the check could be added to improve performance. This is 3.3.x issue only, 
> 3.2 has no this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (TINKERPOP-1871) Exception handling is slow in element ReferenceElement creation

2018-01-23 Thread stephen mallette (JIRA)

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette reopened TINKERPOP-1871:
-

> Exception handling is slow in element  ReferenceElement creation
> 
>
> Key: TINKERPOP-1871
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.1
>Reporter: Artem Aliev
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.3.2
>
>
> Following exception happen for each vertex in OLAP and takes ~10% of 
> execution time.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceElement.java#L48]
> The exception is always thrown for ComputerGraph.ComputerAdjacentVertex class.
> So the check could be added to improve performance. This is 3.3.x issue only, 
> 3.2 has no this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-1871) Exception handling is slow in element ReferenceElement creation

2018-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335763#comment-16335763
 ] 

ASF GitHub Bot commented on TINKERPOP-1871:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/780


> Exception handling is slow in element  ReferenceElement creation
> 
>
> Key: TINKERPOP-1871
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.3.1
>Reporter: Artem Aliev
>Priority: Major
>
> Following exception happen for each vertex in OLAP and takes ~10% of 
> execution time.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceElement.java#L48]
> The exception is always thrown for ComputerGraph.ComputerAdjacentVertex class.
> So the check could be added to improve performance. This is 3.3.x issue only, 
> 3.2 has no this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tinkerpop pull request #780: TINKERPOP-1871: improve performance by not hand...

2018-01-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/780


---


[jira] [Commented] (TINKERPOP-1871) Exception handling is slow in element ReferenceElement creation

2018-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335747#comment-16335747
 ] 

ASF GitHub Bot commented on TINKERPOP-1871:
---

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/780
  
lgtm! VOTE: +1


> Exception handling is slow in element  ReferenceElement creation
> 
>
> Key: TINKERPOP-1871
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.3.1
>Reporter: Artem Aliev
>Priority: Major
>
> Following exception happen for each vertex in OLAP and takes ~10% of 
> execution time.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceElement.java#L48]
> The exception is always thrown for ComputerGraph.ComputerAdjacentVertex class.
> So the check could be added to improve performance. This is 3.3.x issue only, 
> 3.2 has no this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tinkerpop issue #780: TINKERPOP-1871: improve performance by not handling ex...

2018-01-23 Thread jorgebay
Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/780
  
lgtm! VOTE: +1


---


[jira] [Commented] (TINKERPOP-1878) Sparql to Gremlin Transpiler

2018-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335733#comment-16335733
 ] 

ASF GitHub Bot commented on TINKERPOP-1878:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/783
  
I've merged this to TINKERPOP-1878 - future pull requests should be 
directed there until this is determined by the community to be ready for merge 
to a release branch. 

https://issues.apache.org/jira/browse/TINKERPOP-1878


> Sparql to Gremlin Transpiler
> 
>
> Key: TINKERPOP-1878
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1878
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.1
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>
> The {{sparql-gremlin}} module should convert sparql queries to Gremlin thus 
> allowing that query language to run on any TinkerPop-enabled graph system.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tinkerpop issue #783: Initial commit for sparql-gremlin changes

2018-01-23 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/783
  
I've merged this to TINKERPOP-1878 - future pull requests should be 
directed there until this is determined by the community to be ready for merge 
to a release branch. 

https://issues.apache.org/jira/browse/TINKERPOP-1878


---


[GitHub] tinkerpop pull request #783: Initial commit for sparql-gremlin changes

2018-01-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/783


---


[jira] [Created] (TINKERPOP-1878) Sparql to Gremlin Transpiler

2018-01-23 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-1878:
---

 Summary: Sparql to Gremlin Transpiler
 Key: TINKERPOP-1878
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1878
 Project: TinkerPop
  Issue Type: Improvement
  Components: process
Affects Versions: 3.3.1
Reporter: stephen mallette
Assignee: stephen mallette


The {{sparql-gremlin}} module should convert sparql queries to Gremlin thus 
allowing that query language to run on any TinkerPop-enabled graph system.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)