[jira] [Closed] (TINKERPOP-1978) Check for Websocket connection state when retrieved from Connection Pool missing
[
https://issues.apache.org/jira/browse/TINKERPOP-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Hockmann closed TINKERPOP-1978.
---
Resolution: Fixed
Fix Version/s: 3.2.10
3.3.4
3.4.0
> Check for Websocket connection state when retrieved from Connection Pool
> missing
>
>
> Key: TINKERPOP-1978
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1978
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.3.3
>Reporter: Jamilu Abubakar
>Assignee: Florian Hockmann
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> When retrieving a connection from the connection pool there is no check to
> see what the current connection state of the websocket is before it is used.
> This means that if the websocket were to be closed because the server
> recycled or the connection was aborted by the server since it was last used
> and its Send method were to be called the following exception would be thrown:
> {quote}Error during execution ExecuteJObjectQueryAsync method. Exception:
> System.Net.Http.WinHttpException (0x80072EFF): The connection with the server
> was terminated abnormally
> at System.Net.WebSockets.WinHttpWebSocket.SendAsync(ArraySegment`1 buffer,
> WebSocketMessageType messageType, Boolean endOfMessage, CancellationToken
> cancellationToken)
> at System.Net.WebSockets.WebSocketHandle.SendAsync(ArraySegment`1 buffer,
> WebSocketMessageType messageType, Boolean endOfMessage, CancellationToken
> cancellationToken)
> at Gremlin.Net.Driver.WebSocketConnection.d__5.MoveNext()
> {quote}
>
> Please add check the Websocket state before use, handle exceptions due to
> closed or aborted connections and ideally have an extensible retry handler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1978) Check for Websocket connection state when retrieved from Connection Pool missing
[
https://issues.apache.org/jira/browse/TINKERPOP-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525332#comment-16525332
]
ASF GitHub Bot commented on TINKERPOP-1978:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/885
> Check for Websocket connection state when retrieved from Connection Pool
> missing
>
>
> Key: TINKERPOP-1978
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1978
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.3.3
>Reporter: Jamilu Abubakar
>Assignee: Florian Hockmann
>Priority: Major
>
> When retrieving a connection from the connection pool there is no check to
> see what the current connection state of the websocket is before it is used.
> This means that if the websocket were to be closed because the server
> recycled or the connection was aborted by the server since it was last used
> and its Send method were to be called the following exception would be thrown:
> {quote}Error during execution ExecuteJObjectQueryAsync method. Exception:
> System.Net.Http.WinHttpException (0x80072EFF): The connection with the server
> was terminated abnormally
> at System.Net.WebSockets.WinHttpWebSocket.SendAsync(ArraySegment`1 buffer,
> WebSocketMessageType messageType, Boolean endOfMessage, CancellationToken
> cancellationToken)
> at System.Net.WebSockets.WebSocketHandle.SendAsync(ArraySegment`1 buffer,
> WebSocketMessageType messageType, Boolean endOfMessage, CancellationToken
> cancellationToken)
> at Gremlin.Net.Driver.WebSocketConnection.d__5.MoveNext()
> {quote}
>
> Please add check the Websocket state before use, handle exceptions due to
> closed or aborted connections and ideally have an extensible retry handler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #885: TINKERPOP-1978 Gremlin.Net: Add check for conne...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/885 ---
[jira] [Commented] (TINKERPOP-1989) Preserve order that plugins are applied in Gremlin Console
[
https://issues.apache.org/jira/browse/TINKERPOP-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525261#comment-16525261
]
ASF GitHub Bot commented on TINKERPOP-1989:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/880
> Preserve order that plugins are applied in Gremlin Console
> --
>
> Key: TINKERPOP-1989
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1989
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> Plugins are now loaded in the order that {{ServiceLoader}} constructs them.
> Would be better if the plugins respected the order of the configuration file,
> that way the user could expect some control there in case one plugin depended
> on another for some reason. It's not a perfect system as users would be
> responsible for ordering, but it's a cheap, non-breaking way to at least
> provide some method for dealing with dependencies.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (TINKERPOP-1989) Preserve order that plugins are applied in Gremlin Console
[
https://issues.apache.org/jira/browse/TINKERPOP-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1989.
---
Resolution: Done
> Preserve order that plugins are applied in Gremlin Console
> --
>
> Key: TINKERPOP-1989
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1989
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.2.9
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> Plugins are now loaded in the order that {{ServiceLoader}} constructs them.
> Would be better if the plugins respected the order of the configuration file,
> that way the user could expect some control there in case one plugin depended
> on another for some reason. It's not a perfect system as users would be
> responsible for ordering, but it's a cheap, non-breaking way to at least
> provide some method for dealing with dependencies.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #880: TINKERPOP-1989 Enforce order of plugin load in ...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/880 ---
