[jira] [Commented] (TINKERPOP-1298) Save OLAP results to file

2018-07-29 Thread stephen mallette (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561302#comment-16561302
 ] 

stephen mallette commented on TINKERPOP-1298:
-

well - i'm not saying that it does - i'm saying that we now have a {{write()}} 
step and since it's part of the Gremlin language now I'd think we could surely 
make use of it for writing results to places if we wanted it to. 

> Save OLAP results to file
> -
>
> Key: TINKERPOP-1298
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1298
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io, process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Provide a way to save (tabular) results to text files, just like Spark's 
> {{saveAsTextFile}}.
> I'm not sure about the best way to do it. 3 options come to my mind:
> # a new step.
> # a {{VertexProgram}}
> # a configuration option
> Things to consider / open questions:
> * Is it sufficient to simply {{toString()}} all values or should we allow 
> formatters / format stings?
> * [~jlewandowski] pointed out that it would be nice to have support for the 
> [parquet file format|https://parquet.apache.org/]. I guess now we're already 
> talking about support for different {{FileOutputFormats}} and not just 
> formatters.
> * Is that only relevant for OLAP?
> * Can we support arbitrary file systems?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tinkerpop pull request #898: gremlin-javascript: Typescript typings definiti...

2018-07-29 Thread daem0ndev
GitHub user daem0ndev opened a pull request:

https://github.com/apache/tinkerpop/pull/898

gremlin-javascript: Typescript typings definition

Provides an index.d.ts typings definition file for TypeScript consumers of 
`gremin-javascript`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daem0ndev/tinkerpop patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/898.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #898


commit 93deb6d67fdaf60327b7110ffa10090c922a5753
Author: Asif Rahman 
Date:   2018-07-29T19:41:58Z

Typescript typings definition

Provides an index.d.ts typings definition file for TypeScript consumers.




---


[jira] [Commented] (TINKERPOP-1298) Save OLAP results to file

2018-07-29 Thread Daniel Kuppitz (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561212#comment-16561212
 ] 

Daniel Kuppitz commented on TINKERPOP-1298:
---

Oh, I didn't realize that it can do that, I thought it can only handle graphs. 
I need to play with it, but if it works as shown in your snippet, then that's 
that.

> Save OLAP results to file
> -
>
> Key: TINKERPOP-1298
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1298
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io, process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Provide a way to save (tabular) results to text files, just like Spark's 
> {{saveAsTextFile}}.
> I'm not sure about the best way to do it. 3 options come to my mind:
> # a new step.
> # a {{VertexProgram}}
> # a configuration option
> Things to consider / open questions:
> * Is it sufficient to simply {{toString()}} all values or should we allow 
> formatters / format stings?
> * [~jlewandowski] pointed out that it would be nice to have support for the 
> [parquet file format|https://parquet.apache.org/]. I guess now we're already 
> talking about support for different {{FileOutputFormats}} and not just 
> formatters.
> * Is that only relevant for OLAP?
> * Can we support arbitrary file systems?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-1967) Add a connectedComponent() step

2018-07-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561210#comment-16561210
 ] 

ASF GitHub Bot commented on TINKERPOP-1967:
---

Github user dkuppitz commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/897#discussion_r205981525
  
--- Diff: docs/src/recipes/connected-components.asciidoc ---
@@ -35,46 +54,92 @@ g.addV().property(id, "A").as("a").
   addE("link").from("d").to("e").iterate()
 
 
-One way to detect the various subgraphs would be to do something like this:
+ Small graph traversals
 
+Connected components in a small graph can be determined with either an 
OLTP traversal or the OLAP
+`connectedComponent()`-step. The `connectedComponent()`-step is available 
as of TinkerPop 3.4.0 and is
+described in more detail in the

+link:http://tinkerpop.apache.org/docs/x.y.z/reference/#connectedcomponent-step[Reference
 Documentation].
+The traversal looks like:
 [gremlin-groovy,existing]
 

-g.V().emit(cyclicPath().or().not(both())).repeat(both()).until(cyclicPath()).  
<1>
-  path().aggregate("p").   
<2>
-  unfold().dedup().
<3>
-  map(__.as("v").select("p").unfold(). 
<4>
- filter(unfold().where(eq("v"))).
- unfold().dedup().order().by(id).fold()).
-  dedup()  
<5>
+g.withComputer().V().connectedComponent().
+group().by('gremlin.connectedComponentVertexProgram.component').
--- End diff --

I think you should use the constant 
`ConnectedComponentVertexProgram.COMPONENT`.


> Add a connectedComponent() step
> ---
>
> Key: TINKERPOP-1967
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1967
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.3
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.4.0
>
>
> Given TINKERPOP-1852 we should probably just simplify and improve performance 
> of connected component identification. Implementing this will involved the 
> creation of {{ConnectedComponentVertexProgram}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tinkerpop pull request #897: TINKERPOP-1967 connectedComponent()

2018-07-29 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/897#discussion_r205981525
  
--- Diff: docs/src/recipes/connected-components.asciidoc ---
@@ -35,46 +54,92 @@ g.addV().property(id, "A").as("a").
   addE("link").from("d").to("e").iterate()
 
 
-One way to detect the various subgraphs would be to do something like this:
+ Small graph traversals
 
+Connected components in a small graph can be determined with either an 
OLTP traversal or the OLAP
+`connectedComponent()`-step. The `connectedComponent()`-step is available 
as of TinkerPop 3.4.0 and is
+described in more detail in the

+link:http://tinkerpop.apache.org/docs/x.y.z/reference/#connectedcomponent-step[Reference
 Documentation].
+The traversal looks like:
 [gremlin-groovy,existing]
 

-g.V().emit(cyclicPath().or().not(both())).repeat(both()).until(cyclicPath()).  
<1>
-  path().aggregate("p").   
<2>
-  unfold().dedup().
<3>
-  map(__.as("v").select("p").unfold(). 
<4>
- filter(unfold().where(eq("v"))).
- unfold().dedup().order().by(id).fold()).
-  dedup()  
<5>
+g.withComputer().V().connectedComponent().
+group().by('gremlin.connectedComponentVertexProgram.component').
--- End diff --

I think you should use the constant 
`ConnectedComponentVertexProgram.COMPONENT`.


---


[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication

2018-07-29 Thread mattallenuk
Github user mattallenuk commented on the issue:

https://github.com/apache/tinkerpop/pull/889
  
@jorgebay I've modified the Sasl Authenticator so that a mechanism can now 
be passed in along with any mechanism options. I've changed the Sasl Plain 
Authenticator to mimic the Java handler code as discussed, however I had to do 
some fudging as I couldn't get the flow to work right. 

From my understanding of the Java code the 
Driver/Handler/GremlinSaslAuthenticationHandler class receives a 407 from the 
Gremlin Server and then sends a message containing { saslMechanism: 'PLAIN', 
sasl: (A base64 encoded null byte string) }, the server then returns an initial 
response and the client then sends the actual sasl authentication message... I 
tried that and I was getting a message that "Authentication ID must not be 
null". Having looked at the Gremlin Server code and the 
Handler/SaslAuthenticationHandler class and the Auth/SimpleAuthentication class 
it doesn't appear that saslMechanism token is actually parsed and the the 
server expects the actual sasl message right away. So, currently, in the JS 
SaslAuthenticator class I've passed the full Sasl message with the initial 
SaslMechanism argument. 

I hope that makes sense and if it needs changing I'm happy to do so.


---


[jira] [Assigned] (TINKERPOP-1774) Gremlin .NET: Support min and max sizes in Connection pool

2018-07-29 Thread Florian Hockmann (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Florian Hockmann reassigned TINKERPOP-1774:
---

Assignee: Florian Hockmann

> Gremlin .NET: Support min and max sizes in Connection pool
> --
>
> Key: TINKERPOP-1774
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1774
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Affects Versions: 3.2.7
>Reporter: Jorge Bay
>Assignee: Florian Hockmann
>Priority: Minor
>
> Similar to the java connection pool, we should limit the maximum amount of 
> connections and start with a minimum number.
> It would also a good opportunity to remove the synchronous acquisitions of 
> {{lock}} in the pool implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)