[jira] [Updated] (TINKERPOP-2021) Prevent maximum recursion depth failure
[
https://issues.apache.org/jira/browse/TINKERPOP-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP-2021:
Affects Version/s: (was: 3.2.9)
3.3.3
> Prevent maximum recursion depth failure
> ---
>
> Key: TINKERPOP-2021
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2021
> Project: TinkerPop
> Issue Type: Bug
> Components: python
>Affects Versions: 3.3.3
>Reporter: stephen mallette
>Priority: Major
>
> There have been at least two separate reported errors around "maximum
> recursion depth":
> https://groups.google.com/d/msg/gremlin-users/9X9wuUnrFAQ/-cIUYPDYCwAJ
> https://stackoverflow.com/q/51741181/1831717
> Typical error message looks like this:
> {code}
> ERROR | tornado.application | function: handle_callback_exception | line: 638
> | Exception in callback functools.partial( wrap..null_wrapper at 0x1097911e0>)
> Traceback (most recent call last):
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/ioloop.py",
> line 605, in _run_callback
> ret = callback()
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
> line 277, in null_wrapper
> return fn(*args, **kwargs)
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/iostream.py",
> line 562, in wrapper
> return callback(*args)
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
> line 345, in wrapped
> raise_exc_info(exc)
> File "", line 4, in raise_exc_info
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
> line 316, in wrapped
> ret = fn(*args, **kwargs)
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/websocket.py",
> line 869, in _on_frame_length_64
> self._read_frame_data(False)
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/websocket.py",
> line 849, in _read_frame_data
> self._on_masked_frame_data if masked else self._on_frame_data)
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/iostream.py",
> line 319, in read_bytes
> assert isinstance(num_bytes, numbers.Integral)
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/bin/../lib/python3.6/abc.py",
> line 184, in __instancecheck__
> if subclass in cls._abc_cache:
> File
> "~/.local/share/virtualenvs/caladrius-5FocEuMm/bin/../lib/python3.6/_weakrefset.py",
> line 75, in __contains__
> return wr in self.data
> RecursionError: maximum recursion depth exceeded in comparison
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (TINKERPOP-2021) Prevent maximum recursion depth failure
[
https://issues.apache.org/jira/browse/TINKERPOP-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP-2021:
Description:
There have been at least two separate reported errors around "maximum recursion
depth":
https://groups.google.com/d/msg/gremlin-users/9X9wuUnrFAQ/-cIUYPDYCwAJ
https://stackoverflow.com/q/51741181/1831717
Typical error message looks like this:
{code}
ERROR | tornado.application | function: handle_callback_exception | line: 638 |
Exception in callback functools.partial(.null_wrapper at
0x1097911e0>)
Traceback (most recent call last):
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/ioloop.py",
line 605, in _run_callback
ret = callback()
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
line 277, in null_wrapper
return fn(*args, **kwargs)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/iostream.py",
line 562, in wrapper
return callback(*args)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
line 345, in wrapped
raise_exc_info(exc)
File "", line 4, in raise_exc_info
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
line 316, in wrapped
ret = fn(*args, **kwargs)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/websocket.py",
line 869, in _on_frame_length_64
self._read_frame_data(False)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/websocket.py",
line 849, in _read_frame_data
self._on_masked_frame_data if masked else self._on_frame_data)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/iostream.py",
line 319, in read_bytes
assert isinstance(num_bytes, numbers.Integral)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/bin/../lib/python3.6/abc.py",
line 184, in __instancecheck__
if subclass in cls._abc_cache:
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/bin/../lib/python3.6/_weakrefset.py",
line 75, in __contains__
return wr in self.data
RecursionError: maximum recursion depth exceeded in comparison
{code}
doesn't seem to happen on 3.2.9.
was:
There have been at least two separate reported errors around "maximum recursion
depth":
https://groups.google.com/d/msg/gremlin-users/9X9wuUnrFAQ/-cIUYPDYCwAJ
https://stackoverflow.com/q/51741181/1831717
Typical error message looks like this:
{code}
ERROR | tornado.application | function: handle_callback_exception | line: 638 |
Exception in callback functools.partial(.null_wrapper at
0x1097911e0>)
Traceback (most recent call last):
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/ioloop.py",
line 605, in _run_callback
ret = callback()
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
line 277, in null_wrapper
return fn(*args, **kwargs)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/iostream.py",
line 562, in wrapper
return callback(*args)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
line 345, in wrapped
raise_exc_info(exc)
File "", line 4, in raise_exc_info
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/stack_context.py",
line 316, in wrapped
ret = fn(*args, **kwargs)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/websocket.py",
line 869, in _on_frame_length_64
self._read_frame_data(False)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/websocket.py",
line 849, in _read_frame_data
self._on_masked_frame_data if masked else self._on_frame_data)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/lib/python3.6/site-packages/tornado/iostream.py",
line 319, in read_bytes
assert isinstance(num_bytes, numbers.Integral)
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/bin/../lib/python3.6/abc.py",
line 184, in __instancecheck__
if subclass in cls._abc_cache:
File
"~/.local/share/virtualenvs/caladrius-5FocEuMm/bin/../lib/python3.6/_weakrefset.py",
line 75, in __contains__
return wr in self.data
RecursionError: maximum recursion depth exceeded in comparison
{code}
> Prevent maximum recursion depth failure
> ---
>
> Key: TINKERPOP-2021
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2021
> Project: TinkerPop
> Issue Type: Bug
> Components: python
>Affects Versions: 3.3.3
>
[GitHub] tinkerpop issue #919: String loop to String builder [tp32]
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/919 @dkuppitz Will do. ---
[GitHub] tinkerpop issue #919: String loop to String builder [tp32]
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/919 In the future, can we please let those (potential) CTR's sit for a bit longer? I haven't had a chance to really look at it and I guess I would have voted against it (it's not bad, but also not perfect in my opinion). So I'm not asking to revert it, just for a little more patience (at least for outside PRs). ---
[jira] [Commented] (TINKERPOP-2023) Gremlin Server should not create self-signed certs
[ https://issues.apache.org/jira/browse/TINKERPOP-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590322#comment-16590322 ] ASF GitHub Bot commented on TINKERPOP-2023: --- Github user k4rthikr commented on the issue: https://github.com/apache/tinkerpop/pull/912 I agree. Thanks for the change! > Gremlin Server should not create self-signed certs > -- > > Key: TINKERPOP-2023 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2023 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.2.9 >Reporter: Robert Dale >Assignee: Robert Dale >Priority: Minor > Labels: breaking, deprecation > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements
Github user k4rthikr commented on the issue: https://github.com/apache/tinkerpop/pull/912 I agree. Thanks for the change! ---
[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/889 Awesome, thanks guys for the help in getting it there! ---
[DISCUSS] Add Gremlin IDE to Powered By Listing
Hi, just came across: https://github.com/bechbd/gremlin-ide I thought we could add it to the Powered By listing. If there are no objections in the next 72 hours, I will assume lazy consensus and proceed. Thanks, Stephen
[jira] [Closed] (TINKERPOP-1977) Gremlin-JavaScript: Support SASL authentication
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Bay closed TINKERPOP-1977.
Resolution: Done
> Gremlin-JavaScript: Support SASL authentication
> ---
>
> Key: TINKERPOP-1977
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1977
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Jorge Bay
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> We should add support for SASL authentication flow, ideally a generic
> interface and an implementation using username and password.
> An authenticator could have the following interface:
> {code:javascript}
> /** @abstract */
> class Authenticator {
> /**
> @returns {Promise} Returns a promise containing the Request to be sent.
> When the Promise resolves to a null value, it indicates that the
> authentication flow was successful.
> */
> evaluateChallenge(response) {
> throw new Error("evaluateChallenge should be implemented");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/889 Merged ð! Thanks @mattallenuk for your contribution. ---
[jira] [Commented] (TINKERPOP-1977) Gremlin-JavaScript: Support SASL authentication
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590184#comment-16590184
]
ASF GitHub Bot commented on TINKERPOP-1977:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/889
> Gremlin-JavaScript: Support SASL authentication
> ---
>
> Key: TINKERPOP-1977
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1977
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Jorge Bay
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> We should add support for SASL authentication flow, ideally a generic
> interface and an implementation using username and password.
> An authenticator could have the following interface:
> {code:javascript}
> /** @abstract */
> class Authenticator {
> /**
> @returns {Promise} Returns a promise containing the Request to be sent.
> When the Promise resolves to a null value, it indicates that the
> authentication flow was successful.
> */
> evaluateChallenge(response) {
> throw new Error("evaluateChallenge should be implemented");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop pull request #889: Tinkerpop 1977 - Sasl Authentication
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/889 ---
[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition
Github user Tankobot commented on the issue: https://github.com/apache/tinkerpop/pull/898 @jorgebay From the looks of that groovy file, only the traversal files are generated. Are the other scripts in the repository handwritten? I'm actually in a situation very similar to @daem0ndev (writing a server in NestJS and looking for gremlin types). I ended up writing my own type declaration file for gremlin-javascript (it differs slightly from @daem0ndev's types). I wouldn't mind rewriting the entire gremlin-javascript package myself (it's not that big) in TypeScript in order to give it native types. It might still be beneficial to generate some TS files such as those mirroring the Traversal api. Side note: I was looking into implementing the GraphComputer portion of TinkerPop into this package before I saw this pull request on the mailing list (I'm not adept at using mailing lists yet). ---
[jira] [Updated] (TINKERPOP-2025) Change to SHA-256/512 and drop SHA-1 for releases
[ https://issues.apache.org/jira/browse/TINKERPOP-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-2025: Description: Given changes to Apache build requirements it seems we need to adjust our release process again: https://www.apache.org/dev/release-distribution#sigs-and-sums Note that it appears the apache parent pom has updates to consider in this regard: https://issues.apache.org/jira/browse/MPOM-205 Official release information is here: https://s.apache.org/asf-pom-21 was: Given changes to Apache build requirements it seems we need to adjust our release process again: https://www.apache.org/dev/release-distribution#sigs-and-sums Note that it appears the apache parent pom has updates to consider in this regard: https://issues.apache.org/jira/browse/MPOM-205 > Change to SHA-256/512 and drop SHA-1 for releases > - > > Key: TINKERPOP-2025 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2025 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.2.9 >Reporter: stephen mallette >Assignee: Daniel Kuppitz >Priority: Critical > > Given changes to Apache build requirements it seems we need to adjust our > release process again: > https://www.apache.org/dev/release-distribution#sigs-and-sums > Note that it appears the apache parent pom has updates to consider in this > regard: > https://issues.apache.org/jira/browse/MPOM-205 > Official release information is here: > https://s.apache.org/asf-pom-21 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (TINKERPOP-1977) Gremlin-JavaScript: Support SASL authentication
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Bay updated TINKERPOP-1977:
-
Affects Version/s: 3.3.3
3.2.9
> Gremlin-JavaScript: Support SASL authentication
> ---
>
> Key: TINKERPOP-1977
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1977
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Jorge Bay
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> We should add support for SASL authentication flow, ideally a generic
> interface and an implementation using username and password.
> An authenticator could have the following interface:
> {code:javascript}
> /** @abstract */
> class Authenticator {
> /**
> @returns {Promise} Returns a promise containing the Request to be sent.
> When the Promise resolves to a null value, it indicates that the
> authentication flow was successful.
> */
> evaluateChallenge(response) {
> throw new Error("evaluateChallenge should be implemented");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (TINKERPOP-1977) Gremlin-JavaScript: Support SASL authentication
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Bay updated TINKERPOP-1977:
-
Fix Version/s: 3.2.10
3.3.4
3.4.0
> Gremlin-JavaScript: Support SASL authentication
> ---
>
> Key: TINKERPOP-1977
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1977
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Jorge Bay
>Priority: Major
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> We should add support for SASL authentication flow, ideally a generic
> interface and an implementation using username and password.
> An authenticator could have the following interface:
> {code:javascript}
> /** @abstract */
> class Authenticator {
> /**
> @returns {Promise} Returns a promise containing the Request to be sent.
> When the Promise resolves to a null value, it indicates that the
> authentication flow was successful.
> */
> evaluateChallenge(response) {
> throw new Error("evaluateChallenge should be implemented");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1977) Gremlin-JavaScript: Support SASL authentication
[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589899#comment-16589899
]
ASF GitHub Bot commented on TINKERPOP-1977:
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/889
I've pushed to the dev branch TINKERPOP-1977 with some minor fixes:
https://github.com/apache/tinkerpop/compare/tp32...TINKERPOP-1977
Travis started building it, if it succeeds I'll merge it to `tp32`:
https://travis-ci.org/apache/tinkerpop/branches
> Gremlin-JavaScript: Support SASL authentication
> ---
>
> Key: TINKERPOP-1977
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1977
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Reporter: Jorge Bay
>Priority: Major
>
> We should add support for SASL authentication flow, ideally a generic
> interface and an implementation using username and password.
> An authenticator could have the following interface:
> {code:javascript}
> /** @abstract */
> class Authenticator {
> /**
> @returns {Promise} Returns a promise containing the Request to be sent.
> When the Promise resolves to a null value, it indicates that the
> authentication flow was successful.
> */
> evaluateChallenge(response) {
> throw new Error("evaluateChallenge should be implemented");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/889 I've pushed to the dev branch TINKERPOP-1977 with some minor fixes: https://github.com/apache/tinkerpop/compare/tp32...TINKERPOP-1977 Travis started building it, if it succeeds I'll merge it to `tp32`: https://travis-ci.org/apache/tinkerpop/branches ---
[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/889 Its looking great! I'll merge it to a dev branch into the project repo and fix the minor test failure. ---
