Re: code freeze 3.2.10/3.3.4
> I created a ticket to track this and I can probably take care of it next
week
that makes sense, thank you.
separately, code freeze is now lifted on tp33 - i've bumped to
3.3.5-SNAPSHOT, published initial docs/artifacts and all is good to go.
I've left tp32 on 3.2.10 until we decide to actually do something on that
branch. For now, we'll just say we're done there as we discussed
elsethread.
kuppitz, feel free to fire up the dead branch cleanup email. i wonder if it
will be more convenient to delete branches as we go now that we have the
github UI available to us. might be good to just hit the "delete branch"
button right when we hit the merge one.
i will announce the releases on monday morning EST time.
On Fri, Oct 19, 2018 at 5:04 PM Florian Hockmann
wrote:
> We currently use this to push the package:
>
> ${nugetExe} push Gremlin.Net/bin/Gremlin.Net.*.nupkg
>
> which pushes all NuGet packages starting with Gremlin.Net. You probably
> also had the package for version 3.4.0-rc2 in that directory. So,
> nuget.exe tried to push that version again which isn't allowed by NuGet
> as packages are immutable for a given version.
>
> I guess we should specify the exact version here instead to avoid these
> problems in the future. Otherwise we could push development versions to
> nuget.org by accident. I probably implemented it like this at first
> because I assumed that mvn clean would always remove older packages
> which seems to be not the case here.
>
> Anyway, I created a ticket to track this and I can probably take care of
> it next week:
>
> https://issues.apache.org/jira/browse/TINKERPOP-2074
>
>
> Am 19.10.2018 um 21:16 schrieb Stephen Mallette:
> > Florian, any idea what's going on with this error when i deployed 3.3.4:
> >
> > main:
> > [echo] nuget.exe already downloaded.
> > [exec] Pushing Gremlin.Net.3.3.4.nupkg to '
> > https://www.nuget.org/api/v2/package'...
> > [exec] PUT https://www.nuget.org/api/v2/package/
> > [exec] Created https://www.nuget.org/api/v2/package/ 1362ms
> > [exec] Your package was pushed.
> > [exec] Pushing Gremlin.Net.Template.3.3.4.nupkg to '
> > https://www.nuget.org/api/v2/package'...
> > [exec] PUT https://www.nuget.org/api/v2/package/
> > [exec] Created https://www.nuget.org/api/v2/package/ 11405ms
> > [exec] Your package was pushed.
> > [exec] Pushing Gremlin.Net.Template.3.4.0-rc2.nupkg to '
> > https://www.nuget.org/api/v2/package'...
> > [exec] PUT https://www.nuget.org/api/v2/package/
> > [exec] Conflict https://www.nuget.org/api/v2/package/ 365ms
> > [exec] 409 (A package with ID 'Gremlin.Net.Template' and version
> > '3.4.0-rc2' already exists and cannot be modified.)
> >
> >
> > why is it trying to push the 3.4.0 line? looks like the error didn't
> > matter as the other two published fine, but let's fix the error if we
> > can...
> >
> > On Fri, Oct 12, 2018 at 7:27 PM Stephen Mallette
> > wrote:
> >
> >> Robert Dale is without power so I pushed the 3.2.10-SNAPSHOT artifacts
> and
> >> docs too:
> >>
> >> http://tinkerpop.apache.org/docs/3.2.10-SNAPSHOT/
> >>
> >>
> >>
> >> On Fri, Oct 12, 2018 at 8:22 AM Stephen Mallette
> >> wrote:
> >>
> >>> I just published final 3.3.4-SNAPSHOT artifacts and docs:
> >>>
> >>> http://tinkerpop.apache.org/docs/3.3.4-SNAPSHOT/
> >>>
> >>> On Sun, Oct 7, 2018 at 8:33 AM Robert Dale wrote:
> >>>
> I'll take 3.2.10.
>
> Robert Dale
>
>
> On Fri, Oct 5, 2018 at 7:40 PM Stephen Mallette >
> wrote:
>
> > So - code freeze for the tp32 and tp33 branches is in effect at this
> point.
> > We'll use this thread to discuss issues related to 3.2.10 and 3.3.4
> leading
> > up to the build of release artifacts for 10/15. We currently have a
> few PRs
> > that need merging to those branches,
> >
> > https://github.com/apache/tinkerpop/pull/952 (submit scripts with
> > gremlin-javascript)
> > https://github.com/apache/tinkerpop/pull/953 (minor fix for testing
> around
> > inject in .net)
> >
> > but they are related to GLVs so we shouldn't be affecting the ability
> of
> > graph providers to test against the core code. If those merge during
> code
> > freeze, I don't think that's too big a problem.
> >
> > Note that the master branch will remain open for development during
> this
> > time period.
> >
> > Anyone care to volunteer for release manager duties for either of
> these
> > releases?
> >
>
>
Re: code freeze 3.2.10/3.3.4
We currently use this to push the package:
${nugetExe} push Gremlin.Net/bin/Gremlin.Net.*.nupkg
which pushes all NuGet packages starting with Gremlin.Net. You probably
also had the package for version 3.4.0-rc2 in that directory. So,
nuget.exe tried to push that version again which isn't allowed by NuGet
as packages are immutable for a given version.
I guess we should specify the exact version here instead to avoid these
problems in the future. Otherwise we could push development versions to
nuget.org by accident. I probably implemented it like this at first
because I assumed that mvn clean would always remove older packages
which seems to be not the case here.
Anyway, I created a ticket to track this and I can probably take care of
it next week:
https://issues.apache.org/jira/browse/TINKERPOP-2074
Am 19.10.2018 um 21:16 schrieb Stephen Mallette:
> Florian, any idea what's going on with this error when i deployed 3.3.4:
>
> main:
> [echo] nuget.exe already downloaded.
> [exec] Pushing Gremlin.Net.3.3.4.nupkg to '
> https://www.nuget.org/api/v2/package'...
> [exec] PUT https://www.nuget.org/api/v2/package/
> [exec] Created https://www.nuget.org/api/v2/package/ 1362ms
> [exec] Your package was pushed.
> [exec] Pushing Gremlin.Net.Template.3.3.4.nupkg to '
> https://www.nuget.org/api/v2/package'...
> [exec] PUT https://www.nuget.org/api/v2/package/
> [exec] Created https://www.nuget.org/api/v2/package/ 11405ms
> [exec] Your package was pushed.
> [exec] Pushing Gremlin.Net.Template.3.4.0-rc2.nupkg to '
> https://www.nuget.org/api/v2/package'...
> [exec] PUT https://www.nuget.org/api/v2/package/
> [exec] Conflict https://www.nuget.org/api/v2/package/ 365ms
> [exec] 409 (A package with ID 'Gremlin.Net.Template' and version
> '3.4.0-rc2' already exists and cannot be modified.)
>
>
> why is it trying to push the 3.4.0 line? looks like the error didn't
> matter as the other two published fine, but let's fix the error if we
> can...
>
> On Fri, Oct 12, 2018 at 7:27 PM Stephen Mallette
> wrote:
>
>> Robert Dale is without power so I pushed the 3.2.10-SNAPSHOT artifacts and
>> docs too:
>>
>> http://tinkerpop.apache.org/docs/3.2.10-SNAPSHOT/
>>
>>
>>
>> On Fri, Oct 12, 2018 at 8:22 AM Stephen Mallette
>> wrote:
>>
>>> I just published final 3.3.4-SNAPSHOT artifacts and docs:
>>>
>>> http://tinkerpop.apache.org/docs/3.3.4-SNAPSHOT/
>>>
>>> On Sun, Oct 7, 2018 at 8:33 AM Robert Dale wrote:
>>>
I'll take 3.2.10.
Robert Dale
On Fri, Oct 5, 2018 at 7:40 PM Stephen Mallette
wrote:
> So - code freeze for the tp32 and tp33 branches is in effect at this
point.
> We'll use this thread to discuss issues related to 3.2.10 and 3.3.4
leading
> up to the build of release artifacts for 10/15. We currently have a
few PRs
> that need merging to those branches,
>
> https://github.com/apache/tinkerpop/pull/952 (submit scripts with
> gremlin-javascript)
> https://github.com/apache/tinkerpop/pull/953 (minor fix for testing
around
> inject in .net)
>
> but they are related to GLVs so we shouldn't be affecting the ability
of
> graph providers to test against the core code. If those merge during
code
> freeze, I don't think that's too big a problem.
>
> Note that the master branch will remain open for development during
this
> time period.
>
> Anyone care to volunteer for release manager duties for either of these
> releases?
>
[jira] [Created] (TINKERPOP-2074) Ensure that only NuGet packages for the current version are pushed
Florian Hockmann created TINKERPOP-2074:
---
Summary: Ensure that only NuGet packages for the current version
are pushed
Key: TINKERPOP-2074
URL: https://issues.apache.org/jira/browse/TINKERPOP-2074
Project: TinkerPop
Issue Type: Improvement
Components: build-release, dotnet
Reporter: Florian Hockmann
We currently use this command to push the NuGet packages to nuget.org:
{code}
${nugetExe} push Gremlin.Net/bin/Gremlin.Net.*.nupkg [...]{code}
which will push all versions of the package it can find in the
{{Gremlin.Net/bin}} directory. The same applies to the Gremlin.Net.Template.
We should use the exact version here instead to avoid pushing packages for any
other versions by accident.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (TINKERPOP-2071) gremlin-python: the graphson deserializer for g:Set should return a python set
[ https://issues.apache.org/jira/browse/TINKERPOP-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette reassigned TINKERPOP-2071: --- Assignee: stephen mallette Affects Version/s: 3.3.3 Fix Version/s: (was: 3.3.4) > gremlin-python: the graphson deserializer for g:Set should return a python set > -- > > Key: TINKERPOP-2071 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2071 > Project: TinkerPop > Issue Type: Improvement > Components: python >Affects Versions: 3.3.3 >Reporter: Alan Boudreault >Assignee: stephen mallette >Priority: Major > > This is something that has already been discussed. The reason that a g:Set is > deserialized to a list is because Java can return some numerical values that > are not differentiate by python. See TINKERPOP-1844 for more details. > However, I think this is is not something very common so I would like to > propose another behavior: > 1. By default, always return a python set as normal for g:Set > 2. When we detect the case described, log a warning and return a python list. > 3. Document properly the limitation and the behavior of g:Set. > Already discussed with Stephen and we think it's an acceptable behavior. I > will provide a PR shortly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: code freeze 3.2.10/3.3.4
Florian, any idea what's going on with this error when i deployed 3.3.4: main: [echo] nuget.exe already downloaded. [exec] Pushing Gremlin.Net.3.3.4.nupkg to ' https://www.nuget.org/api/v2/package'... [exec] PUT https://www.nuget.org/api/v2/package/ [exec] Created https://www.nuget.org/api/v2/package/ 1362ms [exec] Your package was pushed. [exec] Pushing Gremlin.Net.Template.3.3.4.nupkg to ' https://www.nuget.org/api/v2/package'... [exec] PUT https://www.nuget.org/api/v2/package/ [exec] Created https://www.nuget.org/api/v2/package/ 11405ms [exec] Your package was pushed. [exec] Pushing Gremlin.Net.Template.3.4.0-rc2.nupkg to ' https://www.nuget.org/api/v2/package'... [exec] PUT https://www.nuget.org/api/v2/package/ [exec] Conflict https://www.nuget.org/api/v2/package/ 365ms [exec] 409 (A package with ID 'Gremlin.Net.Template' and version '3.4.0-rc2' already exists and cannot be modified.) why is it trying to push the 3.4.0 line? looks like the error didn't matter as the other two published fine, but let's fix the error if we can... On Fri, Oct 12, 2018 at 7:27 PM Stephen Mallette wrote: > Robert Dale is without power so I pushed the 3.2.10-SNAPSHOT artifacts and > docs too: > > http://tinkerpop.apache.org/docs/3.2.10-SNAPSHOT/ > > > > On Fri, Oct 12, 2018 at 8:22 AM Stephen Mallette > wrote: > >> I just published final 3.3.4-SNAPSHOT artifacts and docs: >> >> http://tinkerpop.apache.org/docs/3.3.4-SNAPSHOT/ >> >> On Sun, Oct 7, 2018 at 8:33 AM Robert Dale wrote: >> >>> I'll take 3.2.10. >>> >>> Robert Dale >>> >>> >>> On Fri, Oct 5, 2018 at 7:40 PM Stephen Mallette >>> wrote: >>> >>> > So - code freeze for the tp32 and tp33 branches is in effect at this >>> point. >>> > We'll use this thread to discuss issues related to 3.2.10 and 3.3.4 >>> leading >>> > up to the build of release artifacts for 10/15. We currently have a >>> few PRs >>> > that need merging to those branches, >>> > >>> > https://github.com/apache/tinkerpop/pull/952 (submit scripts with >>> > gremlin-javascript) >>> > https://github.com/apache/tinkerpop/pull/953 (minor fix for testing >>> around >>> > inject in .net) >>> > >>> > but they are related to GLVs so we shouldn't be affecting the ability >>> of >>> > graph providers to test against the core code. If those merge during >>> code >>> > freeze, I don't think that's too big a problem. >>> > >>> > Note that the master branch will remain open for development during >>> this >>> > time period. >>> > >>> > Anyone care to volunteer for release manager duties for either of these >>> > releases? >>> > >>> >>
[jira] [Commented] (TINKERPOP-2073) Generate tabs for static code blocks
[ https://issues.apache.org/jira/browse/TINKERPOP-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657178#comment-16657178 ] ASF GitHub Bot commented on TINKERPOP-2073: --- dkuppitz opened a new pull request #965: TINKERPOP-2073 Generate tabs for static code blocks URL: https://github.com/apache/tinkerpop/pull/965 https://issues.apache.org/jira/browse/TINKERPOP-2073 Tested with the sample code blocks shown in the Jira ticket - looked good. VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Generate tabs for static code blocks > > > Key: TINKERPOP-2073 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2073 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.4.0 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Major > > Tabs are only generated for evaluated code blocks. It should be possible to > tabify static code blocks, too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [tinkerpop] dkuppitz opened pull request #965: TINKERPOP-2073 Generate tabs for static code blocks
https://issues.apache.org/jira/browse/TINKERPOP-2073 Tested with the sample code blocks shown in the Jira ticket - looked good. VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/965 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Commented] (TINKERPOP-2073) Generate tabs for static code blocks
[
https://issues.apache.org/jira/browse/TINKERPOP-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657171#comment-16657171
]
Daniel Kuppitz commented on TINKERPOP-2073:
---
Proposed solution:
{noformat}
[source,java,tab]
Vertex v =
[source,python]
v =
[source,javascript]
const v =
{noformat}
If the first static code block contains the {{tab}} argument, this block and
all the following code blocks will be tabified.
> Generate tabs for static code blocks
>
>
> Key: TINKERPOP-2073
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2073
> Project: TinkerPop
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 3.4.0
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Tabs are only generated for evaluated code blocks. It should be possible to
> tabify static code blocks, too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (TINKERPOP-2073) Generate tabs for static code blocks
Daniel Kuppitz created TINKERPOP-2073: - Summary: Generate tabs for static code blocks Key: TINKERPOP-2073 URL: https://issues.apache.org/jira/browse/TINKERPOP-2073 Project: TinkerPop Issue Type: Improvement Components: documentation Affects Versions: 3.4.0 Reporter: Daniel Kuppitz Assignee: Daniel Kuppitz Tabs are only generated for evaluated code blocks. It should be possible to tabify static code blocks, too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] TinkerPop 3.2.10 Release
This vote is now closed with a total of 4 +1s, no +0s and no -1s. The results are: BINDING VOTES: +1 (4 -- Stephen Mallette, Daniel Kuppitz, Florian Hockmann, Robert Dale) 0 (0) -1 (0) Robert Dale On Wed, Oct 17, 2018 at 3:42 AM Florian Hockmann wrote: > I tested the new Docker images manually and briefly reviewed the docs. The > docker images are successfully built and tagged as 3.2.10 and 3.2. > > VOTE +1 > > -Ursprüngliche Nachricht- > Von: Stephen Mallette > Gesendet: Dienstag, 16. Oktober 2018 18:16 > An: dev@tinkerpop.apache.org > Betreff: Re: [VOTE] TinkerPop 3.2.10 Release > > validate-distribution.sh is nice, docs look good from a cursory glance > > VOTE +1 > > On Tue, Oct 16, 2018 at 12:10 PM Daniel Kuppitz wrote: > > > Validating binary distributions > > > > * downloading Apache TinkerPop Gremlin > > (apache-tinkerpop-gremlin-console-3.2.10-bin.zip)... OK > > * validating signatures and checksums ... > > * PGP signature ... OK > > * SHA512 checksum ... OK > > * unzipping Apache TinkerPop Gremlin ... OK > > * validating Apache TinkerPop Gremlin's docs ... OK > > * validating Apache TinkerPop Gremlin's binaries ... OK > > * validating Apache TinkerPop Gremlin's legal files ... > > * LICENSE ... OK > > * NOTICE ... OK > > * validating Apache TinkerPop Gremlin's plugin directory ... OK > > * validating Apache TinkerPop Gremlin's lib directory ... OK > > * testing script evaluation ... OK > > > > * downloading Apache TinkerPop Gremlin > > (apache-tinkerpop-gremlin-server-3.2.10-bin.zip)... OK > > * validating signatures and checksums ... > > * PGP signature ... OK > > * SHA512 checksum ... OK > > * unzipping Apache TinkerPop Gremlin ... OK > > * validating Apache TinkerPop Gremlin's docs ... OK > > * validating Apache TinkerPop Gremlin's binaries ... OK > > * validating Apache TinkerPop Gremlin's legal files ... > > * LICENSE ... OK > > * NOTICE ... OK > > * validating Apache TinkerPop Gremlin's plugin directory ... OK > > * validating Apache TinkerPop Gremlin's lib directory ... OK > > > > Validating source distribution > > > > * downloading Apache TinkerPop 3.2.10 > (apache-tinkerpop-3.2.10-src.zip)... > > OK > > * validating signatures and checksums ... > > * PGP signature ... OK > > * SHA512 checksum ... OK > > * unzipping Apache TinkerPop 3.2.10 ... OK > > * building project ... OK > > > > > > All good, VOTE +1 > > > > Cheers, > > Daniel > > > > > > On Mon, Oct 15, 2018 at 2:05 PM Robert Dale wrote: > > > > > Hello, > > > > > > We are happy to announce that TinkerPop 3.2.10 is ready for release. > > > > > > The release artifacts can be found at this location: > > > https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.10/ > > > > > > The source distribution is provided by: > > > apache-tinkerpop-3.2.10-src.zip > > > > > > Two binary distributions are provided for user convenience: > > > apache-tinkerpop-gremlin-console-3.2.10-bin.zip > > > apache-tinkerpop-gremlin-server-3.2.10-bin.zip > > > > > > The GPG key used to sign the release artifacts is available at: > > > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS > > > > > > The online docs can be found here: > > > http://tinkerpop.apache.org/docs/3.2.10/ (user docs) > > > http://tinkerpop.apache.org/docs/3.2.10/upgrade/ (upgrade > docs) > > > http://tinkerpop.apache.org/javadocs/3.2.10/core/ (core > javadoc) > > > http://tinkerpop.apache.org/javadocs/3.2.10/full/ (full > > > javadoc) > > > > > > The tag in Apache Git can be found here: > > > https://github.com/apache/tinkerpop/tree/3.2.10 > > > > > > The release notes are available here: > > > > > > > > > > > https://github.com/apache/tinkerpop/blob/3.2.10/CHANGELOG.asciidoc#rel > > ease-3-2-10 > > > > > > NOTE: Please use the latest `bin/validate-distribution.sh` from the > > > tp32 branch as a last-minute bug was fixed. > > > > > > The [VOTE] will be open for the next 72 hours --- closing Thursday > > (October > > > 11 2018) at 5:05 PM EDT. > > > > > > My vote is +1. > > > > > > Thank you very much, > > > Robert Dale > > > > > > >
[RESULT][VOTE] TinkerPop 3.3.4 Release
This vote is now closed with a total of 4 +1s, no +0s and no -1s. The
results are:
BINDING VOTES:
+1 (4 -- Stephen Mallette, Daniel Kuppitz, Florian Hockmann, Robert Dale)
0 (0)
-1 (0)
On Fri, Oct 19, 2018 at 9:46 AM Stephen Mallette
wrote:
> dari can manually correct that
>
> On Fri, Oct 19, 2018 at 9:45 AM Robert Dale wrote:
>
>> Reviewed docs.
>>
>> In http://tinkerpop.apache.org/docs/3.3.4/upgrade/#_timedinterrupt , it
>> has *{{
>> }} *instead of the normal code format:
>>
>> In Gremlin Server, it is best not to use the {{timedInterrupt}} option on
>> {{GroovyCompilerGremlinPlugin}} because it can compete with the
>> {{scriptEvaluationTimeout}} setting and produce a different error path.
>> Simply rely on {{scriptEvaluationTimeout}} as it covers both script
>> evaluation time and result iteration time.
>>
>>
>> Not a deal breaker.
>>
>> VOTE +1
>>
>>
>> Robert Dale
>>
>>
>> On Wed, Oct 17, 2018 at 3:58 AM Florian Hockmann
>> wrote:
>>
>> > I tested the new Docker images manually and briefly reviewed the docs.
>> The
>> > docker images are successfully built and tagged as 3.3.4, 3.3, and
>> latest
>> > (so, `docker run -it tinkerpop/gremlin-console` works now).
>> >
>> > BTW, nice work with the different output versions for code listings
>> > (currently "CONSOLE (GROOVY)" or "GROOVY"). I hope we can extend those
>> for
>> > Python/C#/JS over time.
>> >
>> > VOTE +1
>> >
>> > -Ursprüngliche Nachricht-
>> > Von: Daniel Kuppitz
>> > Gesendet: Dienstag, 16. Oktober 2018 18:11
>> > An: dev@tinkerpop.apache.org
>> > Betreff: Re: [VOTE] TinkerPop 3.3.4 Release
>> >
>> > Validating binary distributions
>> >
>> > * downloading Apache TinkerPop Gremlin
>> > (apache-tinkerpop-gremlin-console-3.3.4-bin.zip)... OK
>> > * validating signatures and checksums ...
>> > * PGP signature ... OK
>> > * SHA512 checksum ... OK
>> > * unzipping Apache TinkerPop Gremlin ... OK
>> > * validating Apache TinkerPop Gremlin's docs ... OK
>> > * validating Apache TinkerPop Gremlin's binaries ... OK
>> > * validating Apache TinkerPop Gremlin's legal files ...
>> > * LICENSE ... OK
>> > * NOTICE ... OK
>> > * validating Apache TinkerPop Gremlin's plugin directory ... OK
>> > * validating Apache TinkerPop Gremlin's lib directory ... OK
>> > * testing script evaluation ... OK
>> >
>> > * downloading Apache TinkerPop Gremlin
>> > (apache-tinkerpop-gremlin-server-3.3.4-bin.zip)... OK
>> > * validating signatures and checksums ...
>> > * PGP signature ... OK
>> > * SHA512 checksum ... OK
>> > * unzipping Apache TinkerPop Gremlin ... OK
>> > * validating Apache TinkerPop Gremlin's docs ... OK
>> > * validating Apache TinkerPop Gremlin's binaries ... OK
>> > * validating Apache TinkerPop Gremlin's legal files ...
>> > * LICENSE ... OK
>> > * NOTICE ... OK
>> > * validating Apache TinkerPop Gremlin's plugin directory ... OK
>> > * validating Apache TinkerPop Gremlin's lib directory ... OK
>> >
>> > Validating source distribution
>> >
>> > * downloading Apache TinkerPop 3.3.4
>> (apache-tinkerpop-3.3.4-src.zip)... OK
>> > * validating signatures and checksums ...
>> > * PGP signature ... OK
>> > * SHA512 checksum ... OK
>> > * unzipping Apache TinkerPop 3.3.4 ... OK
>> > * building project ... OK
>> >
>> > All good, VOTE +1
>> >
>> > Cheers,
>> > Daniel
>> >
>> >
>> > On Tue, Oct 16, 2018 at 8:46 AM Stephen Mallette
>> > wrote:
>> >
>> > > Hello,
>> > >
>> > > We are happy to announce that TinkerPop 3.3.4 is ready for release.
>> > >
>> > > The release artifacts can be found at this location:
>> > > https://dist.apache.org/repos/dist/dev/tinkerpop/3.3.4/
>> > >
>> > > The source distribution is provided by:
>> > > apache-tinkerpop-3.3.4-src.zip
>> > >
>> > > Two binary distributions are provided for user convenience:
>> > > apache-tinkerpop-gremlin-console-3.3.4-bin.zip
>> > > apache-tinkerpop-gremlin-server-3.3.4-bin.zip
>> > >
>> > > The GPG key used to sign the release artifacts is available at:
>> > > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
>> > >
>> > > The online docs can be found here:
>> > > http://tinkerpop.apache.org/docs/3.3.4/ (user docs)
>> > > http://tinkerpop.apache.org/docs/3.3.4/upgrade/ (upgrade
>> docs)
>> > > http://tinkerpop.apache.org/javadocs/3.3.4/core/ (core
>> javadoc)
>> > > http://tinkerpop.apache.org/javadocs/3.3.4/full/ (full
>> > > javadoc)
>> > >
>> > > The tag in Apache Git can be found here:
>> > > https://github.com/apache/tinkerpop/tree/3.3.4
>> > >
>> > > The release notes are available here:
>> > >
>> > > https://github.com/apache/tinkerpop/blob/3.3.4/CHANGELOG.asciidoc
>> > >
>> > > The [VOTE] will be open for the next 72 hours --- closing Friday
>> > > (October 19, 2018) at 12pm EST.
>> > >
>> > > My vote is +1.
>> > >
>> > > Thank you very much,
>> > > Stephen
>> > >
>> >
>> >
>>
>
[jira] [Created] (TINKERPOP-2072) Refactor custom type translation for ScriptTranslators
stephen mallette created TINKERPOP-2072:
---
Summary: Refactor custom type translation for ScriptTranslators
Key: TINKERPOP-2072
URL: https://issues.apache.org/jira/browse/TINKERPOP-2072
Project: TinkerPop
Issue Type: Improvement
Components: groovy
Affects Versions: 3.3.4
Reporter: stephen mallette
Assignee: stephen mallette
Refactor the `TypeTranslator` system a bit so that it is better designed for
extension rather than the "plugin" style system that exists now. The current
method seems to work but it's a bit awkward in that it introduces some circular
logic if a custom translator needs to refer back to the default one. In the
worst case it means embedding {{GroovyTranslator}} itself in the
{{TypeTranslator}}.
Anyway, this is a breaking change because it completely alters the old method
for handling this. On the plus side, this is a very low-level and internal
feature that is only of interest to graph providers so it shouldn't break too
much code out there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [VOTE] TinkerPop 3.3.4 Release
Reviewed docs.
In http://tinkerpop.apache.org/docs/3.3.4/upgrade/#_timedinterrupt , it has *{{
}} *instead of the normal code format:
In Gremlin Server, it is best not to use the {{timedInterrupt}} option on
{{GroovyCompilerGremlinPlugin}} because it can compete with the
{{scriptEvaluationTimeout}} setting and produce a different error path.
Simply rely on {{scriptEvaluationTimeout}} as it covers both script
evaluation time and result iteration time.
Not a deal breaker.
VOTE +1
Robert Dale
On Wed, Oct 17, 2018 at 3:58 AM Florian Hockmann
wrote:
> I tested the new Docker images manually and briefly reviewed the docs. The
> docker images are successfully built and tagged as 3.3.4, 3.3, and latest
> (so, `docker run -it tinkerpop/gremlin-console` works now).
>
> BTW, nice work with the different output versions for code listings
> (currently "CONSOLE (GROOVY)" or "GROOVY"). I hope we can extend those for
> Python/C#/JS over time.
>
> VOTE +1
>
> -Ursprüngliche Nachricht-
> Von: Daniel Kuppitz
> Gesendet: Dienstag, 16. Oktober 2018 18:11
> An: dev@tinkerpop.apache.org
> Betreff: Re: [VOTE] TinkerPop 3.3.4 Release
>
> Validating binary distributions
>
> * downloading Apache TinkerPop Gremlin
> (apache-tinkerpop-gremlin-console-3.3.4-bin.zip)... OK
> * validating signatures and checksums ...
> * PGP signature ... OK
> * SHA512 checksum ... OK
> * unzipping Apache TinkerPop Gremlin ... OK
> * validating Apache TinkerPop Gremlin's docs ... OK
> * validating Apache TinkerPop Gremlin's binaries ... OK
> * validating Apache TinkerPop Gremlin's legal files ...
> * LICENSE ... OK
> * NOTICE ... OK
> * validating Apache TinkerPop Gremlin's plugin directory ... OK
> * validating Apache TinkerPop Gremlin's lib directory ... OK
> * testing script evaluation ... OK
>
> * downloading Apache TinkerPop Gremlin
> (apache-tinkerpop-gremlin-server-3.3.4-bin.zip)... OK
> * validating signatures and checksums ...
> * PGP signature ... OK
> * SHA512 checksum ... OK
> * unzipping Apache TinkerPop Gremlin ... OK
> * validating Apache TinkerPop Gremlin's docs ... OK
> * validating Apache TinkerPop Gremlin's binaries ... OK
> * validating Apache TinkerPop Gremlin's legal files ...
> * LICENSE ... OK
> * NOTICE ... OK
> * validating Apache TinkerPop Gremlin's plugin directory ... OK
> * validating Apache TinkerPop Gremlin's lib directory ... OK
>
> Validating source distribution
>
> * downloading Apache TinkerPop 3.3.4 (apache-tinkerpop-3.3.4-src.zip)... OK
> * validating signatures and checksums ...
> * PGP signature ... OK
> * SHA512 checksum ... OK
> * unzipping Apache TinkerPop 3.3.4 ... OK
> * building project ... OK
>
> All good, VOTE +1
>
> Cheers,
> Daniel
>
>
> On Tue, Oct 16, 2018 at 8:46 AM Stephen Mallette
> wrote:
>
> > Hello,
> >
> > We are happy to announce that TinkerPop 3.3.4 is ready for release.
> >
> > The release artifacts can be found at this location:
> > https://dist.apache.org/repos/dist/dev/tinkerpop/3.3.4/
> >
> > The source distribution is provided by:
> > apache-tinkerpop-3.3.4-src.zip
> >
> > Two binary distributions are provided for user convenience:
> > apache-tinkerpop-gremlin-console-3.3.4-bin.zip
> > apache-tinkerpop-gremlin-server-3.3.4-bin.zip
> >
> > The GPG key used to sign the release artifacts is available at:
> > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS
> >
> > The online docs can be found here:
> > http://tinkerpop.apache.org/docs/3.3.4/ (user docs)
> > http://tinkerpop.apache.org/docs/3.3.4/upgrade/ (upgrade docs)
> > http://tinkerpop.apache.org/javadocs/3.3.4/core/ (core javadoc)
> > http://tinkerpop.apache.org/javadocs/3.3.4/full/ (full
> > javadoc)
> >
> > The tag in Apache Git can be found here:
> > https://github.com/apache/tinkerpop/tree/3.3.4
> >
> > The release notes are available here:
> >
> > https://github.com/apache/tinkerpop/blob/3.3.4/CHANGELOG.asciidoc
> >
> > The [VOTE] will be open for the next 72 hours --- closing Friday
> > (October 19, 2018) at 12pm EST.
> >
> > My vote is +1.
> >
> > Thank you very much,
> > Stephen
> >
>
>
