[jira] [Commented] (TINKERPOP-2105) Gremlin-Python connection not returned back to the pool on exception from gremlin server

2018-11-29 Thread Kunal (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703829#comment-16703829
 ] 

Kunal commented on TINKERPOP-2105:
--

I am not sure that the fix I have tested locally is ideal here. I changed the 
_receive method to contain a finally such that self._pool.put_nowait(self) is 
always executed. Do you think that is the right fix here?

 
{quote}def _receive(self):
  try: 
      while True:
          data = self._transport.read()
          status_code = self._protocol.data_received(data, self._results)
          if status_code != 206:
              break
 finally:
    self._pool.put_nowait(self)
{quote}

> Gremlin-Python connection not returned back to the pool on exception from 
> gremlin server
> 
>
> Key: TINKERPOP-2105
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2105
> Project: TinkerPop
>  Issue Type: Bug
>  Components: driver, python
>Reporter: Kunal
>Priority: Major
> Attachments: issue.py
>
>
> The is an issue with the gremlin-python driver where for requests that return 
> an exception from the gremlin server result in the connection not being 
> returned to the pool. I have a reproducer and have attached the code to this 
> issue as issue.py. 
> The root cause seems to be in the error handling logic in connection.py refer 
> to 
> [https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main/jython/gremlin_python/driver/connection.py#L75-L81.]
>  In exception scenarios an exception is thrown on line 77 which cause line 81 
> to be not executed.
> The result of this is if we use a singleton connection (as in the attached 
> reproducer) on the client side with default pool size of 4 then the client 
> becomes unresponsive after 4 requests that result in server throwing an 
> exception.
> This issue is reproducible with tinkergraph reference implementation as well.
>  
> I tried a workaround by changing connection.py locally which did work for me 
> but not sure if that would be the ideal fix. Basically in the _receive() 
> function in connection.py I added a try finally and call the 
> self._pool.put_nowait(self) in the finally block
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (TINKERPOP-2095) GroupStep looks for irrelevant barrier steps

2018-11-29 Thread Daniel Kuppitz (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz closed TINKERPOP-2095.
-
   Resolution: Fixed
Fix Version/s: 3.3.5
   3.4.0

> GroupStep looks for irrelevant barrier steps
> 
>
> Key: TINKERPOP-2095
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2095
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.4
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
> Fix For: 3.4.0, 3.3.5
>
>
> {{GroupStep}} looks for a {{Barrier}} step to determine the reducing 
> bi-operator. This is wrong and I'm really surprised that this has never been 
> spotted before.
> {noformat}
> gremlin> 
> g.V().hasLabel('person').as('p').out('created').group().by('name').by(select('p').values('age').sum())
> java.lang.Long cannot be cast to 
> org.apache.tinkerpop.gremlin.process.traversal.traverser.util.TraverserSet
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
> In the query above the first barrier step is a {{NoOpBarrier}} step (added by 
> {{PathRetractionStrategy}}). This step obviously has no reducing bi-operator. 
> What we really want to do is look for the first barrier step that is not a 
> {{LocalBarrier}} step.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-2095) GroupStep looks for irrelevant barrier steps

2018-11-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703712#comment-16703712
 ] 

ASF GitHub Bot commented on TINKERPOP-2095:
---

asfgit closed pull request #997: TINKERPOP-2095 GroupStep looks for irrelevant 
barrier steps
URL: https://github.com/apache/tinkerpop/pull/997
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GroupStep looks for irrelevant barrier steps
> 
>
> Key: TINKERPOP-2095
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2095
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.4
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> {{GroupStep}} looks for a {{Barrier}} step to determine the reducing 
> bi-operator. This is wrong and I'm really surprised that this has never been 
> spotted before.
> {noformat}
> gremlin> 
> g.V().hasLabel('person').as('p').out('created').group().by('name').by(select('p').values('age').sum())
> java.lang.Long cannot be cast to 
> org.apache.tinkerpop.gremlin.process.traversal.traverser.util.TraverserSet
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
> In the query above the first barrier step is a {{NoOpBarrier}} step (added by 
> {{PathRetractionStrategy}}). This step obviously has no reducing bi-operator. 
> What we really want to do is look for the first barrier step that is not a 
> {{LocalBarrier}} step.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] asfgit closed pull request #997: TINKERPOP-2095 GroupStep looks for irrelevant barrier steps

2018-11-29 Thread GitHub
[ pull request closed by asfgit ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/997 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Commented] (TINKERPOP-2090) After running backend for a day or so System.IO.IOException keep throwing

2018-11-29 Thread Florian Hockmann (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703617#comment-16703617
 ] 

Florian Hockmann commented on TINKERPOP-2090:
-

No, unfortunately not. I emailed [~lb...@microsoft.com] from the Cosmos DB team 
and pointed him to this issue, but he didn't reply (yet). I can't reproduce 
this and therefore I also can't really investigate what's causing this. I 
wonder whether this issue is related to TINKERPOP-2019 in any way as both seem 
to be specific to Cosmos DB and both seem to be caused by connections being 
dropped by the remote site (Cosmos DB / Azure).

Reusing connections with request pipelining (TINKERPOP-1775) hopefully makes 
this situation less likely to occur as it should reduce the number of idle 
connections dramatically. I'm currently working on that and hope that I can get 
it in for 3.4.0.

Apart from that I'm afraid we need more information from the Cosmos DB team 
about why the connections are getting closed. Otherwise I have no idea how we 
could prevent this situation on our site. Maybe we also need a 
{{validationRequest}} like in the Java driver, but my current understanding is 
still that the Websocket keepalive ping should already prevent connections from 
being considered idle. Before we have a better understanding of the problem, I 
don't really want to add something like that since we don't know whether it 
actually solves the problem.

 

> After running backend for a day or so System.IO.IOException keep throwing
> -
>
> Key: TINKERPOP-2090
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2090
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.4.0
> Environment: .NET Core 2.1.5
> Microsoft Azure
>Reporter: Saber Karmous
>Priority: Critical
>
> .NET Core 2.1.5
> Gremlin.NET 3.4.0-rc2 
> We're using the latest RC of the Gremlin client. And we have a gremlin client 
> that's being injected as a singleton through out IoC container. After running 
> the backend for a day or two it keeps throwing System.IO.IOExceptions. If we 
> restart the application it works again.
> We use Polly for out retry strategy, and retrying for 9 times. But it keeps 
> failing.
> I added the stack trace below. Reproducing is a bit of a pain in the behind, 
> you have to wait for a day or two for the exception to occur.
> {noformat}
> *no* System.IO.IOException:
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at Gr

[jira] [Closed] (TINKERPOP-2048) Java Driver: Support custom headers in WebSocket request

2018-11-29 Thread stephen mallette (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-2048.
---
Resolution: Won't Do

> Java Driver: Support custom headers in WebSocket request
> 
>
> Key: TINKERPOP-2048
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2048
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: driver
>Affects Versions: 3.2.9
>Reporter: Jorge Bay
>Priority: Major
>
> Similar to TINKERPOP-2035, we should allow users to set custom request 
> headers in WebSocket request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-2090) After running backend for a day or so System.IO.IOException keep throwing

2018-11-29 Thread stephen mallette (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703580#comment-16703580
 ] 

stephen mallette commented on TINKERPOP-2090:
-

[~Florian Hockmann] did you ever learn anything new on this one?

> After running backend for a day or so System.IO.IOException keep throwing
> -
>
> Key: TINKERPOP-2090
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2090
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.4.0
> Environment: .NET Core 2.1.5
> Microsoft Azure
>Reporter: Saber Karmous
>Priority: Critical
>
> .NET Core 2.1.5
> Gremlin.NET 3.4.0-rc2 
> We're using the latest RC of the Gremlin client. And we have a gremlin client 
> that's being injected as a singleton through out IoC container. After running 
> the backend for a day or two it keeps throwing System.IO.IOExceptions. If we 
> restart the application it works again.
> We use Polly for out retry strategy, and retrying for 9 times. But it keeps 
> failing.
> I added the stack trace below. Reproducing is a bit of a pain in the behind, 
> you have to wait for a day or two for the exception to occur.
> {noformat}
> *no* System.IO.IOException:
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable+ConfiguredValueTaskAwaiter.GetResult
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Net.Security.SslStreamInternal+d`1.MoveNext
>  (System.Net.Security, Version=4.1.1.0, Culture=neutral, 
> PublicKeyToken=b03f5f7f11d50a3a)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at Gremlin.Net.Driver.WebSocketConnection+d__7.MoveNext 
> (Gremlin.Net, Version=3.4.0.0, Culture=neutral, 
> PublicKeyToken=d2035e9aa387a711)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
>  (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at Gremlin.Net.Driver.Connection+d__13.MoveNext (Gremlin.Net, 
> Version=3.4.0.0, Culture=neutral, PublicKeyToken=d2035e9aa387a711)
>  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess 
> (System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, 
> PublicKeyToken=7cec85d7bea7798e)
>  at 
> System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccess

[jira] [Closed] (TINKERPOP-2104) Allow ImportCustomizer to handle fields

2018-11-29 Thread stephen mallette (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-2104.
---
   Resolution: Done
Fix Version/s: 3.4.0

> Allow ImportCustomizer to handle fields
> ---
>
> Key: TINKERPOP-2104
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2104
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.4.0
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.4.0
>
>
> Allow {{ImportCustomizer}} to handle field imports to the {{ScriptEngine}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] spmallette closed pull request #1008: TINKERPOP-2104 Allow ImportCustomizer to handle fields

2018-11-29 Thread GitHub
[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1008 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Commented] (TINKERPOP-2104) Allow ImportCustomizer to handle fields

2018-11-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703126#comment-16703126
 ] 

ASF GitHub Bot commented on TINKERPOP-2104:
---

spmallette closed pull request #1008: TINKERPOP-2104 Allow ImportCustomizer to 
handle fields
URL: https://github.com/apache/tinkerpop/pull/1008
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow ImportCustomizer to handle fields
> ---
>
> Key: TINKERPOP-2104
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2104
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.4.0
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.4.0
>
>
> Allow {{ImportCustomizer}} to handle field imports to the {{ScriptEngine}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-2106) When gremlin executes timeout, throw TimeoutException instead of TraversalInterruptedException/InterruptedIOException

2018-11-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703098#comment-16703098
 ] 

ASF GitHub Bot commented on TINKERPOP-2106:
---

javeme opened a new pull request #1009: TINKERPOP-2106 throw TimeoutException 
instead of TraversalInterruptedException
URL: https://github.com/apache/tinkerpop/pull/1009
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2106
   
   When gremlin executes timeout, it throws an error 
"TraversalInterruptedException: null".
   According to our user 
feedback(https://github.com/hugegraph/hugegraph/issues/102), the message is not 
easy to understand. we think it is clearer if it prompts timeout error directly.
   
   This commit converts some InterruptedException to a TimeoutException.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> When gremlin executes timeout, throw TimeoutException instead of 
> TraversalInterruptedException/InterruptedIOException
> -
>
> Key: TINKERPOP-2106
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2106
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.5
>Reporter: Jermy Li
>Priority: Major
>
> When gremlin executes timeout, it throws an error 
> "TraversalInterruptedException: null". According to our user feedback, the 
> message is not easy to understand. we think it is clearer if it prompts 
> timeout error directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (TINKERPOP-2106) When gremlin executes timeout, throw TimeoutException instead of TraversalInterruptedException/InterruptedIOException

2018-11-29 Thread Jermy Li (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jermy Li updated TINKERPOP-2106:

Priority: Major  (was: Minor)

> When gremlin executes timeout, throw TimeoutException instead of 
> TraversalInterruptedException/InterruptedIOException
> -
>
> Key: TINKERPOP-2106
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2106
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.5
>Reporter: Jermy Li
>Priority: Major
>
> When gremlin executes timeout, it throws an error 
> "TraversalInterruptedException: null". According to our user feedback, the 
> message is not easy to understand. we think it is clearer if it prompts 
> timeout error directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] javeme opened pull request #1009: TINKERPOP-2106 throw TimeoutException instead of TraversalInterruptedException

2018-11-29 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2106

When gremlin executes timeout, it throws an error 
"TraversalInterruptedException: null".
According to our user 
feedback(https://github.com/hugegraph/hugegraph/issues/102), the message is not 
easy to understand. we think it is clearer if it prompts timeout error directly.

This commit converts some InterruptedException to a TimeoutException.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1009 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Updated] (TINKERPOP-2106) When gremlin executes timeout, throw TimeoutException instead of TraversalInterruptedException/InterruptedIOException

2018-11-29 Thread Jermy Li (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jermy Li updated TINKERPOP-2106:

Issue Type: Improvement  (was: Bug)

> When gremlin executes timeout, throw TimeoutException instead of 
> TraversalInterruptedException/InterruptedIOException
> -
>
> Key: TINKERPOP-2106
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2106
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.5
>Reporter: Jermy Li
>Priority: Minor
>
> When gremlin executes timeout, it throws an error 
> "TraversalInterruptedException: null". According to our user feedback, the 
> message is not easy to understand. we think it is clearer if it prompts 
> timeout error directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (TINKERPOP-2106) When gremlin executes timeout, throw TimeoutException instead of TraversalInterruptedException/InterruptedIOException

2018-11-29 Thread Jermy Li (JIRA)
Jermy Li created TINKERPOP-2106:
---

 Summary: When gremlin executes timeout, throw TimeoutException 
instead of TraversalInterruptedException/InterruptedIOException
 Key: TINKERPOP-2106
 URL: https://issues.apache.org/jira/browse/TINKERPOP-2106
 Project: TinkerPop
  Issue Type: Bug
  Components: groovy
Affects Versions: 3.2.5
Reporter: Jermy Li


When gremlin executes timeout, it throws an error 
"TraversalInterruptedException: null". According to our user feedback, the 
message is not easy to understand. we think it is clearer if it prompts timeout 
error directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] jorgebay commented on issue #1008: TINKERPOP-2104 Allow ImportCustomizer to handle fields

2018-11-29 Thread GitHub
looks good :shipit: 
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1008 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org