[GitHub] [tinkerpop] spmallette closed pull request #1093: Add some additional tests for negative Text predicates

[GitHub]

[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1093 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Closed] (TINKERPOP-2191) Implement EdgeLabelVerificationStrategy

[Daniel Kuppitz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Kuppitz closed TINKERPOP-2191.
-
   Resolution: Fixed
Fix Version/s: 3.4.2
   3.3.7

> Implement EdgeLabelVerificationStrategy
> ---
>
> Key: TINKERPOP-2191
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2191
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.6, 3.4.1
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
> Fix For: 3.3.7, 3.4.2
>
>
> Using edge-steps, without specifying any labels, is documented as an 
> anti-pattern. We should have a strategy that verifies that all edge-steps 
> specify at least one label.
> The strategy should not be added by default, as not every provider may agree 
> that this an anti-pattern. It should also be possible to choose how the 
> strategy behaves, e.g. whether it throws an exception or only logs a warning 
> message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-2191) Implement EdgeLabelVerificationStrategy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812736#comment-16812736
 ] 

ASF GitHub Bot commented on TINKERPOP-2191:
---

dkuppitz commented on pull request #1087: TINKERPOP-2191 Implement 
EdgeLabelVerificationStrategy
URL: https://github.com/apache/tinkerpop/pull/1087
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Implement EdgeLabelVerificationStrategy
> ---
>
> Key: TINKERPOP-2191
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2191
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.6, 3.4.1
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Using edge-steps, without specifying any labels, is documented as an 
> anti-pattern. We should have a strategy that verifies that all edge-steps 
> specify at least one label.
> The strategy should not be added by default, as not every provider may agree 
> that this an anti-pattern. It should also be possible to choose how the 
> strategy behaves, e.g. whether it throws an exception or only logs a warning 
> message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] dkuppitz closed pull request #1087: TINKERPOP-2191 Implement EdgeLabelVerificationStrategy

[GitHub]

[ pull request closed by dkuppitz ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1087 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1086: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1

[GitHub]

Closing this for lack of supporting evidence as a security fix. TINKERPOP-2185 
will be fixed via major version bump.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1086 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale closed pull request #1086: TINKERPOP-2185 bump commons-configuration to 1.10.0.redhat-1

[GitHub]

[ pull request closed by robertdale ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1086 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2185) Use commons-configuration2 instead of commons-configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812656#comment-16812656
 ] 

ASF GitHub Bot commented on TINKERPOP-2185:
---

robertdale commented on pull request #1086: TINKERPOP-2185 bump 
commons-configuration to 1.10.0.redhat-1
URL: https://github.com/apache/tinkerpop/pull/1086
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use commons-configuration2 instead of commons-configuration
> ---
>
> Key: TINKERPOP-2185
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2185
> Project: TinkerPop
>  Issue Type: Bug
>  Components: structure
>Affects Versions: 3.3.6, 3.4.1
>Reporter: Alex Ott
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> Product called Whitesource reports vulnerabilities in the 
> commons-configuration 1.10 that is dependency of the gremlin-core module. As 
> result, some projects couldn't be allowed to production because of the 
> failing check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] robertdale commented on issue #1087: TINKERPOP-2191 Implement EdgeLabelVerificationStrategy

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1087 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1088: TINKERPOP-2181 Allow ctrl+c to break a command in Gremlin Console

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1088 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1090: TINKERPOP-2182 Removed gperfutils dependencies in Console

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1090 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1092: TINKERPOP-2193 Allow a Traversal to know what TraversalSource it spawned from

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1092 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1093: Add some additional tests for negative Text predicates

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1093 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1075: Docker gremlin-server test script

[GitHub]

looks like something changed between 3.4.0 and 3.4.1

@spmallette try now

[ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[TP4 Benchmarking] Pipes vs. Single-Threaded RxJava vs. Multi-Threaded RxJava

[Marko Rodriguez]

Hi,

I implemented Multi-threaded RxJava this morning — its called ParallelRxJava. 
Single-threaded is called SerialRxJava.

The RxJavaProcessor factory will generate either depending on the Map.of() 
configuration:


https://github.com/apache/tinkerpop/blob/tp4/java/machine/processor/rxjava/src/main/java/org/apache/tinkerpop/machine/processor/rxjava/RxJavaProcessor.java#L49-L53
 


 You can see the source code for each RxJava implementation here:


https://github.com/apache/tinkerpop/blob/tp4/java/machine/processor/rxjava/src/main/java/org/apache/tinkerpop/machine/processor/rxjava/SerialRxJava.java
 


https://github.com/apache/tinkerpop/blob/tp4/java/machine/processor/rxjava/src/main/java/org/apache/tinkerpop/machine/processor/rxjava/ParallelRxJava.java
 


Given Ted’s comments last week, I decided to create a micro-benchmark @Test to 
compare SerialRxJava, ParallelRxJava, and Pipes.


https://github.com/apache/tinkerpop/blob/tp4/java/machine/processor/rxjava/src/test/java/org/apache/tinkerpop/machine/processor/rxjava/RxJavaBenchmark.java
 


The results are below. My notes on the results are as follows:

* ParallelRxJava used 7 threads.
* Times averaged over 30 runs (minus the first 2 runs — JVM warmup).
* SerialRxJava and Pipes are very close on non-branching traversals 
with a small input set.
* ParallelRxJava never beats Pipes, but does beat SerialRxJava on large 
input sets.
* My implementation of repeat() in RxJava is not good. I need to think 
of a better way to implement recursion (and branching in general).
* ParallelRxJava will probably shine when the query has a lot of 
database operations (e.g. out(), inE(), addV(), etc.).
* There is a lot of intelligence to to add to ParallelRxJava — e.g., 
** If the nested traversal is simple (only a few steps), don’t 
thread. For example, there is no need to thread the is() of 
choose(is(gt(3)),….).
** One of the beautiful things about TP4 is that each 
Compilation (nest) can have a different processor.
*** Thus, parallel for long sequences and serial for 
short sequences…or, Pipes for short sequences! (Beam uses Pipes for short 
sequences).

———

g.inject(input).unfold().incr().incr().incr().incr().iterate()

Input size: 10
Average time [seri]: 0.4
Average time [para]: 2.4
Average time [pipe]: 0.5

Input size: 100
Average time [seri]: 0.9664
Average time [para]: 4.335
Average time [pipe]: 0.8

Input size: 1000
Average time [seri]: 2.533
Average time [para]: 4.165
Average time [pipe]: 1.7

Input size: 1
Average time [seri]: 12.1
Average time [para]: 10.63
Average time [pipe]: 8.1

Input size: 10
Average time [seri]: 103.96667
Average time [para]: 95.06
Average time [pipe]: 59.94

——
——

g.inject(input).unfold().repeat(incr()).times(4).iterate()

Input size: 10
Average time [seri]: 1.334
Average time [para]: 4.8
Average time [pipe]: 0.833

Input size: 100
Average time [seri]: 2.9
Average time [para]: 8.87
Average time [pipe]: 1.033

Input size: 1000
Average time [seri]: 15.7
Average time [para]: 22.08
Average time [pipe]: 3.4

Input size: 1
Average time [seri]: 50.4
Average time [para]: 35.8
Average time [pipe]: 8.57

Input size: 10
Average time [seri]: 387.06668
Average time [para]: 271.2
Average time [pipe]: 60.56

——
——

One of the reasons for implementing a multi-threaded single machine processor 
was to see how threading would work with the intermediate CFunction 
representation. At first, I thought I was going to have to make CFunctions 
thread safe (as they can nest and can contain Compilations), but then I 
realized we provide a clone() method. Thus, its up to the processor to clone 
CFunctions accordingly across threads (“rails” in RxJava). For ParallelRxJava, 
its as simple as using ThreadLocal. Here is the MapFlow ReactiveX Function:


https://github.com/apache/tinkerpop/blob/tp4/java/machine/processor/rxjava/src/main/java/org/apache/tinkerpop/machine/processor/rxjava/MapFlow.java
 


After using ThreadLocal in the map, flatmap, filter, 

[GitHub] [tinkerpop] dkuppitz commented on issue #1076: TINKERPOP-2112 Fold property() so that T values can work in any order

[GitHub]

~~VOTE +1~~

[ Full content available at: https://github.com/apache/tinkerpop/pull/1076 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1076: TINKERPOP-2112 Fold property() so that T values can work in any order

[GitHub]

this thing is still busted..neo4j is not happy which means other 
stuff probably isn't happy.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1076 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on issue #1076: TINKERPOP-2112 Fold property() so that T values can work in any order

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1076 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on issue #1088: TINKERPOP-2181 Allow ctrl+c to break a command in Gremlin Console

[GitHub]

Very nice!

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1088 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on issue #1093: Add some additional tests for negative Text predicates

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1093 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on issue #1092: TINKERPOP-2193 Allow a Traversal to know what TraversalSource it spawned from

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1092 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] robertdale commented on issue #1075: Docker gremlin-server test script

[GitHub]

looks like something changed between 3.4.0 and 3.4.1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2185) Use commons-configuration2 instead of commons-configuration

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812445#comment-16812445
 ] 

stephen mallette commented on TINKERPOP-2185:
-

I've tagged this for resolution in 3.5.0 when we can allow for a major breaking 
change in the API. 

> Use commons-configuration2 instead of commons-configuration
> ---
>
> Key: TINKERPOP-2185
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2185
> Project: TinkerPop
>  Issue Type: Bug
>  Components: structure
>Affects Versions: 3.3.6, 3.4.1
>Reporter: Alex Ott
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> Product called Whitesource reports vulnerabilities in the 
> commons-configuration 1.10 that is dependency of the gremlin-core module. As 
> result, some projects couldn't be allowed to production because of the 
> failing check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (TINKERPOP-2185) Use commons-configuration2 instead of commons-configuration

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-2185:

Fix Version/s: 3.5.0
  Summary: Use commons-configuration2 instead of commons-configuration  
(was: Use commons-configuration2 instead of commns-configuration)

> Use commons-configuration2 instead of commons-configuration
> ---
>
> Key: TINKERPOP-2185
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2185
> Project: TinkerPop
>  Issue Type: Bug
>  Components: structure
>Affects Versions: 3.3.6, 3.4.1
>Reporter: Alex Ott
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> Product called Whitesource reports vulnerabilities in the 
> commons-configuration 1.10 that is dependency of the gremlin-core module. As 
> result, some projects couldn't be allowed to production because of the 
> failing check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (TINKERPOP-2076) Build with Java 11

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-2076:

Fix Version/s: 3.5.0

> Build with Java 11
> --
>
> Key: TINKERPOP-2076
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2076
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.3.4
> Environment: $ java --version 
> java 11 2018-09-25 
> Java(TM) SE Runtime Environment 18.9 (build 11+28) 
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11+28, mixed mode)
>Reporter: Steve Strassmann
>Assignee: stephen mallette
>Priority: Major
> Fix For: 3.5.0
>
>
> I cannot build TinkerPop with a current (v11) Java version.
> On the gremlin-users Google group, Robert Dale suggests using Java 8, but 
> that is deprecated. Recommended: support current Java versions. Stephen 
> Mallette says "we need to start worrying about such things."
> Oracle [says Java 8 is 
> deprecated|https://www.oracle.com/technetwork/java/javase/overview/index.html]:
> {quote}{color:#d04437}[End of Public Updates for Oracle JDK 
> 8|https://www.oracle.com/technetwork/java/javase/eol-135779.html]{color}
>  Oracle will not post further updates of Java SE 8 to its public download 
> sites for commercial use after January 2019.
> {quote}
>  
>  See issue posted in Gremlin-users Google Group: 
>  
> [https://groups.google.com/forum/?utm_medium=email_source=footer#!topic/gremlin-users/Kgnq4BkrZXQ]
> {{unable to build Tinkerpop from master with mvn clean install. }}
>   
>  The error appears to be
>     An API incompatibility was encountered while executing 
> org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce: 
> java.lang.ExceptionInInitializerError: null
> {code:java}
> $ git clone https://github.com/apache/tinkerpop.git 
> $ git checkout master  
> $ mvn --version
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
> 2018-06-17T14:33:14-04:00)
> Maven home: /opt/maven
> Java version: 11, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"
> {code}
>  
>   
> {code:java}
> $ mvn clean install
> [INFO] Scanning for projects...
> [WARNING] The project org.apache.tinkerpop:tinkerpop:pom:3.4.0-SNAPSHOT uses 
> prerequisites which is only intended for maven-plugin projects but not for 
> non maven-plugin projects. For such purposes you should use the 
> maven-enforcer-plugin. See 
> https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
> [INFO] 
> 
> [INFO] Reactor Build Order:
> [INFO] 
> [INFO] Apache TinkerPop                                                   
> [pom]
> [INFO] Apache TinkerPop :: Gremlin Shaded                                 
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Core                                   
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Test                                   
> [jar]
> [INFO] Apache TinkerPop :: TinkerGraph Gremlin                            
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Groovy                                 
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Driver                                 
> [jar]
> [INFO] Apache TinkerPop :: Neo4j Gremlin                                  
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Server                                 
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Javascript                             
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Python                                 
> [jar]
> [INFO] Apache TinkerPop :: Gremlin.Net                                    
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Source                           
> [pom]
> [INFO] Apache TinkerPop :: Gremlin.Net - Tests                            
> [pom]
> [INFO] Apache TinkerPop :: Hadoop Gremlin                                 
> [jar]
> [INFO] Apache TinkerPop :: Spark Gremlin                                  
> [jar]
> [INFO] Apache TinkerPop :: SPARQL Gremlin                                 
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Console                                
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Archetype                              
> [pom]
> [INFO] Apache TinkerPop :: Archetype - TinkerGraph                        
> [jar]
> [INFO] Apache TinkerPop :: Archetype - Server                             
> [jar]
> [INFO] Apache TinkerPop :: Archetype - DSL                                
> [jar]
> [INFO] Apache TinkerPop :: Gremlin Tools                                  
> [pom]
> [INFO] Apache TinkerPop :: Gremlin Benchmark                             

[DISCUSS] 3.5.0 pre-planning

[Stephen Mallette]

I just set up a 3.5.0 version in JIRA. While there is no real start of work
on this version yet, there are a few items in JIRA that would benefit from
being tagged with that version as there are breaking changes that we really
can't implement well along 3.3.x and 3.4.x. I imagine that we will start
3.5.0 after our next release of 3.3.7/3.4.2 (couple of months or so to keep
up with the release cadence we'd roughly agreed on).

[GitHub] [tinkerpop] spmallette commented on issue #1087: TINKERPOP-2191 Implement EdgeLabelVerificationStrategy

[GitHub]

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1087 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1075: Docker gremlin-server test script

[GitHub]

Came back to this to try it out. When I go to start it with: 
`docker/gremlin-server.sh` i get:

```text
$ docker/gremlin-server.sh
Using Gremlin Server latest
Sending build context to Docker daemon  770.3MB
Step 1/9 : FROM tinkerpop/gremlin-server:latest
 ---> 826f5bf53d48
Step 2/9 : RUN mkdir -p /opt
 ---> Running in 0c0fd5c03b8a
 ---> 95a2a636f89a
Removing intermediate container 0c0fd5c03b8a
Step 3/9 : WORKDIR /opt
 ---> 53b5ad93b0e4
Removing intermediate container 0d1c3c5bd364
Step 4/9 : COPY gremlin-server/src/test /opt/test/
 ---> 429d70b20698
Removing intermediate container 8e558f9d322a
Step 5/9 : COPY docker/gremlin-server/docker-entrypoint.sh 
docker/gremlin-server/*.yaml /opt/
 ---> 43f453f4fbe9
Removing intermediate container 57df79bfb216
Step 6/9 : RUN chmod 755 /opt/docker-entrypoint.sh
 ---> Running in 31395a09f130
chmod: /opt/docker-entrypoint.sh: Operation not permitted
The command '/bin/sh -c chmod 755 /opt/docker-entrypoint.sh' returned a 
non-zero code: 1
Unable to find image 'tinkerpop:gremlin-server-test-1554728236' locally
docker: Error response from daemon: repository tinkerpop not found: does not 
exist or no pull access.
See 'docker run --help'.
```

[ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1093: Add some additional tests for negative Text predicates

[GitHub]

Travis seems happy so that means all GLVs should be passing with the new tests:

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1093 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] nastra opened pull request #1093: Add some additional tests for negative Text predicates

[GitHub]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1093 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org