[jira] [Commented] (TINKERPOP-2379) Consistent defaults and initialization APIs for drivers

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413448#comment-17413448
 ] 

ASF GitHub Bot commented on TINKERPOP-2379:
---

simonz-bq commented on pull request #1472:
URL: https://github.com/apache/tinkerpop/pull/1472#issuecomment-917306703


   I updated the PR with the following changes:
   
   - Use maxSimultaneousUsagePerConnection as the equivalent for the 
MaxInProcessPerConnection in .NET
   - Added JIRA number in title
   - Added description in upgrading for users section
   - Squashed the commits (I'm used to just doing this when merging in the PR)
   
   I think this is a reasonable state for the PR to be in until more discussion 
is done.
   
   @spmallette The timeouts matched when there was an equivalent option. In 
JavaScript, I did not see any current configuration for the clients in a way 
that was changing similar fields as the other languages. Maybe it is worth 
investigating settings in the underlying clients but I believe that to be 
outside of the scope of this ticket. Doing something like that requires an 
agreement that we *do* want to change the default configuration of a different 
library, and even beyond that it also requires a discussion of whether or not 
it should be exposed as configuration for the user.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Consistent defaults and initialization APIs for drivers
> ---
>
> Key: TINKERPOP-2379
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2379
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: driver
>Affects Versions: 3.4.6
>Reporter: Stephen Mallette
>Priority: Minor
>
> Some drivers allow the connection URL to be directly set which means that it 
> is wholly configurable. For example, Javascript allows:
> {code}
> const g = traversal().withRemote(new 
> DriverRemoteConnection('ws://localhost:8182/gremlin'));
> {code}
> Python allows something similar, but Java and .NET do not. I don't recall a 
> reason for that inconsistency and there are times when it seems that such 
> options would be helpful.
> In addition, some drivers will take a file for configuration and some will 
> not. Furthermore, defaults for various settings are different from one driver 
> to the next. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Anything I could do to help?

[Stephen Mallette]

Marko, I agree with your assertion that the project needs innovation and
talented contributors to continue to thrive. It needs that as much as it
needs stability and reliability for the users who depend on it today.
Obviously, things can't quite be as they were, but perhaps they can become
something new.

On Tue, Sep 7, 2021 at 6:34 PM Marko Rodriguez  wrote:

> Hi guys/gals,
>
> Looks like it’s just been Stephen nick-nacking away again as it’s been the
> last few years. Given the recent big turnover in management, I was hoping
> to eat my own words and see some performance out of Josh, but unfortunately
> as given the last 15+ years, 'talk and walk’ (which is even worse than
> ‘commit and split’). Given that Amazon Neptune is including openCypher in
> their distribution and with Neo4j just took in a whomping $300+ million in
> a Series , seems Apache TinkerPop will be falling to the
> wayside unless some real innovation happens.
>
> As such, perhaps I could offer a helping hand given my intimate knowledge
> of the codebase and my master of the theory and history of graph computing
> that I helped formulate over the last 15 years. With that said, I
> completely understand if y’all need to hold to the narrative that I’m a
> “Nazi racist” and thus, unworthy of contributing (after all, the "Nazi
> code" I wrote over a decade has proven how detrimental ‘racism’ has been to
> the integrity of the software). However, on the other hand, if y’all have
> moved past such trivial concepts of ‘good and evil’, perhaps we can get
> TinkerPop movin' again.
>
> Take care mein comrades,
> Marko.
>
> http://markorodriguez.com 
>
>
>

[jira] [Commented] (TINKERPOP-2556) Support remote transactions in .NET

[Florian Hockmann (Jira)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413157#comment-17413157
 ] 

Florian Hockmann commented on TINKERPOP-2556:
-

{quote}Few providers are on 3.5.0 yet so perhaps it's a non-issue for them at 
this stage.
{quote}
Oh right, I didn't think about that. So, we probably can still target 3.5.x for 
this.

I started a DISCUSS thread as you suggested: 
[https://lists.apache.org/thread.html/r04afd845357c191d018d0202e5e370633840ad3e83e7c7abefba58cd%40%3Cdev.tinkerpop.apache.org%3E]

 

> Support remote transactions in .NET
> ---
>
> Key: TINKERPOP-2556
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2556
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Affects Versions: 3.5.0
>Reporter: Stephen Mallette
>Priority: Major
>
> TINKERPOP-2537 introduced remote transactions with {{g.tx()}} for use with 
> Java. The same functionality should be made available in .NET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[DISCUSS] Breaking change in .NET to support tx()

[Florian Hockmann]

We have introduced tx() to support remote transactions with Bytecode based
requests in 3.5.0 and 3.5.1 added support for this to Gremlin-Javascript.

 

In order to also support tx() in .NET, we need to extend the
IRemoteConnection interface [1] that providers have to implement if they
want to provide their own driver. It needs additional functionality for
transactions which results in a breaking change. Given that most providers
are not yet on 3.5.x, I wonder whether anyone would actually be affected by
this breaking change.

Users who implement the interface in tests to get a fake remote connection
would also be affected by this, but the required change should be minimal,
and we can inform them about this breaking change in the upgrade docs.

 

Overall, it seems worthwhile to accept this breaking change in 3.5.x so we
can quickly add the feature for .NET users instead of having to wait for
3.6.0. But we might also be missing something here. So, if anyone has any
feedback on this, then please speak up.

 

If there are no objections until next Wednesday (2021-09-15), then I'll
assume lazy consensus in favor of accepting the breaking change in the 3.5.x
line.

 

The ticket for this is: https://issues.apache.org/jira/browse/TINKERPOP-2556

 

[1]:
https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.N
et/Process/Remote/IRemoteConnection.cs

[jira] [Commented] (TINKERPOP-2556) Support remote transactions in .NET

[Stephen Mallette (Jira)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413119#comment-17413119
 ] 

Stephen Mallette commented on TINKERPOP-2556:
-

I would suggest you do a DISCUSS thread on dev to call attention to the change 
and if there is no objection proceed for 3.5.x. Few providers are on 3.5.0 yet 
so perhaps it's a non-issue for them at this stage. And I think for a test 
class compile failure there isn't a whole lot of overhead there while I sense 
more users would like to have the {{tx()}} functionality available for .NET.

> Support remote transactions in .NET
> ---
>
> Key: TINKERPOP-2556
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2556
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Affects Versions: 3.5.0
>Reporter: Stephen Mallette
>Priority: Major
>
> TINKERPOP-2537 introduced remote transactions with {{g.tx()}} for use with 
> Java. The same functionality should be made available in .NET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (TINKERPOP-2605) Further enforce and refine null semantics

[Stephen Mallette (Jira)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Mallette closed TINKERPOP-2605.
---
Fix Version/s: 3.5.2
   3.6.0
   Resolution: Done

> Further enforce and refine null semantics
> -
>
> Key: TINKERPOP-2605
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2605
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process, test-suite
>Affects Versions: 3.5.1
>Reporter: Stephen Mallette
>Assignee: Stephen Mallette
>Priority: Major
> Fix For: 3.6.0, 3.5.2
>
>
> A number of areas where {{null}} is used in traversals result in some odd 
> looking errors. Identify these situations and improve them to be more user 
> friendly. Some specific items to take care of:
> {code}
> hasLabel(null) // currently results in exception, should just filter
> P.within(null) // TINKERPOP-2598
> sum() // NPE if null is present, should ignore nulls in calculation and 
> return null if all values are null
> mean() // NPE if null is present, should ignore nulls in calculation and 
> return null if all values are null
> max() // NPE if null is present, should ignore nulls in calculation and 
> return null if all values are null
> min() // NPE if null is present, should ignore nulls in calculation and 
> return null if all values are null
> inject(null) // NPE
> hasValue(null) // NPE if accidentally applied to hasValue(P), should just 
> filter
> hasKey(null) // NPE, should just filter
> withSideEffect('k',null) // NPE, should just allow the assignment
> g.inject(1,null).as('a') // NPE and won't allow labelling 
> path() // NPE when encountering nulls
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (TINKERPOP-2598) within(null) NPE

[Stephen Mallette (Jira)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Mallette closed TINKERPOP-2598.
---
Fix Version/s: 3.5.2
   3.6.0
 Assignee: Stephen Mallette
   Resolution: Fixed

> within(null) NPE
> 
>
> Key: TINKERPOP-2598
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2598
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.4.12
>Reporter: Willem Broekema
>Assignee: Stephen Mallette
>Priority: Minor
> Fix For: 3.6.0, 3.5.2
>
>
> {code}
> gremlin> within(null).test(null)
> java.lang.NullPointerException
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> y
> java.lang.NullPointerException
>   at 
> org.apache.tinkerpop.gremlin.process.traversal.Contains$1.test(Contains.java:57)
>   at 
> org.apache.tinkerpop.gremlin.process.traversal.Contains$1.test(Contains.java:52)
>   at org.apache.tinkerpop.gremlin.process.traversal.P.test(P.java:72)
>   at java_util_function_Predicate$test.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TINKERPOP-2605) Further enforce and refine null semantics

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413091#comment-17413091
 ] 

ASF GitHub Bot commented on TINKERPOP-2605:
---

spmallette merged pull request #1471:
URL: https://github.com/apache/tinkerpop/pull/1471


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Further enforce and refine null semantics
> -
>
> Key: TINKERPOP-2605
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2605
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process, test-suite
>Affects Versions: 3.5.1
>Reporter: Stephen Mallette
>Assignee: Stephen Mallette
>Priority: Major
>
> A number of areas where {{null}} is used in traversals result in some odd 
> looking errors. Identify these situations and improve them to be more user 
> friendly. Some specific items to take care of:
> {code}
> hasLabel(null) // currently results in exception, should just filter
> P.within(null) // TINKERPOP-2598
> sum() // NPE if null is present, should ignore nulls in calculation and 
> return null if all values are null
> mean() // NPE if null is present, should ignore nulls in calculation and 
> return null if all values are null
> max() // NPE if null is present, should ignore nulls in calculation and 
> return null if all values are null
> min() // NPE if null is present, should ignore nulls in calculation and 
> return null if all values are null
> inject(null) // NPE
> hasValue(null) // NPE if accidentally applied to hasValue(P), should just 
> filter
> hasKey(null) // NPE, should just filter
> withSideEffect('k',null) // NPE, should just allow the assignment
> g.inject(1,null).as('a') // NPE and won't allow labelling 
> path() // NPE when encountering nulls
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (TINKERPOP-2556) Support remote transactions in .NET

[Florian Hockmann (Jira)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412977#comment-17412977
 ] 

Florian Hockmann commented on TINKERPOP-2556:
-

Yes, exactly. This would of course affect graph providers who implemented their 
own driver, but I think only one provider did that which is DataStax. Users 
could however also be affected if they for example implemented the interface in 
their tests to get a fake remote connection.

Do you think that we should still do it in 3.5 then?

> Support remote transactions in .NET
> ---
>
> Key: TINKERPOP-2556
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2556
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: dotnet
>Affects Versions: 3.5.0
>Reporter: Stephen Mallette
>Priority: Major
>
> TINKERPOP-2537 introduced remote transactions with {{g.tx()}} for use with 
> Java. The same functionality should be made available in .NET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)