[jira] [Updated] (TINKERPOP-2628) Gremlin test suite run on Windows
[ https://issues.apache.org/jira/browse/TINKERPOP-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fredrick Eisele updated TINKERPOP-2628: --- Attachment: correct_comparison_of_file_output_with__r_n.patch > Gremlin test suite run on Windows > - > > Key: TINKERPOP-2628 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2628 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Affects Versions: 3.5.2 > Environment: OS: Windows >Reporter: Davide Riva >Priority: Minor > Attachments: correct_comparison_of_file_output_with__r_n.patch, > correct_string_interpolation_for_file_path_issues.patch, > correct_string_interpolation_for_file_path_issues1.patch > > > Currently, there are some tests (IoReader or IoWrite) which always fail on > Windows. This is probably due to how temporary folders are created > How to reproduce: run IoReader or IoWriter on Windows on a particular > implementation ({{mvn clean test}} should be sufficient) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TINKERPOP-2628) Gremlin test suite run on Windows
[ https://issues.apache.org/jira/browse/TINKERPOP-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470868#comment-17470868 ] Fredrick Eisele commented on TINKERPOP-2628: When file outputs are produced it is likely that, on Windows 10, lines will be delimited by \r\n rather than \n. There is a test DefaultTraversalMetricsTest.java where this causes it to incorrectly fail. [^correct_comparison_of_file_output_with__r_n.patch] > Gremlin test suite run on Windows > - > > Key: TINKERPOP-2628 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2628 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Affects Versions: 3.5.2 > Environment: OS: Windows >Reporter: Davide Riva >Priority: Minor > Attachments: correct_comparison_of_file_output_with__r_n.patch, > correct_string_interpolation_for_file_path_issues.patch, > correct_string_interpolation_for_file_path_issues1.patch > > > Currently, there are some tests (IoReader or IoWrite) which always fail on > Windows. This is probably due to how temporary folders are created > How to reproduce: run IoReader or IoWriter on Windows on a particular > implementation ({{mvn clean test}} should be sufficient) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (TINKERPOP-2628) Gremlin test suite run on Windows
[ https://issues.apache.org/jira/browse/TINKERPOP-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fredrick Eisele updated TINKERPOP-2628: --- Attachment: correct_string_interpolation_for_file_path_issues1.patch > Gremlin test suite run on Windows > - > > Key: TINKERPOP-2628 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2628 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Affects Versions: 3.5.2 > Environment: OS: Windows >Reporter: Davide Riva >Priority: Minor > Attachments: correct_string_interpolation_for_file_path_issues.patch, > correct_string_interpolation_for_file_path_issues1.patch > > > Currently, there are some tests (IoReader or IoWrite) which always fail on > Windows. This is probably due to how temporary folders are created > How to reproduce: run IoReader or IoWriter on Windows on a particular > implementation ({{mvn clean test}} should be sufficient) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TINKERPOP-2628) Gremlin test suite run on Windows
[ https://issues.apache.org/jira/browse/TINKERPOP-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470823#comment-17470823 ] Fredrick Eisele commented on TINKERPOP-2628: During testing the testing of `g.io(...).iterate()` the file path needs to be adjusted. When this adjustment happens the file path on Windows 10 uses '\' which needs to be escaped properly. The attached fix makes that repair. [^correct_string_interpolation_for_file_path_issues1.patch] > Gremlin test suite run on Windows > - > > Key: TINKERPOP-2628 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2628 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Affects Versions: 3.5.2 > Environment: OS: Windows >Reporter: Davide Riva >Priority: Minor > Attachments: correct_string_interpolation_for_file_path_issues.patch, > correct_string_interpolation_for_file_path_issues1.patch > > > Currently, there are some tests (IoReader or IoWrite) which always fail on > Windows. This is probably due to how temporary folders are created > How to reproduce: run IoReader or IoWriter on Windows on a particular > implementation ({{mvn clean test}} should be sufficient) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (TINKERPOP-2684) Path Defects in Windows 10 Builds : String Interpolation
[ https://issues.apache.org/jira/browse/TINKERPOP-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fredrick Eisele closed TINKERPOP-2684. -- Resolution: Fixed Incorporated into existing issue. > Path Defects in Windows 10 Builds : String Interpolation > > > Key: TINKERPOP-2684 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2684 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Attachments: correct_string_interpolation_for_file_path_issues-1.patch > > > The build for the Tinkerpop repository does not work on Windows 10. > This issue documents the changes needed to get the bulk of modules to build > on Windows 10. > The corrections in the attached patch address the problem due to Maven > string-interpolation presenting Groovy with unescaped literal strings. e.g. > "C:\User\foo\tp/src/main/..." where the '\' should be escaped as > "C:\\User\\foo\\tp/src/main/...". > This can be remedied by passing the target directory via > configuration-properties, which appear as Groovy variables rather than Groovy > string-literals. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TINKERPOP-2628) Gremlin test suite run on Windows
[ https://issues.apache.org/jira/browse/TINKERPOP-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470816#comment-17470816 ] Fredrick Eisele commented on TINKERPOP-2628: The corrections in the attached patch address the problem due to Maven string-interpolation presenting Groovy with unescaped literal strings. e.g. "C:\User\foo\tp/src/main/..." where the '\' should be escaped as "C:\\User\\foo tp/src/main/...". This can be remedied by passing the target directory via configuration-properties, which appear as Groovy variables rather than Groovy string-literals. [^correct_string_interpolation_for_file_path_issues.patch] > Gremlin test suite run on Windows > - > > Key: TINKERPOP-2628 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2628 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Affects Versions: 3.5.2 > Environment: OS: Windows >Reporter: Davide Riva >Priority: Minor > Attachments: correct_string_interpolation_for_file_path_issues.patch > > > Currently, there are some tests (IoReader or IoWrite) which always fail on > Windows. This is probably due to how temporary folders are created > How to reproduce: run IoReader or IoWriter on Windows on a particular > implementation ({{mvn clean test}} should be sufficient) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (TINKERPOP-2628) Gremlin test suite run on Windows
[ https://issues.apache.org/jira/browse/TINKERPOP-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fredrick Eisele updated TINKERPOP-2628: --- Attachment: correct_string_interpolation_for_file_path_issues.patch > Gremlin test suite run on Windows > - > > Key: TINKERPOP-2628 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2628 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Affects Versions: 3.5.2 > Environment: OS: Windows >Reporter: Davide Riva >Priority: Minor > Attachments: correct_string_interpolation_for_file_path_issues.patch > > > Currently, there are some tests (IoReader or IoWrite) which always fail on > Windows. This is probably due to how temporary folders are created > How to reproduce: run IoReader or IoWriter on Windows on a particular > implementation ({{mvn clean test}} should be sufficient) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (TINKERPOP-2684) Path Defects in Windows 10 Builds : String Interpolation
Fredrick Eisele created TINKERPOP-2684: -- Summary: Path Defects in Windows 10 Builds : String Interpolation Key: TINKERPOP-2684 URL: https://issues.apache.org/jira/browse/TINKERPOP-2684 Project: TinkerPop Issue Type: Bug Components: build-release Affects Versions: 3.5.1 Reporter: Fredrick Eisele Attachments: correct_string_interpolation_for_file_path_issues-1.patch The build for the Tinkerpop repository does not work on Windows 10. This issue documents the changes needed to get the bulk of modules to build on Windows 10. The corrections in the attached patch address the problem due to Maven string-interpolation presenting Groovy with unescaped literal strings. e.g. "C:\User\foo\tp/src/main/..." where the '\' should be escaped as "C:\\User\\foo\\tp/src/main/...". This can be remedied by passing the target directory via configuration-properties, which appear as Groovy variables rather than Groovy string-literals. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470804#comment-17470804 ] Stephen Mallette commented on TINKERPOP-2683: - > The grammar seems to assume the Groovy grammar as a starting point. that's just the nature of how the grammar came into existence, since groovy was the original script language prior to the grammar. we're trying to reverse that now. If you think i can be solved in the test framework that's fine i think, though i still think it's an interesting point for the grammar itself. > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470692#comment-17470692 ] Fredrick Eisele edited comment on TINKERPOP-2683 at 1/7/22, 6:16 PM: - The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have now tested the following: {code:java} import static org.apache.commons.text.StringEscapeUtils.escapeJava; ... private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (! matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relPath, escapeJava(absPath)); return gremlin; } {code} was (Author: phreed): The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have now tested the following: {code:java} private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (! matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relPath, escapeJava(absPath)); return gremlin; } {code} > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470692#comment-17470692 ] Fredrick Eisele edited comment on TINKERPOP-2683 at 1/7/22, 6:16 PM: - The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have now tested the following: {code:java} private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (! matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relPath, escapeJava(absPath)); return gremlin; } {code} was (Author: phreed): The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have not tested the following but I think it shows the approach. {code:java} private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (! matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relPath, escapeJava(absPath)); return gremlin; } {code} > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: [DISCUSS] Removal of Marko A. Rodriguez from Apache TinkerPop
Thanks for the update. I opened up my email this morning to ping: “Any updates? I can’t believe open source software has come to this. I look back and think, once you took your recent corporate position and then were put on the Apache Board, it turned a once great software development team, never mired in politics, into secret backdoor discussions of what I can only presume to be of the nature “What does he know? More than what he mentioned? **k that guy! We’re Apache — we're not going to be held hostage by some Nazi racist!” Stephen, you would be surprised by who has connected with me after hearing of Apache’s move to remove me from my project. The people you have allied yourself with (for whatever reason) are not of the caliber of person that I know you to be. I’ve known you for 15 years now, working closely in harmony over numerous companies, and while I’m aware of your life stresses and what that can do to a man, I’m certain you are not of their breed. Don’t sully your soul by remaining entangled with an organization that was once the life blood of open source software and now, given all I’ve seen with my situation with them and have come to learn from other, also its death. Good luck to you, old friend — I will continue to remain in my holding pattern.” Take care, Marko. > On Jan 7, 2022, at 4:28 AM, Stephen Mallette wrote: > > Hi Marko, I know this thread is a week old at this point. I just wanted to > let you know it's not being ignored. Thank you for your patience. > > On Wed, Jan 5, 2022 at 3:24 PM Marko Rodriguez wrote: > >> Understood. >> >> Marko. >> >>> On Jan 5, 2022, at 12:31 PM, Stephen Mallette >> wrote: >>> >>> Please allow some more time for a reply as I've been away for the New >> Years >>> Eve weekend. >>> >>> On Wed, Jan 5, 2022 at 12:50 PM Marko Rodriguez >>> wrote: >>> Hey Stephen, Any movement on what I presented below? Meaning, do you 1.) agree with inconsistent application of the “violated social norms” clause and if so 2.) do you plan to argue my point ‘in good faith’ (meaning, the >> following sentiment resonates with you: "every person has skeletons in their >> closet so why I are we attacking Marko after contributing his PhD work to >> Apache and then spending over a decade developing it only to kick him off the project for telling jokes on Twitter?”). If you don’t agree, then please tell me so I can move forward on my >> side. Thank you very much, Marko. > On Dec 31, 2021, at 2:14 PM, Marko Rodriguez wrote: > > Hello everyone, > > As you all may know, I was recently removed from TinkerPop for the >> crime of “being a Nazi troll.” When arguing I’m not a Nazi, I was told I “violated social norms.” Assuming I violated social norms, I inquired >> as to where such social norms are specified as I never signed anything when providing TinkerPop to Apache that mentioned ’social norms'. Moreover, >> if the crime of violating social norms is in fact how Apache wishes to >> judge people for the sake of removal by committee, then I believe this statute should be applied fairly and equally. Thus, please review the following “social norm violations” made by people in Apache and on Apache >> TinkerPop. Given that social norms are not specified anywhere, I offer simply what >> I believe fall within this fuzzy category. > > 1. Roy Fielding stating I’m a Nazi troll. When asked for evidence of me being part of the Nazi party, none was presented. As far as I know, the Nazi party dissolved post WW2 and seems to exist as a word use by modern folk to remove people they dislike from their positions. The question: >> is libel a violation of social norms? > > 2. Sam Ruby in the past had threatened me with physical violence. If threat of violence is not breaking social norms then that seems like a break from social norms in and of itself. Thus, was Sam Ruby removed >> from his position in Apache? The question: is threat of violence a violation >> of social norms? > > 3. danielfb@ is the mysterious character that had access to our private@tinkerpop mailing list and said that a picture I made in photoshop of one of my chickens in WW2 regalia was “offensive” to him (I assume ‘him' given the name ‘daniel’). My response was initially to joke (as I do), but then continued with (I paraphrase) “let’s talk more as I think you will find me to be a jokester.” That man was never heard from again. The question: is allowing seemingly random people on our private mailing list in order to entrap me a violation of social norms? > > 4. Roy Fielding was unhappy with the fact that no one on the TinkerPop PMC cared about danielfb@’s allegation of me being a racist. In fact, Jorge said (I
[jira] [Comment Edited] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470692#comment-17470692 ] Fredrick Eisele edited comment on TINKERPOP-2683 at 1/7/22, 3:59 PM: - The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have not tested the following but I think it shows the approach. {code:java} private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (! matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relPath, escapeJava(absPath)); return gremlin; } {code} was (Author: phreed): The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have not tested the following but I think it shows the approach. {code:java} private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relPath, escapeJava(absPath)); return gremlin; } {code} > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470692#comment-17470692 ] Fredrick Eisele edited comment on TINKERPOP-2683 at 1/7/22, 3:58 PM: - The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have not tested the following but I think it shows the approach. {code:java} private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relPath, escapeJava(absPath)); return gremlin; } {code} was (Author: phreed): The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have not tested the following but I think it shows the approach. {code:java} private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relpath, escapeJava(absPath)); return gremlin; } {code} > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470692#comment-17470692 ] Fredrick Eisele edited comment on TINKERPOP-2683 at 1/7/22, 3:32 PM: - The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] I have not tested the following but I think it shows the approach. {code:java} private String tryUpdateDataFilePath(final String docString) { final Matcher matcher = ioPattern.matcher(docString); if (matcher.matches()) { return docString; } final String relPath = matcher.group(1); final String absPath = world.changePathToDataFile(relPath); final String gremlin = docString.replace(relpath, escapeJava(absPath)); return gremlin; } {code} was (Author: phreed): The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] {code:java} // code placeholder {code} > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470692#comment-17470692 ] Fredrick Eisele edited comment on TINKERPOP-2683 at 1/7/22, 3:27 PM: - The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. [escapeJava|http://docs.groovy-lang.org/latest/html/gapi/groovy/json/StringEscapeUtils.html#escapeJava(java.lang.String)] {code:java} // code placeholder {code} was (Author: phreed): The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470692#comment-17470692 ] Fredrick Eisele commented on TINKERPOP-2683: The grammar seems to assume the Groovy grammar as a starting point. Groovy allows the escaped backslash in strings. There is a third (and probably correct) alternative. The path could be escaped before being inserted into the script. > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (TINKERPOP-2683) Defective Path in Testing g.io()
[ https://issues.apache.org/jira/browse/TINKERPOP-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470557#comment-17470557 ] Stephen Mallette commented on TINKERPOP-2683: - This is an interesting question. My initial thought is that the grammar is meant to be the canonical Gremlin representation, so the question is: what is the file path specification in Gremlin? It would then be up to the underlying implementation to interpret that and properly translate the file path to one understood by the OS it is executing on. So, I think that the fix here would be to update the parser, specifically {{TraversalSourceSpawnMethodVisitor}} which would take the grammar representation of a path and convert it to be OS specific. Perhaps we should even have the notion of a {{File}} in the grammar itself to make this all more explicit? > Defective Path in Testing g.io() > > > Key: TINKERPOP-2683 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2683 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph >Affects Versions: 3.5.1 >Reporter: Fredrick Eisele >Priority: Blocker > Labels: easyfix, test-stability > > I found a small bug in the tinkergraph testing on windows 10. > It comes up because the grammar does not allow a '\' ... > {code:none} > fragment > DoubleQuotedStringCharacters > : DoubleQuotedStringCharacter+ > ; > fragment > DoubleQuotedStringCharacter > : ~('"' | '\\') > | JoinLineEscape > | EscapeSequence > ; > {code} > ``` > ...and the function which locates the g.io() file adds in a '\'. > [TinkerGraphWorld.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphWorld.java] > {code:java} > @Override > public String changePathToDataFile(final String pathToFileFromGremlin) { > return ".." + File.separator + pathToFileFromGremlin; > } > {code} > The File.separator on linux is a valid character '/' but the problematic '\' > character on Windows 10. > Which gets called by... > [StepDefinition.java|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java] > {code:java} > private String tryUpdateDataFilePath(final String docString) { > final Matcher matcher = ioPattern.matcher(docString); > final String gremlin = matcher.matches() ? > docString.replace(matcher.group(1), > world.changePathToDataFile(matcher.group(1))) : docString; > return gremlin; > } > {code} > In particular this gets triggered by the > [Read.feature|https://github.com/apache/tinkerpop/blob/53503bfa28ba1de061204fb96835dee856576bbf/gremlin-test/features/sideEffect/Read.feature] > . -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (TINKERPOP-2673) Allow case insensitive searches when using Text Predicates
[ https://issues.apache.org/jira/browse/TINKERPOP-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette updated TINKERPOP-2673: Component/s: process Affects Version/s: 3.5.1 > Allow case insensitive searches when using Text Predicates > -- > > Key: TINKERPOP-2673 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2673 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.5.1 >Reporter: Dave Bechberger >Priority: Major > > A common request from users is to allow for text insensitive searches when > using the text predicates like eq(), startingWith(), containing(), etc. -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: [DISCUSS] Removal of Marko A. Rodriguez from Apache TinkerPop
Hi Marko, I know this thread is a week old at this point. I just wanted to let you know it's not being ignored. Thank you for your patience. On Wed, Jan 5, 2022 at 3:24 PM Marko Rodriguez wrote: > Understood. > > Marko. > > > On Jan 5, 2022, at 12:31 PM, Stephen Mallette > wrote: > > > > Please allow some more time for a reply as I've been away for the New > Years > > Eve weekend. > > > > On Wed, Jan 5, 2022 at 12:50 PM Marko Rodriguez > > wrote: > > > >> Hey Stephen, > >> > >> Any movement on what I presented below? Meaning, do you 1.) agree with > >> inconsistent application of the “violated social norms” clause and if so > >> 2.) do you plan to argue my point ‘in good faith’ (meaning, the > following > >> sentiment resonates with you: "every person has skeletons in their > closet > >> so why I are we attacking Marko after contributing his PhD work to > Apache > >> and then spending over a decade developing it only to kick him off the > >> project for telling jokes on Twitter?”). > >> > >> If you don’t agree, then please tell me so I can move forward on my > side. > >> > >> Thank you very much, > >> Marko. > >> > >> > >> > >>> On Dec 31, 2021, at 2:14 PM, Marko Rodriguez > >> wrote: > >>> > >>> Hello everyone, > >>> > >>> As you all may know, I was recently removed from TinkerPop for the > crime > >> of “being a Nazi troll.” When arguing I’m not a Nazi, I was told I > >> “violated social norms.” Assuming I violated social norms, I inquired > as to > >> where such social norms are specified as I never signed anything when > >> providing TinkerPop to Apache that mentioned ’social norms'. Moreover, > if > >> the crime of violating social norms is in fact how Apache wishes to > judge > >> people for the sake of removal by committee, then I believe this statute > >> should be applied fairly and equally. Thus, please review the following > >> “social norm violations” made by people in Apache and on Apache > TinkerPop. > >> Given that social norms are not specified anywhere, I offer simply what > I > >> believe fall within this fuzzy category. > >>> > >>> 1. Roy Fielding stating I’m a Nazi troll. When asked for evidence of me > >> being part of the Nazi party, none was presented. As far as I know, the > >> Nazi party dissolved post WW2 and seems to exist as a word use by modern > >> folk to remove people they dislike from their positions. The question: > is > >> libel a violation of social norms? > >>> > >>> 2. Sam Ruby in the past had threatened me with physical violence. If > >> threat of violence is not breaking social norms then that seems like a > >> break from social norms in and of itself. Thus, was Sam Ruby removed > from > >> his position in Apache? The question: is threat of violence a violation > of > >> social norms? > >>> > >>> 3. danielfb@ is the mysterious character that had access to our > >> private@tinkerpop mailing list and said that a picture I made in > >> photoshop of one of my chickens in WW2 regalia was “offensive” to him (I > >> assume ‘him' given the name ‘daniel’). My response was initially to joke > >> (as I do), but then continued with (I paraphrase) “let’s talk more as I > >> think you will find me to be a jokester.” That man was never heard from > >> again. The question: is allowing seemingly random people on our private > >> mailing list in order to entrap me a violation of social norms? > >>> > >>> 4. Roy Fielding was unhappy with the fact that no one on the TinkerPop > >> PMC cared about danielfb@’s allegation of me being a racist. In fact, > >> Jorge said (I paraphrase) "that’s not racism, he’s just being silly.” He > >> went on to note organizations that Apache could get behind that help > fight > >> racism — unfortunately, that fell on deaf ears. Instead, Roy Fielding > went > >> ahead and ignored the PMC's brush off saying (I paraphrase) “I know you > are > >> friends and its hard to punish people you’ve worked with.” This seemed > odd > >> to me because the email prior I had said “no one ever stands up for me > >> because most people never understand the point I’m trying to make with > my > >> craft.” (I consider much of the work I do ‘art’). Thus, Roy Fielding > pushed > >> an agenda placing thoughts/emotions in colleagues that did not exist. > The > >> question: is baiting the group so they do his 'dirty work' not a > violation > >> of social norms? > >>> > >>> 5. Stephen Mallette and I have worked together for over a decade. It > >> came as a shock to me that he said nothing in favor of my person when I > was > >> deemed a “racist” and a “nazi.” The question: is not standing up for a > >> friend who has been there for you for many years not a violation of > social > >> norms? > >>> > >>> 6. Stephen Mallette knows what I was “charged with” was just some > social > >> ploy using the rhetoric of the times to restructure power by removing > those > >> individuals that don’t tow some party line which I was never made aware > of. > >> While I assert these are