[jira] [Closed] (TINKERPOP-2872) Inconsistency in comparing Elements in JavaScript tests
[ https://issues.apache.org/jira/browse/TINKERPOP-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cole Greer closed TINKERPOP-2872. - Fix Version/s: 3.7.2 Resolution: Fixed > Inconsistency in comparing Elements in JavaScript tests > --- > > Key: TINKERPOP-2872 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2872 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.7.0 >Reporter: Valentyn Kahamlyk >Assignee: Cole Greer >Priority: Major > Fix For: 3.7.2 > > > In most GLV's we consider Elements the same when they have the same ID. > In JavaScript tests used [member wise > comparison|https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L176] > Make it work like the others GLV's, just compare ID. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (TINKERPOP-3025) l_trim() and r_trim() missing in python
[ https://issues.apache.org/jira/browse/TINKERPOP-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cole Greer closed TINKERPOP-3025. - Fix Version/s: 3.7.2 Assignee: Cole Greer Resolution: Fixed > l_trim() and r_trim() missing in python > --- > > Key: TINKERPOP-3025 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3025 > Project: TinkerPop > Issue Type: Bug > Components: python >Affects Versions: 3.7.1 >Reporter: Stephen Mallette >Assignee: Cole Greer >Priority: Critical > Fix For: 3.7.2 > > > The steps are present but only in the camel case form and not the proper > pythonic snake case form. Check for other missing snake case options. > Deprecate the old forms. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (TINKERPOP-2872) Inconsistency in comparing Elements in JavaScript tests
[ https://issues.apache.org/jira/browse/TINKERPOP-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cole Greer reassigned TINKERPOP-2872: - Assignee: Cole Greer > Inconsistency in comparing Elements in JavaScript tests > --- > > Key: TINKERPOP-2872 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2872 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.7.0 >Reporter: Valentyn Kahamlyk >Assignee: Cole Greer >Priority: Major > > In most GLV's we consider Elements the same when they have the same ID. > In JavaScript tests used [member wise > comparison|https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L176] > Make it work like the others GLV's, just compare ID. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3025) l_trim() and r_trim() missing in python
[ https://issues.apache.org/jira/browse/TINKERPOP-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805838#comment-17805838 ] ASF GitHub Bot commented on TINKERPOP-3025: --- Cole-Greer merged PR #2432: URL: https://github.com/apache/tinkerpop/pull/2432 > l_trim() and r_trim() missing in python > --- > > Key: TINKERPOP-3025 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3025 > Project: TinkerPop > Issue Type: Bug > Components: python >Affects Versions: 3.7.1 >Reporter: Stephen Mallette >Priority: Critical > > The steps are present but only in the camel case form and not the proper > pythonic snake case form. Check for other missing snake case options. > Deprecate the old forms. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2872) Inconsistency in comparing Elements in JavaScript tests
[ https://issues.apache.org/jira/browse/TINKERPOP-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805839#comment-17805839 ] ASF GitHub Bot commented on TINKERPOP-2872: --- Cole-Greer merged PR #2422: URL: https://github.com/apache/tinkerpop/pull/2422 > Inconsistency in comparing Elements in JavaScript tests > --- > > Key: TINKERPOP-2872 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2872 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.7.0 >Reporter: Valentyn Kahamlyk >Priority: Major > > In most GLV's we consider Elements the same when they have the same ID. > In JavaScript tests used [member wise > comparison|https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L176] > Make it work like the others GLV's, just compare ID. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2872) Inconsistency in comparing Elements in JavaScript tests
[ https://issues.apache.org/jira/browse/TINKERPOP-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805837#comment-17805837 ] ASF GitHub Bot commented on TINKERPOP-2872: --- Cole-Greer commented on PR #2422: URL: https://github.com/apache/tinkerpop/pull/2422#issuecomment-1888146639 Thanks Ryan! VOTE +1 > Inconsistency in comparing Elements in JavaScript tests > --- > > Key: TINKERPOP-2872 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2872 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.7.0 >Reporter: Valentyn Kahamlyk >Priority: Major > > In most GLV's we consider Elements the same when they have the same ID. > In JavaScript tests used [member wise > comparison|https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L176] > Make it work like the others GLV's, just compare ID. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3025) l_trim() and r_trim() missing in python
[ https://issues.apache.org/jira/browse/TINKERPOP-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805830#comment-17805830 ] ASF GitHub Bot commented on TINKERPOP-3025: --- Cole-Greer commented on PR #2432: URL: https://github.com/apache/tinkerpop/pull/2432#issuecomment-1888121174 Thanks Ryan! LGTM! VOTE +1 > l_trim() and r_trim() missing in python > --- > > Key: TINKERPOP-3025 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3025 > Project: TinkerPop > Issue Type: Bug > Components: python >Affects Versions: 3.7.1 >Reporter: Stephen Mallette >Priority: Critical > > The steps are present but only in the camel case form and not the proper > pythonic snake case form. Check for other missing snake case options. > Deprecate the old forms. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3029) Gremlin.Net: Traversal enumeration fails on .NET 8
[
https://issues.apache.org/jira/browse/TINKERPOP-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805827#comment-17805827
]
ASF GitHub Bot commented on TINKERPOP-3029:
---
xiazcy commented on PR #2424:
URL: https://github.com/apache/tinkerpop/pull/2424#issuecomment-1888079847
VOTE +1
> Gremlin.Net: Traversal enumeration fails on .NET 8
> --
>
> Key: TINKERPOP-3029
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3029
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.5.8, 3.6.6, 3.7.1
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Critical
>
> This has been reported by Eric Sites on the dev mailing list:
> [https://lists.apache.org/thread/snztwgk3s18h83mx8ql455hmx6ncl2r4]
>
> I am having a lot of issues using the Gremlin.Net driver version 3.7.1 with
> .Net 8.
> It is almost entirely unusable.
> Any request that uses an Iterator throws an exception ({{{}MoveNext{}}},
> {{{}Next{}}}, {{{}Iterate{}}}).
> {{{}System.InvalidOperationException: Enumeration has not started. Call
> MoveNext{}}}.
> Tracked it down to a change in .Net 8 {{IEnumerable.Current}} behavior.
> Here is an issue about this filed in dotnet runtime:
> [https://github.com/dotnet/runtime/issues/85243]
> New bad code:
> {code:java}
> var enumerator = saves.GetEnumerator();
> while (enumerator.Current == null) // <- Throws exception now
> {
>if (!enumerator.MoveNext())
> return list;
> }
> {code}
> Should be changed to something like this:
> {code:java}
> while (enumerator.MoveNext())
> {
> var item = enumerator.Current;
> }
> {code}
> Here is an example of the issue in the Gremlin.Net code:
> [https://github.com/apache/tinkerpop/blob/e8b9532fc0ec811460e97ebf5e00b8b9ec9192ac/gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs#L132]
> {code:java}
> private object? GetCurrent()
> {
> // Use dynamic to object to prevent runtime dynamic conversion evaluation
> return TraverserEnumerator.Current?.Object;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2872) Inconsistency in comparing Elements in JavaScript tests
[ https://issues.apache.org/jira/browse/TINKERPOP-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805826#comment-17805826 ] ASF GitHub Bot commented on TINKERPOP-2872: --- xiazcy commented on PR #2422: URL: https://github.com/apache/tinkerpop/pull/2422#issuecomment-1888079376 VOTE +1 > Inconsistency in comparing Elements in JavaScript tests > --- > > Key: TINKERPOP-2872 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2872 > Project: TinkerPop > Issue Type: Improvement > Components: javascript >Affects Versions: 3.7.0 >Reporter: Valentyn Kahamlyk >Priority: Major > > In most GLV's we consider Elements the same when they have the same ID. > In JavaScript tests used [member wise > comparison|https://github.com/apache/tinkerpop/blob/master/gremlin-javascript/src/main/javascript/gremlin-javascript/test/cucumber/feature-steps.js#L176] > Make it work like the others GLV's, just compare ID. -- This message was sent by Atlassian Jira (v8.20.10#820010)
