[jira] [Updated] (TINKERPOP-3032) Align readPartitions data type for PartitionStrategy
[
https://issues.apache.org/jira/browse/TINKERPOP-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Mallette updated TINKERPOP-3032:
Description: gremlin-language doesn't have {{Set}} yet until TINKERPOP-3023
but .NET forces {{PartitionStrategy.readPartitions}} to be of that type. The
other languages accept {{List}}. There should be some alignment here. {{Set}}
makes sense for this configuration but from an API perspective users probably
don't need to be forced into it. Seems like it could internally use {{Set}} but
accept a {{List}} to avoid that extra specificity. This also applies to Go.
{{Set}} is also used in constructing some other strategies like
{{ReservedKeysVerificationStrategy}}. (was: gremlin-language doesn't have
{{Set}} yet until TINKERPOP-3023 but .NET forces
{{PartitionStrategy.readPartitions}} to be of that type. The other languages
accept {{List}}. There should be some alignment here. {{Set}} makes sense for
this configuration but from an API perspective users probably don't need to be
forced into it. Seems like it could internally use {{Set}} but accept a
{{List}} to avoid that extra specificity. This also applies to Go. )
> Align readPartitions data type for PartitionStrategy
>
>
> Key: TINKERPOP-3032
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3032
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet, go, process
>Affects Versions: 3.6.6
>Reporter: Stephen Mallette
>Priority: Minor
>
> gremlin-language doesn't have {{Set}} yet until TINKERPOP-3023 but .NET
> forces {{PartitionStrategy.readPartitions}} to be of that type. The other
> languages accept {{List}}. There should be some alignment here. {{Set}} makes
> sense for this configuration but from an API perspective users probably don't
> need to be forced into it. Seems like it could internally use {{Set}} but
> accept a {{List}} to avoid that extra specificity. This also applies to Go.
> {{Set}} is also used in constructing some other strategies like
> {{ReservedKeysVerificationStrategy}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3030) Update to .NET 8
[ https://issues.apache.org/jira/browse/TINKERPOP-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812687#comment-17812687 ] ASF GitHub Bot commented on TINKERPOP-3030: --- codecov-commenter commented on PR #2468: URL: https://github.com/apache/tinkerpop/pull/2468#issuecomment-1919010560 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`3ae5298`)](https://app.codecov.io/gh/apache/tinkerpop/commit/3ae529870bb6ad448e081fecd4ee095f667a5892?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 75.42% compared to head [(`2c0ce57`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2468?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 75.15%. > Report is 10 commits behind head on 3.6-dev. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.6-dev#2468 +/- ## = - Coverage 75.42% 75.15% -0.27% + Complexity 1232112314 -7 = Files 1032 1057 +25 Lines 5969863470+3772 Branches6936 6936 = + Hits 4502947704+2675 - Misses 1228713193 +906 - Partials2382 2573 +191 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2468?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Update to .NET 8 > > > Key: TINKERPOP-3030 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3030 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Affects Versions: 3.5.8, 3.6.6, 3.7.1 >Reporter: Florian Hockmann >Assignee: Florian Hockmann >Priority: Minor > > .NET 8 is now the latest LTS release so we should update to it. > We need to do that on all release branches so contributors only need to have > one version of .NET installed on their systems. > This also means that we test by default with .NET 8 which would have shown > problems like the one described in TINKERPOP-3029. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3030) Update to .NET 8
[ https://issues.apache.org/jira/browse/TINKERPOP-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812685#comment-17812685 ] ASF GitHub Bot commented on TINKERPOP-3030: --- FlorianHockmann opened a new pull request, #2468: URL: https://github.com/apache/tinkerpop/pull/2468 https://issues.apache.org/jira/browse/TINKERPOP-3030 I've also noticed that the examples used camel casing for some method names which I switched to pascal casing to stay idiomatic in C#. I had to update the Docker image to Ubuntu 20.04 because .NET 8 is not available for Ubuntu 18.04. Since 18.04 is out of support since June already, this update makes sense in general [1]. I verified that the Docker build is still working with: ```sh ./docker/build.sh --dotnet ``` VOTE +1 [1]: https://wiki.ubuntu.com/Releases > Update to .NET 8 > > > Key: TINKERPOP-3030 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3030 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Affects Versions: 3.5.8, 3.6.6, 3.7.1 >Reporter: Florian Hockmann >Assignee: Florian Hockmann >Priority: Minor > > .NET 8 is now the latest LTS release so we should update to it. > We need to do that on all release branches so contributors only need to have > one version of .NET installed on their systems. > This also means that we test by default with .NET 8 which would have shown > problems like the one described in TINKERPOP-3029. -- This message was sent by Atlassian Jira (v8.20.10#820010)
