[jira] [Reopened] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Xia reopened TINKERPOP-3068: - > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Assignee: Yang Xia >Priority: Major > Fix For: 3.6.7 > > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Xia updated TINKERPOP-3068: Fix Version/s: 3.7.2 > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Assignee: Yang Xia >Priority: Major > Fix For: 3.6.7, 3.7.2 > > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Xia closed TINKERPOP-3068. --- Resolution: Fixed > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Assignee: Yang Xia >Priority: Major > Fix For: 3.6.7, 3.7.2 > > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Xia closed TINKERPOP-3068. --- Fix Version/s: 3.6.7 Assignee: Yang Xia Resolution: Fixed > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Assignee: Yang Xia >Priority: Major > Fix For: 3.6.7 > > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834425#comment-17834425 ] ASF GitHub Bot commented on TINKERPOP-3068: --- xiazcy commented on PR #2544: URL: https://github.com/apache/tinkerpop/pull/2544#issuecomment-2040520494 Cherry-picked to d9da293 as CTR. > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Priority: Major > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834424#comment-17834424 ] ASF GitHub Bot commented on TINKERPOP-3068: --- xiazcy closed pull request #2544: [TINKERPOP-3068] Make serviceName and mergedParams public for provide… URL: https://github.com/apache/tinkerpop/pull/2544 > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Priority: Major > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834419#comment-17834419 ] ASF GitHub Bot commented on TINKERPOP-3068: --- Cole-Greer commented on PR #2544: URL: https://github.com/apache/tinkerpop/pull/2544#issuecomment-2040480466 VOTE +1 > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Priority: Major > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834417#comment-17834417 ] ASF GitHub Bot commented on TINKERPOP-3068: --- xiazcy commented on PR #2544: URL: https://github.com/apache/tinkerpop/pull/2544#issuecomment-2040476522 VOTE +1. I'll cherry pick the proper commit into the branch. > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Priority: Major > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834281#comment-17834281 ] ASF GitHub Bot commented on TINKERPOP-3068: --- codecov-commenter commented on PR #2544: URL: https://github.com/apache/tinkerpop/pull/2544#issuecomment-2039672224 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `66.36637%` with `224 lines` in your changes are missing coverage. Please review. > Project coverage is 76.50%. Comparing base [(`d9e34fb`)](https://app.codecov.io/gh/apache/tinkerpop/commit/d9e34fb4678c29ffa167066de45a9fa7329a319a?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`1d671f3`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 31 commits behind head on 3.6-dev. | [Files](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...in/language/grammar/DefaultGremlinBaseVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FDefaultGremlinBaseVisitor.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0RlZmF1bHRHcmVtbGluQmFzZVZpc2l0b3IuamF2YQ==) | 0.00% | [137 Missing :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...rpop/gremlin/language/grammar/ArgumentVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FArgumentVisitor.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0FyZ3VtZW50VmlzaXRvci5qYXZh) | 76.47% | [21 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...remlin/language/grammar/GenericLiteralVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FGenericLiteralVisitor.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL0dlbmVyaWNMaXRlcmFsVmlzaXRvci5qYXZh) | 68.42% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...e/tinkerpop/gremlin/console/GremlinGroovysh.groovy](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree=gremlin-console%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Fconsole%2FGremlinGroovysh.groovy_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvR3JlbWxpbkdyb292eXNoLmdyb292eQ==) | 52.94% | [6 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...emlin/language/grammar/TraversalMethodVisitor.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree=gremlin-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Flanguage%2Fgrammar%2FTraversalMethodVisitor.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL1RyYXZlcnNhbE1ldGhvZFZpc2l0b3IuamF2YQ==) | 95.39% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2544?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
[jira] [Commented] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
[ https://issues.apache.org/jira/browse/TINKERPOP-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834269#comment-17834269 ] ASF GitHub Bot commented on TINKERPOP-3068: --- saikiranboga opened a new pull request, #2544: URL: https://github.com/apache/tinkerpop/pull/2544 …r usage in CallStep > Make serviceName and mergedParams public for provider usage in CallStep > --- > > Key: TINKERPOP-3068 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 > Project: TinkerPop > Issue Type: Improvement > Components: process >Reporter: Saikiran Boga >Priority: Major > > When using CallStep, providers require access to the serviceName and the > merged params from CallStep for implementation. > > service name is currently private > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] > and merged params getter is protected > [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (TINKERPOP-3068) Make serviceName and mergedParams public for provider usage in CallStep
Saikiran Boga created TINKERPOP-3068: Summary: Make serviceName and mergedParams public for provider usage in CallStep Key: TINKERPOP-3068 URL: https://issues.apache.org/jira/browse/TINKERPOP-3068 Project: TinkerPop Issue Type: Improvement Components: process Reporter: Saikiran Boga When using CallStep, providers require access to the serviceName and the merged params from CallStep for implementation. service name is currently private [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L63] and merged params getter is protected [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/CallStep.java#L195] -- This message was sent by Atlassian Jira (v8.20.10#820010)
