[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python

2016-06-16 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/340
  
@leifurhauks do you know why travis is not happy? the build took some 
errors it seems. Can you please look into that as you push your next change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python

2016-06-16 Thread leifurhauks
Github user leifurhauks commented on the issue:

https://github.com/apache/tinkerpop/pull/340
  
@okram , I realized the current implementation of bindings as dicts is 
breaking 2/3 compatibility. It also makes it bit hairy to extract just the key 
in `RawExpression`. 

I would suggest using a tuple (e.g. `('symbol', value)` ) or a simple class 
that just has two data members. May I revise the bindings implementation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python

2016-06-16 Thread leifurhauks
Github user leifurhauks commented on the issue:

https://github.com/apache/tinkerpop/pull/340
  
> This is just for the GeoPoint-style adding classes?

More generally, it can be used to create expressions that make use of APIs, 
presumably provided by the graph vendor, that aren't strictly part of gremlin. 
My immediate use case is to call static methods on Titan's Geoshape class.

I'll add an example to the asciidoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---