[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/344 Can you add the license boilerplate? BTW: Just pulled your patch and building locally now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests
Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/344 Also, the generated `__version__.py` file fails the rat check. I think it needs to be either a) generated with the license boilerplate b) excluded from the rat check, or c) included in the clean configuration. Please advise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #344: gremlin_python: generate/build/deps before tests
Github user leifurhauks commented on the issue: https://github.com/apache/tinkerpop/pull/344 I think this should fix the CI test failures. On the subject of the python dependencies (aenum and requests), should they be bundled in the jar? aenum has a 3-clause BSD [license](https://bitbucket.org/stoneleaf/aenum/src/c9dc3b8fc3e3755a919ba4357ab9ed9b22131af1/aenum/LICENSE?at=default&fileviewer=file-view-default), and requests uses the ASL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
