[GitHub] tinkerpop issue #699: TINKERPOP-1759 Improve hashcode and equals for Travers...

2017-09-05 Thread robertdale
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/699
  
VOTE +1


---


[GitHub] tinkerpop issue #699: TINKERPOP-1759 Improve hashcode and equals for Travers...

2017-08-30 Thread okram
Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/699
  
I'm scared -- VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #699: TINKERPOP-1759 Improve hashcode and equals for Travers...

2017-08-30 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/699
  
`docker/build.sh -t -n -i` still succeeds after recent changes.

Still VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] tinkerpop issue #699: TINKERPOP-1759 Improve hashcode and equals for Travers...

2017-08-28 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/699
  
I can rename them or just make them package private. I'd prefer the latter. 
In fact that's what I've at first... I changed it to prevent your "please make 
that final protected" comment ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---