[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/825 Can this be merged? ---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/825 VOTE +1 ---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/825 added changelog entry ---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/825 Should get a CHANGELOG entry, right? ---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/825 Best PR ever ;) VOTE: +1 ---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/825 i meant to come back to that pom.xml and forgot. seems ok to drop the two exclusions now that giraph is gone. didn't get any new conflicts in doing so when i built. ---
[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/825
I think there's more that can be removed:
```diff
diff --git a/pom.xml b/pom.xml
index ef2be4821d..ddd9167a51 100644
--- a/pom.xml
+++ b/pom.xml
@@ -582,15 +582,6 @@ limitations under the License.
commons-logging
commons-logging
-
-
-org.codehaus.jackson
-jackson-core-asl
-
-
-org.codehaus.jackson
-jackson-mapper-asl
-
junit
@@ -1146,7 +1137,7 @@ limitations under the License.
${basedir}/docs/javadoc/overview.html
true
-
giraph-gremlin/src/main/java:gremlin-core/src/main/java:gremlin-driver/src/main/java:gremlin-groovy/src/main/java:gremlin-python/src/main/java:gremlin-server/src/main/java:gremlin-test/src/main/java:hadoop-gremlin/src/main/java:neo4j-gremlin/src/main/java:spark-gremlin/src/main/java:tinkergraph-gremlin/src/main/java
+
gremlin-core/src/main/java:gremlin-driver/src/main/java:gremlin-groovy/src/main/java:gremlin-python/src/main/java:gremlin-server/src/main/java:gremlin-test/src/main/java:hadoop-gremlin/src/main/java:neo4j-gremlin/src/main/java:spark-gremlin/src/main/java:tinkergraph-gremlin/src/main/java
```
However, `docker/build.sh -d` fails with an `AbstractMethodError` in Spark,
but I'm afraid that's a problem in other branches as well.
---
