[GitHub] tinkerpop issue #907: Fix Sack Split.

2018-08-30 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
> We develop a gremlin query engine based on c++,

interestingIs that code available as open source? 


---

[GitHub] tinkerpop issue #907: Fix Sack Split.

2018-08-30 Thread RainMark 
Github user RainMark commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
@spmallette @robertdale 

The sack of clone traverser is correctly.
Sorry, I'm new for java, I never noticed Java's object clone method.
Recently, We develop a gremlin query engine based on c++, So I ask this 
question.
Anyway,Thank you very much!



---

[GitHub] tinkerpop issue #907: Fix Sack Split.

2018-08-29 Thread RainMark 
Github user RainMark commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
@spmallette yes,I will come back to address the comments. just a little 
busy recently


---

[GitHub] tinkerpop issue #907: Fix Sack Split.

2018-08-28 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
hi @RainMark do you plan to come back to address the comments here? 


---

[GitHub] tinkerpop issue #907: Fix Sack Split.

2018-08-13 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
@RainMark did you have a chance to consider the previous comment from 
@robertdale ?  While I appreciate that you have a solution to a problem you are 
seeing, I share his concern about understanding the nature of the problem 
itself that is being fixed.


---

[GitHub] tinkerpop issue #907: Fix Sack Split.

2018-08-06 Thread robertdale 
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
@RainMark Could you create an issue in Jira and describe the problem?   See 
also [Contributing code 
changes](https://tinkerpop.apache.org/docs/current/dev/developer/#_contributing_code_changes).
 It would be good to see a test case that fails without the change and passes 
with the change but also satisfies the examples in the documentation.

I also want to make sure you're not running into this
- http://tinkerpop.apache.org/docs/current/reference/#sack-step
```
The first example does not use a split operator and as such, the same map 
is propagated to
all traversers (a global data structure). The second example, demonstrates 
how Map.clone()
ensures that each traverser’s sack contains a unique, local sack.
```



---

[GitHub] tinkerpop issue #907: Fix Sack Split.

2018-08-06 Thread RainMark 
Github user RainMark commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
Nop,there is no test for sack split operator. 
If I pass in a special split operator, this operator can't obtain source 
traverser's sack value with apply() method.


---

[GitHub] tinkerpop issue #907: Fix Sack Split.

2018-08-05 Thread robertdale 
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
Is there a test that covers this?


---