[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/384


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/384#discussion_r75560386
  
--- Diff: 
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/GremlinGroovysh.groovy
 ---
@@ -45,12 +46,13 @@ class GremlinGroovysh extends Groovysh {
 Command findCommand(final String line, final List parsedArgs = 
null) {
 def l = line ?: ""
 
-final List args = parseLine(l)
-if (args.size() == 0) return null
+final List linetokens = parseLine(l)
+if (linetokens.size() == 0) return null
 
-def cmd = registry.find(args[0])
+def cmd = registry.find(linetokens[0])
 
-if (cmd != null && args.size() > 1 && parsedArgs != null) {
+if (cmd != null && linetokens.size() > 1 && parsedArgs != null) {
+List args = CommandArgumentParser.parseLine(line, 
parsedArgs == null ? 1 : -1)
--- End diff --

groovysh added this line 1 month after this code was written.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful

[pluradj]

Github user pluradj commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/384#discussion_r75548087
  
--- Diff: 
gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/Console.groovy
 ---
@@ -66,12 +72,48 @@ class Console {
 public static final String PREFERENCE_ITERATION_MAX = "max-iteration"
 private static final int DEFAULT_ITERATION_MAX = 100
 private static int maxIteration = DEFAULT_ITERATION_MAX
+
+   public static final String PREF_GREMLIN_COLOR = "gremlin.color"
+def gremlinColor = { Preferences.get(PREF_GREMLIN_COLOR, "reset") }
+   
--- End diff --

Got a mix of tab and space indenting going on here. The [dev 
docs](http://tinkerpop.apache.org/docs/current/dev/developer/#_code_style) 
don't call for one over the other, but most Java/Groovy files in the repo use 
spaces only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #384: TINKERPOP-1037 Made life more colorful

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/384

TINKERPOP-1037 Made life more colorful

Stephen did all the hard work.
- Added option -C to disable ANSI colors just in case.
- Colorized the gremlin ascii art.
- Added bold red to some, but probably not all, error messages
- Snuck in the help text for TINKERPOP-1246

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertdale/tinkerpop TINKERPOP-1037

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #384


commit ef518fbfef1910a73183abeed0bee90ba38e9a1f
Author: Robert Dale 
Date:   2016-08-18T17:34:04Z

made life more colorful




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---