[GitHub] tinkerpop pull request #687: TINKERPOP-1742 RangeByIsCountStrategy fails for...

[okram]

Github user okram commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/687#discussion_r132184141
  
--- Diff: 
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategyTest.java
 ---
@@ -95,6 +95,7 @@
 {__.filter(__.bothE().count().is(gte(1))), 
__.filter(__.bothE())},
 {__.filter(__.bothE().count().is(gt(1))), 
__.filter(__.bothE().limit(2).count().is(gt(1)))},
 {__.filter(__.bothE().count().is(gte(2))), 
__.filter(__.bothE().limit(2).count().is(gte(2)))},
+{__.and(__.out().count().is(0), __.in().count().is(0)), 
__.and(__.not(__.out()), __.not(__.in()))}
 });
--- End diff --

Perhaps one more test using both `and()` and `or()` and another pattern 
such as `is(gt(1))`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #687: TINKERPOP-1742 RangeByIsCountStrategy fails for...

[okram]

Github user okram commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/687#discussion_r132183920
  
--- Diff: CHANGELOG.asciidoc ---
@@ -143,6 +143,7 @@ TinkerPop 3.2.6 (Release Date: NOT OFFICIALLY RELEASED 
YET)
 
 This release also includes changes from <>.
 
+* Fixed a bug in `RangeByIsCountStrategy`.
--- End diff --

Can you be a bit more explicit? -- e.g. "Fixed a bug regarding 
`ConnectiveSteps` in `RangeByIsCountStrategy`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #687: TINKERPOP-1742 RangeByIsCountStrategy fails for...

[dkuppitz]

GitHub user dkuppitz opened a pull request:

https://github.com/apache/tinkerpop/pull/687

TINKERPOP-1742 RangeByIsCountStrategy fails for ConnectiveSteps

https://issues.apache.org/jira/browse/TINKERPOP-1742

Fixed a bug in `RangeByIsCountStrategy`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1742-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #687


commit 14f03183b9507de38da5107e36f56daed609b773
Author: Daniel Kuppitz 
Date:   2017-08-07T16:43:45Z

CTR: Fixed screwed Groovy test

commit fde3aeb3235ea4d15f39982d836c9fb0f9f3ad53
Author: Daniel Kuppitz 
Date:   2017-08-08T15:23:06Z

Fixed a bug in `RangeByIsCountStrategy`.

commit e38df2d84cd0bc37b88e34627af353937fa1693d
Author: Daniel Kuppitz 
Date:   2017-08-08T15:25:08Z

Merge branch 'TINKERPOP-1742' into TINKERPOP-1742-master




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---