[GitHub] tinkerpop pull request #778: TINKERPOP-1870: Extends TraverserSet to have Ve...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/778


---

[GitHub] tinkerpop pull request #778: TINKERPOP-1870: Extends TraverserSet to have Ve...

[artem-aliev]

Github user artem-aliev commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/778#discussion_r162065650
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoVersion.java
 ---
@@ -305,6 +307,7 @@ public String getVersion() {
 add(GryoTypeReg.of(RangeGlobalStep.RangeBiOperator.class, 
114));
 add(GryoTypeReg.of(OrderGlobalStep.OrderBiOperator.class, 118, 
new JavaSerializer()));
 add(GryoTypeReg.of(ProfileStep.ProfileBiOperator.class, 119));
+add(GryoTypeReg.of(VertexTraverserSet.class, 173));
--- End diff --

master PR: https://github.com/apache/tinkerpop/pull/781
I have make both tp32 and tp33 ids the same. so I skipped 171,172 in  tp32


---

[GitHub] tinkerpop pull request #778: TINKERPOP-1870: Extends TraverserSet to have Ve...

[spmallette]

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/778#discussion_r161835490
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoVersion.java
 ---
@@ -305,6 +307,7 @@ public String getVersion() {
 add(GryoTypeReg.of(RangeGlobalStep.RangeBiOperator.class, 
114));
 add(GryoTypeReg.of(OrderGlobalStep.OrderBiOperator.class, 118, 
new JavaSerializer()));
 add(GryoTypeReg.of(ProfileStep.ProfileBiOperator.class, 119));
+add(GryoTypeReg.of(VertexTraverserSet.class, 173));
--- End diff --

please move the "last id" comment down from:


https://github.com/apache/tinkerpop/pull/778/files#diff-f1eb3822f6d5659dd2bdc913ae475241R208

you might need to create a separate PR against master for us to review 
because of this change because Gryo 3.0 will need a similar entry on master (i 
suspect the kryo id will be different) and we'd need to be sure this all works 
on master as well.


---

[GitHub] tinkerpop pull request #778: TINKERPOP-1870: Extends TraverserSet to have Ve...

[artem-aliev]

GitHub user artem-aliev opened a pull request:

https://github.com/apache/tinkerpop/pull/778

TINKERPOP-1870: Extends TraverserSet to have Vertex index for remote …

…traversers

That replaces linear search in reversal traversal interator with hashtable 
lookup.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/artem-aliev/tinkerpop TINKERPOP-1870

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #778


commit f1dd251174dd1f04b6ed722b1956d5c3291a842a
Author: artemaliev 
Date:   2018-01-15T15:23:49Z

TINKERPOP-1870: Extends TraverserSet to have Vertex index for remote 
traversers
That replaces linear search in reversal traversal interator with hashtable 
lookup.




---