[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439340#comment-16439340
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/830


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437979#comment-16437979
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/830
  
VOTE +1


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428807#comment-16428807
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/830
  
VOTE: +1


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428800#comment-16428800
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179849183
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

that makes sense - fixed and pushed


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428797#comment-16428797
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user dkuppitz commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179848121
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

It's not bad. I don't fully understand the code in `CountMatchAlgorithm` 
(the only place where the boolean flag makes a difference), but it seems like 
it only reorders the match traversals, possibly to optimize memory consumption 
and/or processing time.


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428762#comment-16428762
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179843523
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

oh wow - good catch. i guess the tests pass either way though...don't know 
if that's bad.???


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428669#comment-16428669
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

Github user dkuppitz commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/830#discussion_r179829888
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MatchStep.java
 ---
@@ -362,7 +360,7 @@ private boolean hasPathLabel(final Path path, final 
Set labels) {
 while (true) {
 if (this.first) {
 this.first = false;
-
this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD);
+this.initializeMatchAlgorithm(true);
--- End diff --

Shouldn't this be `false`?


> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1143) Remove deprecated TraversalSource.Builder and TraversalEngine.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426752#comment-16426752
 ] 

ASF GitHub Bot commented on TINKERPOP-1143:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/830

TINKERPOP-1143 Moved TraversalEngine to gremlin-test

https://issues.apache.org/jira/browse/TINKERPOP-1143

`TraversalEngine` and related infrastructure was deprecated way back on 
3.2.0 but it was kept around because it was used in some infrastructure for 
testing. Graph providers should in no way still be using this interface and 
should have long ago gone to `Computer` as the `gremlin-core` infrastructure 
long ago quit using `TraversalEngine` in any capacity.

The only weird part was that `MatchStep` used `TraversalEngine` as a switch 
- I just converted that to use a boolean for checks that determine if the step 
is being executed `onComputer` or not.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1143

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #830


commit 38e74727f3d9e3fc14c52bddf354a8936b1731b5
Author: Stephen Mallette 
Date:   2018-04-04T21:32:04Z

TINKERPOP-1143 Moved TraversalEngine to gremlin-test

TraversalEngine and related infrastructure was deprecated way back on 3.2.0 
but it was kept around because it was used in some infrastructure for testing. 
Graph providers should in no way still be using this interface and should have 
long ago gone to Computer as the gremlin-core infrastructure long ago quit 
using TraversalEngine in any capacity.




> Remove deprecated TraversalSource.Builder and TraversalEngine.
> --
>
> Key: TINKERPOP-1143
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1143
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)