[jira] [Commented] (TINKERPOP-1338) Bump to Groovy 2.4.7
[ https://issues.apache.org/jira/browse/TINKERPOP-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368222#comment-15368222 ] ASF GitHub Bot commented on TINKERPOP-1338: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/356 > Bump to Groovy 2.4.7 > > > Key: TINKERPOP-1338 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1338 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.2.0-incubating >Reporter: stephen mallette >Assignee: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Provides a number of bug fixes: > http://groovy-lang.org/changelogs/changelog-2.4.7.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1338) Bump to Groovy 2.4.7
[ https://issues.apache.org/jira/browse/TINKERPOP-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367478#comment-15367478 ] ASF GitHub Bot commented on TINKERPOP-1338: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/356 All tests pass with `docker/build.sh -t -n -i` VOTE +1 > Bump to Groovy 2.4.7 > > > Key: TINKERPOP-1338 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1338 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.2.0-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Provides a number of bug fixes: > http://groovy-lang.org/changelogs/changelog-2.4.7.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1338) Bump to Groovy 2.4.7
[ https://issues.apache.org/jira/browse/TINKERPOP-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364951#comment-15364951 ] ASF GitHub Bot commented on TINKERPOP-1338: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/356 I rebased to include @okram 's fix in the jira ticket. 4.5 hours later, "docker/build.sh -t -i -n" passed! > Bump to Groovy 2.4.7 > > > Key: TINKERPOP-1338 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1338 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.2.0-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Provides a number of bug fixes: > http://groovy-lang.org/changelogs/changelog-2.4.7.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1338) Bump to Groovy 2.4.7
[ https://issues.apache.org/jira/browse/TINKERPOP-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364375#comment-15364375 ] Marko A. Rodriguez commented on TINKERPOP-1338: --- The bug was in the @dalaro work where `Void` and `void` in the shim serializer are assuming `FieldSerializer`. I studied the Kryo code to note that `void` and `Void` are defaulted with `VoidSerializer`. The `spark-gremlin/` integration tests now pass and I have pushed the fix to master CTR. > Bump to Groovy 2.4.7 > > > Key: TINKERPOP-1338 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1338 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.2.0-incubating >Reporter: stephen mallette >Priority: Minor > Fix For: 3.2.1 > > > Provides a number of bug fixes: > http://groovy-lang.org/changelogs/changelog-2.4.7.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1338) Bump to Groovy 2.4.7
[ https://issues.apache.org/jira/browse/TINKERPOP-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364310#comment-15364310 ] ASF GitHub Bot commented on TINKERPOP-1338: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/356 Note that it's not sufficient in this case to only run gremlin server integration tests. You should probably run the whole suite. When i run that with docker via `docker/build.sh -t -i -n` i get tons of: ```text Caused by: java.lang.IllegalArgumentException: Unable to create serializer "com.esotericsoftware.kryo.serializers.FieldSerializer" for class: void at com.esotericsoftware.kryo.Kryo.newSerializer(Kryo.java:335) at com.esotericsoftware.kryo.Kryo.newDefaultSerializer(Kryo.java:314) at com.twitter.chill.KryoBase.newDefaultSerializer(KryoBase.scala:48) at com.esotericsoftware.kryo.Kryo.getDefaultSerializer(Kryo.java:307) at com.esotericsoftware.kryo.Kryo.register(Kryo.java:351) at org.apache.tinkerpop.gremlin.spark.structure.io.gryo.GryoRegistrator.registerClasses(GryoRegistrator.java:94) at org.apache.tinkerpop.gremlin.spark.structure.io.gryo.GryoRegistrator.registerClasses(GryoRegistrator.java:65) at org.apache.spark.serializer.KryoSerializer$$anonfun$newKryo$6.apply(KryoSerializer.scala:124) at org.apache.spark.serializer.KryoSerializer$$anonfun$newKryo$6.apply(KryoSerializer.scala:124) at scala.Option.foreach(Option.scala:236) at org.apache.spark.serializer.KryoSerializer.newKryo(KryoSerializer.scala:124) at org.apache.tinkerpop.gremlin.spark.structure.io.gryo.IoRegistryAwareKryoSerializer.newKryo(IoRegistryAwareKryoSerializer.java:57) at org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoShimService.initialize(UnshadedKryoShimService.java:144) at org.apache.tinkerpop.gremlin.spark.structure.io.gryo.kryoshim.unshaded.UnshadedKryoShimService.applyConfiguration(UnshadedKryoShimService.java:106) at org.apache.tinkerpop.gremlin.structure.io.gryo.kryoshim.KryoShimServiceLoader.load(KryoShimServiceLoader.java:125) at org.apache.tinkerpop.gremlin.spark.process.computer.SparkHadoopGraphGryoRegistratorProvider.getBaseConfiguration(SparkHadoopGraphGryoRegistratorProvider.java:48) at org.apache.tinkerpop.gremlin.AbstractGraphProvider.newGraphConfiguration(AbstractGraphProvider.java:70) at org.apache.tinkerpop.gremlin.GraphProvider.standardGraphConfiguration(GraphProvider.java:144) at org.apache.tinkerpop.gremlin.GraphManager$ManagedGraphProvider.standardGraphConfiguration(GraphManager.java:132) at org.apache.tinkerpop.gremlin.AbstractGremlinTest.setup(AbstractGremlinTest.java:81) at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.apache.tinkerpop.gremlin.process.GremlinProcessRunner.runChild(GremlinProcessRunner.java:54) at org.apache.tinkerpop.gremlin.process.GremlinProcessRunner.runChild(GremlinProcessRunner.java:37) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.apache.tinkerpop.gremlin.AbstractGremlinSuite.runChild(AbstractGremlinSuite.java:212) at org.apache.tinkerpop.gremlin.AbstractGremlinSuite.runChild(AbstractGremlinSuite.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at
