[jira] [Commented] (TINKERPOP-1388) Make ExpandableStepIterator non-final

2017-10-02 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188339#comment-16188339
 ] 

Marko A. Rodriguez commented on TINKERPOP-1388:
---

Is this still a desired change? If not, please close.

> Make ExpandableStepIterator non-final
> -
>
> Key: TINKERPOP-1388
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1388
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Matthias Broecheler
>Assignee: Marko A. Rodriguez
>Priority: Minor
>
> to allow TinkerPop implementations to extend it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (TINKERPOP-1388) Make ExpandableStepIterator non-final

2016-08-04 Thread Marko A. Rodriguez (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407769#comment-15407769
 ] 

Marko A. Rodriguez commented on TINKERPOP-1388:
---

Can you explain exactly what you are trying to do? Perhaps there is an 
interface that can be created? Perhaps there is a method we could add to 
{{ExpandableStepIterator}}?... As you can see, I'm reluctant to open up such 
low-level classes to developers. 



> Make ExpandableStepIterator non-final
> -
>
> Key: TINKERPOP-1388
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1388
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Matthias Broecheler
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.1.4, 3.2.2
>
>
> to allow TinkerPop implementations to extend it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (TINKERPOP-1388) Make ExpandableStepIterator non-final

2016-07-27 Thread Matthias Broecheler (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396031#comment-15396031
 ] 

Matthias Broecheler commented on TINKERPOP-1388:


If a graph implementation wants to control how elements flow through the 
traversal it has two options:
1) Insert a custom step before each step in the traversal that does the flow 
control through a strategy. However, that makes the toString and profiling ugly 
because of all the spurious steps that are introduced. This strategy is also 
likely to clash with other strategies
2) Extend ExpandableStepIterator and overwrite starts (which is protected) in 
AbstractStep.

Option 2) seems cleaner but requires that ExpandableStepIterator is not final.

/cc [~spmallette] [~okram]

> Make ExpandableStepIterator non-final
> -
>
> Key: TINKERPOP-1388
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1388
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.1.3
>Reporter: Matthias Broecheler
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.1.4, 3.2.2
>
>
> to allow TinkerPop implementations to extend it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)