[jira] [Commented] (TINKERPOP-1445) Large nested VertexProperties and Properties do not get printed well

[Jorge Bay (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119664#comment-16119664
 ] 

Jorge Bay commented on TINKERPOP-1445:
--

Please ignore previous hook generated message from the hook, it was 
unintended...

> Large nested VertexProperties and Properties do not get printed well
> 
>
> Key: TINKERPOP-1445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1445
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.2
>Reporter: Kevin Gallardo
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.3.0
>
>
> {code}
> gremlin> m = ['hello':'world', 'helo':'fromtheotherside']
> ==>hello=world
> ==>helo=fromtheotherside
> gremlin> graph.traversal().E().next().property('longMap', m)
> ==>p[longMap->{hello=world, helo=f]
> {code}
> Maybe the printing could be improved just to at least inform that there's 
> more in the value with a {{...}} or {{\[...\]}} for example.
> It seems to be the {{substring()}} call in 
> [propertyString|https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/StringFactory.java#L113].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1445) Large nested VertexProperties and Properties do not get printed well

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119658#comment-16119658
 ] 

ASF GitHub Bot commented on TINKERPOP-1445:
---

GitHub user jorgebay opened a pull request:

https://github.com/apache/tinkerpop/pull/690

TINKERPOP-1445 Unwrap AggregateException for sync io operations

https://issues.apache.org/jira/browse/TINKERPOP-1744

Includes a test expecting the underlying exception (`ResponseException`) to 
be thrown.

Builds with `mvn clean install -P gremlin-dotnet`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1744

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/690.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #690


commit a655e2649ab9a6ba1885dde317d81e845a7507b8
Author: Jorge Bay Gondra 
Date:   2017-08-09T09:46:28Z

Unwrap AggregateException for sync io operations




> Large nested VertexProperties and Properties do not get printed well
> 
>
> Key: TINKERPOP-1445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1445
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.2
>Reporter: Kevin Gallardo
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.3.0
>
>
> {code}
> gremlin> m = ['hello':'world', 'helo':'fromtheotherside']
> ==>hello=world
> ==>helo=fromtheotherside
> gremlin> graph.traversal().E().next().property('longMap', m)
> ==>p[longMap->{hello=world, helo=f]
> {code}
> Maybe the printing could be improved just to at least inform that there's 
> more in the value with a {{...}} or {{\[...\]}} for example.
> It seems to be the {{substring()}} call in 
> [propertyString|https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/StringFactory.java#L113].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1445) Large nested VertexProperties and Properties do not get printed well

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063154#comment-16063154
 ] 

ASF GitHub Bot commented on TINKERPOP-1445:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/631


> Large nested VertexProperties and Properties do not get printed well
> 
>
> Key: TINKERPOP-1445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1445
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.2
>Reporter: Kevin Gallardo
>Priority: Minor
> Fix For: 3.3.0
>
>
> {code}
> gremlin> m = ['hello':'world', 'helo':'fromtheotherside']
> ==>hello=world
> ==>helo=fromtheotherside
> gremlin> graph.traversal().E().next().property('longMap', m)
> ==>p[longMap->{hello=world, helo=f]
> {code}
> Maybe the printing could be improved just to at least inform that there's 
> more in the value with a {{...}} or {{\[...\]}} for example.
> It seems to be the {{substring()}} call in 
> [propertyString|https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/StringFactory.java#L113].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1445) Large nested VertexProperties and Properties do not get printed well

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059407#comment-16059407
 ] 

ASF GitHub Bot commented on TINKERPOP-1445:
---

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/631#discussion_r123512314
  
--- Diff: 
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/PropertyTest.java
 ---
@@ -59,14 +59,40 @@
 public static class BasicPropertyTest extends AbstractGremlinTest {
 @Test
 @FeatureRequirementSet(FeatureRequirementSet.Package.VERTICES_ONLY)
-public void shouldHaveStandardStringRepresentation() {
+public void 
shouldHaveStandardStringRepresentationForVertexProperty() {
 final Vertex v = graph.addVertex("name", "marko");
 final Property p = v.property("name");
 assertEquals(StringFactory.propertyString(p), p.toString());
 }
 
 @Test
 @FeatureRequirementSet(FeatureRequirementSet.Package.VERTICES_ONLY)
+public void 
shouldHaveTruncatedStringRepresentationForVertexProperty() {
+final Vertex v = graph.addVertex("name", "maria de la santa 
cruz rosalina agnelia rodriguez cuellar rene");
+final Property p = v.property("name");
+assertEquals(StringFactory.propertyString(p), p.toString());
--- End diff --

That test is more to validate that providers are using the `StringFactory` 
(or at least make their stuff align to `StringFactory` output).


> Large nested VertexProperties and Properties do not get printed well
> 
>
> Key: TINKERPOP-1445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1445
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.2
>Reporter: Kevin Gallardo
>Priority: Minor
>
> {code}
> gremlin> m = ['hello':'world', 'helo':'fromtheotherside']
> ==>hello=world
> ==>helo=fromtheotherside
> gremlin> graph.traversal().E().next().property('longMap', m)
> ==>p[longMap->{hello=world, helo=f]
> {code}
> Maybe the printing could be improved just to at least inform that there's 
> more in the value with a {{...}} or {{\[...\]}} for example.
> It seems to be the {{substring()}} call in 
> [propertyString|https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/StringFactory.java#L113].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1445) Large nested VertexProperties and Properties do not get printed well

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059387#comment-16059387
 ] 

ASF GitHub Bot commented on TINKERPOP-1445:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/631
  
hmm - i didn't add that. It's the `StringUtils` utility. I guess it is not 
smart about the final space.


> Large nested VertexProperties and Properties do not get printed well
> 
>
> Key: TINKERPOP-1445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1445
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.2
>Reporter: Kevin Gallardo
>Priority: Minor
>
> {code}
> gremlin> m = ['hello':'world', 'helo':'fromtheotherside']
> ==>hello=world
> ==>helo=fromtheotherside
> gremlin> graph.traversal().E().next().property('longMap', m)
> ==>p[longMap->{hello=world, helo=f]
> {code}
> Maybe the printing could be improved just to at least inform that there's 
> more in the value with a {{...}} or {{\[...\]}} for example.
> It seems to be the {{substring()}} call in 
> [propertyString|https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/StringFactory.java#L113].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1445) Large nested VertexProperties and Properties do not get printed well

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059380#comment-16059380
 ] 

ASF GitHub Bot commented on TINKERPOP-1445:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/631
  
VOTE +1. (However, I wouldn't add the  between the last line and the 
`...` but whateves)


> Large nested VertexProperties and Properties do not get printed well
> 
>
> Key: TINKERPOP-1445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1445
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.2
>Reporter: Kevin Gallardo
>Priority: Minor
>
> {code}
> gremlin> m = ['hello':'world', 'helo':'fromtheotherside']
> ==>hello=world
> ==>helo=fromtheotherside
> gremlin> graph.traversal().E().next().property('longMap', m)
> ==>p[longMap->{hello=world, helo=f]
> {code}
> Maybe the printing could be improved just to at least inform that there's 
> more in the value with a {{...}} or {{\[...\]}} for example.
> It seems to be the {{substring()}} call in 
> [propertyString|https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/StringFactory.java#L113].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1445) Large nested VertexProperties and Properties do not get printed well

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053292#comment-16053292
 ] 

ASF GitHub Bot commented on TINKERPOP-1445:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/631
  
VOTE: +1 (and an extra +1 for finding a super long name that actually 
exists :))


> Large nested VertexProperties and Properties do not get printed well
> 
>
> Key: TINKERPOP-1445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1445
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.2
>Reporter: Kevin Gallardo
>Priority: Minor
>
> {code}
> gremlin> m = ['hello':'world', 'helo':'fromtheotherside']
> ==>hello=world
> ==>helo=fromtheotherside
> gremlin> graph.traversal().E().next().property('longMap', m)
> ==>p[longMap->{hello=world, helo=f]
> {code}
> Maybe the printing could be improved just to at least inform that there's 
> more in the value with a {{...}} or {{\[...\]}} for example.
> It seems to be the {{substring()}} call in 
> [propertyString|https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/StringFactory.java#L113].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1445) Large nested VertexProperties and Properties do not get printed well

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053279#comment-16053279
 ] 

ASF GitHub Bot commented on TINKERPOP-1445:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/631

TINKERPOP-1445 Add ellipses for long property values

https://issues.apache.org/jira/browse/TINKERPOP-1445

This was an easy change but I decided to do this as a PR so that the change 
would be noted as it does affect something that is user facing. I did this 
change for 3.3.0 only in case someone is depending on the `toString()` value of 
`Property` for some reason.

```text
gremlin> graph = TinkerGraph.open()
==>tinkergraph[vertices:0 edges:0]
gremlin> g = graph.traversal()
==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
gremlin> g.addV().property('short','pretty short').property('long','this 
one is much longer so it is going to get truncated a bit').as('a').
..1>   addE('self').property('short','pretty short').property('long', 
'this one is much longer so it is going to get truncated a 
bit').from('a').to('a')
==>e[3][0-self->0]
gremlin> g.V().properties()
==>vp[short->pretty short]
==>vp[long->this one is much ...]
gremlin> g.E().properties()
==>p[short->pretty short]
==>p[long->this one is much ...]
```

Builds with `mvn clean install`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1445

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/631.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #631


commit 47afd7a664ecb7c737341cac7c005e403c0b569e
Author: Stephen Mallette 
Date:   2017-06-18T18:25:15Z

TINKERPOP-1445 Add ellipses for long property values




> Large nested VertexProperties and Properties do not get printed well
> 
>
> Key: TINKERPOP-1445
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1445
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.2
>Reporter: Kevin Gallardo
>Priority: Minor
>
> {code}
> gremlin> m = ['hello':'world', 'helo':'fromtheotherside']
> ==>hello=world
> ==>helo=fromtheotherside
> gremlin> graph.traversal().E().next().property('longMap', m)
> ==>p[longMap->{hello=world, helo=f]
> {code}
> Maybe the printing could be improved just to at least inform that there's 
> more in the value with a {{...}} or {{\[...\]}} for example.
> It seems to be the {{substring()}} call in 
> [propertyString|https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/StringFactory.java#L113].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)