[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

2017-10-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191289#comment-16191289
 ] 

ASF GitHub Bot commented on TINKERPOP-1795:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/726


> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Assignee: Marko A. Rodriguez
>Priority: Minor
> Fix For: 3.2.7
>
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

2017-10-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191228#comment-16191228
 ] 

ASF GitHub Bot commented on TINKERPOP-1795:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/726
  
VOTE: +1


> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Assignee: Marko A. Rodriguez
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

2017-10-04 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191088#comment-16191088
 ] 

ASF GitHub Bot commented on TINKERPOP-1795:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/726
  
All tests pass with `docker/build.sh -t -n -i`

VOTE +1


> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Assignee: Marko A. Rodriguez
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

2017-10-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188875#comment-16188875
 ] 

ASF GitHub Bot commented on TINKERPOP-1795:
---

GitHub user okram opened a pull request:

https://github.com/apache/tinkerpop/pull/726

TINKERPOP-1795: Getting Lambda comparator message for .profile() step

https://issues.apache.org/jira/browse/TINKERPOP-1795

Some objects are hard to check for "lambdaness" and require a `toString()` 
analysis. We checked for `@` but that doesn't work for named steps within 
`order()` (when using `profile()`). That is, its error prone. I came up with a 
new way to check for lambdas that works for Java, Groovy, and Python/Jython. 

@spmallette -- can you please verify that a "toString()" of a lambda in C# 
will hold as well for the pattern.

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1795

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #726


commit beae74c43505d1f7732f92a500dc58fc4b142af1
Author: Marko A. Rodriguez 
Date:   2017-10-02T21:23:33Z

fixed a bug in LambdaRestrictionStrategy where named @ steps were 
considered lambda. Came up with a different way to check lambdas in 
.toString(). Works for Groovy, Java, and Python.




> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Assignee: Marko A. Rodriguez
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

2017-10-02 Thread Marko A. Rodriguez (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188818#comment-16188818
 ] 

Marko A. Rodriguez commented on TINKERPOP-1795:
---

I was able to reproduce this with TinkerGraph.

{code}
gremlin> 
gremlin> g = TinkerGraph.open().traversal()
==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
gremlin> g = g.withStrategies(LambdaRetrictionStrategy.instance())
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
The provided step contains a lambda comparator: 
OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
Type ':help' or ':h' for help.
Display stack trace? [yN]
{code}

> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1795) Getting Lambda comparator message for .profile() step

2017-10-02 Thread Robert Dale (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188720#comment-16188720
 ] 

Robert Dale commented on TINKERPOP-1795:


What graph is this on? Couldn't reproduce on TinkerGraph...

{noformat}
gremlin> 
g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
==>Traversal Metrics
Step   Count  
Traversers   Time (ms)% Dur
=
TinkerGraphStep(vertex,[~label.eq(Question), qu... 1
   1   0.050 7.36
VertexStep(IN,[has_question],vertex)   1
   1   0.058 8.57
OrderGlobalStep([[[VertexStep(IN,[reviewed],edg... 1
   1   0.57384.07
  VertexStep(IN,[reviewed],edge)   1
   1   0.016
  PropertiesStep([rating],value)   1
   1   0.384
  MeanGlobalStep   1
   1   0.083
>TOTAL -
   -   0.681-
{noformat}


> Getting Lambda  comparator message for .profile() step
> --
>
> Key: TINKERPOP-1795
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1795
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Shaunak Das
>Priority: Minor
>
> Ran into this message when adding a .profile() step, even though Gremlin 
> query does not have any lambda steps:
> {code}
> gremlin> 
> g.V().has("Question","questionType","yes/no").in("has_question").order().by(inE("reviewed").values("rating").mean()).profile()
> The provided step contains a lambda comparator: 
> OrderGlobalStep([[[VertexStep(IN,[reviewed],edge), 
> PropertiesStep([rating],value), MeanGlobalStep@[~gremlin.profile]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)