[jira] [Commented] (TINKERPOP-1893) AddV(string label) does not add label

[Florian Hockmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370518#comment-16370518
 ] 

Florian Hockmann commented on TINKERPOP-1893:
-

Thanks for the explanation, Stephen!

I just looked in the changelog for 3.3.1 and forgot to also look into that of 
3.2.7 :(

So it looks like we can close this as a duplicate of TINKERPOP-1789.

> AddV(string label) does not add label
> -
>
> Key: TINKERPOP-1893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1893
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.2.7, 3.3.1
> Environment: Windows, IIS, docker
>Reporter: Klaus Stephan
>Assignee: Florian Hockmann
>Priority: Major
> Attachments: image-2018-02-19-15-45-22-135.png, 
> image-2018-02-19-15-45-33-986.png, image-2018-02-19-15-45-46-671.png
>
>
> public GraphTraversal AddV(string label) does not add a label 
> to the vertex.
> Can someone please check this?
> Is there a workaround to set the label until the next build? (I am fairly new 
> to gremlin)
> I tried this on 3.3.2-rc1 and 3.2.8-rc1 (the majors don't work for me because 
> of TINKERPOP-1880)
> I use [https://hub.docker.com/r/bricaud/gremlin-server/] for testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1893) AddV(string label) does not add label

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370510#comment-16370510
 ] 

stephen mallette commented on TINKERPOP-1893:
-

It took some research but there was an insanely bad bug in 3.2.5/3.3.0 where 
"reference" elements didn't have their labels being set. I think it was 
overlooked because we were still defaulting to "detached" elements at the time, 
but when "reference" elements went mainstream the problem was realized. The fix 
came in 3.2.7/3.3.1 - you can see the note in the 3.2.7 changelog:

https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc#tinkerpop-327-release-date-december-17-2017

> ReferenceVertex was missing its label() string. ReferenceElement now supports 
> all label handling.

Just upgrade the server from 3.3.0 and i think it should work.

> AddV(string label) does not add label
> -
>
> Key: TINKERPOP-1893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1893
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.2.7, 3.3.1
> Environment: Windows, IIS, docker
>Reporter: Klaus Stephan
>Assignee: Florian Hockmann
>Priority: Major
> Attachments: image-2018-02-19-15-45-22-135.png, 
> image-2018-02-19-15-45-33-986.png, image-2018-02-19-15-45-46-671.png
>
>
> public GraphTraversal AddV(string label) does not add a label 
> to the vertex.
> Can someone please check this?
> Is there a workaround to set the label until the next build? (I am fairly new 
> to gremlin)
> I tried this on 3.3.2-rc1 and 3.2.8-rc1 (the majors don't work for me because 
> of TINKERPOP-1880)
> I use [https://hub.docker.com/r/bricaud/gremlin-server/] for testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1893) AddV(string label) does not add label

[Florian Hockmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370467#comment-16370467
 ] 

Florian Hockmann commented on TINKERPOP-1893:
-

I just reproduced the issue with Gremlin.Net 3.3.2-rc1 and Gremlin Server 3.3.0 
from [the Docker image you 
mentioned|https://hub.docker.com/r/bricaud/gremlin-server/]. However, there is 
nothing wrong with the {{AddV}} step of Gremlin.Net. Instead, it turned out 
that the label simply isn't returned as part of the vertex from the server with 
this configuration, but it will be added to the created vertex.
 When I modified your fetch query to {{g.V().Label().ToList()}}, then I got a 
list of vertex labels that simply contained the label I previously added with 
{{AddV}}.

To be honest, I don't know why this occurs only with these versions, but not 
with the code we currently have in {{master}} as in both cases GraphSON 3 
should be used. Maybe someone else with more knowledge of GraphSON and 
TinkerPop I/O with the Gremlin Server could shed some light on this? 
[~spmallette] perhaps?

> AddV(string label) does not add label
> -
>
> Key: TINKERPOP-1893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1893
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.2.7, 3.3.1
> Environment: Windows, IIS, docker
>Reporter: Klaus Stephan
>Assignee: Florian Hockmann
>Priority: Major
> Attachments: image-2018-02-19-15-45-22-135.png, 
> image-2018-02-19-15-45-33-986.png, image-2018-02-19-15-45-46-671.png
>
>
> public GraphTraversal AddV(string label) does not add a label 
> to the vertex.
> Can someone please check this?
> Is there a workaround to set the label until the next build? (I am fairly new 
> to gremlin)
> I tried this on 3.3.2-rc1 and 3.2.8-rc1 (the majors don't work for me because 
> of TINKERPOP-1880)
> I use [https://hub.docker.com/r/bricaud/gremlin-server/] for testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1893) AddV(string label) does not add label

[Florian Hockmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369454#comment-16369454
 ] 

Florian Hockmann commented on TINKERPOP-1893:
-

What you're doing looks correct (although converting {{DateTime}} into an 
{{int}} and then a {{string}} is a bit strange, the recommended way would be to 
use {{DateTimeOffset}} which will be serialized automatically by Gremlin.Net, 
but that's unrelated to your problem).

I tried to reproduce this with a simple unit test on {{master}} that basically 
does the same as what you showed in your screen shots:
{code:java}
[Fact]
public void AddLabelTest()
{
var graph = new Graph();
    var connection = _connectionFactory.CreateRemoteConnection();
var g = graph.Traversal().WithRemote(connection);

try
{
var vertices = g.AddV("someLabel").Property("name", 
"someName").ToList();

Assert.Equal("someLabel", vertices.First().Label);
Assert.Equal(1, g.V().Has("someLabel", "name", 
"someName").Count().Next());
Assert.Equal("someLabel", g.V().Has("someLabel", "name", 
"someName").ToList().First().Label);
}
finally
{
g.V().Has("someLabel", "name", "someName").Drop().Iterate();
}
}{code}
but that ran successfully. Next step will be to check with the pre-release 
NuGet packages and the Docker image that you used.

If you want to help us finding the cause of this, then you can check whether 
this also occurs with the latest version of Gremlin Server which you can 
[download as a zip 
archive|https://www.apache.org/dyn/closer.lua/tinkerpop/3.3.1/apache-tinkerpop-gremlin-server-3.3.1-bin.zip].

In the meantime, you should be able to set the label on vertices with another 
overload of {{AddV}}:
{code:java}
g.AddV(T.label, "someLabel").Property("name", "someName").Iterate();
{code}
This overload was removed in TinkerPop 3.3.0 as the recommend way to set the 
label is the one that you tried to use, so you can only use it with version < 
3.3.0. Would be good to hear if at least that works for you.

> AddV(string label) does not add label
> -
>
> Key: TINKERPOP-1893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1893
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.2.7, 3.3.1
> Environment: Windows, IIS, docker
>Reporter: Klaus Stephan
>Assignee: Florian Hockmann
>Priority: Major
> Attachments: image-2018-02-19-15-45-22-135.png, 
> image-2018-02-19-15-45-33-986.png, image-2018-02-19-15-45-46-671.png
>
>
> public GraphTraversal AddV(string label) does not add a label 
> to the vertex.
> Can someone please check this?
> Is there a workaround to set the label until the next build? (I am fairly new 
> to gremlin)
> I tried this on 3.3.2-rc1 and 3.2.8-rc1 (the majors don't work for me because 
> of TINKERPOP-1880)
> I use [https://hub.docker.com/r/bricaud/gremlin-server/] for testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1893) AddV(string label) does not add label

[Klaus Stephan (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369201#comment-16369201
 ] 

Klaus Stephan commented on TINKERPOP-1893:
--

!image-2018-02-19-15-45-22-135.png!

!image-2018-02-19-15-45-46-671.png!

 

The functions are inside a class that wraps the initialization of the gremlin 
connection:

 public class GremlinDataLayer
    {
    protected GremlinServer server \{ get; }
    protected IGremlinClient client \{ get; }
    protected Graph graph \{ get; }
    protected GraphTraversalSource g \{ get; }

    public GremlinDataLayer()
    {
    server = new GremlinServer("localhost", 32768);
    client = new GremlinClient(server);
    graph = new Graph();
    g = graph.Traversal().WithRemote(new 
DriverRemoteConnection(client));
    }

This is my class to interact with the gremlin-server.

 

> AddV(string label) does not add label
> -
>
> Key: TINKERPOP-1893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1893
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.2.7, 3.3.1
> Environment: Windows, IIS, docker
>Reporter: Klaus Stephan
>Assignee: Florian Hockmann
>Priority: Major
> Attachments: image-2018-02-19-15-45-22-135.png, 
> image-2018-02-19-15-45-33-986.png, image-2018-02-19-15-45-46-671.png
>
>
> public GraphTraversal AddV(string label) does not add a label 
> to the vertex.
> Can someone please check this?
> Is there a workaround to set the label until the next build? (I am fairly new 
> to gremlin)
> I tried this on 3.3.2-rc1 and 3.2.8-rc1 (the majors don't work for me because 
> of TINKERPOP-1880)
> I use [https://hub.docker.com/r/bricaud/gremlin-server/] for testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1893) AddV(string label) does not add label

[Florian Hockmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369185#comment-16369185
 ] 

Florian Hockmann commented on TINKERPOP-1893:
-

{quote}I get a vertex without a label
{quote}
How did you verify this?

A code snippet that shows how you are creating the vertex would also be helpful 
here.

> AddV(string label) does not add label
> -
>
> Key: TINKERPOP-1893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1893
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.2.7, 3.3.1
> Environment: Windows, IIS, docker
>Reporter: Klaus Stephan
>Assignee: Florian Hockmann
>Priority: Major
>
> public GraphTraversal AddV(string label) does not add a label 
> to the vertex.
> Can someone please check this?
> Is there a workaround to set the label until the next build? (I am fairly new 
> to gremlin)
> I tried this on 3.3.2-rc1 and 3.2.8-rc1 (the majors don't work for me because 
> of TINKERPOP-1880)
> I use [https://hub.docker.com/r/bricaud/gremlin-server/] for testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1893) AddV(string label) does not add label

[Florian Hockmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369144#comment-16369144
 ] 

Florian Hockmann commented on TINKERPOP-1893:
-

{{AddV}} is a step that adds a new vertex to the graph and not a label to an 
existing vertex. See the reference docs for more information: 
[http://tinkerpop.apache.org/docs/current/reference/#addvertex-step]

You can't change vertex labels of an existing vertex in TinkerPop. Instead, you 
have to set them when you create the vertex (with the {{AddV}} step).

I'm closing this one as it isn't a bug, but feel free to re-open in case you 
meant something else.

> AddV(string label) does not add label
> -
>
> Key: TINKERPOP-1893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1893
> Project: TinkerPop
>  Issue Type: Bug
>  Components: dotnet
>Affects Versions: 3.2.7, 3.3.1
> Environment: Windows, IIS, docker
>Reporter: Klaus Stephan
>Assignee: Florian Hockmann
>Priority: Major
>
> public GraphTraversal AddV(string label) does not add a label 
> to the vertex.
> Can someone please check this?
> Is there a workaround to set the label until the next build? (I am fairly new 
> to gremlin)
> I tried this on 3.3.2-rc1 and 3.2.8-rc1 (the majors don't work for me because 
> of TINKERPOP-1880)
> I use [https://hub.docker.com/r/bricaud/gremlin-server/] for testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)