[jira] [Commented] (TINKERPOP-1992) count has negative time in profile

2019-02-28 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780610#comment-16780610
 ] 

ASF GitHub Bot commented on TINKERPOP-1992:
---

spmallette commented on pull request #1069: TINKERPOP-1992 count has negative 
time in profile
URL: https://github.com/apache/tinkerpop/pull/1069
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> count has negative time in profile
> --
>
> Key: TINKERPOP-1992
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1992
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Robert Dale
>Priority: Minor
>
> {noformat}
> gremlin> g.V().group().by().by(bothE().count()).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 19172  
>  19172   4.957 5.24
> GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1  
>  1  89.69694.76
>   VertexStep(BOTH,edge)84812  
>  84812  50.723
>   CountGlobalStep  19172  
>  19172 -39.649
> >TOTAL -  
>  -  94.654-
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1992) count has negative time in profile

2019-02-21 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774419#comment-16774419
 ] 

ASF GitHub Bot commented on TINKERPOP-1992:
---

spmallette commented on pull request #1069: TINKERPOP-1992 count has negative 
time in profile
URL: https://github.com/apache/tinkerpop/pull/1069
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-1992
   
   Not sure if this the best way to do this but basically introduced an 
interface called `ProfilingAware` that makes it so that `ProfileStrategy` can 
notify that step that "profiling" is happening so that the step has a chance to 
get its life in order. For this particular problem, that meant that `group()` 
needed to reset its reducing barrier step (if present) for its value traversal 
(i.e. second `by()` modulator) so that it could internally start the profile 
timer (which doesn't happen otherwise. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> count has negative time in profile
> --
>
> Key: TINKERPOP-1992
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1992
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Robert Dale
>Priority: Minor
>
> {noformat}
> gremlin> g.V().group().by().by(bothE().count()).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 19172  
>  19172   4.957 5.24
> GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1  
>  1  89.69694.76
>   VertexStep(BOTH,edge)84812  
>  84812  50.723
>   CountGlobalStep  19172  
>  19172 -39.649
> >TOTAL -  
>  -  94.654-
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1992) count has negative time in profile

2018-07-27 Thread stephen mallette (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560032#comment-16560032
 ] 

stephen mallette commented on TINKERPOP-1992:
-

Identified the problem, but not sure how to fix it - note that in {{GroupStep}} 
we grab the first barrier:

https://github.com/apache/tinkerpop/blob/9ab5efa6772bb831238f6c9a4e46fc925a45ddaa/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java#L73

and we iterate that:

https://github.com/apache/tinkerpop/blob/9ab5efa6772bb831238f6c9a4e46fc925a45ddaa/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java#L89

and therefore if a {{ProfileStep}} is present then we don't start its timer. as 
a result, when the traversal timers get normalized you end up with a negative 
value.


> count has negative time in profile
> --
>
> Key: TINKERPOP-1992
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1992
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Robert Dale
>Priority: Minor
>
> {noformat}
> gremlin> g.V().group().by().by(bothE().count()).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 19172  
>  19172   4.957 5.24
> GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1  
>  1  89.69694.76
>   VertexStep(BOTH,edge)84812  
>  84812  50.723
>   CountGlobalStep  19172  
>  19172 -39.649
> >TOTAL -  
>  -  94.654-
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1992) count has negative time in profile

2018-07-25 Thread stephen mallette (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555992#comment-16555992
 ] 

stephen mallette commented on TINKERPOP-1992:
-

for some reason, that makes me happier - in my head that might make it easier 
to isolate?

> count has negative time in profile
> --
>
> Key: TINKERPOP-1992
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1992
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Robert Dale
>Priority: Minor
>
> {noformat}
> gremlin> g.V().group().by().by(bothE().count()).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 19172  
>  19172   4.957 5.24
> GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1  
>  1  89.69694.76
>   VertexStep(BOTH,edge)84812  
>  84812  50.723
>   CountGlobalStep  19172  
>  19172 -39.649
> >TOTAL -  
>  -  94.654-
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1992) count has negative time in profile

2018-07-25 Thread Daniel Kuppitz (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555871#comment-16555871
 ] 

Daniel Kuppitz commented on TINKERPOP-1992:
---

It actually happens to any reducing step in {{group()}}'s value selector.

{code}
gremlin> g.V().group().by().by(bothE().fold()).profile()
==>Traversal Metrics
Step   Count  
Traversers   Time (ms)% Dur
=
TinkerGraphStep(vertex,[]) 6
   6   0.05313.94
GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1
   1   0.32986.06
  VertexStep(BOTH,edge)   12
  12   0.084
  FoldStep 6
   6  -0.063
>TOTAL -
   -   0.383-
gremlin> g.V().group().by().by(bothE().values('weight').sum()).profile()
==>Traversal Metrics
Step   Count  
Traversers   Time (ms)% Dur
=
TinkerGraphStep(vertex,[]) 6
   6   0.05810.54
GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1
   1   0.49289.46
  VertexStep(BOTH,edge)   12
  12   0.104
  PropertiesStep([weight],value)  12
  12   0.086
  SumGlobalStep6
   6  -0.160
>TOTAL -
   -   0.550-
{code}

> count has negative time in profile
> --
>
> Key: TINKERPOP-1992
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1992
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Robert Dale
>Priority: Minor
>
> {noformat}
> gremlin> g.V().group().by().by(bothE().count()).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 19172  
>  19172   4.957 5.24
> GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1  
>  1  89.69694.76
>   VertexStep(BOTH,edge)84812  
>  84812  50.723
>   CountGlobalStep  19172  
>  19172 -39.649
> >TOTAL -  
>  -  94.654-
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1992) count has negative time in profile

2018-06-22 Thread Robert Dale (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520793#comment-16520793
 ] 

Robert Dale commented on TINKERPOP-1992:


Tested on TinkerGraph

> count has negative time in profile
> --
>
> Key: TINKERPOP-1992
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1992
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Robert Dale
>Priority: Minor
>
> {noformat}
> gremlin> g.V().group().by().by(bothE().count()).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 19172  
>  19172   4.957 5.24
> GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1  
>  1  89.69694.76
>   VertexStep(BOTH,edge)84812  
>  84812  50.723
>   CountGlobalStep  19172  
>  19172 -39.649
> >TOTAL -  
>  -  94.654-
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1992) count has negative time in profile

2018-06-22 Thread Robert Dale (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520789#comment-16520789
 ] 

Robert Dale commented on TINKERPOP-1992:


I've tried other variants of count() and groupCount(). It seems to be this 
specific usage only.

> count has negative time in profile
> --
>
> Key: TINKERPOP-1992
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1992
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.3, 3.2.9
>Reporter: Robert Dale
>Priority: Minor
>
> {noformat}
> gremlin> g.V().group().by().by(bothE().count()).profile()
> ==>Traversal Metrics
> Step   Count  
> Traversers   Time (ms)% Dur
> =
> TinkerGraphStep(vertex,[]) 19172  
>  19172   4.957 5.24
> GroupStep(identity,[VertexStep(BOTH,edge), Prof... 1  
>  1  89.69694.76
>   VertexStep(BOTH,edge)84812  
>  84812  50.723
>   CountGlobalStep  19172  
>  19172 -39.649
> >TOTAL -  
>  -  94.654-
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)