[jira] [Commented] (TINKERPOP-2182) Remove gperfutils from Gremlin Console
[
https://issues.apache.org/jira/browse/TINKERPOP-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814426#comment-16814426
]
ASF GitHub Bot commented on TINKERPOP-2182:
---
spmallette commented on pull request #1090: TINKERPOP-2182 Removed gperfutils
dependencies in Console
URL: https://github.com/apache/tinkerpop/pull/1090
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove gperfutils from Gremlin Console
> --
>
> Key: TINKERPOP-2182
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2182
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.3.5
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
>
> We long ago stopped espousing the use of the groovy benchmarks/performance
> libs in Gremlin Console. Not sure why they are still packaged in there with
> the distribution except that the utilities plugin references the classes in
> its auto-import. I also think they are somewhat bound to Groovy 2.4.x and
> TinkerPop 3.4.x is on Groovy 2.5.x. I'd say it's best to remove them from
> both {{tp33}} and {{master}} at this point.
> Marking this with the "breaking" label because it means uses who might oddly
> depend on {{gremlin-console}} for this dependency will need to add it
> themselves now and not rely on it transitively. Highly unlikely I would
> imagine. It is also breaking if folks somehow actually use these classes in
> their use of the console.The workaround to bring these libs back in is pretty
> simple - just use the {{:install}} command and do some imports. This can be
> documented in the upgrade docs. Taken all together, this seems like a low
> risk breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2182) Remove gperfutils from Gremlin Console
[
https://issues.apache.org/jira/browse/TINKERPOP-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809177#comment-16809177
]
ASF GitHub Bot commented on TINKERPOP-2182:
---
spmallette commented on pull request #1090: TINKERPOP-2182 Removed gperfutils
dependencies in Console
URL: https://github.com/apache/tinkerpop/pull/1090
https://issues.apache.org/jira/browse/TINKERPOP-2182
Pretty straightforward. Made sure that the upgrade docs explained how to
continue to use this feature if that is needed.
All tests pass with `docker/build.sh -t -i`
VOTE +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove gperfutils from Gremlin Console
> --
>
> Key: TINKERPOP-2182
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2182
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
>Affects Versions: 3.3.5
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Minor
> Labels: breaking
>
> We long ago stopped espousing the use of the groovy benchmarks/performance
> libs in Gremlin Console. Not sure why they are still packaged in there with
> the distribution except that the utilities plugin references the classes in
> its auto-import. I also think they are somewhat bound to Groovy 2.4.x and
> TinkerPop 3.4.x is on Groovy 2.5.x. I'd say it's best to remove them from
> both {{tp33}} and {{master}} at this point.
> Marking this with the "breaking" label because it means uses who might oddly
> depend on {{gremlin-console}} for this dependency will need to add it
> themselves now and not rely on it transitively. Highly unlikely I would
> imagine. It is also breaking if folks somehow actually use these classes in
> their use of the console.The workaround to bring these libs back in is pretty
> simple - just use the {{:install}} command and do some imports. This can be
> documented in the upgrade docs. Taken all together, this seems like a low
> risk breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
