[jira] [Commented] (TINKERPOP-2804) gherkin feature files should be on the classpath

2022-12-05 Thread Stephen Mallette (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643474#comment-17643474
 ] 

Stephen Mallette commented on TINKERPOP-2804:
-

added: 
https://github.com/apache/tinkerpop/commit/b85bf4e26f9fc792aec31c9bc1e317635c0ad7d7
 after merge master to deal with Edge.feature file that was only in that branch.

> gherkin feature files should be on the classpath
> 
>
> Key: TINKERPOP-2804
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2804
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: test-suite
>Affects Versions: 3.6.0
>Reporter: pieter martin
>Priority: Minor
>
> Currently implementers needs to access the gherkin features on disc.
> It should be available on the classpath.
> i.e. gremlin-test/features should be inside the jar
> This will allow,
> @CucumberOptions(features = { "classpath:/gremlin-test/features" })



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-2804) gherkin feature files should be on the classpath

2022-12-05 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643457#comment-17643457
 ] 

ASF GitHub Bot commented on TINKERPOP-2804:
---

spmallette merged PR #1878:
URL: https://github.com/apache/tinkerpop/pull/1878




> gherkin feature files should be on the classpath
> 
>
> Key: TINKERPOP-2804
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2804
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: test-suite
>Affects Versions: 3.6.0
>Reporter: pieter martin
>Priority: Minor
>
> Currently implementers needs to access the gherkin features on disc.
> It should be available on the classpath.
> i.e. gremlin-test/features should be inside the jar
> This will allow,
> @CucumberOptions(features = { "classpath:/gremlin-test/features" })



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-2804) gherkin feature files should be on the classpath

2022-11-29 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640989#comment-17640989
 ] 

ASF GitHub Bot commented on TINKERPOP-2804:
---

vkagamlyk commented on PR #1878:
URL: https://github.com/apache/tinkerpop/pull/1878#issuecomment-1331447845

   VOTE +1




> gherkin feature files should be on the classpath
> 
>
> Key: TINKERPOP-2804
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2804
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: test-suite
>Affects Versions: 3.6.0
>Reporter: pieter martin
>Priority: Minor
>
> Currently implementers needs to access the gherkin features on disc.
> It should be available on the classpath.
> i.e. gremlin-test/features should be inside the jar
> This will allow,
> @CucumberOptions(features = { "classpath:/gremlin-test/features" })



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-2804) gherkin feature files should be on the classpath

2022-11-29 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640981#comment-17640981
 ] 

ASF GitHub Bot commented on TINKERPOP-2804:
---

codecov-commenter commented on PR #1878:
URL: https://github.com/apache/tinkerpop/pull/1878#issuecomment-1331425983

   # 
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#1878](https://codecov.io/gh/apache/tinkerpop/pull/1878?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (f394d8f) into 
[3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/053064b433b8fe55415c018773ce95da600663a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (053064b) will **decrease** coverage by `5.39%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@  Coverage Diff  @@
   ## 3.6-dev#1878  +/-   ##
   =
   - Coverage  69.46%   64.06%   -5.40% 
   =
 Files875   23 -852 
 Lines  41772 3679   -38093 
 Branches56270-5627 
   =
   - Hits   29016 2357   -26659 
   + Misses 10770 1154-9616 
   + Partials1986  168-1818 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/tinkerpop/pull/1878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...pop/gremlin/driver/message/ResponseStatusCode.java](https://codecov.io/gh/apache/tinkerpop/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9tZXNzYWdlL1Jlc3BvbnNlU3RhdHVzQ29kZS5qYXZh)
 | | |
   | 
[...ure/util/star/StarGraphGraphSONSerializerV3d0.java](https://codecov.io/gh/apache/tinkerpop/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9zdGFyL1N0YXJHcmFwaEdyYXBoU09OU2VyaWFsaXplclYzZDAuamF2YQ==)
 | | |
   | 
[.../server/handler/HttpBasicAuthorizationHandler.java](https://codecov.io/gh/apache/tinkerpop/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9oYW5kbGVyL0h0dHBCYXNpY0F1dGhvcml6YXRpb25IYW5kbGVyLmphdmE=)
 | | |
   | 
[...org/apache/tinkerpop/gremlin/structure/Column.java](https://codecov.io/gh/apache/tinkerpop/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvQ29sdW1uLmphdmE=)
 | | |
   | 
[...kerpop/gremlin/jsr223/DefaultImportCustomizer.java](https://codecov.io/gh/apache/tinkerpop/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9qc3IyMjMvRGVmYXVsdEltcG9ydEN1c3RvbWl6ZXIuamF2YQ==)
 | | |
   | 
[...n/process/traversal/step/sideEffect/StartStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL3NpZGVFZmZlY3QvU3RhcnRTdGVwLmphdmE=)
 | | |
   | 
[...mlin/process/remote/RemoteConnectionException.java](https://codecov.io/gh/apache/tinkerpop/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3JlbW90ZS9SZW1vdGVDb25uZWN0aW9uRXhjZXB0aW9uLmphdmE=)
 | | |
   | 
[...gremlin/process/traversal/step/GraphComputing.java](https://codecov.io/gh/apache/tinkerpop/pull/1878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_cam

[jira] [Commented] (TINKERPOP-2804) gherkin feature files should be on the classpath

2022-11-29 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640954#comment-17640954
 ] 

ASF GitHub Bot commented on TINKERPOP-2804:
---

vkagamlyk commented on PR #1878:
URL: https://github.com/apache/tinkerpop/pull/1878#issuecomment-1331366804

   .net local test run without docker: `System.IO.DirectoryNotFoundException : 
Could not find a part of the path 
'C:\_Projects\tinkerpop-apache\gremlin-test\features'.`
   because 
https://github.com/apache/tinkerpop/blob/3.6-dev/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs#L385




> gherkin feature files should be on the classpath
> 
>
> Key: TINKERPOP-2804
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2804
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: test-suite
>Affects Versions: 3.6.0
>Reporter: pieter martin
>Priority: Minor
>
> Currently implementers needs to access the gherkin features on disc.
> It should be available on the classpath.
> i.e. gremlin-test/features should be inside the jar
> This will allow,
> @CucumberOptions(features = { "classpath:/gremlin-test/features" })



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-2804) gherkin feature files should be on the classpath

2022-11-29 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640932#comment-17640932
 ] 

ASF GitHub Bot commented on TINKERPOP-2804:
---

spmallette opened a new pull request, #1878:
URL: https://github.com/apache/tinkerpop/pull/1878

   https://issues.apache.org/jira/browse/TINKERPOP-2804
   
   Taking this approach makes it easier for providers to reference the files 
from the classpath, otherwise they likely need to have copies of them on the 
local file system which isn't so good. This is a breaking change but it only 
affects providers. They will have a minor adjustment to make to their test 
infrastructure on upgrade.
   
   VOTE +1




> gherkin feature files should be on the classpath
> 
>
> Key: TINKERPOP-2804
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2804
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: test-suite
>Affects Versions: 3.6.0
>Reporter: pieter martin
>Priority: Minor
>
> Currently implementers needs to access the gherkin features on disc.
> It should be available on the classpath.
> i.e. gremlin-test/features should be inside the jar
> This will allow,
> @CucumberOptions(features = { "classpath:/gremlin-test/features" })



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-2804) gherkin feature files should be on the classpath

2022-10-30 Thread pieter martin (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626188#comment-17626188
 ] 

pieter martin commented on TINKERPOP-2804:
--

The io files need to be available on the test scoped classpath. Currently they 
are referring to *../data/*


{code:java}
java.lang.RuntimeException: java.lang.IllegalStateException: 
../data/tinkerpop-modern.kryo does not exist

at 
org.apache.tinkerpop.gremlin.features.StepDefinition.assertThatNoErrorWasThrown(StepDefinition.java:405)
{code}


> gherkin feature files should be on the classpath
> 
>
> Key: TINKERPOP-2804
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2804
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: test-suite
>Affects Versions: 3.6.0
>Reporter: pieter martin
>Priority: Minor
>
> Currently implementers needs to access the gherkin features on disc.
> It should be available on the classpath.
> i.e. gremlin-test/features should be inside the jar
> This will allow,
> @CucumberOptions(features = { "classpath:/gremlin-test/features" })



--
This message was sent by Atlassian Jira
(v8.20.10#820010)