[jira] [Commented] (TINKERPOP-3031) Bad translation for g.tx()

2024-02-16 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817967#comment-17817967
 ] 

ASF GitHub Bot commented on TINKERPOP-3031:
---

spmallette merged PR #2488:
URL: https://github.com/apache/tinkerpop/pull/2488




> Bad translation for g.tx()
> --
>
> Key: TINKERPOP-3031
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3031
> Project: TinkerPop
>  Issue Type: Bug
>  Components: translator
>Affects Versions: 3.6.6
>Reporter: Stephen Mallette
>Priority: Critical
>
> Not sure if other translators are affected but {{GroovyTranslator}} doesn't 
> translate {{tx()}} properly:
> {code}
> gremlin> 
> GroovyTranslator.of('g').translate(org.apache.tinkerpop.gremlin.process.traversal.GraphOp.TX_ROLLBACK.bytecode).script
> ==>g.tx("rollback")
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-3031) Bad translation for g.tx()

2024-02-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817491#comment-17817491
 ] 

ASF GitHub Bot commented on TINKERPOP-3031:
---

Cole-Greer commented on PR #2488:
URL: https://github.com/apache/tinkerpop/pull/2488#issuecomment-1944399941

   VOTE +1




> Bad translation for g.tx()
> --
>
> Key: TINKERPOP-3031
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3031
> Project: TinkerPop
>  Issue Type: Bug
>  Components: translator
>Affects Versions: 3.6.6
>Reporter: Stephen Mallette
>Priority: Critical
>
> Not sure if other translators are affected but {{GroovyTranslator}} doesn't 
> translate {{tx()}} properly:
> {code}
> gremlin> 
> GroovyTranslator.of('g').translate(org.apache.tinkerpop.gremlin.process.traversal.GraphOp.TX_ROLLBACK.bytecode).script
> ==>g.tx("rollback")
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-3031) Bad translation for g.tx()

2024-02-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817490#comment-17817490
 ] 

ASF GitHub Bot commented on TINKERPOP-3031:
---

vkagamlyk commented on PR #2488:
URL: https://github.com/apache/tinkerpop/pull/2488#issuecomment-1944396448

   VOTE +1




> Bad translation for g.tx()
> --
>
> Key: TINKERPOP-3031
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3031
> Project: TinkerPop
>  Issue Type: Bug
>  Components: translator
>Affects Versions: 3.6.6
>Reporter: Stephen Mallette
>Priority: Critical
>
> Not sure if other translators are affected but {{GroovyTranslator}} doesn't 
> translate {{tx()}} properly:
> {code}
> gremlin> 
> GroovyTranslator.of('g').translate(org.apache.tinkerpop.gremlin.process.traversal.GraphOp.TX_ROLLBACK.bytecode).script
> ==>g.tx("rollback")
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-3031) Bad translation for g.tx()

2024-02-14 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817487#comment-17817487
 ] 

ASF GitHub Bot commented on TINKERPOP-3031:
---

xiazcy commented on PR #2488:
URL: https://github.com/apache/tinkerpop/pull/2488#issuecomment-1944391281

   VOTE +1




> Bad translation for g.tx()
> --
>
> Key: TINKERPOP-3031
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3031
> Project: TinkerPop
>  Issue Type: Bug
>  Components: translator
>Affects Versions: 3.6.6
>Reporter: Stephen Mallette
>Priority: Critical
>
> Not sure if other translators are affected but {{GroovyTranslator}} doesn't 
> translate {{tx()}} properly:
> {code}
> gremlin> 
> GroovyTranslator.of('g').translate(org.apache.tinkerpop.gremlin.process.traversal.GraphOp.TX_ROLLBACK.bytecode).script
> ==>g.tx("rollback")
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-3031) Bad translation for g.tx()

2024-02-13 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817114#comment-17817114
 ] 

ASF GitHub Bot commented on TINKERPOP-3031:
---

codecov-commenter commented on PR #2488:
URL: https://github.com/apache/tinkerpop/pull/2488#issuecomment-1942184344

   ## 
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2488?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`4e8a8f9`)](https://app.codecov.io/gh/apache/tinkerpop/commit/4e8a8f95fa5237bca98de9b7b65a3a056ee44067?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 75.14% compared to head 
[(`d4892ad`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2488?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 75.14%.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff @@
   ## 3.6-dev#2488   +/-   ##
   ==
 Coverage  75.14%   75.14%   
   - Complexity 1234412345+1 
   ==
 Files   1058 1058   
 Lines  6361063628   +18 
 Branches6962 6967+5 
   ==
   + Hits   4779847815   +17 
   - Misses 1322613231+5 
   + Partials2586 2582-4 
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2488?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   




> Bad translation for g.tx()
> --
>
> Key: TINKERPOP-3031
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3031
> Project: TinkerPop
>  Issue Type: Bug
>  Components: translator
>Affects Versions: 3.6.6
>Reporter: Stephen Mallette
>Priority: Critical
>
> Not sure if other translators are affected but {{GroovyTranslator}} doesn't 
> translate {{tx()}} properly:
> {code}
> gremlin> 
> GroovyTranslator.of('g').translate(org.apache.tinkerpop.gremlin.process.traversal.GraphOp.TX_ROLLBACK.bytecode).script
> ==>g.tx("rollback")
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (TINKERPOP-3031) Bad translation for g.tx()

2024-02-13 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817108#comment-17817108
 ] 

ASF GitHub Bot commented on TINKERPOP-3031:
---

spmallette opened a new pull request, #2488:
URL: https://github.com/apache/tinkerpop/pull/2488

   https://issues.apache.org/jira/browse/TINKERPOP-3031
   
   VOTE +1




> Bad translation for g.tx()
> --
>
> Key: TINKERPOP-3031
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3031
> Project: TinkerPop
>  Issue Type: Bug
>  Components: translator
>Affects Versions: 3.6.6
>Reporter: Stephen Mallette
>Priority: Critical
>
> Not sure if other translators are affected but {{GroovyTranslator}} doesn't 
> translate {{tx()}} properly:
> {code}
> gremlin> 
> GroovyTranslator.of('g').translate(org.apache.tinkerpop.gremlin.process.traversal.GraphOp.TX_ROLLBACK.bytecode).script
> ==>g.tx("rollback")
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)