[jira] [Commented] (TINKERPOP-3054) RequestId serialization broken in Python GLV

2024-02-29 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822230#comment-17822230
 ] 

ASF GitHub Bot commented on TINKERPOP-3054:
---

Cole-Greer merged PR #2494:
URL: https://github.com/apache/tinkerpop/pull/2494




> RequestId serialization broken in Python GLV
> 
>
> Key: TINKERPOP-3054
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3054
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.6.6, 3.7.1
>Reporter: Valentyn Kahamlyk
>Priority: Blocker
>
> `g.with_('requestId', uuid.uuid1()).V().count().toList()`
> failed with error `AttributeError: 'UUID' object has no attribute 'replace'`
> in line 
> `uuid.UUID(request_id) # Checks for proper UUID or else server will return an 
> error.`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3054) RequestId serialization broken in Python GLV

2024-02-29 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1789#comment-1789
 ] 

ASF GitHub Bot commented on TINKERPOP-3054:
---

Cole-Greer commented on PR #2494:
URL: https://github.com/apache/tinkerpop/pull/2494#issuecomment-1971562226

   VOTE +1




> RequestId serialization broken in Python GLV
> 
>
> Key: TINKERPOP-3054
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3054
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.6.6, 3.7.1
>Reporter: Valentyn Kahamlyk
>Priority: Blocker
>
> `g.with_('requestId', uuid.uuid1()).V().count().toList()`
> failed with error `AttributeError: 'UUID' object has no attribute 'replace'`
> in line 
> `uuid.UUID(request_id) # Checks for proper UUID or else server will return an 
> error.`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3054) RequestId serialization broken in Python GLV

2024-02-23 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820247#comment-17820247
 ] 

ASF GitHub Bot commented on TINKERPOP-3054:
---

kenhuuu commented on PR #2494:
URL: https://github.com/apache/tinkerpop/pull/2494#issuecomment-1962184812

   VOTE +1




> RequestId serialization broken in Python GLV
> 
>
> Key: TINKERPOP-3054
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3054
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.6.6, 3.7.1
>Reporter: Valentyn Kahamlyk
>Priority: Blocker
>
> `g.with_('requestId', uuid.uuid1()).V().count().toList()`
> failed with error `AttributeError: 'UUID' object has no attribute 'replace'`
> in line 
> `uuid.UUID(request_id) # Checks for proper UUID or else server will return an 
> error.`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3054) RequestId serialization broken in Python GLV

2024-02-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817563#comment-17817563
 ] 

ASF GitHub Bot commented on TINKERPOP-3054:
---

codecov-commenter commented on PR #2494:
URL: https://github.com/apache/tinkerpop/pull/2494#issuecomment-1945138647

   ## 
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2494?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`c7f3d24`)](https://app.codecov.io/gh/apache/tinkerpop/commit/c7f3d2454a654cea57c2a99077d859b115fec4c3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 75.15% compared to head 
[(`e6be164`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2494?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 75.39%.
   > Report is 8 commits behind head on 3.6-dev.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ## 3.6-dev#2494  +/-   ##
   =
   + Coverage  75.15%   75.39%   +0.23% 
   + Complexity 1235112346   -5 
   =
 Files   1058 1033  -25 
 Lines  6361059838-3772 
 Branches6962 6962  
   =
   - Hits   4780645113-2693 
   + Misses 1322412329 -895 
   + Partials2580 2396 -184 
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2494?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   




> RequestId serialization broken in Python GLV
> 
>
> Key: TINKERPOP-3054
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3054
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.6.6, 3.7.1
>Reporter: Valentyn Kahamlyk
>Priority: Blocker
>
> `g.with_('requestId', uuid.uuid1()).V().count().toList()`
> failed with error `AttributeError: 'UUID' object has no attribute 'replace'`
> in line 
> `uuid.UUID(request_id) # Checks for proper UUID or else server will return an 
> error.`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TINKERPOP-3054) RequestId serialization broken in Python GLV

2024-02-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817556#comment-17817556
 ] 

ASF GitHub Bot commented on TINKERPOP-3054:
---

ryn5 opened a new pull request, #2494:
URL: https://github.com/apache/tinkerpop/pull/2494

   https://issues.apache.org/jira/browse/TINKERPOP-3054
   Error was being caused by uuid constructor/validator receiving `request_id` 
from message as UUID instead of string.  Added str() guard to uuid validation 
and removed the type conversion on deserialization to keep `request_id` 
consistently of type UUID.




> RequestId serialization broken in Python GLV
> 
>
> Key: TINKERPOP-3054
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3054
> Project: TinkerPop
>  Issue Type: Bug
>  Components: python
>Affects Versions: 3.6.6, 3.7.1
>Reporter: Valentyn Kahamlyk
>Priority: Blocker
>
> `g.with_('requestId', uuid.uuid1()).V().count().toList()`
> failed with error `AttributeError: 'UUID' object has no attribute 'replace'`
> in line 
> `uuid.UUID(request_id) # Checks for proper UUID or else server will return an 
> error.`



--
This message was sent by Atlassian Jira
(v8.20.10#820010)