[GitHub] [tinkerpop] heljoyLiu commented on issue #1278: gremlin-python: add 'timeout' argument in client-submit
> Just a comment, I think I have a Jira open on this somewhere but could not
> find it in a quick search. It would be good if the Python client, and for
> that matter any of the GLV clients exposed easy ways to set options like the
> per query timeout. I get fairly regular feedback from TinkerPop users who are
> frustrated that the Java client has features that are enabled by special case
> code that the other GLVs do not yet expose. Per query timeout is probably the
> one that comes up the most but others like sessions (recently added - thank
> you) come up as well.
it's better to give users the same features all GLVs, like API(submit,
submitAsync) , options, thanks.
now, I'm not sure how to set Timeout args for bytecode request, and couldn't
find issue like this.
so, I support timeout in demo graph server as bellow.
```
g.with('scriptEvaluationTimeout', 5000L).V().count()
```
[ Full content available at: https://github.com/apache/tinkerpop/pull/1278 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] heljoyLiu commented on issue #1278: gremlin-python: add 'timeout' argument in client-submit
> Just a comment, I think I have a Jira open on this somewhere but could not
> find it in a quick search. It would be good if the Python client, and for
> that matter any of the GLV clients exposed easy ways to set options like the
> per query timeout. I get fairly regular feedback from TinkerPop users who are
> frustrated that the Java client has features that are enabled by special case
> code that the other GLVs do not yet expose. Per query timeout is probably the
> one that comes up the most but others like sessions (recently added - thank
> you) come up as well.
it's better to give users the same features all GLVs, like API(submit,
submitAsync) , options, thanks.
now, I'm not sure how to set Timeout args for bytecode request, and couldn't
find issue like this.
so, I support timeout in demo graph server as bellow. TBD
```
g.with('scriptEvaluationTimeout', 5000L).V().count()
```
[ Full content available at: https://github.com/apache/tinkerpop/pull/1278 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1280: gremlin-python: fix up serializer out of range of int
Thus far we've forced python users to be explicit and think in java terms, thus:
```python
g.V().has('age', long(851401972585122)).count()
```
but I suppose it's better if this were just handled automatically as it might
yield less confusion and be more pythonic. The test you added here is fine but
please add a test here:
https://github.com/apache/tinkerpop/blob/3.3-dev/gremlin-python/src/main/jython/tests/structure/io/test_graphsonV2d0.py#L306
and here:
https://github.com/apache/tinkerpop/blob/3.3-dev/gremlin-python/src/main/jython/tests/structure/io/test_graphsonV3d0.py#L357
to more directly test GraphSON. Please do not remove the existing tests that
use the old `long()` syntax as I think it's still worth testing that since it's
something we will continue to support. Just add new assertions for your new
logic. I guess it wouldn't hurt to add tests to cover both positive and
negative values in your range.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1280 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Created] (TINKERPOP-2360) failed to deserializer int32 when gremlin-python submit bytecode with a bit int value
Liu Jianping created TINKERPOP-2360:
---
Summary: failed to deserializer int32 when gremlin-python submit
bytecode with a bit int value
Key: TINKERPOP-2360
URL: https://issues.apache.org/jira/browse/TINKERPOP-2360
Project: TinkerPop
Issue Type: Bug
Components: python
Affects Versions: 3.3.4
Reporter: Liu Jianping
python integer support 64bit, but java integer only 32bit in server, so server
may throw deserializer error when get a big integer value from `{{python sdk`}}.
[WARN] AbstractGraphSONMessageSerializerV2d0 - Request
[PooledUnsafeDirectByteBuf(ridx: 307, widx: 307, cap: 341)] could not be
deserialized by
org.apache.tinkerpop.gremlin.driver.ser.AbstractGraphSONMessageSerializerV2d0.[WARN]
AbstractGraphSONMessageSerializerV2d0 - Request
[PooledUnsafeDirectByteBuf(ridx: 307, widx: 307, cap: 341)] could not be
deserialized by
org.apache.tinkerpop.gremlin.driver.ser.AbstractGraphSONMessageSerializerV2d0.org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException:
Could not deserialize the JSON value as required. Nested exception:
org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException: Could not
deserialize the JSON value as required. Nested exception:
org.apache.tinkerpop.shaded.jackson.core.JsonParseException: Numeric value
(851401972585122) out of range of int at [Source: (byte[])"\{"op": "bytecode",
"requestId": {"@type": "g:UUID", "@value":
"17895281-a111-4635-ac50-41ac1771f704"}, "args": \{"gremlin": {"@type":
"g:Bytecode", "@value": {"step": [["V"], ["has", "customer_id", {"@type":
"g:Int32", "@value": 851401972585122}], ["id"]]}}, "aliases": \{"g": "g"}},
"processor": "traversal"}"; line: 1, column: 244] at [Source: (byte[])"\{"op":
"bytecode", "requestId": {"@type": "g:UUID", "@value":
"17895281-a111-4635-ac50-41ac1771f704"}, "args": \{"gremlin": {"@type":
"g:Bytecode", "@value": {"step": [["V"], ["has", "customer_id", {"@type":
"g:Int32", "@value": 851401972585122}], ["id"]]}}, "aliases": \{"g": "g"}},
"processor": "traversal"}"; line: 1, column: 229] at [Source: (byte[])"\{"op":
"bytecode", "requestId": {"@type": "g:UUID", "@value":
"17895281-a111-4635-ac50-41ac1771f704"}, "args": \{"gremlin": {"@type":
"g:Bytecode", "@value": {"step": [["V"], ["has", "customer_id", {"@type":
"g:Int32", "@value": 851401972585122}], ["id"]]}}, "aliases": \{"g": "g"}},
"processor": "traversal"}"; line: 1, column: 229] (through reference chain:
java.util.LinkedHashMap["args"]->java.util.LinkedHashMap["gremlin"]) at
org.apache.tinkerpop.shaded.jackson.databind.JsonMappingException.from(JsonMappingException.java:271)
at
org.apache.tinkerpop.shaded.jackson.databind.DeserializationContext.mappingException(DeserializationContext.java:1718)
at
org.apache.tinkerpop.gremlin.structure.io.graphson.GraphSONTypeDeserializer.deserialize(GraphSONTypeDeserializer.java:194)
at
org.apache.tinkerpop.gremlin.structure.io.graphson.GraphSONTypeDeserializer.deserializeTypedFromAny(GraphSONTypeDeserializer.java:101)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.UntypedObjectDeserializer.deserializeWithType(UntypedObjectDeserializer.java:312)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.MapDeserializer._readAndBindStringKeyMap(MapDeserializer.java:529)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:364)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:29)
at
org.apache.tinkerpop.gremlin.structure.io.graphson.GraphSONTypeDeserializer.deserialize(GraphSONTypeDeserializer.java:219)
at
org.apache.tinkerpop.gremlin.structure.io.graphson.GraphSONTypeDeserializer.deserializeTypedFromAny(GraphSONTypeDeserializer.java:101)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.UntypedObjectDeserializer.deserializeWithType(UntypedObjectDeserializer.java:312)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.MapDeserializer._readAndBindStringKeyMap(MapDeserializer.java:529)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:364)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:29)
at
org.apache.tinkerpop.gremlin.structure.io.graphson.GraphSONTypeDeserializer.deserialize(GraphSONTypeDeserializer.java:212)
at
org.apache.tinkerpop.gremlin.structure.io.graphson.GraphSONTypeDeserializer.deserializeTypedFromObject(GraphSONTypeDeserializer.java:86)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.std.MapDeserializer.deserializeWithType(MapDeserializer.java:400)
at
org.apache.tinkerpop.shaded.jackson.databind.deser.impl.TypeWrappedDeserializer.deserialize(TypeWrappedDeserializer.java:68)
at
[GitHub] [tinkerpop] heljoyLiu commented on issue #1280: gremlin-python: fix up serializer out of range of int
issue [2360](https://issues.apache.org/jira/browse/TINKERPOP-2360) here [ Full content available at: https://github.com/apache/tinkerpop/pull/1280 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Created] (TINKERPOP-2361) Prevent using GraphTraversalSource spawned traversals as children
Stephen Mallette created TINKERPOP-2361:
---
Summary: Prevent using GraphTraversalSource spawned traversals as
children
Key: TINKERPOP-2361
URL: https://issues.apache.org/jira/browse/TINKERPOP-2361
Project: TinkerPop
Issue Type: Improvement
Components: process
Affects Versions: 3.3.10
Reporter: Stephen Mallette
It would be nice to prevent this:
{code}
g.V().union(identity(), g.V())
{code}
we of course want the use of an anonymous traversal here:
{code}
g.V().union(identity(), __.V())
{code}
It seems we need to enforce this less as a convention and more as a
programmatic axiom.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TINKERPOP-1641) Kerberos authentication for gremlin-python
[ https://issues.apache.org/jira/browse/TINKERPOP-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087636#comment-17087636 ] Marc de Lignie commented on TINKERPOP-1641: --- You asked me to check docker changes regarding gremlin-server, but I saw some issues there: # docker/gremlin-server.sh 3.4.5 runs fine, but 3.4.6 and 3.5.0-SNAPSHOT warn about the failing gremlin-python install on gremlin-server (which was removed after 3.4.5, I guess) # docker/gremlin-server.sh also starts server-secure on port 45941, but port 45941 was never exposed in the gremlin-server docker-template If you agree, I suppose you rather patch them separately from TINKERPOP-1641. > Kerberos authentication for gremlin-python > -- > > Key: TINKERPOP-1641 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1641 > Project: TinkerPop > Issue Type: Improvement > Components: python >Affects Versions: 3.3.0 >Reporter: Marc de Lignie >Priority: Minor > > Enable kerberos authentication for gremlin-python. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TINKERPOP-1641) Kerberos authentication for gremlin-python
[
https://issues.apache.org/jira/browse/TINKERPOP-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087651#comment-17087651
]
Stephen Mallette commented on TINKERPOP-1641:
-
> docker/gremlin-server.sh 3.4.5 runs fine, but 3.4.6 and 3.5.0-SNAPSHOT warn
> about the failing gremlin-python install on gremlin-server (which was removed
> after 3.4.5, I guess)
hmm - I guess the problem here is that we've let the docker image become
inconsistent across branches. however, given our usage for testing only, i
think that's ok provided you rebuild your image each time you change branches.
Did you do the following each time you changed branches:
{code}
mvn clean install -DskipTests && mvn install -Pdocker-images -pl :gremlin-server
{code}
> docker/gremlin-server.sh also starts server-secure on port 45941, but port
> 45941 was never exposed in the gremlin-server docker-template
that was an oversight - that should be added. good find.
> Kerberos authentication for gremlin-python
> --
>
> Key: TINKERPOP-1641
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1641
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
>Affects Versions: 3.3.0
>Reporter: Marc de Lignie
>Priority: Minor
>
> Enable kerberos authentication for gremlin-python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TINKERPOP-1641) Kerberos authentication for gremlin-python
[ https://issues.apache.org/jira/browse/TINKERPOP-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087788#comment-17087788 ] Marc de Lignie commented on TINKERPOP-1641: --- The alternative maven build steps (run after removing all docker images) make no difference. Relevant part of the stacktrace: Installing dependency org.apache.tinkerpop gremlin-python 3.5.0-SNAPSHOT Could not install the dependency: Error grabbing grapes -- /root/.groovy/grapes/resolved-caller-all-caller-working29.) java.lang.RuntimeException: Error grabbing grapes -- /root/.groovy/grapes/resolved-caller-all-caller-working29.xml (N) It seems the groovy error really is due to gremlin-python 3.5.0-SNAPSHOT being non-existent (I also checked that in my local .m2 and .groovy). Actually, this does not kill the container (because of a missing "set -e" bash line) . And 45940 just starts without gremlin-python as it should for this branch. I do not mind if we leave it as is for now (but a comment in the docker-entrypoint.sh would help).-- > Kerberos authentication for gremlin-python > -- > > Key: TINKERPOP-1641 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1641 > Project: TinkerPop > Issue Type: Improvement > Components: python >Affects Versions: 3.3.0 >Reporter: Marc de Lignie >Priority: Minor > > Enable kerberos authentication for gremlin-python. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (TINKERPOP-1641) Kerberos authentication for gremlin-python
[ https://issues.apache.org/jira/browse/TINKERPOP-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087788#comment-17087788 ] Marc de Lignie edited comment on TINKERPOP-1641 at 4/20/20, 2:35 PM: - The alternative maven build steps (run after removing all docker images) make no difference. Relevant part of the stacktrace: Installing dependency org.apache.tinkerpop gremlin-python 3.5.0-SNAPSHOT Could not install the dependency: Error grabbing grapes -- /root/.groovy/grapes/resolved-caller-all-caller-working29.) java.lang.RuntimeException: Error grabbing grapes -- /root/.groovy/grapes/resolved-caller-all-caller-working29.xml (N) It seems the groovy error really is due to gremlin-python 3.5.0-SNAPSHOT being non-existent (I also checked that in my local .m2 and .groovy). Actually, this does not kill the container (because of a missing "set -e" bash line) . And 45940 just starts without gremlin-python as it should for this branch. I do not mind if we leave it as is for now (but a comment in the docker-entrypoint.sh would help). was (Author: hadoopmarc): The alternative maven build steps (run after removing all docker images) make no difference. Relevant part of the stacktrace: Installing dependency org.apache.tinkerpop gremlin-python 3.5.0-SNAPSHOT Could not install the dependency: Error grabbing grapes -- /root/.groovy/grapes/resolved-caller-all-caller-working29.) java.lang.RuntimeException: Error grabbing grapes -- /root/.groovy/grapes/resolved-caller-all-caller-working29.xml (N) It seems the groovy error really is due to gremlin-python 3.5.0-SNAPSHOT being non-existent (I also checked that in my local .m2 and .groovy). Actually, this does not kill the container (because of a missing "set -e" bash line) . And 45940 just starts without gremlin-python as it should for this branch. I do not mind if we leave it as is for now (but a comment in the docker-entrypoint.sh would help).-- > Kerberos authentication for gremlin-python > -- > > Key: TINKERPOP-1641 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1641 > Project: TinkerPop > Issue Type: Improvement > Components: python >Affects Versions: 3.3.0 >Reporter: Marc de Lignie >Priority: Minor > > Enable kerberos authentication for gremlin-python. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TINKERPOP-1641) Kerberos authentication for gremlin-python
[
https://issues.apache.org/jira/browse/TINKERPOP-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087803#comment-17087803
]
Stephen Mallette commented on TINKERPOP-1641:
-
Oh..I see now - {{gremlin-server/docker-entrypoint.sh}} installs the
{{gremlin-python}} plugin in Gremlin Server:
https://github.com/apache/tinkerpop/blob/f6a44cb1fcdc2b70e5cad20ee1fe0c578bb4202a/docker/gremlin-server/docker-entrypoint.sh#L34
That can be removed in {{master}} without trouble. Then when we rebuild with
{{-Pdocker-images}} everything should work. Do you want to make that change as
well?
> Kerberos authentication for gremlin-python
> --
>
> Key: TINKERPOP-1641
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1641
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
>Affects Versions: 3.3.0
>Reporter: Marc de Lignie
>Priority: Minor
>
> Enable kerberos authentication for gremlin-python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (TINKERPOP-1641) Kerberos authentication for gremlin-python
[ https://issues.apache.org/jira/browse/TINKERPOP-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087824#comment-17087824 ] Marc de Lignie commented on TINKERPOP-1641: --- OK. I make the changes (remove install and expose ports) in my branch and will do a final rebase against master before making the PR. I do not know, however, when the PR will be ready. Had also troubles with the recent groovy bump 2.5.7 -> 2.5.11 with groovy 2.5.7 remnants hanging around and causing conflicts. Also, the python3 docs generation is still giving troubles with the build ending without error but the output singlehtml for the ref docs being truncated after the gephi plugin. I will come back to these issues when I have better understanding of what is going on. > Kerberos authentication for gremlin-python > -- > > Key: TINKERPOP-1641 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1641 > Project: TinkerPop > Issue Type: Improvement > Components: python >Affects Versions: 3.3.0 >Reporter: Marc de Lignie >Priority: Minor > > Enable kerberos authentication for gremlin-python. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TINKERPOP-1641) Kerberos authentication for gremlin-python
[
https://issues.apache.org/jira/browse/TINKERPOP-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087829#comment-17087829
]
Stephen Mallette commented on TINKERPOP-1641:
-
> troubles with the recent groovy bump 2.5.7 -> 2.5.11
I wasn't aware of issues with the groovy upgrade - going to run the docker
tests on {{master}} my end to see if i have troubles.
> the python3 docs generation is still giving troubles with the build ending
> without error but the output singlehtml for the ref docs being truncated
> after the gephi plugin
hmmm - maybe i have that problem too - i will double check that as well.
> Kerberos authentication for gremlin-python
> --
>
> Key: TINKERPOP-1641
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1641
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
>Affects Versions: 3.3.0
>Reporter: Marc de Lignie
>Priority: Minor
>
> Enable kerberos authentication for gremlin-python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
