Bug report for Tomcat 3 [2007/09/23]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 2350|Ver|Nor|2001-06-27|ServletConfig.getInitParameter() requires url-patt| | 5331|Ass|Nor|2001-12-09|getPathInfo vs URL normalization | | 6027|Inf|Maj|2002-01-25|Tomcat Automatically shuts down as service | | 6488|Ver|Maj|2002-02-15|Error: 304. Apparent bug in default ErrorHandler c| | 7785|Inf|Blk|2002-04-06|tomcat bug in context reloading | | 7863|Inf|Maj|2002-04-09|I have a problem when running Tomcat with IIS | | 8187|Inf|Cri|2002-04-17|Errors when Tomcat used with MS Access database | | 9737|Ver|Nor|2002-06-10|ArrayIndexOutOfBoundsException when sending just p| |10047|Ass|Cri|2002-06-20|IllegalStateException | |10406|Ass|Cri|2002-07-02|IllegalStateException | |11087|Inf|Blk|2002-07-23|IllegalStateException | |12156|Inf|Cri|2002-08-29|Apache and Tomcat 3.3.1 Interworking problem | |16363|Ass|Cri|2003-01-23|Stack Overflow accessing compiled JSP - Tomcat 3.2| |39250|Inf|Cri|2006-04-07|Tomcat 3.2.1 + JDK 1.4| +-+---+---+--+--+ | Total 14 bugs | +---+ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Watchdog [2007/09/23]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 278|Unc|Nor|2000-12-04|Bug in GetParameterValuesTestServlet.java file Bug| | 279|Unc|Nor|2000-12-04|Logical Error in GetParameterValuesTestServlet Bug| | 469|Unc|Nor|2001-01-17|in example-taglib.tld urn should be uri BugRat| | 470|Unc|Nor|2001-01-17|FAIL positiveForward.jsp and positiveInclude.jsp B| | 9634|New|Enh|2002-06-05|No tests exist for ServletContext.getResourcePaths| |10703|New|Enh|2002-07-11|Need to test getRequestURI after RequestDispatcher| |11336|New|Enh|2002-07-31|Test wrapped path methods with RD.foward()| |11663|New|Maj|2002-08-13|JSP precompile tests rely on Jasper specific behav| |11664|New|Maj|2002-08-13|A sweep is needed of all Watchdog 4.0 tag librarie| |11665|New|Maj|2002-08-13|ServletToJSPErrorPageTest and ServletToServletErro| |11666|New|Maj|2002-08-13|SetBufferSize_1TestServlet is invalid.| |14004|New|Maj|2002-10-28|Incorrent behaviour of all attribute-related lifec| |15504|New|Nor|2002-12-18|JSP positiveGetValues test relies on order preserv| |24649|New|Nor|2003-11-12|getRemoteHost fails when agent has uppercase chara| |29398|New|Nor|2004-06-04|Update site and note current status | +-+---+---+--+--+ | Total 15 bugs | +---+ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Tomcat 5 [2007/09/23]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29160|Ver|Enh|2004-05-23|precompile problem: _jspx_meth_* (javax.servlet.js| |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |30241|Ver|Enh|2004-07-21|Enhance build script to use branch argument when c| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33650|Inf|Enh|2005-02-19|Jasper performance for multiple files processing | |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |35869|Inf|Enh|2005-07-26|Can't run as a service on Windows Server 2003 64-B| |36133|Inf|Enh|2005-08-10|Support JSS SSL implementation| |36169|New|Enh|2005-08-12|[PATCH] Enable chunked encoding for requests in II| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing | |36923|New|Nor|2005-10-05|Deactivated EL expressions are not parsed for jsp | |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37072|Ass|Nor|2005-10-13|Encoding mismatch in error condition | |37084|Opn| |2005-10-14|JspC from ant fails on JSPs that use custom taglib| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |37449|Opn|Enh|2005-11-10|Two UserDatabaseRealm break manager user | |37485|Inf|Enh|2005-11-14|I'd like to run init SQL after JDBC Connection cre| |37498|Inf|Nor|2005-11-14|[PATCH] NPE in org.apache.catalina.core.ContainerB| |37515|Inf|Nor|2005-11-15|smap not generated by JspC when used from Ant for | |37627|Opn|Nor|2005-11-24|Slow and incomplete dynamic content generation aft| |37785|Inf|Nor|2005-12-05|Changing startup type via Tomcat Monitor does not | |37794|Opn|Nor|2005-12-05|getParameter() fails on POST with transfer-encodin| |37797|Inf|Maj|2005-12-05|Configure Tomcat utility truncates classpath to 96| |37822|Opn|Nor|2005-12-07|WebappClassLoader interfering with Catalina core c| |37847|Ass|Enh|2005-12-09|Allow User To Optionally Specify Catalina Output F| |37869|Opn|Nor|2005-12-12|Cannot obtain client certificate with SSL / client| |37918|Inf|Nor|2005-12-15|EL cannot find valid getter from object when using| |37984|New|Nor|2005-12-21|JNDIRealm.java not able to handle MD5 password| |38001|Inf|Nor|2005-12-22|TruncatedClassFile when loadind applets | |38046|Ass| |2005-12-27|apache-tomcat-5.5.14-deployer doesn't work (Illega| |38131|New|Enh|2006-01-05|WatchedResource does not work if app is outside w| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38290|Inf|Nor|2006-01-16|No SESSION_DESTROYED_EVENT sent for existing webap| |38291|Inf|Nor|2006-01-16|Form actions hanging in UDecoder.convert | |38352|Inf|Nor|2006-01-22|Additional Entries for Default catalina.policy fil| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38367|Inf|Nor|2006-01-24|Executing any Catalina Ant task results in an exce| |38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti| |38427|Inf|Nor|2006-01-27|ServletContextListener Notified Multiple Times Whe| |38483|Inf|Nor|2006-02-01|access log valve uses simpledateformat in tread-un|
Bug report for Tomcat 4 [2007/09/23]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 3839|Opn|Enh|2001-09-26|Problem bookmarking login page| | 4227|Opn|Enh|2001-10-17|Invalid CGI path | | 5329|New|Enh|2001-12-08|NT Service exits startup before Tomcat is finished| | 5795|New|Enh|2002-01-10|Catalina Shutdown relies on localhost causing prob| | 5829|New|Enh|2002-01-13|StandardManager needs to cope with sessions throwi| | 5985|New|Enh|2002-01-23|Tomcat should perform a more restrictive validatio| | 6600|Opn|Enh|2002-02-20|enodeURL adds 'jsession' when 'isRequestedSessionI| | 6614|New|Enh|2002-02-21|Have Bootstrap and StandardClassLoader use the sam| | 6671|New|Enh|2002-02-25|Simple custom tag example uses old declaration sty| | 7043|New|Enh|2002-03-12|database user and password for JDBC Based Store | | 7374|New|Enh|2002-03-22|Apache Tomcat/4.0.1 message on standard output| | 7676|New|Enh|2002-04-02|Allow name property to use match experssions in h| | 7723|New|Enh|2002-04-03|[patch] additional factory for org.apache.naming.f| | 8026|New|Enh|2002-04-12|Exceptions in StandardHostDeployer.addChild are lo| | 8323|New|Enh|2002-04-20|No support for running the 64 bit JVM | | 8343|New|Enh|2002-04-21|adding a absorber logger class to org.apache.ca| | 8441|New|Enh|2002-04-23|Command line files for NetWare| | 8705|New|Enh|2002-05-01|SessionListener should extend EventListener | | 8744|New|Enh|2002-05-02|No way to configure/extend runtime classloaders. | | 8776|New|Enh|2002-05-03|The session url encoding under somce circumstances| | 9227|New|Enh|2002-05-19|Allow an empty value of a pathname in the Standard| | 9456|New|Enh|2002-05-28|Problem saving server.xml file: invalid XML markup| | 9511|New|Enh|2002-05-30|Object instantiation optimization in StandardSessi| | 9629|New|Enh|2002-06-05|Fix ServletContext.getResourcePaths to match spec | | 9745|New|Enh|2002-06-10|extern cache mgt bug for conditionally dynamic pag| | 9852|New|Enh|2002-06-13|Odd Digest and Realm Behaviour| |10021|New|Enh|2002-06-19|Include upgrade option in installer | |10060|New|Enh|2002-06-20|Make the common and shared class loaders look in c| |10120|New|Enh|2002-06-21|Custom realm and shared instalation. | |10225|New|Enh|2002-06-25|ANT Tasks Error Situation | |10335|New|Enh|2002-06-28|[RFE,patch] Make JAASRealm more flexible | |10457|New|Enh|2002-07-03|Patch submission for DefaultServlet/WebdavServlet | |10526|New|Enh|2002-07-06|Authenticators do not always cache the Principal | |10565|Opn|Enh|2002-07-08|shutdown hook problem: java.lang.NoClassDefFoundE| |10691|Ass|Enh|2002-07-11|staring tomcat gives indication that tomcat is sta| |10699|New|Enh|2002-07-11|Apache SOAP 2.3 will not operate properly | |10972|New|Enh|2002-07-19|Realm without className in server.xml produces N| |11069|Opn|Enh|2002-07-23|Tomcat not flag error if tld is outside of /WEB-IN| |11129|New|Enh|2002-07-24|New valve for putting the sessionIDs in the reques| |11248|New|Enh|2002-07-29|DefaultServlet doesn't send expires header| |11754|Opn|Enh|2002-08-15|Synchronous shutdown script - shutdown.sh should w| |12069|New|Enh|2002-08-27|Creation of more HttpSession objects for one previ| |12428|Opn|Enh|2002-09-09|request.getUserPrincipal(): Misinterpretation of s| |12658|New|Enh|2002-09-15|a proxy host and port at the Host element level | |12766|New|Enh|2002-09-18|Tomcat should use tld files in /WEB-INF/ over vers| |13309|Opn|Enh|2002-10-04|Catalina calls System.exit() | |13634|New|Enh|2002-10-15|Allowing system properties to be substituted in co| |13689|Opn|Enh|2002-10-16|Classloader paths for 'Common' classes and librari| |13731|New|Enh|2002-10-17|Final request, response, session and other variabl| |13941|New|Enh|2002-10-24|reload is VERY slow | |13965|New|Enh|2002-10-25|Catalina.sh correction request for Tru64 Unix |
Re: [Tomcat Wiki] Update of TomcatVersions by markt
@@ -55, +77 @@ ||Spec versions:||Servlet 2.5, JSP 2.1|| ||Stable:||Yes|| ||Enhancements:||TBD - currently Yes|| - ||Bug Fixes:||Yes|| + ||Bug Fixes:||TBD - currently Yes|| - ||Security Fixes:||Yes|| + ||Security Fixes:||TBD - currently Yes|| + ||Process:||RTC|| ||Listed on download pages||Yes|| ||Release Manager:||Remy Maucherat (remm)|| + = Tomcat 6.2.x = + ||Spec versions:||Servlet 2.5, JSP 2.1|| + ||Stable:||Yes|| + ||Enhancements:||Yes|| + ||Bug Fixes:||Yes|| + ||Security Fixes:||Yes|| + ||Process:||RTC|| + ||Listed on download pages||Yes|| + ||Release Manager:||TBD|| + Features: + * 6.0.x plus + * Geronimo API changes + * TBD + + = Tomcat 6.3.x = + ||Spec versions:||Servlet 2.5, JSP 2.1|| + ||Stable:||No|| + ||Enhancements:||Yes|| + ||Bug Fixes:||Yes|| + ||Security Fixes:||Yes|| + ||Process:||CTR|| + ||Listed on download pages||Yes|| + ||Release Manager:||TBD|| + Features: + * 6.2.x plus + * TBD + Having a 6.2.x and a 6.3.x doesn't fit with the httpd way. I think that we should have a trunk based on the actual 6.0.x and discuss what we want to include in it. Cheers Jean-Frederic - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r578613 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml
[EMAIL PROTECTED] wrote: Author: funkman Date: Sun Sep 23 16:53:05 2007 New Revision: 578613 URL: http://svn.apache.org/viewvc?rev=578613view=rev Log: bug 43453: ClassCastException at org.apache.catalina.core.StandardContext.findStatusPage(int) In reality - I don't see anywhere that calls findStatusPage(). Is there a chance (in the future) to drop this method from StandardContext as well as the Context interface? I can confirm this is not called anywhere, and it would be a good idea to remove this method. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43457] New: - Native:JK Component - Error thrown by worker ajp13
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43457. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43457 Summary: Native:JK Component - Error thrown by worker ajp13 Product: Tomcat 6 Version: unspecified Platform: Sun OS/Version: Solaris Status: NEW Severity: critical Priority: P2 Component: Native:JK AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Hi I have compiled tomcat-connectors-1.2.25-src.tar.gz on Sun One Webserver 6.1 SP2. I am using it to establish communication between Sun One Webserver 6.1 SP2 and Vignette Collaboration server 7.1 which runs a tomcat internally. The architecture is that the request from the browser goes to the webserver which then communicates with the Colloboration server. I am frequently getting a 'Page not found' error whenever I route the request via the webserver. On running the Collaboration server without the webserver, I don't see this error. Follwoing is the error in the nsapi.log file: [Mon Sep 24 11:40:28.404 2007] [3025:61] [warn] ajp_get_endpoint::jk_ajp_common.c (2505): Unable to get the free endpoint for worker ajp13 from 1 slots [Mon Sep 24 11:40:28.404 2007] [3025:61] [info] ajp_get_endpoint::jk_ajp_common.c (2519): can't find free endpoint Can this be fixed? Thanks Varnita -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43457] - Native:JK Component - Error thrown by worker ajp13
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43457. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43457 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 05:21 --- I guess, your workers.properties does not contain a connection pool size bigger than 1. From the page http://tomcat.apache.org/connectors-doc/webserver_howto/nes.html: Edit your worker definition file workers.properties. You should at least choose a connection pool size: For the meaning of the parameter, search for connection_pool_size on page http://tomcat.apache.org/connectors-doc/reference/workers.html. If my guess is wrong, please give your configuration details and reopen this ticket. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 41797] - CNFE/NPE thrown from function mapper when externalizing
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41797. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=41797 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 06:09 --- I verified the issue but could not test against a build since there doesn't seem to be CI oriented mavenization (neither for snapshots nor real versions?). Hence I don't feel comfortable marking this closed myself without actually testing it first with a build common for all. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43461] New: - mod_jk JkShmFile directive documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43461. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43461 Summary: mod_jk JkShmFile directive documentation Product: Tomcat 5 Version: Unknown Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Native:JK AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Additional information regarding the JkShmFile directive has been added. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43461] - mod_jk JkShmFile directive documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43461. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43461 --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 08:29 --- Created an attachment (id=20871) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=20871action=view) JkShmFile directive update Original file location: http://svn.apache.org/repos/asf/tomcat/connectors/trunk/jk/xdocs/reference/apache.xml -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43462] New: - mod_jk JkShmSize directive automatic configuration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43462. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43462 Summary: mod_jk JkShmSize directive automatic configuration Product: Tomcat 5 Version: Unknown Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Connector:AJP AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Ability of the the mod_jk JkShmSize directive to automatically optimize it's size according to the amount of lb workers. Comments from Rainer Jung: Yes, that would be nice. Unfortunately this requires a little code surgery and not only a small patch, because at the moment the shm is statically acquired (fixed size) and we need it before we parse the worker configuration, so beforee we know, how many workers we have. To fix that, we would either need to count the workers in a separate pass in advance, or enhance the shm handling to allow growth of it. At the moment we initialize the shm for 64 workers, which on some platforms lead to 28800 Bytes size. Actually I'm not sure, if we will really be able to use 64 workers, or if the number is slightly smaller (63?), because we might need to subtract some offset size used as a header. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43463] New: - Change default location of JkShmFile
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43463. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43463 Summary: Change default location of JkShmFile Product: Tomcat 5 Version: Unknown Platform: Other OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Connector:AJP AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The current default location is: logs/jk-runtime-status a more appropriate location if the Linux File System Hierarchy is followed, would be: /var/run/jk-runtime-status -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43463] - Change default location of JkShmFile
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43463. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43463 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 09:15 --- I don't agree with this one. JK is multi-platform. In terms of Apache httpd the correct directory would be runtimedir (or DEFAULT_REL_RUNTIMEDIR) both of which are configured during httpd build time, but unfortunately they are not available after httpd installation. So the apxs build system doesn't give a hook to get the correct run directory from httpd. So we are up to decide upon good defaults. Since the logs directory exists for all ASF provided httpd downloads, it seems this is a good directory for a default. If the user doesn't use the JkShmFile, he gets a log message about JK using the default. So if he looks at his logs, he will be aware, that the logs directory gets used. In case you've got a better solution, please reopen this issue. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43462] - mod_jk JkShmSize directive automatic configuration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43462. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43462 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||LATER -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43461] - mod_jk JkShmFile directive documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43461. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43461 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #20871|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 09:33 --- Created an attachment (id=20873) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=20873action=view) Modified patch Patch from the modified page provided earlier. Slioghtly reordered and shortened. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43461] - mod_jk JkShmFile directive documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43461. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43461 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2007-09-24 09:34 --- Hi Gerhardus, Full page is better than a page with varying line endings, but a real patch would even be nicer :) I did some small reorderings and shortened it a bit. Thanks. Rainer -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
6.0.x request processing patch
Currently, the RequestInfo.getRequestProcessingTime is not taking into
account if the request is active or not, hence returning a larger and
larger value if a new request is not received.
The patch addresses the following
1. getRequestProcessingTime returns 0 if no request is active
2. getLastRequestProcessingTime will return the time for the last request
Does anyone think the values that are returned should be different?
thoughts?
Filip
Index: org/apache/coyote/RequestInfo.java
===
--- org/apache/coyote/RequestInfo.java (revision 578847)
+++ org/apache/coyote/RequestInfo.java (working copy)
@@ -112,7 +112,8 @@
}
public long getRequestProcessingTime() {
-return (System.currentTimeMillis() - req.getStartTime());
+if ( req.getStartTime() == 0 ) return 0;
+else return (System.currentTimeMillis() - req.getStartTime());
}
// Statistical data
@@ -130,6 +131,9 @@
private int requestCount;
// number of response codes = 400
private int errorCount;
+
+//the time of the last request
+private long lastRequestProcssingTime = 0;
/** Called by the processor before recycling the request. It'll collect
@@ -145,11 +149,13 @@
long t0=req.getStartTime();
long t1=System.currentTimeMillis();
long time=t1-t0;
+this.lastRequestProcssingTime = time;
processingTime+=time;
if( maxTime time ) {
maxTime=time;
maxRequestUri=req.requestURI().toString();
}
+req.setStartTime(0);
}
public int getStage() {
@@ -224,6 +230,10 @@
return rpName;
}
+public long getLastRequestProcssingTime() {
+return lastRequestProcssingTime;
+}
+
public void setWorkerThreadName(String workerThreadName) {
this.workerThreadName = workerThreadName;
}
@@ -231,4 +241,8 @@
public void setRpName(ObjectName rpName) {
this.rpName = rpName;
}
+
+public void setLastRequestProcssingTime(long lastRequestProcssingTime) {
+this.lastRequestProcssingTime = lastRequestProcssingTime;
+}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: 6.0.x request processing patch
I would think that using the stage would be more reliable than hacking the startTime, but otherwise, I have no strong opinion either way. -Original Message- From: Filip Hanik - Dev Lists [mailto:[EMAIL PROTECTED] Sent: Monday, September 24, 2007 11:49 AM To: Tomcat Developers List Subject: 6.0.x request processing patch Currently, the RequestInfo.getRequestProcessingTime is not taking into account if the request is active or not, hence returning a larger and larger value if a new request is not received. The patch addresses the following 1. getRequestProcessingTime returns 0 if no request is active 2. getLastRequestProcessingTime will return the time for the last request Does anyone think the values that are returned should be different? thoughts? Filip This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: 6.0.x request processing patch
Bill Barker wrote: I would think that using the stage would be more reliable than hacking the startTime, but otherwise, I have no strong opinion either way. yes, that makes sense. Filip -Original Message- From: Filip Hanik - Dev Lists [mailto:[EMAIL PROTECTED] Sent: Monday, September 24, 2007 11:49 AM To: Tomcat Developers List Subject: 6.0.x request processing patch Currently, the RequestInfo.getRequestProcessingTime is not taking into account if the request is active or not, hence returning a larger and larger value if a new request is not received. The patch addresses the following 1. getRequestProcessingTime returns 0 if no request is active 2. getLastRequestProcessingTime will return the time for the last request Does anyone think the values that are returned should be different? thoughts? Filip This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: 6.0.x request processing patch
here is the modified patch
Filip
Bill Barker wrote:
I would think that using the stage would be more reliable than hacking the
startTime, but otherwise, I have no strong opinion either way.
-Original Message-
From: Filip Hanik - Dev Lists [mailto:[EMAIL PROTECTED]
Sent: Monday, September 24, 2007 11:49 AM
To: Tomcat Developers List
Subject: 6.0.x request processing patch
Currently, the RequestInfo.getRequestProcessingTime is not
taking into
account if the request is active or not, hence returning a larger and
larger value if a new request is not received.
The patch addresses the following
1. getRequestProcessingTime returns 0 if no request is active
2. getLastRequestProcessingTime will return the time for the
last request
Does anyone think the values that are returned should be different?
thoughts?
Filip
This message is intended only for the use of the person(s) listed above as the
intended recipient(s), and may contain information that is PRIVILEGED and
CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or
distribute this message or any attachment. If you received this communication
in error, please notify us immediately by e-mail and then delete all copies of
this message and any attachments.
In addition you should be aware that ordinary (unencrypted) e-mail sent through
the Internet is not secure. Do not send confidential or sensitive information,
such as social security numbers, account numbers, personal identification
numbers and passwords, to us via ordinary (unencrypted) e-mail.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Index: java/org/apache/coyote/RequestInfo.java
===
--- java/org/apache/coyote/RequestInfo.java (revision 578847)
+++ java/org/apache/coyote/RequestInfo.java (working copy)
@@ -112,7 +112,8 @@
}
public long getRequestProcessingTime() {
-return (System.currentTimeMillis() - req.getStartTime());
+if ( getStage() == org.apache.coyote.Constants.STAGE_ENDED ) return 0;
+else return (System.currentTimeMillis() - req.getStartTime());
}
// Statistical data
@@ -130,6 +131,9 @@
private int requestCount;
// number of response codes = 400
private int errorCount;
+
+//the time of the last request
+private long lastRequestProcssingTime = 0;
/** Called by the processor before recycling the request. It'll collect
@@ -145,6 +149,7 @@
long t0=req.getStartTime();
long t1=System.currentTimeMillis();
long time=t1-t0;
+this.lastRequestProcssingTime = time;
processingTime+=time;
if( maxTime time ) {
maxTime=time;
@@ -224,6 +229,10 @@
return rpName;
}
+public long getLastRequestProcssingTime() {
+return lastRequestProcssingTime;
+}
+
public void setWorkerThreadName(String workerThreadName) {
this.workerThreadName = workerThreadName;
}
@@ -231,4 +240,8 @@
public void setRpName(ObjectName rpName) {
this.rpName = rpName;
}
+
+public void setLastRequestProcssingTime(long lastRequestProcssingTime) {
+this.lastRequestProcssingTime = lastRequestProcssingTime;
+}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r578963 - in /tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net: NioBlockingSelector.java NioEndpoint.java
Author: fhanik
Date: Mon Sep 24 13:56:31 2007
New Revision: 578963
URL: http://svn.apache.org/viewvc?rev=578963view=rev
Log:
optimize pollers, don't lock into a blocking select if there are other things
for the thread to do
Modified:
tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioBlockingSelector.java
tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified:
tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL:
http://svn.apache.org/viewvc/tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioBlockingSelector.java?rev=578963r1=578962r2=578963view=diff
==
---
tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioBlockingSelector.java
(original)
+++
tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioBlockingSelector.java
Mon Sep 24 13:56:31 2007
@@ -207,8 +207,7 @@
}
public void wakeup() {
-int i = wakeupCounter.addAndGet(1);
-if (i==1) selector.wakeup();
+if (wakeupCounter.addAndGet(1)==0) selector.wakeup();
}
public void cancel(SelectionKey sk, KeyAttachment key, int ops){
@@ -301,8 +300,10 @@
int i = wakeupCounter.get();
if (i0)
keyCount = selector.selectNow();
-else
+else {
+wakeupCounter.set(-1);
keyCount = selector.select(1000);
+}
wakeupCounter.set(0);
if (!run) break;
}catch ( NullPointerException x ) {
Modified: tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=578963r1=578962r2=578963view=diff
==
--- tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioEndpoint.java
(original)
+++ tomcat/sandbox/gdev6x/java/org/apache/tomcat/util/net/NioEndpoint.java Mon
Sep 24 13:56:31 2007
@@ -1342,7 +1342,7 @@
public void addEvent(Runnable event) {
events.offer(event);
-if ( wakeupCounter.incrementAndGet() 3 ) selector.wakeup();
+if ( wakeupCounter.incrementAndGet() == 0 ) selector.wakeup();
}
public void cometInterest(NioChannel socket) {
@@ -1459,7 +1459,14 @@
int keyCount = 0;
try {
if ( !close ) {
-keyCount = selector.select(selectorTimeout);
+if (wakeupCounter.get()0) {
+//if we are here, means we have other stuff to
do
+//do a non blocking select
+keyCount = selector.selectNow();
+}else {
+wakeupCounter.set( -1);
+keyCount = selector.select(selectorTimeout);
+}
wakeupCounter.set(0);
}
if (close) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r578980 - /tomcat/tc6.0.x/trunk/STATUS
Author: remm Date: Mon Sep 24 14:27:16 2007 New Revision: 578980 URL: http://svn.apache.org/viewvc?rev=578980view=rev Log: - Add status file. Added: tomcat/tc6.0.x/trunk/STATUS Added: tomcat/tc6.0.x/trunk/STATUS URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=578980view=auto == --- tomcat/tc6.0.x/trunk/STATUS (added) +++ tomcat/tc6.0.x/trunk/STATUS Mon Sep 24 14:27:16 2007 @@ -0,0 +1,31 @@ + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the License); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an AS IS BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + + +$Id: BUILDING.txt 562769 2007-08-04 22:08:32Z markt $ + + = + Apache Tomcat 6.0 Patch Proposals + = + + +PATCHES PROPOSED TO BACKPORT: + [ New proposals should be added at the end of the list ] + +* New cookie parser (third party contribution) + +1: + -1: + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43468] New: - HTMLManagerServlet NullPointerException listing context
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43468. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=43468 Summary: HTMLManagerServlet NullPointerException listing context Product: Tomcat 6 Version: 6.0.14 Platform: Sun URL: http://localhost:8080/manager/html/list OS/Version: Solaris Status: NEW Severity: normal Priority: P2 Component: Manager application AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Obtained the following NullPointerException, stack trace below java.lang.NullPointerException org.apache.catalina.manager.HTMLManagerServlet.list(HTMLManagerServlet.java:437) org.apache.catalina.manager.HTMLManagerServlet.doGet(HTMLManagerServlet.java:136) Code is: args[11] = new Integer(context.getManager().getMaxInactiveInterval()/60); Seemingly the getManager() is returning null. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Tomcat 6 and Java 5 syntax
Hi, I am looking at the Tomcat 6 code and checking out the the possibility of collaborating with the project, and one thing that pops up is that the entire code base is not using Java 5 syntax. Was this syntax avoided for a specific reason? Regards, lg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43470] New: - ClassCastException at org.apache.catalina.deploy.NamingResources
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=43470.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43470
Summary: ClassCastException at
org.apache.catalina.deploy.NamingResources
Product: Tomcat 6
Version: 6.0.14
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
NamingResources reads
public void removeLocalEjb(String name) {
entries.remove(name);
ContextLocalEjb localEjb = null;
synchronized (localEjbs) {
localEjb = (ContextLocalEjb) ejbs.remove(name);
}
if (localEjb != null) {
support.firePropertyChange(localEjb, localEjb, null);
localEjb.setNamingResources(null);
}
}
if should be
public void removeLocalEjb(String name) {
entries.remove(name);
ContextLocalEjb localEjb = null;
synchronized (localEjbs) {
localEjb = (ContextLocalEjb) localEjbs.remove(name); // The error
was in this line
}
if (localEjb != null) {
support.firePropertyChange(localEjb, localEjb, null);
localEjb.setNamingResources(null);
}
}
Regards,
lg
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Tomcat 6 and Java 5 syntax
Lucas Galfaso wrote: Hi, I am looking at the Tomcat 6 code and checking out the the possibility of collaborating with the project, and one thing that pops up is that the entire code base is not using Java 5 syntax. Was this syntax avoided for a specific reason? The code is based on (actually copied from) Tomcat 5. TC5 required JDK 1.4. Java 5 syntax is added as we develop new features or fix bugs. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43470] - ClassCastException at org.apache.catalina.deploy.NamingResources
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=43470.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43470
--- Additional Comments From [EMAIL PROTECTED] 2007-09-24 20:02 ---
There are some more bug at this same class
It reads
public void addResourceEnvRef(ContextResourceEnvRef resource) {
if (entries.containsKey(resource.getName())) {
return;
} else {
entries.put(resource.getName(), resource.getType());
}
synchronized (localEjbs) { // This is wrong
resource.setNamingResources(this);
resourceEnvRefs.put(resource.getName(), resource);
}
support.firePropertyChange(resourceEnvRef, null, resource);
}
Corrected version
public void addResourceEnvRef(ContextResourceEnvRef resource) {
if (entries.containsKey(resource.getName())) {
return;
} else {
entries.put(resource.getName(), resource.getType());
}
synchronized (resource) { // This is correct
resource.setNamingResources(this);
resourceEnvRefs.put(resource.getName(), resource);
}
support.firePropertyChange(resourceEnvRef, null, resource);
}
and
public void removeResourceEnvRef(String name) {
entries.remove(name);
String type = null;
synchronized (resourceEnvRefs) {
type = (String) resourceEnvRefs.remove(name);
}
if (type != null) {
support.firePropertyChange(resourceEnvRef,
name + : + type, null);
}
}
Should be
public void removeResourceEnvRef(String name) {
entries.remove(name);
ContextResourceEnvRef resourceEventRef = null;
synchronized (resourceEnvRefs) {
resourceEventRef = (ContextResourceEnvRef)
resourceEnvRefs.remove(name);
}
if (resourceEventRef != null) {
support.firePropertyChange(resourceEnvRef,
name + : + resourceEventRef.getType(),
null);
}
}
Regards,
lg
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
