Re: Who added google-site-verification to index.html?
On 25.09.2010 23:04, Mark Thomas wrote: On 25/09/2010 13:33, Rainer Jung wrote: The meta tag google-site-verification is included in our main index.html. It is not in the authoritative svn copy. Is there a reason for that? If yes, please do also add it to the authoritative site copy in svn (/tomcat/site/trunk), otherwise remove. That was me. It is a one-time thing so it can go now Google has verified the site. I'll delete it next time on people.a.o. If someone else gets there first that's fine. OK, removed. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001383 - /tomcat/trunk/webapps/docs/building.xml
Author: timw Date: Sun Sep 26 07:46:27 2010 New Revision: 1001383 URL: http://svn.apache.org/viewvc?rev=1001383view=rev Log: Fixing Tomcat startup class in building instructions. Modified: tomcat/trunk/webapps/docs/building.xml Modified: tomcat/trunk/webapps/docs/building.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/building.xml?rev=1001383r1=1001382r2=1001383view=diff == --- tomcat/trunk/webapps/docs/building.xml (original) +++ tomcat/trunk/webapps/docs/building.xml Sun Sep 26 07:46:27 2010 @@ -222,7 +222,7 @@ these dependencies. root directory of the source tree and will be available in the emRun-gt;Run Configurations/em dialog. Use these to start and stop Tomcat from Eclipse. br/If you want to configure these yourself (or are using a different IDE) -then use codeorg.apache.catalina.startup.Catalina/code as the main class, +then use codeorg.apache.catalina.startup.Bootstrap/code as the main class, codestart/code/codestop/code as program arguments, and specify code-Dcatalina.home=.../code (with the name of your build directory) as VM arguments. /p - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49955] Building instructions incorrect.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Tim Whittington t...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #4 from Tim Whittington t...@apache.org 2010-09-26 04:01:05 EDT --- Startup class corrected - thanks for spotting that. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
OK, will do. I've just had a motherboard failure, so will be a couple of days before I can get this patched up. Any objections to the suggestion of an 'eclipse' or 'ide-eclipse' target to pull the Eclipse files into the root directory? cheers tim On Fri, Sep 24, 2010 at 6:47 AM, Rainer Jung rainer.j...@kippdata.de wrote: On 23.09.2010 18:24, Mark Thomas wrote: On 23/09/2010 03:15, t...@apache.org wrote: Author: timw Date: Thu Sep 23 10:15:16 2010 New Revision: 1000392 URL: http://svn.apache.org/viewvc?rev=1000392view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Improvements and corrections for the Building Tomcat guide, plus sample Eclipse launch targets. Based on contribution from Wesley Acheson. Added: tomcat/trunk/Start Tomcat.launch tomcat/trunk/Stop Tomcat.launch -1 on the names. File names with spaces are a PITA. Do these have to be in the root of the source tree? I know I started the whole adding Eclipse files to the source tree but I am beginning to regret how I did it. How about moving all the the IDE support files to res/ide-support and update the docs to point to the new location from where users can copy the files they want and ignore the ones they don't? +1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
On Fri, Sep 24, 2010 at 6:49 AM, Wesley Acheson wesley.ache...@gmail.com wrote: On Thu, Sep 23, 2010 at 12:15 PM, t...@apache.org wrote: Author: timw Date: Thu Sep 23 10:15:16 2010 New Revision: 1000392 URL: http://svn.apache.org/viewvc?rev=1000392view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Improvements and corrections for the Building Tomcat guide, plus sample Eclipse launch targets. tomcat/trunk/Start Tomcat.launch tomcat/trunk/Stop Tomcat.launch In accordance with the others -1 on the filename. Also your launch files depend on the project being called tomcat-7.0.x which for instance my checkout just isn't called. Finally you removed the line in the patch that mentioned where the branches were stored. If someones trying to checkout the files to find a bug in a particular downloaded version then thats making it more difficult for them. +0 The building instructions for each branch differ (JDK version, Ant version, SVN locations, Download URLs, there's a separate docs area and building page for each version already and the SVN repository layout is well documented at http://tomcat.apache.org/svn.html, so I kept the separation. cheers tim - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Tim Whittington t...@apache.org changed: What|Removed |Added AssignedTo|dev@tomcat.apache.org |t...@apache.org -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.
On 26.09.2010 10:23, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Tim Whittingtont...@apache.org changed: What|Removed |Added AssignedTo|dev@tomcat.apache.org |t...@apache.org Tim: Mark might correct me, but I think this prevents any further issue mails for 50001 being sent to the dev list (I added a test comment there to check this). If you want to notify others you are working on an issue to reduce the risk of duplicate work, you can add a comment, although most of the time it doesn't seem necessary. If you want to track bugs you are interested in, you can e.g. add yourself to the CC list of the issue and use it in searches. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. cheers tim On Sun, Sep 26, 2010 at 3:28 AM, rj...@apache.org wrote: Author: rjung Date: Sat Sep 25 14:28:36 2010 New Revision: 1001216 URL: http://svn.apache.org/viewvc?rev=1001216view=rev Log: Please no tabs. Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1001216r1=1001215r2=1001216view=diff == --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sat Sep 25 14:28:36 2010 @@ -68,8 +68,8 @@ Old behaviour can be enabled by defining USE_CGI_HEADERS. (timw) /fix fix - bug49511/bug: IIS: Do not override IIS log information when subsequent - requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw) + bug49511/bug: IIS: Do not override IIS log information when subsequent + requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw) /fix fix Docs: Document SSLOptions needed for SSL information forwarding. (rjung) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Taglibs [2010/09/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27717|New|Maj|2004-03-16|x:forEach very slow in JSTL 1.1 | |33934|New|Cri|2005-03-09|[standard] memory leak in jstl c:set tag | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Nor|2007-05-14|[PATCH] Log Taglib enhancements | |43640|New|Nor|2007-10-16|Move the tests package to JUnit | |45197|Ass|Nor|2008-06-12|Need to support the JSTL 1.2 specification| |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Nor|2009-12-02|TLD generator | |48773|New|Nor|2010-02-19|DataSourceWrapper and DriverManager problems | |49292|New|Nor|2010-05-14|Memory leak in org.apache.taglibs.standard.lang.js| |49578|New|Nor|2010-07-09|XPath handling only supports single reference to v| |49900|New|Nor|2010-09-08|BundleSupport.release() does not call super.releas| +-+---+---+--+--+ | Total 13 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 5 [2010/09/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing | |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, | |38577|Inf|Enh|2006-02-08|Enhance logging of security failures | |38916|Inf|Enh|2006-03-10|HttpServletRequest cannot handle multipart request| |39053|Inf|Enh|2006-03-21|include Tomcat embedded sample| |39740|New|Enh|2006-06-07|semi-colon ; isn't allowed as a query argument sep| |39862|Inf|Enh|2006-06-22|provide support for protocol-independent GenericSe| |40211|Inf|Enh|2006-08-08|Compiled JSP don't indent HTML code | |40402|New|Enh|2006-09-03|Manager should display Exceptions | |40510|New|Enh|2006-09-14|installer does not create shortcuts for all users | |40712|New|Enh|2006-10-10|Realm admin error.| |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov| |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel - | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment| |41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i| |41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C| |41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co| |41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume| |41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar| |41673|New|Enh|2007-02-21|Jasper output the message of compiling error using| |41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows| |41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af| |41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe| |42416|New|Enh|2007-05-14|Tomcat startup hangs and AJP13 connector port 8009| |43423|New|Enh|2007-09-18|catalina.sh -force too fast | |43538|New|Enh|2007-10-02|[patch] Show the hostname and IP address in the ma| |43796|Inf|Enh|2007-11-05|Add MIME type mapping for the log extension | |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |43960|New|Enh|2007-11-26|Expose StandardWrapper unavailable and/or availabl| |43991|New|Enh|2007-11-29|Contributing a URLResourceFactory |
Bug report for Tomcat 6 [2010/09/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro| |41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso| |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41791|New|Enh|2007-03-07|Tomcat behaves inconsistently concerning flush-pac| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |41944|New|Enh|2007-03-25|Start running the RAT tool to see where we're miss| |41992|New|Enh|2007-03-30|Need ability to set OS process title | |42463|New|Enh|2007-05-20|crossContext and classloader issues - pls amend | |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43003|New|Enh|2007-07-30|Separate dependent component download and build ta| |43400|New|Enh|2007-09-14|enum support for tag libs | |43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre| |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43642|New|Enh|2007-10-17|Add prestartminSpareThreads attribute for Executor| |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool | |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w| |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44299|New|Enh|2008-01-26|Provider manager app with a log out button| |44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host| |44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI java.nam| |44787|New|Enh|2008-04-09|provide more error context on java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!| |45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive | |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex| |46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46451|New|Enh|2008-12-30|Configure svn:bugtraq properties | |46461|New|Enh|2009-01-01|fail graceful on dns changes for connectors/hosts | |46497|New|Enh|2009-01-08|Install Tomcat Deployer/ANT on Windows Platform | |46558|New|Enh|2009-01-19|Shutdown port with address binding|
Bug report for Tomcat 7 [2010/09/26]
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) |
| | +-+
| | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major |
| | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial |
| | | +-+
| | | | Date Posted |
| | | | +--+
| | | | | Description |
| | | | | |
|48550|New|Enh|2010-01-14|Update examples and default server.xml to use UTF-|
|48644|Opn|Nor|2010-01-30|Code should never ignore throwable|
|48692|New|Enh|2010-02-07|Provide option to parse application/x-www-form-url|
|48837|New|Enh|2010-03-01|Memory leaks protection does not cure leaks trigge|
|48870|New|Enh|2010-03-08|avoid parallel arrays of base types |
|48892|New|Enh|2010-03-11|Use URIEncoding from server.xml for decoding post |
|49000|New|Enh|2010-03-26|Cookie parsing bug when an empty value has an equa|
|49100|New|Enh|2010-04-12|Mutable public constants: MemberImpl.TRIBES_MBR_BE|
|49101|New|Enh|2010-04-12|All constants in tribes.transport.Constants are mu|
|49125|New|Enh|2010-04-14|toString on byte[] array probably is not correct |
|49126|New|Enh|2010-04-14|jasper.compiler.Generator.createJspId() can genera|
|49142|New|Enh|2010-04-16|Missing serialVersionUIDs |
|49159|New|Enh|2010-04-20|Improve ThreadLocal memory leak clean-up |
|49165|New|Enh|2010-04-21|Enhancement - Allow %{TIME_FORMAT}t As Configurati|
|49180|New|Enh|2010-04-24|Add option to disable log rotation in FileHandler.|
|49284|New|Enh|2010-05-12|Implement SSL renegotiation for the NIO connector |
|49290|New|Enh|2010-05-14|Using a JarScanner with scanAllDirectories=true ca|
|49295|New|Enh|2010-05-14|JMXAccessorTask.getProperties() - return Propertie|
|49297|New|Min|2010-05-15|Whitespace absence is allowed before attribute nam|
|49317|New|Enh|2010-05-20|org.apache.catalina.util.Base64 interface needs re|
|49318|New|Enh|2010-05-20|add a Negotiate (Kerberos/NTLM) authenticator / in|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49426|New|Nor|2010-06-11|Manager app wrongly localized |
|49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al|
|49591|New|Enh|2010-07-13|Custom error page always uses Transfer-Encoding: c|
|49650|New|Enh|2010-07-26|Streamline package.access property definition in c|
|49683|New|Nor|2010-08-01|Separate async, keep-alive, connection timeout wit|
|49711|New|Enh|2010-08-05|HttpServletRequest#getParts() does not work in a F|
|49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm|
|49819|New|Enh|2010-08-25|Improved index.html for default ROOT application |
|49821|New|Enh|2010-08-25|Tomcat CLI|
|49884|New|Nor|2010-09-04|NullPointerException in org.apache.catalina.core.A|
|49916|New|Nor|2010-09-11|use an init-param for jspFile on explicit jsp serv|
|49922|New|Nor|2010-09-14|ApplicationFilterChain more than the same filter |
|49923|New|Nor|2010-09-14|The latest thunk can't shutdown if add tomcat nati|
|49925|New|Nor|2010-09-14|java.lang.NoSuchMethodException error when call |
|49937|New|Nor|2010-09-16|Problems with AsyncListener and resource injection|
|49945|New|Nor|2010-09-17|Continuation of JMX Descriptor Improvements |
|49952|New|Nor|2010-09-17|ServletContainerInitializer can't actually add lis|
|49956|New|Nor|2010-09-17|@Resource(name=) Normalization of JNDI Name |
|49957|New|Reg|2010-09-19|Work directories of deployed webapps are deleted a|
|49978|New|Nor|2010-09-22|WebappLoader throws exception if workDir already e|
|49991|New|Nor|2010-09-23|Tomcat 7 JAAS problem with CDI|
|49994|New|Nor|2010-09-24|NamingContext Possible Bug|
|50001|New|Nor|2010-09-24|Eclipse source files don't belong in project root.|
+-+---+---+--+--+
| Total 45 bugs |
+---+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2010/09/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk | |39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta| |40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a| |41170|Inf|Nor|2006-12-13|single crlf in header termination crashes app.| |41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort | |42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio| |42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work | |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 apache 2.2.9 static compiled on so| |45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being| |46337|New|Nor|2008-12-04|real worker name is wrong | |46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper| |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Nor|2009-08-11|Unable to allocate shared memory when using isapi_| |47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i| |47692|New|Reg|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |48925|Inf|Maj|2010-03-16|((ServletRequest) request).getLocalAddr() returns | |48940|New|Maj|2010-03-18|IIS to Tomcat occasionally fails on POST with T-E | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49048|New|Nor|2010-04-05|ACL not applied to redirect URLs | |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49413|Opn|Reg|2010-06-09|Apache Mod_jk 1.2.30 is shutting down communicatio| |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49511|New|Maj|2010-06-28|IIS 7.5 incorrect logging: pfc-pFilterContext is | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | +-+---+---+--+--+ | Total
Bug report for Tomcat Native [2010/09/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti| |41361|New|Nor|2007-01-14|Content lost when read by a slow client. | |42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections| |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ| |46179|New|Maj|2008-11-10|apr ssl client authentication | |46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris| |47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown| |47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code | |48253|New|Min|2009-11-20|Tomcat Native patch - adding dynamic locking callb| |48655|New|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |49556|New|Cri|2010-07-05|the proc.create function used args as env to get t| |49557|New|Cri|2010-07-05|index erro in the loop to get the env info in the | |49595|New|Cri|2010-07-15|Tomcat crashes in tcnative-1.dll frequently | |49851|New|Blk|2010-08-31|JNI Registry.deleteKey and Registry.deleteValue co| +-+---+---+--+--+ | Total 16 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Modules [2010/09/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49543|New|Enh|2010-07-02|Request for a shared datasource configuration as| |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |49953|New|Nor|2010-09-17|Missing @Override annotations | |49954|New|Nor|2010-09-17|Code tidyup | +-+---+---+--+--+ | Total8 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
On 26 September 2010 10:00, Tim Whittington t...@apache.org wrote: Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. Hit me too amny times. The tabs setting for the XML editor is in a different place: Preferences / XML / XML Files / Editor / Indent using tabs/spaces. cheers tim On Sun, Sep 26, 2010 at 3:28 AM, rj...@apache.org wrote: Author: rjung Date: Sat Sep 25 14:28:36 2010 New Revision: 1001216 URL: http://svn.apache.org/viewvc?rev=1001216view=rev Log: Please no tabs. Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1001216r1=1001215r2=1001216view=diff == --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sat Sep 25 14:28:36 2010 @@ -68,8 +68,8 @@ Old behaviour can be enabled by defining USE_CGI_HEADERS. (timw) /fix fix - bug49511/bug: IIS: Do not override IIS log information when subsequent - requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw) + bug49511/bug: IIS: Do not override IIS log information when subsequent + requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw) /fix fix Docs: Document SSLOptions needed for SSL information forwarding. (rjung) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50003] New: AbstractEndpoint.setMinSpareThreads calls executor.setCorePoolSize with incorrect parameter
https://issues.apache.org/bugzilla/show_bug.cgi?id=50003 Summary: AbstractEndpoint.setMinSpareThreads calls executor.setCorePoolSize with incorrect parameter Product: Tomcat 7 Version: 7.0.2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Connectors AssignedTo: dev@tomcat.apache.org ReportedBy: sylvain.laur...@gmail.com It's calling setCorePoolSize(maxThreads) instead of setCorePoolSize(minSpareThreads) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50003] AbstractEndpoint.setMinSpareThreads calls executor.setCorePoolSize with incorrect parameter
https://issues.apache.org/bugzilla/show_bug.cgi?id=50003 --- Comment #1 from sylvain.laur...@gmail.com 2010-09-26 08:08:27 EDT --- Created an attachment (id=26075) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26075) proposed patch for tc7 proposed patch for tc7. The problem does not apply to tc6 because the AbstractEndpoint class does not exist in tc6 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Atomicity violation in setAttribute
Hi, We are building a tool for detecting non atomic usages of concurrent collections. We analyzed Tomcat’s code using our tool and found the following behavior: The following code is located at the beginning of function setAttribute at class ApplicationContext. This code fragment intends to check whether a key is already inside the “attributes” collection. If it does, then a “replaced” bit is turned on while the corresponding value is kept in “oldValue”. Then a new value is inserted for the same key and the function continue while using “replaced” and “oldValue”. oldValue = attributes.get(name); if (oldValue != null) replaced = true; attributes.put(name, value); This code can behave non atomically when two different threads call setAttribute function with the same attribute name. In this case, there exists a thread interleaving where two threads call the get function before both of them launch the put operation. In this case, both threads will continue running the function with “replaced” bit turned on and the oldValue of both thread will point to the same location. This means that the value of the first thread that did the put operation will not be treated as a value that was replaced. Could you please let me know whether you consider this as a bug? A possible way of modifying the code in order to execute this code atomically is as follows: val = attributes.put(name, value); if (val != null) replaced = true; Thanks, Ohad
DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Chuck Caldarale chuck.caldar...@unisys.com changed: What|Removed |Added CC||dev@tomcat.apache.org -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Atomicity violation in removeAttribute
Hi,
In addition to the behavior we experienced in function setAttribute. We also
experienced another atomicity violation in function removeAttribute.
The following code is located at the beginning of function removeAttribute
at class ApplicationContext. This code fragment intends to check whether a
key is already inside the “attributes” collection. If it does, then the key
is removed from the collection and the function continues running while
assigning the corresponding value to “value”. Otherwise, the function should
return.
found = attributes.containsKey(name);
if (found) {
value = attributes.get(name);
attributes.remove(name);
} else {
return;
}
This code can behave non atomically when two different threads call
removeAttribute function with the same attribute name. In this case, there
exists a thread interleaving where two threads enter the “if” condition
while the first one removes “name” from the attributes collection before the
second one runs the get operation. This causes the function to continue
running with value == null instead of returning.
Could you please let me know whether you consider this as a bug?
A possible way of modifying the code in order to execute this code
atomically is as follows:
if (attributes.containsKey(name)) {
value = attributes.remove(name);
if (value == null)
return;
}
Thanks,
Ohad
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
On Sun, Sep 26, 2010 at 10:00:29PM +1300, Tim Whittington wrote: Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. Then, once you get it right, document it! I think most settings like that can be done at a project level or globally; if project level override is used, it gets saved in .settings, if you commit that, everybody who starts after that will get this setting. Be cautious with this and don't overdo it. I have in the past used Errors Warnings - Unused Imports - Error to ensure that other devs would clean up imports. It's a bit draconian, but it works. Your proposed eclipse target could have an echo to remind ppl of whatever you've come up with... Ian - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
2010/9/26 sebb seb...@gmail.com: On 26 September 2010 10:00, Tim Whittington t...@apache.org wrote: Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. Hit me too amny times. The tabs setting for the XML editor is in a different place: Preferences / XML / XML Files / Editor / Indent using tabs/spaces. BTW, there is Preferences / General / Editors / Text Editors / Show whitespace characters that applies to all Text editors there 2010/9/26 Ian Darwin i...@darwinsys.com: On Sun, Sep 26, 2010 at 10:00:29PM +1300, Tim Whittington wrote: Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. Then, once you get it right, document it! I think most settings like that can be done at a project level or globally; if project level override is used, it gets saved in .settings, if you commit that, everybody who starts after that will get this setting. I do not think that we should commit anything that is in .settings. I do not mind against eclipse.settings though, so that one can rename/move that to .settings. ;) Best regards, - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Atomicity violation in setAttribute
In this case, both threads will continue running the function with ?replaced? bit turned on and the oldValue of both thread will point to the same location. This means that the value of the first thread that did the put operation will not be treated as a value that was replaced. Could you please let me know whether you consider this as a bug? Is it any different than if two threads invoke the operation serially? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.
On 26/09/2010 09:59, Rainer Jung wrote: On 26.09.2010 10:23, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Tim Whittingtont...@apache.org changed: What|Removed |Added AssignedTo|dev@tomcat.apache.org |t...@apache.org Tim: Mark might correct me, but I think this prevents any further issue mails for 50001 being sent to the dev list (I added a test comment there to check this). Rainer is correct. (Note to self: take a look at making this field read-only). If you want to notify others you are working on an issue to reduce the risk of duplicate work, you can add a comment, although most of the time it doesn't seem necessary. If you want to track bugs you are interested in, you can e.g. add yourself to the CC list of the issue and use it in searches. +1 Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001485 - /tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
Author: markt
Date: Sun Sep 26 17:57:07 2010
New Revision: 1001485
URL: http://svn.apache.org/viewvc?rev=1001485view=rev
Log:
Tab police
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/Constants.java?rev=1001485r1=1001484r2=1001485view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/Constants.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/Constants.java Sun Sep 26 17:57:07
2010
@@ -155,9 +155,9 @@ public final class Constants {
* @param code the coded value
* @return the string value of the method
*/
- public static final String getMethodForCode(final int code) {
- return methodTransArray[code];
- }
+public static final String getMethodForCode(final int code) {
+return methodTransArray[code];
+}
public static final int SC_M_JK_STORED = (byte) 0xFF;
@@ -202,9 +202,9 @@ public final class Constants {
* @param code the coded value
* @return the string value of the header name
*/
- public static final String getHeaderForCode(final int code) {
- return headerTransArray[code];
- }
+public static final String getHeaderForCode(final int code) {
+return headerTransArray[code];
+}
// Translates integer codes to response header names
private static final String [] responseTransArray = {
@@ -226,9 +226,9 @@ public final class Constants {
* @param code the coded value
* @return the string value of the header
*/
- public static final String getResponseHeaderForCode(final int code) {
- return responseTransArray[code];
- }
+public static final String getResponseHeaderForCode(final int code) {
+return responseTransArray[code];
+}
private static final HashtableString,Integer responseTransHash =
new HashtableString,Integer(20);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
On Sun, Sep 26, 2010 at 6:05 PM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2010/9/26 sebb seb...@gmail.com: On 26 September 2010 10:00, Tim Whittington t...@apache.org wrote: Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. Hit me too amny times. The tabs setting for the XML editor is in a different place: Preferences / XML / XML Files / Editor / Indent using tabs/spaces. BTW, there is Preferences / General / Editors / Text Editors / Show whitespace characters that applies to all Text editors there 2010/9/26 Ian Darwin i...@darwinsys.com: On Sun, Sep 26, 2010 at 10:00:29PM +1300, Tim Whittington wrote: Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. Then, once you get it right, document it! I think most settings like that can be done at a project level or globally; if project level override is used, it gets saved in .settings, if you commit that, everybody who starts after that will get this setting. I do not think that we should commit anything that is in .settings. I do not mind against eclipse.settings though, so that one can rename/move that to .settings. ;) Best regards, - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org Assuming bgu 50001 passes should we copy a .settings into the project root also? What settings should this be, though, I keep getting vague answers to code style. What I know bracing style : java standard indentation : 4 spaces line length :80 (rigid) multiple parameters: same line?? so long as its under 80 chrs? xml indentation: 2 spaces??? (basing that off build.xml) multiple xml attributes (over 80 chars)?? Anything else? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Which IDE?
Commiters, patch authors. Do you use an IDE to modify tomcat source code? If you do which one? Asking again in releation to bug 50001. Trying to see what ide's should be supported. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On 26/09/2010 19:08, Wesley Acheson wrote: Commiters, patch authors. Do you use an IDE to modify tomcat source code? Yes. If you do which one? Eclipse for Java. Visual Studio (rarely) for C code. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas ma...@apache.org wrote: On 26/09/2010 19:08, Wesley Acheson wrote: Commiters, patch authors. Do you use an IDE to modify tomcat source code? Yes. If you do which one? Eclipse for Java. Really do you use the formatter for the code? If so we could use your settings. Visual Studio (rarely) for C code. Mark I've no idea on how to put in IDE specific files for Visual Studio. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
On Sun, Sep 26, 2010 at 1:37 PM, sebb seb...@gmail.com wrote: On 26 September 2010 10:00, Tim Whittington t...@apache.org wrote: Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. Hit me too amny times. The tabs setting for the XML editor is in a different place: Preferences / XML / XML Files / Editor / Indent using tabs/spaces. cheers tim On Sun, Sep 26, 2010 at 3:28 AM, rj...@apache.org wrote: Author: rjung Date: Sat Sep 25 14:28:36 2010 New Revision: 1001216 URL: http://svn.apache.org/viewvc?rev=1001216view=rev Log: Please no tabs. Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1001216r1=1001215r2=1001216view=diff == --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Sat Sep 25 14:28:36 2010 @@ -68,8 +68,8 @@ Old behaviour can be enabled by defining USE_CGI_HEADERS. (timw) /fix fix - bug49511/bug: IIS: Do not override IIS log information when subsequent - requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw) + bug49511/bug: IIS: Do not override IIS log information when subsequent + requests on a keep-alive connection are not mapped into the ISAPI Redirector. (timw) /fix fix Docs: Document SSLOptions needed for SSL information forwarding. (rjung) How about a pre-commit script that replaces ^(\t)+ with four spaces, on files with an extension of .java? Seen the tab thing come up a few times in my short subscription to this list. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On 26/09/2010 19:38, Wesley Acheson wrote: On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas ma...@apache.org wrote: On 26/09/2010 19:08, Wesley Acheson wrote: Commiters, patch authors. Do you use an IDE to modify tomcat source code? Yes. If you do which one? Eclipse for Java. Really do you use the formatter for the code? If so we could use your settings. No. Applying the code formatter makes too many changes and adds far to much noise to the commits. The only change I make to default Eclipse settings is to switch from tabs to spaces. Mark Visual Studio (rarely) for C code. Mark I've no idea on how to put in IDE specific files for Visual Studio. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On Sun, Sep 26, 2010 at 8:44 PM, Mark Thomas ma...@apache.org wrote: On 26/09/2010 19:38, Wesley Acheson wrote: On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas ma...@apache.org wrote: On 26/09/2010 19:08, Wesley Acheson wrote: Commiters, patch authors. Do you use an IDE to modify tomcat source code? Yes. If you do which one? Eclipse for Java. Really do you use the formatter for the code? If so we could use your settings. No. Applying the code formatter makes too many changes and adds far to much noise to the commits. Only the once though if everyone (the commiters especially) has the same format. Which is really nice. Its a big noise but its a big noise once. Wes The only change I make to default Eclipse settings is to switch from tabs to spaces. Mark Visual Studio (rarely) for C code. Mark I've no idea on how to put in IDE specific files for Visual Studio. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On 26/09/2010 19:47, Wesley Acheson wrote: Which is really nice. Its a big noise but its a big noise once. Which persists in the file's history making diffs that span the format change almost impossible to decipher. Small gradual changes is the approach the project has taken to date. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.
OK Oh how I've missed working with Bugzilla... tim On Mon, Sep 27, 2010 at 6:29 AM, Mark Thomas ma...@apache.org wrote: On 26/09/2010 09:59, Rainer Jung wrote: On 26.09.2010 10:23, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Tim Whittingtont...@apache.org changed: What |Removed |Added AssignedTo|dev@tomcat.apache.org |t...@apache.org Tim: Mark might correct me, but I think this prevents any further issue mails for 50001 being sent to the dev list (I added a test comment there to check this). Rainer is correct. (Note to self: take a look at making this field read-only). If you want to notify others you are working on an issue to reduce the risk of duplicate work, you can add a comment, although most of the time it doesn't seem necessary. If you want to track bugs you are interested in, you can e.g. add yourself to the CC list of the issue and use it in searches. +1 Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Tim Whittington t...@apache.org changed: What|Removed |Added AssignedTo|t...@apache.org |dev@tomcat.apache.org -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On 26/09/2010 19:57, Mark Thomas wrote: On 26/09/2010 19:47, Wesley Acheson wrote: Which is really nice. Its a big noise but its a big noise once. Which persists in the file's history making diffs that span the format change almost impossible to decipher. Small gradual changes is the approach the project has taken to date. There's a lot of code in Tomcat that's been around for a long time. There's a few places where cosmetic changes would help readability, and plenty more when extensive/detailed commenting (by someone who understands what that code intends to do, and actually does) would help. I'd rather see that as a priority, than applying a common code style, in the foreseeable. p 0x62590808.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature
Re: Which IDE?
On Sun, Sep 26, 2010 at 10:26 PM, Pid p...@pidster.com wrote: On 26/09/2010 19:57, Mark Thomas wrote: On 26/09/2010 19:47, Wesley Acheson wrote: Which is really nice. Its a big noise but its a big noise once. Which persists in the file's history making diffs that span the format change almost impossible to decipher. Small gradual changes is the approach the project has taken to date. There's a lot of code in Tomcat that's been around for a long time. There's a few places where cosmetic changes would help readability, and plenty more when extensive/detailed commenting (by someone who understands what that code intends to do, and actually does) would help. I'd rather see that as a priority, than applying a common code style, in the foreseeable. p Understood. The reason I was thinking it was important is to try to lower the bar. So to speak the easier you make it for people to contribute the more likely you are to get contributions. I also agree with Marks statement above I just didn't think of it at the time. And yes that would be more helpful. Though I'm sure everyone just helps in the way they can. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Atomicity violation in setAttribute
This is technically a race condition, but given the vague information provided in ServletContextAttributeEvent (e.g. the inability to differentiate adds vs replaces) I can't see it causing a real problem. i.e. there's no atomicity in the interaction of an attribute listener with the context, so a temporary internal inconsistency isn't going to hurt. val = attributes.put(name, value); if (val != null) replaced = true; +1 - this is simpler in any case. cheers tim On Mon, Sep 27, 2010 at 6:25 AM, Ian Darwin i...@darwinsys.com wrote: In this case, both threads will continue running the function with ?replaced? bit turned on and the oldValue of both thread will point to the same location. This means that the value of the first thread that did the put operation will not be treated as a value that was replaced. Could you please let me know whether you consider this as a bug? Is it any different than if two threads invoke the operation serially? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001525 - in /tomcat/trunk/java/org/apache/coyote/http11: LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties
Author: markt
Date: Sun Sep 26 21:26:08 2010
New Revision: 1001525
URL: http://svn.apache.org/viewvc?rev=1001525view=rev
Log:
Clean-up. Reduce whitespace, unnecessary comments
Modified:
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_fr.properties
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_ja.properties
Modified: tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties?rev=1001525r1=1001524r2=1001525view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/LocalStrings.properties Sun Sep
26 21:26:08 2010
@@ -13,16 +13,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# $Id$
-
-# language
-
-# package org.apache.coyote.http11
-
-#
-# Http11Protocol
-#
-
http11protocol.destroy=Destroying Coyote HTTP/1.1 on {0}
http11protocol.endpoint.initerror=Error initializing endpoint
http11protocol.endpoint.starterror=Error starting endpoint
@@ -43,10 +33,6 @@ http11protocol.endpoint.pauseerror=Error
http11protocol.resume=Resuming Coyote HTTP/1.1 on {0}
http11protocol.endpoint.resumeerror=Error resuming endpoint
-#
-# Http11Processor
-#
-
http11processor.regexp.error=Error parsing regular expression {0}
http11processor.filter.unknown=Unknown filter {0}
http11processor.filter.error=Error intializing filter {0}
@@ -60,11 +46,6 @@ http11processor.socket.info=Exception ge
http11processor.socket.ssl=Exception getting SSL attributes
http11processor.socket.timeout=Error setting socket timeout
-#
-# InternalInputBuffer
-#
-
iib.eof.error=Unexpected EOF read on the socket
iib.requestheadertoolarge.error=Request header is too large
iib.invalidmethod=Invalid character (CR or LF) found in method name
-
Modified: tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties?rev=1001525r1=1001524r2=1001525view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties Sun
Sep 26 21:26:08 2010
@@ -12,11 +12,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-# $Id$
-# language es
-# package org.apache.coyote.http11
-#
-# Http11Protocol
+
http11protocol.endpoint.initerror = Error inicializando punto final (endpoint)
http11protocol.endpoint.starterror = Error arrancando punto final (endpoint)
http11protocol.init = Inicializando Coyote HTTP/1.1 en puerto {0}
@@ -34,6 +30,7 @@ http11protocol.pause = Pausando Coyote H
http11protocol.endpoint.pauseerror = Error al pausar punto final
http11protocol.resume = Retomando Coyote HTTP/1.1 en {0}
http11protocol.endpoint.resumeerror = Error al retomar punto final
+
http11processor.regexp.error = Error al analizar expresi\u00F3n regular {0}
http11processor.filter.unknown = Filtro desconocido {0}
http11processor.filter.error = Error inicializando filtro {0}
@@ -45,10 +42,6 @@ http11processor.response.finish = Error
http11processor.socket.info = Excepci\u00F3n obteniendo informaci\u00F3n de
conector
http11processor.socket.ssl = Excepci\u00F3n obteniendo atributos SSL
http11processor.socket.timeout = Error poniendo tiempo agotado para conector
-#
-# Http11Processor
-#
-#
-# InternalInputBuffer
+
iib.eof.error = Inesperado Fin De Archivo (EOF) le\u00EDdo en el enchufe
(socket)
iib.requestheadertoolarge.error = La cabecera del requerimiento es demasido
grande
Modified: tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_fr.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_fr.properties?rev=1001525r1=1001524r2=1001525view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_fr.properties
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_fr.properties Sun
Sep 26 21:26:08 2010
@@ -13,16 +13,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# $Id$
-
-# language fr
-
-# package org.apache.coyote.http11
-
-#
-# Http11Protocol
-#
-
http11protocol.endpoint.initerror=Erreur \u00e0 l'initialisation du point de
contact
http11protocol.endpoint.starterror=Erreur au d\u00e9marrage du point de contact
Re: Which IDE?
On Sep 26, 2010, at 11:08 AM, Wesley Acheson wrote: Commiters, patch authors. Do you use an IDE to modify tomcat source code? If you do which one? IDEA Asking again in releation to bug 50001. Trying to see what ide's should be supported. My experience with IDE specific files is that checking them into svn usually causes far more problems that it solves. Maybe you'll be lucky and solve more than you cause. If I'm the only IDEA user I'd appreciate your not putting IDEA specific files in svn. thanks david jencks - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001538 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Author: markt
Date: Sun Sep 26 22:22:25 2010
New Revision: 1001538
URL: http://svn.apache.org/viewvc?rev=1001538view=rev
Log:
Better Javadoc.
If endpoint is shutting down, return false so connection to client is closed
immediately.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=1001538r1=1001537r2=1001538view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Sep 26
22:22:25 2010
@@ -490,7 +490,17 @@ public class JIoEndpoint extends Abstrac
/**
- * Process given socket.
+ * Process a new connection from a new client. Wraps the socket so
+ * keep-alive and other attributes can be tracked and then passes the
socket
+ * to the executor for processing.
+ *
+ * @param socketThe socket associated with the client.
+ *
+ * @return codetrue/code if the socket is passed to the
+ * executor, codefalse/code if something went wrong or
+ * if the endpoint is shutting down. Returning
+ * codefalse/code is an indication to close the socket
+ * immediately.
*/
protected boolean processSocket(Socket socket) {
// Process the request from this socket
@@ -500,7 +510,9 @@ public class JIoEndpoint extends Abstrac
// During shutdown, executor may be null - avoid NPE
if (running) {
getExecutor().execute(new SocketProcessor(wrapper));
+return true;
}
+return false;
} catch (RejectedExecutionException x) {
log.warn(Socket processing request was rejected for:+socket,x);
return false;
@@ -510,7 +522,6 @@ public class JIoEndpoint extends Abstrac
log.error(sm.getString(endpoint.process.fail), t);
return false;
}
-return true;
}
public boolean processSocket(SocketWrapperSocket socket, SocketStatus
status) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001545 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpProcessor.java coyote/http11/Http11Processor.java tomcat/util/net/JIoEndpoint.java
Author: markt
Date: Sun Sep 26 22:37:31 2010
New Revision: 1001545
URL: http://svn.apache.org/viewvc?rev=1001545view=rev
Log:
Add some Javadoc.
Use SocketStatus.OPEN rather than STOP since the BIO connector treats them the
same way and it reduces code complexity. It also simplifies async re-factoring
I have in the works,
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1001545r1=1001544r2=1001545view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Sun Sep 26
22:37:31 2010
@@ -660,7 +660,7 @@ public class AjpProcessor implements Act
RequestInfo rp = request.getRequestProcessor();
if ( rp.getStage() != org.apache.coyote.Constants.STAGE_SERVICE )
{ //async handling
dispatch.set(true);
-endpoint.processSocket(this.socket, SocketStatus.STOP);
+endpoint.processSocket(this.socket, SocketStatus.OPEN);
} else {
dispatch.set(false);
}
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java?rev=1001545r1=1001544r2=1001545view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Sun Sep 26
22:37:31 2010
@@ -502,7 +502,7 @@ public class Http11Processor extends Abs
RequestInfo rp = request.getRequestProcessor();
if ( rp.getStage() != org.apache.coyote.Constants.STAGE_SERVICE )
{ //async handling
dispatch.set(true);
-endpoint.processSocket(this.socket, SocketStatus.STOP);
+endpoint.processSocket(this.socket, SocketStatus.OPEN);
} else {
dispatch.set(false);
}
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=1001545r1=1001544r2=1001545view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Sep 26
22:37:31 2010
@@ -524,9 +524,23 @@ public class JIoEndpoint extends Abstrac
}
}
+
+/**
+ * Process an existing async connection. If processing is required, passes
+ * the wrapped socket to an executor for processing.
+ *
+ * @param socketThe socket associated with the client.
+ * @param statusOnly OPEN and TIMEOUT are used. The others are used for
+ * Comet requests that are not supported by the BIO (JIO)
+ * Connector.
+ * @return codetrue/code if the socket is passed to the
+ * executor, codefalse/code if something went wrong.
+ * Returning codefalse/code is an indication to close
+ * the socket immediately.
+ */
public boolean processSocket(SocketWrapperSocket socket, SocketStatus
status) {
try {
-if (status == SocketStatus.OPEN || status == SocketStatus.STOP ||
status == SocketStatus.TIMEOUT) {
+if (status == SocketStatus.OPEN || status == SocketStatus.TIMEOUT)
{
if (waitingRequests.remove(socket)) {
SocketProcessor proc = new SocketProcessor(socket,status);
ClassLoader loader =
Thread.currentThread().getContextClassLoader();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001546 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Author: markt
Date: Sun Sep 26 22:38:14 2010
New Revision: 1001546
URL: http://svn.apache.org/viewvc?rev=1001546view=rev
Log:
Since SocketStatus is always OPEN or TIMEOUT for BIO, remove the test.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=1001546r1=1001545r2=1001546view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Sep 26
22:38:14 2010
@@ -540,28 +540,26 @@ public class JIoEndpoint extends Abstrac
*/
public boolean processSocket(SocketWrapperSocket socket, SocketStatus
status) {
try {
-if (status == SocketStatus.OPEN || status == SocketStatus.TIMEOUT)
{
-if (waitingRequests.remove(socket)) {
-SocketProcessor proc = new SocketProcessor(socket,status);
-ClassLoader loader =
Thread.currentThread().getContextClassLoader();
-try {
-//threads should not be created by the webapp
classloader
-if (Globals.IS_SECURITY_ENABLED) {
-PrivilegedActionVoid pa = new PrivilegedSetTccl(
-getClass().getClassLoader());
-AccessController.doPrivileged(pa);
-} else {
-Thread.currentThread().setContextClassLoader(
-getClass().getClassLoader());
-}
-getExecutor().execute(proc);
-}finally {
-if (Globals.IS_SECURITY_ENABLED) {
-PrivilegedActionVoid pa = new
PrivilegedSetTccl(loader);
-AccessController.doPrivileged(pa);
-} else {
-
Thread.currentThread().setContextClassLoader(loader);
-}
+if (waitingRequests.remove(socket)) {
+SocketProcessor proc = new SocketProcessor(socket,status);
+ClassLoader loader =
Thread.currentThread().getContextClassLoader();
+try {
+//threads should not be created by the webapp classloader
+if (Globals.IS_SECURITY_ENABLED) {
+PrivilegedActionVoid pa = new PrivilegedSetTccl(
+getClass().getClassLoader());
+AccessController.doPrivileged(pa);
+} else {
+Thread.currentThread().setContextClassLoader(
+getClass().getClassLoader());
+}
+getExecutor().execute(proc);
+}finally {
+if (Globals.IS_SECURITY_ENABLED) {
+PrivilegedActionVoid pa = new
PrivilegedSetTccl(loader);
+AccessController.doPrivileged(pa);
+} else {
+Thread.currentThread().setContextClassLoader(loader);
}
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001548 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Author: markt
Date: Sun Sep 26 22:46:35 2010
New Revision: 1001548
URL: http://svn.apache.org/viewvc?rev=1001548view=rev
Log:
Fix a handful of Eclipse warnings
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=1001548r1=1001547r2=1001548view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Sun Sep 26
22:46:35 2010
@@ -129,6 +129,7 @@ public class NioEndpoint extends Abstrac
* Cache for SocketProcessor objects
*/
protected ConcurrentLinkedQueueSocketProcessor processorCache = new
ConcurrentLinkedQueueSocketProcessor() {
+private static final long serialVersionUID = 1L;
protected AtomicInteger size = new AtomicInteger(0);
@Override
public boolean offer(SocketProcessor sc) {
@@ -166,6 +167,7 @@ public class NioEndpoint extends Abstrac
* Cache for key attachment objects
*/
protected ConcurrentLinkedQueueKeyAttachment keyCache = new
ConcurrentLinkedQueueKeyAttachment() {
+private static final long serialVersionUID = 1L;
protected AtomicInteger size = new AtomicInteger(0);
@Override
public boolean offer(KeyAttachment ka) {
@@ -203,6 +205,7 @@ public class NioEndpoint extends Abstrac
* Cache for poller events
*/
protected ConcurrentLinkedQueuePollerEvent eventCache = new
ConcurrentLinkedQueuePollerEvent() {
+private static final long serialVersionUID = 1L;
protected AtomicInteger size = new AtomicInteger(0);
@Override
public boolean offer(PollerEvent pe) {
@@ -240,6 +243,7 @@ public class NioEndpoint extends Abstrac
* Bytebuffer cache, each channel holds a set of buffers (two, except for
SSL holds four)
*/
protected ConcurrentLinkedQueueNioChannel nioChannels = new
ConcurrentLinkedQueueNioChannel() {
+private static final long serialVersionUID = 1L;
protected AtomicInteger size = new AtomicInteger(0);
protected AtomicInteger bytes = new AtomicInteger(0);
@Override
@@ -857,6 +861,7 @@ public class NioEndpoint extends Abstrac
reset(null, null, 0);
}
+@Override
public void run() {
if ( interestOps == OP_REGISTER ) {
try {
@@ -1039,6 +1044,7 @@ public class NioEndpoint extends Abstrac
* The background thread that listens for incoming TCP/IP connections
and
* hands them off to an appropriate processor.
*/
+@Override
public void run() {
// Loop until we receive a shutdown command
while (running) {
@@ -1436,8 +1442,11 @@ public class NioEndpoint extends Abstrac
}
}
+@Override
public ByteBuffer expand(ByteBuffer buffer, int remaining) {return
buffer;}
+@Override
public ByteBuffer getReadBuffer() {return readbuf;}
+@Override
public ByteBuffer getWriteBuffer() {return writebuf;}
}
@@ -1478,6 +1487,7 @@ public class NioEndpoint extends Abstrac
this.status = status;
}
+@Override
public void run() {
SelectionKey key = null;
try {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001552 - /tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Author: markt
Date: Sun Sep 26 22:50:30 2010
New Revision: 1001552
URL: http://svn.apache.org/viewvc?rev=1001552view=rev
Log:
More NPE avoidance.
Keep process methods aligned.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=1001552r1=1001551r2=1001552view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Sep 26
22:50:30 2010
@@ -508,11 +508,10 @@ public class JIoEndpoint extends Abstrac
SocketWrapperSocket wrapper = new SocketWrapperSocket(socket);
wrapper.setKeepAliveLeft(getMaxKeepAliveRequests());
// During shutdown, executor may be null - avoid NPE
-if (running) {
-getExecutor().execute(new SocketProcessor(wrapper));
-return true;
+if (!running) {
+return false;
}
-return false;
+getExecutor().execute(new SocketProcessor(wrapper));
} catch (RejectedExecutionException x) {
log.warn(Socket processing request was rejected for:+socket,x);
return false;
@@ -522,6 +521,7 @@ public class JIoEndpoint extends Abstrac
log.error(sm.getString(endpoint.process.fail), t);
return false;
}
+return true;
}
@@ -553,6 +553,10 @@ public class JIoEndpoint extends Abstrac
Thread.currentThread().setContextClassLoader(
getClass().getClassLoader());
}
+// During shutdown, executor may be null - avoid NPE
+if (!running) {
+return false;
+}
getExecutor().execute(proc);
}finally {
if (Globals.IS_SECURITY_ENABLED) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001553 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractEndpoint.java NioSelectorPool.java jsse/JSSEImplementation.java jsse/JSSESocketFactory.java
Author: markt
Date: Sun Sep 26 22:58:38 2010
New Revision: 1001553
URL: http://svn.apache.org/viewvc?rev=1001553view=rev
Log:
Remove some unused code.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=1001553r1=1001552r2=1001553view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Sun Sep
26 22:58:38 2010
@@ -93,7 +93,6 @@ public abstract class AbstractEndpoint {
public static final String SSL_ATTR_KEYSTORE_PROVIDER = keystoreProvider;
public static final String SSL_ATTR_SSL_PROTOCOL = sslProtocol;
public static final String SSL_ATTR_CIPHERS = ciphers;
-public static final String SSL_ATTR_CIPHERS_ARRAY = ciphersArray;
public static final String SSL_ATTR_KEY_ALIAS = keyAlias;
public static final String SSL_ATTR_KEY_PASS = keyPass;
public static final String SSL_ATTR_TRUSTSTORE_FILE = truststoreFile;
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java?rev=1001553r1=1001552r2=1001553view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java Sun Sep
26 22:58:38 2010
@@ -43,8 +43,6 @@ public class NioSelectorPool {
public NioSelectorPool() {
}
-protected static int threadCount = 0;
-
private static final Log log = LogFactory.getLog(NioSelectorPool.class);
protected final static boolean SHARED =
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java?rev=1001553r1=1001552r2=1001553view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
Sun Sep 26 22:58:38 2010
@@ -36,9 +36,6 @@ public class JSSEImplementation extends
{
static final String SSLSocketClass = javax.net.ssl.SSLSocket;
-static final org.apache.juli.logging.Log logger =
-org.apache.juli.logging.LogFactory.getLog(JSSEImplementation.class);
-
private JSSEFactory factory = null;
public JSSEImplementation() throws ClassNotFoundException {
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?rev=1001553r1=1001552r2=1001553view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
Sun Sep 26 22:58:38 2010
@@ -83,7 +83,6 @@ public class JSSESocketFactory
// Defaults - made public where re-used
static String defaultProtocol = TLS;
-static boolean defaultClientAuth = false;
static String defaultKeystoreType = JKS;
private static final String defaultKeystoreFile
= System.getProperty(user.home) + /.keystore;
@@ -96,7 +95,6 @@ public class JSSESocketFactory
org.apache.juli.logging.LogFactory.getLog(JSSESocketFactory.class);
protected boolean initialized;
-protected String clientAuth = false;
protected SSLServerSocketFactory sslProxy = null;
protected String[] enabledCiphers;
protected boolean allowUnsafeLegacyRenegotiation = false;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On Mon, Sep 27, 2010 at 12:18 AM, David Jencks david_jen...@yahoo.com wrote: On Sep 26, 2010, at 11:08 AM, Wesley Acheson wrote: Commiters, patch authors. Do you use an IDE to modify tomcat source code? If you do which one? IDEA Asking again in releation to bug 50001. Trying to see what ide's should be supported. My experience with IDE specific files is that checking them into svn usually causes far more problems that it solves. Maybe you'll be lucky and solve more than you cause. If I'm the only IDEA user I'd appreciate your not putting IDEA specific files in svn. thanks david jencks 1. I wasn't intending in putting anything where it would automatically be used. 2. I was hoping to munge files. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001564 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpProcessor.java coyote/http11/Http11Processor.java tomcat/util/net/JIoEndpoint.java
Author: markt
Date: Mon Sep 27 00:17:26 2010
New Revision: 1001564
URL: http://svn.apache.org/viewvc?rev=1001564view=rev
Log:
Change method name so it is easier to distinguish between async and comet
processing. No so important here since comet isn't supported, but need to
change it to align with changes to be made in NIO and APR
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1001564r1=1001563r2=1001564view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Mon Sep 27
00:17:26 2010
@@ -660,7 +660,7 @@ public class AjpProcessor implements Act
RequestInfo rp = request.getRequestProcessor();
if ( rp.getStage() != org.apache.coyote.Constants.STAGE_SERVICE )
{ //async handling
dispatch.set(true);
-endpoint.processSocket(this.socket, SocketStatus.OPEN);
+endpoint.processSocketAsync(this.socket, SocketStatus.OPEN);
} else {
dispatch.set(false);
}
@@ -674,7 +674,7 @@ public class AjpProcessor implements Act
RequestInfo rp = request.getRequestProcessor();
AtomicBoolean dispatch = (AtomicBoolean)param;
if ( rp.getStage() != org.apache.coyote.Constants.STAGE_SERVICE )
{//async handling
-endpoint.processSocket(this.socket, SocketStatus.OPEN);
+endpoint.processSocketAsync(this.socket, SocketStatus.OPEN);
dispatch.set(true);
} else {
dispatch.set(true);
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java?rev=1001564r1=1001563r2=1001564view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Mon Sep 27
00:17:26 2010
@@ -502,7 +502,7 @@ public class Http11Processor extends Abs
RequestInfo rp = request.getRequestProcessor();
if ( rp.getStage() != org.apache.coyote.Constants.STAGE_SERVICE )
{ //async handling
dispatch.set(true);
-endpoint.processSocket(this.socket, SocketStatus.OPEN);
+endpoint.processSocketAsync(this.socket, SocketStatus.OPEN);
} else {
dispatch.set(false);
}
@@ -516,7 +516,7 @@ public class Http11Processor extends Abs
RequestInfo rp = request.getRequestProcessor();
AtomicBoolean dispatch = (AtomicBoolean)param;
if ( rp.getStage() != org.apache.coyote.Constants.STAGE_SERVICE )
{//async handling
-endpoint.processSocket(this.socket, SocketStatus.OPEN);
+endpoint.processSocketAsync(this.socket, SocketStatus.OPEN);
dispatch.set(true);
} else {
dispatch.set(true);
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=1001564r1=1001563r2=1001564view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Mon Sep 27
00:17:26 2010
@@ -149,7 +149,7 @@ public class JIoEndpoint extends Abstrac
SocketWrapperSocket socket = sockets.next();
long access = socket.getLastAccess();
if ((now-access)socket.getTimeout()) {
-processSocket(socket,SocketStatus.TIMEOUT);
+processSocketAsync(socket,SocketStatus.TIMEOUT);
}
}
@@ -538,7 +538,8 @@ public class JIoEndpoint extends Abstrac
* Returning codefalse/code is an indication to close
* the socket immediately.
*/
-public boolean processSocket(SocketWrapperSocket socket, SocketStatus
status) {
+public boolean processSocketAsync(SocketWrapperSocket socket,
+SocketStatus status) {
try {
if (waitingRequests.remove(socket)) {
SocketProcessor proc = new SocketProcessor(socket,status);
-
To unsubscribe,
Re: DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.
On 26 September 2010 18:29, Mark Thomas ma...@apache.org wrote: On 26/09/2010 09:59, Rainer Jung wrote: On 26.09.2010 10:23, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Tim Whittingtont...@apache.org changed: What |Removed |Added AssignedTo|dev@tomcat.apache.org |t...@apache.org Tim: Mark might correct me, but I think this prevents any further issue mails for 50001 being sent to the dev list (I added a test comment there to check this). Rainer is correct. (Note to self: take a look at making this field read-only). Hope you don't mind - I created a JIRA enhancement request for this: https://issues.apache.org/jira/browse/INFRA-3015 If you want to notify others you are working on an issue to reduce the risk of duplicate work, you can add a comment, although most of the time it doesn't seem necessary. If you want to track bugs you are interested in, you can e.g. add yourself to the CC list of the issue and use it in searches. +1 Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1001566 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kfujino Date: Mon Sep 27 01:40:53 2010 New Revision: 1001566 URL: http://svn.apache.org/viewvc?rev=1001566view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1001566r1=1001565r2=1001566view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Sep 27 01:40:53 2010 @@ -164,7 +164,7 @@ PATCHES PROPOSED TO BACKPORT: * Update commons pool to 1.5.5 http://svn.apache.org/viewvc?rev=996163view=rev (Changelog: http://commons.apache.org/pool/changes-report.html#a1.5.5) - +1: markt, kkolinko + +1: markt, kkolinko, kfujino -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49924 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
