[g...@vmgump]: Project taglibs-parent (in module tomcat-taglibs) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project taglibs-parent has an issue affecting its community integration. This issue affects 4 projects, and has been outstanding for 12 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - taglibs-parent : Taglib Parent POM - taglibs-standard-spec : JSP Taglibs - tomcat-taglibs-standard : Standard Taglib - tomcat-taglibs-standard-install : JSP Taglibs Full details are available at: http://vmgump.apache.org/gump/public/tomcat-taglibs/taglibs-parent/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole pom output [pom.xml] identifier set to project name -INFO- Optional dependency velocity-engine prerequisite failed with reason build failed -INFO- Optional dependency doxia-site-renderer prerequisite failed with reason build failed -INFO- Optional dependency commons-io failed with reason build failed -INFO- Optional dependency commons-collections failed with reason build failed -DEBUG- (Apache Gump generated) Apache Maven Settings in: /srv/gump/public/workspace/tomcat-taglibs/taglibs-parent/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/tomcat-taglibs/taglibs-parent/pom.xml -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/tomcat-taglibs/taglibs-parent/gump_work/build_tomcat-taglibs_taglibs-parent.html Work Name: build_tomcat-taglibs_taglibs-parent (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /opt/maven2/bin/mvn --batch-mode --settings /srv/gump/public/workspace/tomcat-taglibs/taglibs-parent/gump_mvn_settings.xml install [Working Directory: /srv/gump/public/workspace/tomcat-taglibs/taglibs-parent] M2_HOME: /opt/maven2 - at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) Caused by: org.apache.maven.project.ProjectBuildingException: Cannot find parent: org.apache:apache for project: org.apache.taglibs:taglibs-parent:pom:1-SNAPSHOT for project org.apache.taglibs:taglibs-parent:pom:1-SNAPSHOT at org.apache.maven.project.DefaultMavenProjectBuilder.assembleLineage(DefaultMavenProjectBuilder.java:1396) at org.apache.maven.project.DefaultMavenProjectBuilder.buildInternal(DefaultMavenProjectBuilder.java:823) at org.apache.maven.project.DefaultMavenProjectBuilder.buildFromSourceFileInternal(DefaultMavenProjectBuilder.java:508) at org.apache.maven.project.DefaultMavenProjectBuilder.build(DefaultMavenProjectBuilder.java:200) at org.apache.maven.DefaultMaven.getProject(DefaultMaven.java:604) at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:487) at org.apache.maven.DefaultMaven.getProjects(DefaultMaven.java:391) ... 12 more Caused by: org.apache.maven.project.ProjectBuildingException: POM 'org.apache:apache' not found in repository: Unable to download the artifact from any repository org.apache:apache:pom:7 from the specified remote repositories: gump-central (http://localhost:8192/maven2) for project org.apache:apache at org.apache.maven.project.DefaultMavenProjectBuilder.findModelFromRepository(DefaultMavenProjectBuilder.java:605) at org.apache.maven.project.DefaultMavenProjectBuilder.assembleLineage(DefaultMavenProjectBuilder.java:1392) ... 18 more Caused by: org.apache.maven.artifact.resolver.ArtifactNotFoundException: Unable to download the artifact from any repository org.apache:apache:pom:7 from the specified remote repositories: gump-central (http://localhost:8192/maven2) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:228) at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:90) at
Bug report for Taglibs [2010/12/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27717|New|Maj|2004-03-16|x:forEach very slow in JSTL 1.1 | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | |49578|New|Nor|2010-07-09|XPath handling only supports single reference to v| |50064|New|Nor|2010-10-09|bundle-ify the taglibs jars | |50068|New|Nor|2010-10-09|Memory leak with Driver registration | |50250|New|Maj|2010-11-10|Split package issue in impl and jstlel bundles| |50263|New|Nor|2010-11-13|README_src.txt out of date| |50265|New|Nor|2010-11-13|FormatDateSupport.dateFormatCache lazy init is not| |50414|New|Nor|2010-12-05|tlv package cause another split package issue in i| +-+---+---+--+--+ | Total 13 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 5 [2010/12/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, | |38577|Inf|Enh|2006-02-08|Enhance logging of security failures | |38916|Inf|Enh|2006-03-10|HttpServletRequest cannot handle multipart request| |39053|Inf|Enh|2006-03-21|include Tomcat embedded sample| |39740|New|Enh|2006-06-07|semi-colon ; isn't allowed as a query argument sep| |39862|Inf|Enh|2006-06-22|provide support for protocol-independent GenericSe| |40211|Inf|Enh|2006-08-08|Compiled JSP don't indent HTML code | |40402|New|Enh|2006-09-03|Manager should display Exceptions | |40510|New|Enh|2006-09-14|installer does not create shortcuts for all users | |40712|New|Enh|2006-10-10|Realm admin error.| |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov| |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel - | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment| |41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i| |41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C| |41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co| |41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume| |41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar| |41673|New|Enh|2007-02-21|Jasper output the message of compiling error using| |41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows| |41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af| |41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe| |42416|New|Enh|2007-05-14|Tomcat startup hangs and AJP13 connector port 8009| |43423|New|Enh|2007-09-18|catalina.sh -force too fast | |43538|New|Enh|2007-10-02|[patch] Show the hostname and IP address in the ma| |43796|Inf|Enh|2007-11-05|Add MIME type mapping for the log extension | |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |43960|New|Enh|2007-11-26|Expose StandardWrapper unavailable and/or availabl| |43991|New|Enh|2007-11-29|Contributing a URLResourceFactory | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr|
Bug report for Tomcat Connectors [2010/12/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk | |39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta| |40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a| |41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort | |42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio| |42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work | |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 apache 2.2.9 static compiled on so| |45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being| |46337|New|Nor|2008-12-04|real worker name is wrong | |46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper| |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i| |47692|New|Reg|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |48940|New|Maj|2010-03-18|IIS to Tomcat occasionally fails on POST with T-E | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49048|New|Nor|2010-04-05|ACL not applied to redirect URLs | |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49413|Opn|Reg|2010-06-09|Apache Mod_jk 1.2.30 is shutting down communicatio| |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |50233|New|Cri|2010-11-08|support long URLs (more than 2048)|
Bug report for Tomcat Modules [2010/12/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49543|New|Enh|2010-07-02|Request for a shared datasource configuration as| |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |49953|New|Nor|2010-09-17|Missing @Override annotations | |49954|New|Nor|2010-09-17|Code tidyup | |50025|New|Cri|2010-09-29|getConnection method in class DataSourceProxy is i| |50333|New|Nor|2010-11-25|IllegalArgumentException occurs when setting maxAc| +-+---+---+--+--+ | Total 10 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2010/12/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti| |41361|New|Nor|2007-01-14|Content lost when read by a slow client. | |42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections| |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ| |46179|New|Maj|2008-11-10|apr ssl client authentication | |46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris| |47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown| |47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code | |48253|New|Min|2009-11-20|Tomcat Native patch - adding dynamic locking callb| |48655|New|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |49556|New|Cri|2010-07-05|the proc.create function used args as env to get t| |49557|New|Cri|2010-07-05|index erro in the loop to get the env info in the | |49595|New|Cri|2010-07-15|Tomcat crashes in tcnative-1.dll frequently | |49795|New|Nor|2010-08-22|Crash in Socket.destroy | |49796|New|Nor|2010-08-22|Crash in SSLSocket.handshake()| |49851|New|Blk|2010-08-31|JNI Registry.deleteKey and Registry.deleteValue co| |50135|New|Nor|2010-10-21|IPV6 problem: unable to connect from other host | |50394|New|Nor|2010-12-01|InternalAprInputBuffer.fill() doesn't deal correct| |50410|New|Nor|2010-12-03|Poll.create with THREADSAFE will silently switch t| +-+---+---+--+--+ | Total 21 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1044729 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java res/checkstyle/org-import-control.xml
On 11 December 2010 21:48, ma...@apache.org wrote:
Author: markt
Date: Sat Dec 11 21:48:22 2010
New Revision: 1044729
URL: http://svn.apache.org/viewvc?rev=1044729view=rev
Log:
o.a.tomcat.jni should not have any external dependencies
Maybe document this in the source file?
OK for o.a.naming to have dependencies
Modified:
tomcat/trunk/java/org/apache/tomcat/jni/Library.java
tomcat/trunk/res/checkstyle/org-import-control.xml
Modified: tomcat/trunk/java/org/apache/tomcat/jni/Library.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/jni/Library.java?rev=1044729r1=1044728r2=1044729view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/jni/Library.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/jni/Library.java Sat Dec 11 21:48:22
2010
@@ -17,8 +17,6 @@
package org.apache.tomcat.jni;
Could add a note here that external dependencies are not allowed.
[Much easier to spot than an SVN log message in a few years time]
-import org.apache.tomcat.util.ExceptionUtils;
-
/** Library
*
* @author Mladen Turk
@@ -44,8 +42,13 @@ public final class Library {
System.loadLibrary(NAMES[i]);
loaded = true;
}
- catch (Throwable e) {
- ExceptionUtils.handleThrowable(e);
+ catch (Throwable t) {
+ if (t instanceof ThreadDeath) {
+ throw (ThreadDeath) t;
+ }
+ if (t instanceof VirtualMachineError) {
+ throw (VirtualMachineError) t;
+ }
String name = System.mapLibraryName(NAMES[i]);
String path = System.getProperty(java.library.path);
String sep = System.getProperty(path.separator);
@@ -53,12 +56,12 @@ public final class Library {
for (int j=0; jpaths.length; j++) {
java.io.File fd = new java.io.File(paths[j] , name);
if (fd.exists()) {
- e.printStackTrace();
+ t.printStackTrace();
}
}
if ( i 0)
err += , ;
- err += e.getMessage();
+ err += t.getMessage();
}
if (loaded)
break;
Modified: tomcat/trunk/res/checkstyle/org-import-control.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/checkstyle/org-import-control.xml?rev=1044729r1=1044728r2=1044729view=diff
==
--- tomcat/trunk/res/checkstyle/org-import-control.xml (original)
+++ tomcat/trunk/res/checkstyle/org-import-control.xml Sat Dec 11 21:48:22
2010
@@ -72,7 +72,6 @@
allow pkg=javax.mail/
allow pkg=javax.wsdl/
allow pkg=org.apache.naming/
- !-- To remove? --
allow class=org.apache.catalina.util.RequestUtil/
allow class=org.apache.tomcat.util.http.FastHttpDateFormat/
/subpackage
@@ -81,10 +80,7 @@
subpackage name=buildutil
allow pkg=org.apache.tools.ant/
/subpackage
- subpackage name=jni
- !-- To remove? --
- allow class=org.apache.tomcat.util.ExceptionUtils/
- /subpackage
+ subpackage name=jni/
subpackage name=util
allow pkg=org.apache.juli/
allow pkg=org.apache.tomcat.jni/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of PoweredBy by DavidGhedini
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Tomcat Wiki for change
notification.
The PoweredBy page has been changed by DavidGhedini.
http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=279rev2=280
--
[[http://www.2020media.com/|2020Media.com]] Longest established UK Tomcat
host. Over a decade of Tomcat hosting expertise. Plans on shared, private and
dedicated Tomcat servers. Customer has full control over tomcat, SSH access and
Tomcat version choice.
- === Application Outsource UK Ltd. ===
- {{http://www.application-outsource.co.uk/images/logo.gif}}
+ === Enciva ===
+ {{http://www.enciva.com/images/logo.gif}}
- [[http://www.application-outsource.co.uk/|Application Outsource UK Ltd.]]
offers a variety of affordable Tomcat hosting options. Oracle and MySQL. Tomcat
5 and 6. Choice of US or UK locations. All plans feature private Tomcat
instance. Plans for every budget.
+ [[http://www.enciva.com/|Enciva Solutions Ltd.]] offers premium U.S. and U.K
based Tomcat hosting solutions. MySQL, Oracle, and PostgreSQL database options.
Tomcat 5, 6, and 7. All plans feature private JVM and 1Gbps network speed. VPS
and dedicated solutions also available.
=== WebAppCabaret Hosting ===
{{http://www.webappcabaret.com/wac/waclogo.gif}}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of PoweredBy by DavidGhedini
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Tomcat Wiki for change
notification.
The PoweredBy page has been changed by DavidGhedini.
http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=280rev2=281
--
[[http://www.2020media.com/|2020Media.com]] Longest established UK Tomcat
host. Over a decade of Tomcat hosting expertise. Plans on shared, private and
dedicated Tomcat servers. Customer has full control over tomcat, SSH access and
Tomcat version choice.
+ === WebAppCabaret Hosting ===
+ {{http://www.webappcabaret.com/wac/waclogo.gif}}
+
+ [[http://www.webappcabaret.com/|WebAppCabaret]] is the oldest JAVA Web
hosting provider. Features include one-click installation of many versions of
Tomcat.
+
+ === björn hahnefeld IT TC_Framework ===
+ {{http://www.hahnefeld.de/images/archive/small.jpg}} björn hahnefeld IT
TC_Framework [[http://www.hahnefeld.de|björn hahnefeld IT]] runs on Tomcat. It
is a Framework for the ATOSS employee portal with runs on Tomcat too.
Hosting-Plans for the björn hahnefeld IT TC_Framework can be booked under
[[http://www.hahnefeld.de/internet-services_server.html|TomCat Co-Location and
Serverhousing]]. The björn hahnefeld IT TC_Framework for project and time
control is live in action in four companies at the moment:
[[http://www.schoen-alarm.at|Gerald Schön Elektro- Sicherheitstechnik]], Shop
for
[[http://www.video-security-solutions.eu/dallmeier-recorder/dallmeier-hybrid-recorder-videonetbox.html|VideoNetBox]]
/ [[http://www.video-security-solutions.eu|Dallmeier]],
[[http://www.konstruktionsbuero-dos.de|Konstruktionsbüro DOS]] and
[[http://www.brot-und-wein.eu|Enoteca Brot Wein]].
+
+ === Bodhost.com ===
+ [[http://www.bodhost.com/|BODHost]] - Proud to be Apache Tomcat Hosting
Provider
+
+ === DreamShared ===
+ {{http://www.dreamshared.com/site/images/v2/logo_no_bg.png}}
[[http://www.dreamshared.com/|DreamShared]] uses Tomcat to help people design
and host unique, stylish, custom business websites and wedding websites.
+
+ === eApps Hosting ===
+ {{http://www.eapps.com/images/header_logo.jpg}}
http://www.eapps.com/applications/tomcat-hosting.php eApps Hosting has provided
hosting for Java applications using Tomcat since 2000 and now offers Tomcat
hosting in a reliable, economical VPS container with 24/7 support by in-house
staff.
+
=== Enciva ===
{{http://www.enciva.com/images/logo.gif}}
[[http://www.enciva.com/|Enciva Solutions Ltd.]] offers premium U.S. and U.K
based Tomcat hosting solutions. MySQL, Oracle, and PostgreSQL database options.
Tomcat 5, 6, and 7. All plans feature private JVM and 1Gbps network speed. VPS
and dedicated solutions also available.
-
- === WebAppCabaret Hosting ===
- {{http://www.webappcabaret.com/wac/waclogo.gif}}
-
- [[http://www.webappcabaret.com/|WebAppCabaret]] is the oldest JAVA Web
hosting provider. Features include one-click installation of many versions of
Tomcat.
-
- === björn hahnefeld IT TC_Framework ===
- {{http://www.hahnefeld.de/images/archive/small.jpg}} björn hahnefeld IT
TC_Framework [[http://www.hahnefeld.de|björn hahnefeld IT]] runs on Tomcat. It
is a Framework for the ATOSS employee portal with runs on Tomcat too.
Hosting-Plans for the björn hahnefeld IT TC_Framework can be booked under
[[http://www.hahnefeld.de/internet-services_server.html|TomCat Co-Location and
Serverhousing]]. The björn hahnefeld IT TC_Framework for project and time
control is live in action in four companies at the moment:
[[http://www.schoen-alarm.at|Gerald Schön Elektro- Sicherheitstechnik]], Shop
for
[[http://www.video-security-solutions.eu/dallmeier-recorder/dallmeier-hybrid-recorder-videonetbox.html|VideoNetBox]]
/ [[http://www.video-security-solutions.eu|Dallmeier]],
[[http://www.konstruktionsbuero-dos.de|Konstruktionsbüro DOS]] and
[[http://www.brot-und-wein.eu|Enoteca Brot Wein]].
-
- === Bodhost.com ===
- [[http://www.bodhost.com/|BODHost]] - Proud to be Apache Tomcat Hosting
Provider
-
- === DreamShared ===
- {{http://www.dreamshared.com/site/images/v2/logo_no_bg.png}}
[[http://www.dreamshared.com/|DreamShared]] uses Tomcat to help people design
and host unique, stylish, custom business websites and wedding websites.
-
- === eApps Hosting ===
- {{http://www.eapps.com/images/header_logo.jpg}}
http://www.eapps.com/applications/tomcat-hosting.php eApps Hosting has provided
hosting for Java applications using Tomcat since 2000 and now offers Tomcat
hosting in a reliable, economical VPS container with 24/7 support by in-house
staff.
=== Energized Hosting ===
[[http://www.energizedhosting.com|Energized Hosting]] uses Tomcat for its
[[http://www.energizedhosting.com/hosting_jsp.html|Servlet/JSP hosting]] needs.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail:
svn commit: r1044858 - /tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java
Author: markt
Date: Sun Dec 12 17:24:47 2010
New Revision: 1044858
URL: http://svn.apache.org/viewvc?rev=1044858view=rev
Log:
Fix FindBugs issues in this class
Modified:
tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java
Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java?rev=1044858r1=1044857r2=1044858view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java Sun Dec 12
17:24:47 2010
@@ -1026,8 +1026,8 @@ public abstract class ManagerBase extend
int oldMaxActiveSessions = this.maxActiveSessions;
this.maxActiveSessions = max;
support.firePropertyChange(maxActiveSessions,
- new Integer(oldMaxActiveSessions),
- new Integer(this.maxActiveSessions));
+ Integer.valueOf(oldMaxActiveSessions),
+ Integer.valueOf(this.maxActiveSessions));
}
@@ -1147,7 +1147,7 @@ public abstract class ManagerBase extend
}
if (counter 0) {
if (oldest now) {
-result = (int) ((1000*60*counter)/(now - oldest));
+result = (1000*60*counter)/(int) (now - oldest);
} else {
result = Integer.MAX_VALUE;
}
@@ -1190,7 +1190,7 @@ public abstract class ManagerBase extend
}
if (counter 0) {
if (oldest now) {
-result = (int) ((1000*60*counter)/(now - oldest));
+result = (1000*60*counter)/(int) (now - oldest);
} else {
// Better than reporting zero
result = Integer.MAX_VALUE;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044874 - in /tomcat/trunk: java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/util/SessionIdGenerator.java test/org/apache/catalina/session/Benchmarks.java
Author: markt
Date: Sun Dec 12 18:30:03 2010
New Revision: 1044874
URL: http://svn.apache.org/viewvc?rev=1044874view=rev
Log:
Re-factor session ID generation into a separate class so it can be re-used for
SSO (patch for that to follow)
Added:
tomcat/trunk/java/org/apache/catalina/util/SessionIdGenerator.java (with
props)
Modified:
tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java
tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java
Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java?rev=1044874r1=1044873r2=1044874view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java Sun Dec 12
18:30:03 2010
@@ -23,9 +23,6 @@ import java.beans.PropertyChangeEvent;
import java.beans.PropertyChangeListener;
import java.beans.PropertyChangeSupport;
import java.io.IOException;
-import java.security.NoSuchAlgorithmException;
-import java.security.NoSuchProviderException;
-import java.security.SecureRandom;
import java.util.ArrayList;
import java.util.Date;
import java.util.Deque;
@@ -35,9 +32,7 @@ import java.util.Iterator;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
-import java.util.Queue;
import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.atomic.AtomicLong;
import org.apache.catalina.Container;
@@ -48,6 +43,7 @@ import org.apache.catalina.Manager;
import org.apache.catalina.Session;
import org.apache.catalina.mbeans.MBeanUtils;
import org.apache.catalina.util.LifecycleMBeanBase;
+import org.apache.catalina.util.SessionIdGenerator;
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
import org.apache.tomcat.util.res.StringManager;
@@ -109,44 +105,37 @@ public abstract class ManagerBase extend
/**
- * Queue of random number generator objects to be used when creating
session
- * identifiers. If the queue is empty when a random number generator is
- * required, a new random number generator object is created. This is
- * designed this way since random number generator use a sync to make them
- * thread-safe and the sync makes using a a single object slow(er).
- */
-protected QueueSecureRandom randoms =
-new ConcurrentLinkedQueueSecureRandom();
-
-/**
* The Java class name of the secure random number generator class to be
* used when generating session identifiers. The random number generator
* class must be self-seeding and have a zero-argument constructor. If not
- * specified, an instance of {...@link SecureRandom} will be generated.
+ * specified, an instance of {...@link java.secure.SecureRandom} will be
+ * generated.
*/
protected String secureRandomClass = null;
/**
* The name of the algorithm to use to create instances of
- * {...@link SecureRandom} which are used to generate session IDs. If no
- * algorithm is specified, SHA1PRNG is used. To use the platform default
- * (which may be SHA1PRNG), specify the empty string. If an invalid
- * algorithm and/or provider is specified the {...@link SecureRandom}
instances
- * will be created using the defaults. If that fails, the {...@link
- * SecureRandom} instances will be created using platform defaults.
+ * {...@link java.secure.SecureRandom} which are used to generate session
IDs.
+ * If no algorithm is specified, SHA1PRNG is used. To use the platform
+ * default (which may be SHA1PRNG), specify the empty string. If an invalid
+ * algorithm and/or provider is specified the SecureRandom instances will
be
+ * created using the defaults. If that fails, the SecureRandom instances
+ * will be created using platform defaults.
*/
protected String secureRandomAlgorithm = SHA1PRNG;
/**
* The name of the provider to use to create instances of
- * {...@link SecureRandom} which are used to generate session IDs. If
- * no algorithm is specified the of SHA1PRNG default is used. If an invalid
- * algorithm and/or provider is specified the {...@link SecureRandom}
instances
- * will be created using the defaults. If that fails, the {...@link
- * SecureRandom} instances will be created using platform defaults.
+ * {...@link java.secure.SecureRandom} which are used to generate session
IDs.
+ * If no algorithm is specified the of SHA1PRNG default is used. If an
+ * invalid algorithm and/or provider is specified the SecureRandom
instances
+ * will be created using the defaults. If that fails, the SecureRandom
+ * instances will be created using platform defaults.
*/
protected
svn commit: r1044879 - in /tomcat/trunk: java/org/apache/catalina/authenticator/AuthenticatorBase.java webapps/docs/config/valve.xml
Author: markt
Date: Sun Dec 12 18:47:10 2010
New Revision: 1044879
URL: http://svn.apache.org/viewvc?rev=1044879view=rev
Log:
Use the newly refactored session id generator when generating sso session IDs
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
tomcat/trunk/webapps/docs/config/valve.xml
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java?rev=1044879r1=1044878r2=1044879view=diff
==
--- tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
Sun Dec 12 18:47:10 2010
@@ -20,13 +20,10 @@ package org.apache.catalina.authenticato
import java.io.IOException;
-import java.security.MessageDigest;
-import java.security.NoSuchAlgorithmException;
import java.security.Principal;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.Locale;
-import java.util.Random;
import javax.servlet.ServletException;
import javax.servlet.http.Cookie;
@@ -45,6 +42,7 @@ import org.apache.catalina.connector.Res
import org.apache.catalina.deploy.LoginConfig;
import org.apache.catalina.deploy.SecurityConstraint;
import org.apache.catalina.util.DateTool;
+import org.apache.catalina.util.SessionIdGenerator;
import org.apache.catalina.valves.ValveBase;
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
@@ -137,20 +135,6 @@ public abstract class AuthenticatorBase
/**
- * Return the MessageDigest implementation to be used when
- * creating session identifiers.
- */
-protected MessageDigest digest = null;
-
-
-/**
- * A String initialization parameter used to increase the entropy of
- * the initialization of our random number generator.
- */
-protected String entropy = null;
-
-
-/**
* Descriptive information about this implementation.
*/
protected static final String info =
@@ -169,17 +153,36 @@ public abstract class AuthenticatorBase
protected boolean securePagesWithPragma = true;
/**
- * A random number generator to use when generating session identifiers.
+ * The Java class name of the secure random number generator class to be
+ * used when generating SSO session identifiers. The random number
generator
+ * class must be self-seeding and have a zero-argument constructor. If not
+ * specified, an instance of {...@link java.secure.SecureRandom} will be
+ * generated.
*/
-protected Random random = null;
+protected String secureRandomClass = null;
+/**
+ * The name of the algorithm to use to create instances of
+ * {...@link java.secure.SecureRandom} which are used to generate SSO
session
+ * IDs. If no algorithm is specified, SHA1PRNG is used. To use the platform
+ * default (which may be SHA1PRNG), specify the empty string. If an invalid
+ * algorithm and/or provider is specified the SecureRandom instances will
be
+ * created using the defaults. If that fails, the SecureRandom instances
+ * will be created using platform defaults.
+ */
+protected String secureRandomAlgorithm = SHA1PRNG;
/**
- * The Java class name of the random number generator class to be used
- * when generating session identifiers.
+ * The name of the provider to use to create instances of
+ * {...@link java.secure.SecureRandom} which are used to generate session
SSO
+ * IDs. If no algorithm is specified the of SHA1PRNG default is used. If an
+ * invalid algorithm and/or provider is specified the SecureRandom
instances
+ * will be created using the defaults. If that fails, the SecureRandom
+ * instances will be created using platform defaults.
*/
-protected String randomClass = java.security.SecureRandom;
+protected String secureRandomProvider = null;
+protected SessionIdGenerator sessionIdGenerator = null;
/**
* The string manager for this package.
@@ -280,33 +283,6 @@ public abstract class AuthenticatorBase
/**
- * Return the entropy increaser value, or compute a semi-useful value
- * if this String has not yet been set.
- */
-public String getEntropy() {
-
-// Calculate a semi-useful value if this has not been set
-if (this.entropy == null)
-setEntropy(this.toString());
-
-return (this.entropy);
-
-}
-
-
-/**
- * Set the entropy increaser value.
- *
- * @param entropy The new entropy increaser value
- */
-public void setEntropy(String entropy) {
-
-this.entropy = entropy;
-
-}
-
-
-/**
* Return descriptive information about this Valve implementation.
*/
@Override
svn commit: r1044881 - in /tomcat/trunk/java/org/apache/catalina: session/ util/
Author: markt
Date: Sun Dec 12 18:55:52 2010
New Revision: 1044881
URL: http://svn.apache.org/viewvc?rev=1044881view=rev
Log:
i18n changes for r1044874
Modified:
tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/session/LocalStrings_es.properties
tomcat/trunk/java/org/apache/catalina/session/LocalStrings_fr.properties
tomcat/trunk/java/org/apache/catalina/session/LocalStrings_ja.properties
tomcat/trunk/java/org/apache/catalina/util/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/util/LocalStrings_es.properties
tomcat/trunk/java/org/apache/catalina/util/LocalStrings_fr.properties
tomcat/trunk/java/org/apache/catalina/util/LocalStrings_ja.properties
tomcat/trunk/java/org/apache/catalina/util/SessionIdGenerator.java
Modified: tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties?rev=1044881r1=1044880r2=1044881view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties Sun
Dec 12 18:55:52 2010
@@ -29,9 +29,6 @@ JDBCStore.checkConnectionSQLException=A
JDBCStore.checkConnectionClassNotFoundException=JDBC driver class not found {0}
managerBase.createRandom=Created random number generator for session ID
generation in {0}ms.
managerBase.createSession.ise=createSession: Too many active sessions
-managerBase.random=Exception initializing random number generator of class
[{0}]. Falling back to java.secure.SecureRandom
-managerBase.randomAlgorithm=Exception initializing random number generator
using algorithm [{0}]
-managerBase.randomProviderException initializing random number generator using
provider [{0}]
managerBase.sessionTimeout=Invalid session timeout setting {0}
serverSession.value.iae=null value
standardManager.expireException=processsExpire: Exception during session
expiration
Modified:
tomcat/trunk/java/org/apache/catalina/session/LocalStrings_es.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/LocalStrings_es.properties?rev=1044881r1=1044880r2=1044881view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/LocalStrings_es.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/LocalStrings_es.properties
Sun Dec 12 18:55:52 2010
@@ -27,7 +27,6 @@ JDBCStore.checkConnectionDBReOpenFail =
JDBCStore.checkConnectionSQLException = Ha tenido lugar una excepci\u00F3n SQL
{0}
JDBCStore.checkConnectionClassNotFoundException = No se ha hallado la clase
del manejador (driver) JDBC {0}
managerBase.createSession.ise = createSession\: Demasiadas sesiones activas
-managerBase.random = Excepci\u00F3n inicializando generador de n\u00FAmeros
aleatorios de clase {0}
managerBase.sessionTimeout = Valor inv\u00E1lido de Tiempo Agotado de
sesi\u00F3n {0}
serverSession.value.iae = valor nulo
standardManager.expireException = processsExpire\: Excepci\u00F3n durante la
expiraci\u00F3n de sesi\u00F3n
Modified:
tomcat/trunk/java/org/apache/catalina/session/LocalStrings_fr.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/LocalStrings_fr.properties?rev=1044881r1=1044880r2=1044881view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/LocalStrings_fr.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/LocalStrings_fr.properties
Sun Dec 12 18:55:52 2010
@@ -27,7 +27,6 @@ JDBCStore.checkConnectionDBReOpenFail=La
JDBCStore.checkConnectionSQLException=Une exception SQL s''est produite {0}
JDBCStore.checkConnectionClassNotFoundException=La classe du driver JDBC n''a
pas \u00e9t\u00e9 trouv\u00e9e {0}
managerBase.createSession.ise=createSession: Trop de sessions actives
-managerBase.random=Exception durant l''initialisation de la classe du
g\u00e9n\u00e9rateur de nombre al\u00e9atoire {0}
managerBase.sessionTimeout=R\u00e9glage du d\u00e9lai d''inactivit\u00e9
(timeout) de session invalide {0}
serverSession.value.iae=valeur nulle
standardManager.expireException=processsExpire: Exception lors de
l''expiration de la session
Modified:
tomcat/trunk/java/org/apache/catalina/session/LocalStrings_ja.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/LocalStrings_ja.properties?rev=1044881r1=1044880r2=1044881view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/LocalStrings_ja.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/LocalStrings_ja.properties
Sun Dec 12
svn commit: r1044895 - /tomcat/trunk/test/org/apache/naming/resources/TestNamingContext.java
Author: markt
Date: Sun Dec 12 19:27:13 2010
New Revision: 1044895
URL: http://svn.apache.org/viewvc?rev=1044895view=rev
Log:
Fix FindBugs issues in this class
Modified:
tomcat/trunk/test/org/apache/naming/resources/TestNamingContext.java
Modified: tomcat/trunk/test/org/apache/naming/resources/TestNamingContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/naming/resources/TestNamingContext.java?rev=1044895r1=1044894r2=1044895view=diff
==
--- tomcat/trunk/test/org/apache/naming/resources/TestNamingContext.java
(original)
+++ tomcat/trunk/test/org/apache/naming/resources/TestNamingContext.java Sun
Dec 12 19:27:13 2010
@@ -80,7 +80,7 @@ public class TestNamingContext extends T
}
-public final class Bug49994Servlet extends HttpServlet {
+public static final class Bug49994Servlet extends HttpServlet {
private static final long serialVersionUID = 1L;
@@ -132,7 +132,7 @@ public class TestNamingContext extends T
assertEquals(org.apache.naming.resources.TesterObject,
bc.toString());
}
-public final class Bug23950Servlet extends HttpServlet {
+public static final class Bug23950Servlet extends HttpServlet {
private static final long serialVersionUID = 1L;
@@ -184,7 +184,7 @@ public class TestNamingContext extends T
assertEquals(value, bc.toString());
}
-public final class Bug50351Servlet extends HttpServlet {
+public static final class Bug50351Servlet extends HttpServlet {
private static final long serialVersionUID = 1L;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044896 - /tomcat/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java
Author: markt
Date: Sun Dec 12 19:35:56 2010
New Revision: 1044896
URL: http://svn.apache.org/viewvc?rev=1044896view=rev
Log:
Fix FindBugs issues in this class
Modified:
tomcat/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java
Modified: tomcat/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java?rev=1044896r1=1044895r2=1044896view=diff
==
--- tomcat/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java Sun
Dec 12 19:35:56 2010
@@ -72,7 +72,7 @@ public class TestRemoteIpFilter extends
private static final long serialVersionUID = 1L;
-HttpServletRequest request;
+private transient HttpServletRequest request;
public HttpServletRequest getRequest() {
return request;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044898 - in /tomcat/trunk/test/org/apache/el: TestMethodExpressionImpl.java TesterBeanB.java
Author: markt
Date: Sun Dec 12 19:50:45 2010
New Revision: 1044898
URL: http://svn.apache.org/viewvc?rev=1044898view=rev
Log:
Add some tests for bug50449 but haven't reproduced it yet
Modified:
tomcat/trunk/test/org/apache/el/TestMethodExpressionImpl.java
tomcat/trunk/test/org/apache/el/TesterBeanB.java
Modified: tomcat/trunk/test/org/apache/el/TestMethodExpressionImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/TestMethodExpressionImpl.java?rev=1044898r1=1044897r2=1044898view=diff
==
--- tomcat/trunk/test/org/apache/el/TestMethodExpressionImpl.java (original)
+++ tomcat/trunk/test/org/apache/el/TestMethodExpressionImpl.java Sun Dec 12
19:50:45 2010
@@ -335,4 +335,18 @@ public class TestMethodExpressionImpl ex
#{beanA.valLong}, java.lang.String.class);
assertEquals(5, ve.getValue(context));
}
+
+public void testBug50449a() throws Exception {
+MethodExpression me1 = factory.createMethodExpression(context,
+${beanB.sayHello()}, null, null);
+String actual = (String) me1.invoke(context, null);
+assertEquals(Hello from B, actual);
+}
+
+public void testBug50449b() throws Exception {
+MethodExpression me1 = factory.createMethodExpression(context,
+${beanB.sayHello('Tomcat')}, null, null);
+String actual = (String) me1.invoke(context, null);
+assertEquals(Hello Tomcat from B, actual);
+}
}
Modified: tomcat/trunk/test/org/apache/el/TesterBeanB.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/TesterBeanB.java?rev=1044898r1=1044897r2=1044898view=diff
==
--- tomcat/trunk/test/org/apache/el/TesterBeanB.java (original)
+++ tomcat/trunk/test/org/apache/el/TesterBeanB.java Sun Dec 12 19:50:45 2010
@@ -28,6 +28,10 @@ public class TesterBeanB {
this.name = name;
}
+public String sayHello() {
+return Hello from + name;
+}
+
public String sayHello(String to) {
return Hello + to + from + name;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50449] Methodexpression with arguments fails in JSF composite component
https://issues.apache.org/bugzilla/show_bug.cgi?id=50449 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME OS/Version||All --- Comment #1 from Mark Thomas ma...@apache.org 2010-12-12 16:21:35 EST --- The Mojarra download pages are currently empty so I tested 7.0.x (trunk) with MyFaces 2.0.2 and all works as expected. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50459] StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina|Catalina Version|7.0.5 |6.0.29 Product|Tomcat 7|Tomcat 6 Target Milestone|--- |default --- Comment #3 from Mark Thomas ma...@apache.org 2010-12-12 16:22:28 EST --- Moving to 6 now it is fixed in 7. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50455] Jasper doesn't detect changes in a jsp file if we load and modify the jsp file in the same second
https://issues.apache.org/bugzilla/show_bug.cgi?id=50455 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX Summary|Jasper don't detects|Jasper doesn't detect |changes in jsp file if we |changes in a jsp file if we |load de jsp and after we|load and modify the jsp |modify the jsp in the same |file in the same second |second | --- Comment #2 from Mark Thomas ma...@apache.org 2010-12-12 16:29:34 EST --- The suggested change will not be made. The system described is clearly capable of generating and compiling a JSP within the same second. With the proposed change, the JSP could get compiled unnecessarily. There are a couple of ways of handling the root cause. Bug 23406 is probably the best solution for this scenario. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50413] Tomcat returns 304 instead of 404 response for static custom 404 error file
https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|RESOLVED|REOPENED Component|Catalina|Catalina Version|7.0.5 |5.5.31 Resolution|FIXED | Product|Tomcat 7|Tomcat 5 --- Comment #4 from Mark Thomas ma...@apache.org 2010-12-12 16:30:43 EST --- Re-open against 5.5.x so it gets fixed in 5.5.x and 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50460] First access to a jspx page causes classloader leak in JspDocumentParser
https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 --- Comment #1 from Sylvain Laurent sylvain.laur...@gmail.com 2010-12-12 16:31:14 EST --- Waw, that's a nice bug in the JVM ! To avoid it in tomcat, I vote for 2) Do not cache the Exception. Create a new instance each time. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044933 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Dec 12 21:33:07 2010 New Revision: 1044933 URL: http://svn.apache.org/viewvc?rev=1044933view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044933r1=1044932r2=1044933view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 12 21:33:07 2010 @@ -280,3 +280,9 @@ PATCHES PROPOSED TO BACKPORT: http://people.apache.org/~markt/patches/2010-12-07-ssl-algorithm-tc6.patch +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 + Ensure 304s are not returned when using static files as error pages + http://svn.apache.org/viewvc?view=revisionrevision=1044266 + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1044145 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/tomcat/util/threads/ test/org/apache/tomcat/util/threads/
On 12/12/2010 00:14, Sylvain Laurent wrote: Good catch! Not really - I was running the unit tests for a completely different issue when I stumbled across if :) It does show the value of the unit tests though. Actually I think my commit revealed a current bug in tc 6 7 : https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 I fixed it with http://svn.apache.org/viewvc?rev=1044746view=rev . Now all tests pass (checked with ant clean test). Thanks for such a quick fix. Mark Sylvain On 11 déc. 2010, at 21:34, Mark Thomas wrote: On 09/12/2010 22:11, slaur...@apache.org wrote: Author: slaurent Date: Thu Dec 9 22:11:27 2010 New Revision: 1044145 URL: http://svn.apache.org/viewvc?rev=1044145view=rev Log: bug 49159: Improve ThreadLocal memory leak clean-up https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 -1. This breaks at least one unit test. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044934 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: markt Date: Sun Dec 12 21:35:15 2010 New Revision: 1044934 URL: http://svn.apache.org/viewvc?rev=1044934view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1044934r1=1044933r2=1044934view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Dec 12 21:35:15 2010 @@ -83,3 +83,9 @@ PATCHES PROPOSED TO BACKPORT: http://people.apache.org/~kkolinko/patches/2010-11-22_tc55_httpOnly.patch +1: kkolinko -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 + Ensure 304s are not returned when using static files as error pages + http://svn.apache.org/viewvc?view=revisionrevision=1044266 + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50460] First access to a jspx page causes classloader leak in JspDocumentParser
https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 --- Comment #2 from Mark Thomas ma...@apache.org 2010-12-12 16:38:47 EST --- 2 gets my vote -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044936 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Sun Dec 12 21:55:12 2010 New Revision: 1044936 URL: http://svn.apache.org/viewvc?rev=1044936view=rev Log: vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1044936r1=1044935r2=1044936view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Sun Dec 12 21:55:12 2010 @@ -87,5 +87,5 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 Ensure 304s are not returned when using static files as error pages http://svn.apache.org/viewvc?view=revisionrevision=1044266 - +1: markt + +1: markt, kkolinko -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044936r1=1044935r2=1044936view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 12 21:55:12 2010 @@ -278,11 +278,11 @@ PATCHES PROPOSED TO BACKPORT: * Make SSL protocol selection consistent between BIO and NIO and update docs to reflect current BIO and post-patch NIO. http://people.apache.org/~markt/patches/2010-12-07-ssl-algorithm-tc6.patch - +1: markt + +1: markt, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 Ensure 304s are not returned when using static files as error pages http://svn.apache.org/viewvc?view=revisionrevision=1044266 - +1: markt + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50460] First access to a jspx page causes classloader leak in JspDocumentParser
https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 --- Comment #3 from Sylvain Laurent sylvain.laur...@gmail.com 2010-12-12 16:55:34 EST --- I found another place where the same type of leak might occur : in ProxyDirContext (in tc7, I dod not check with tc6), there is protected static final NameNotFoundException NOT_FOUND_EXCEPTION = new ImmutableNameNotFoundException(); In this case the stack does not contain webapp code, so there's no leak of webapp classloader. But there can be a leak of tomcat's classloader if it is embedded... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044937 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Dec 12 21:57:03 2010 New Revision: 1044937 URL: http://svn.apache.org/viewvc?rev=1044937view=rev Log: Comment Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044937r1=1044936r2=1044937view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 12 21:57:03 2010 @@ -242,6 +242,7 @@ PATCHES PROPOSED TO BACKPORT: kkolinko: (Re: markt's 2010-12-05-bug50201-tc6.patch) 7) Why Lifecycle.DESTROY_EVENT.endsWith(type) in a condition? s/endsWith/equals/ + markt: Auto-complete snafu - fixed in trunk 8) I do not see how the listener can be reused when recalculation happens. (We are now installing a new listener when NoAccessLog wins, @@ -257,6 +258,7 @@ PATCHES PROPOSED TO BACKPORT: I have not applied those changes to TC7 yet, and it might need some more testing: http://people.apache.org/~kkolinko/patches/2010-12-07_tc6_bug50201.patch + markt: +1 to making these changes in TC7 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48973 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044944 - in /tomcat/trunk/java/org/apache/catalina/session: LocalStrings.properties StandardManager.java
Author: kkolinko
Date: Sun Dec 12 22:33:09 2010
New Revision: 1044944
URL: http://svn.apache.org/viewvc?rev=1044944view=rev
Log:
Use i18n for the messages
It is followup to r1042022 which was a fix for BZ 48973
Modified:
tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/session/StandardManager.java
Modified: tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties?rev=1044944r1=1044943r2=1044944view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/LocalStrings.properties Sun
Dec 12 22:33:09 2010
@@ -36,7 +36,9 @@ standardManager.loading=Loading persiste
standardManager.loading.cnfe=ClassNotFoundException while loading persisted
sessions: {0}
standardManager.loading.ioe=IOException while loading persisted sessions: {0}
standardManager.unloading=Saving persisted sessions to {0}
+standardManager.unloading.debug=Unloading persisted sessions
standardManager.unloading.ioe=IOException while saving persisted sessions: {0}
+standardManager.unloading.nosessions=No persisted sessions to unload
standardManager.managerLoad=Exception loading sessions from persistent storage
standardManager.managerUnload=Exception unloading sessions to persistent
storage
standardSession.attributeEvent=Session attribute event listener threw exception
Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/StandardManager.java?rev=1044944r1=1044943r2=1044944view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/StandardManager.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/StandardManager.java Sun Dec
12 22:33:09 2010
@@ -365,10 +365,10 @@ public class StandardManager extends Man
protected void doUnload() throws IOException {
if (log.isDebugEnabled())
-log.debug(Unloading persisted sessions);
-
+log.debug(sm.getString(standardManager.unloading.debug));
+
if (sessions.isEmpty()) {
-log.debug(No persisted sessions to unload);
+log.debug(sm.getString(standardManager.unloading.nosessions));
return; // nothing to do
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044946 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Sun Dec 12 22:35:19 2010 New Revision: 1044946 URL: http://svn.apache.org/viewvc?rev=1044946view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044946r1=1044945r2=1044946view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 12 22:35:19 2010 @@ -269,6 +269,11 @@ PATCHES PROPOSED TO BACKPORT: -0: markt - See http://markmail.org/message/xp5beek4mdacygsc -1: + Additional patch: i18n, as asked by Mark: + http://svn.apache.org/viewvc?rev=1044944view=rev + +1: kkolinko + -1: + * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50282 Improve JreMemoryLeakPreventionListener to load javax.security.auth.login.Configuration to avoid redeployment leak. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
running tests for tc6 with ant
Which ant file to use to run junit tests for tc6 ? BUILDING.TXT says that ant -f dist.xml release should run tests, but it doesn't seem to. I tried ant -f test/build.xml but it's buggy (incorrect path to build.properties) and runs only one test... Sylvain - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044950 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Sun Dec 12 22:46:54 2010 New Revision: 1044950 URL: http://svn.apache.org/viewvc?rev=1044950view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044950r1=1044949r2=1044950view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 12 22:46:54 2010 @@ -282,6 +282,13 @@ PATCHES PROPOSED TO BACKPORT: -0: markt - See http://markmail.org/message/mnowpijhnxg554t5 -1: + Additional patches: (line wrapping and docs spelling) + http://svn.apache.org/viewvc?view=revisionrevision=1042452 + http://svn.apache.org/viewvc?view=revisionrevision=1042447 + http://svn.apache.org/viewvc?view=revisionrevision=1042494 + +1: kkolinko + -1: + * Make SSL protocol selection consistent between BIO and NIO and update docs to reflect current BIO and post-patch NIO. http://people.apache.org/~markt/patches/2010-12-07-ssl-algorithm-tc6.patch - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044951 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: slaurent Date: Sun Dec 12 22:53:33 2010 New Revision: 1044951 URL: http://svn.apache.org/viewvc?rev=1044951view=rev Log: bug 50459: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044951r1=1044950r2=1044951view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 12 22:53:33 2010 @@ -300,3 +300,9 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?view=revisionrevision=1044266 +1: markt, kkolinko -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 + StandardContext.bindThread() and unbindThread() are not symmetrical and not + limited to current thread + http://people.apache.org/~slaurent/patches/2010-12-12_BZ50459_bindThread_tc6.patch + +1: slaurent \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044952 - /tomcat/tc6.0.x/trunk/
Author: slaurent Date: Sun Dec 12 22:55:12 2010 New Revision: 1044952 URL: http://svn.apache.org/viewvc?rev=1044952view=rev Log: svn:ignore work and logs directories as discussed on dev list Modified: tomcat/tc6.0.x/trunk/ (props changed) Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:ignore (original) +++ svn:ignore Sun Dec 12 22:55:12 2010 @@ -3,3 +3,5 @@ .settings output build.properties +work +logs - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50459] StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 --- Comment #4 from Sylvain Laurent sylvain.laur...@gmail.com 2010-12-12 17:56:31 EST --- patch proposed for tomcat 6 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50405] Null Pointer Exception at Coyote Adapter
https://issues.apache.org/bugzilla/show_bug.cgi?id=50405 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |NEEDINFO OS/Version||All --- Comment #1 from Mark Thomas ma...@apache.org 2010-12-12 18:25:32 EST --- I'm having trouble reproducing this. Could you provide a simple test case that demonstrates the issue please. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38360] Domain for session cookies
https://issues.apache.org/bugzilla/show_bug.cgi?id=38360 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||FIXED --- Comment #5 from Mark Thomas ma...@apache.org 2010-12-12 18:38:50 EST --- This is a Servlet 3.0 feature so is available in Tomcat 7. The feature is also available as a context parameter in Tomcat 6. This is very unlikely to get back-ported to Tomcat 5. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50459] StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread
https://issues.apache.org/bugzilla/show_bug.cgi?id=50459 --- Comment #5 from Konstantin Kolinko knst.koli...@gmail.com 2010-12-12 18:43:04 EST --- Looking at r1044746 and the patch proposed for TC6, I think that that replacement of s/DirContextURLStreamHandler.bind(/DirContextURLStreamHandler.bindThread(/ s/DirContextURLStreamHandler.unbind(/DirContextURLStreamHandler.unbindThread(/ is wrong. See DirContextURLStreamHandler#get(). The difference is when a web application starts a child thread. That thread inherits TCCL from its parent and thus DirContextURLStreamHandler will recognize it when using CL-binding, but will not if thread-binding is used. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044957 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Sun Dec 12 23:44:25 2010 New Revision: 1044957 URL: http://svn.apache.org/viewvc?rev=1044957view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044957r1=1044956r2=1044957view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Dec 12 23:44:25 2010 @@ -305,4 +305,5 @@ PATCHES PROPOSED TO BACKPORT: StandardContext.bindThread() and unbindThread() are not symmetrical and not limited to current thread http://people.apache.org/~slaurent/patches/2010-12-12_BZ50459_bindThread_tc6.patch - +1: slaurent \ No newline at end of file + +1: slaurent + -1: kkolinko: https://issues.apache.org/bugzilla/show_bug.cgi?id=50459#c5 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 17146] Simplify build.xml using property environment=env /
https://issues.apache.org/bugzilla/show_bug.cgi?id=17146 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Mark Thomas ma...@apache.org 2010-12-12 18:52:16 EST --- This change doesn't particularly simplify things since most users don't need to set CATALINA_HOME. Therefore, leave webapps/docs/appdev/build.xml.txt as is. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 19011] Java startup params
https://issues.apache.org/bugzilla/show_bug.cgi?id=19011 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Mark Thomas ma...@apache.org 2010-12-12 19:00:06 EST --- 1. Use setenv.bat 2. Scripts output more info these days - plus use setenv.bat 3. -classpath is no better/worse than -Djava.class.path -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044964 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Mon Dec 13 00:02:47 2010 New Revision: 1044964 URL: http://svn.apache.org/viewvc?rev=1044964view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044964r1=1044963r2=1044964view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Dec 13 00:02:47 2010 @@ -266,12 +266,12 @@ PATCHES PROPOSED TO BACKPORT: The patch provided by Marc Guillemot works for tc 6 7 http://svn.apache.org/viewvc?rev=1042022view=rev +1: slaurent, kkolinko - -0: markt - See http://markmail.org/message/xp5beek4mdacygsc + +1: markt with r1044944 -1: Additional patch: i18n, as asked by Mark: http://svn.apache.org/viewvc?rev=1044944view=rev - +1: kkolinko + +1: kkolinko, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50282 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43960] Expose StandardWrapper unavailable and/or available properties to JMX
https://issues.apache.org/bugzilla/show_bug.cgi?id=43960 --- Comment #3 from Mark Thomas ma...@apache.org 2010-12-12 19:19:02 EST --- There is no unavailable property but the available property is already exposed in Tomcat 7. A patch has been proposed for Tomcat 6 and Tomcat 5. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044972 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Mon Dec 13 00:20:06 2010 New Revision: 1044972 URL: http://svn.apache.org/viewvc?rev=1044972view=rev Log: Proposals Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1044972r1=1044971r2=1044972view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Dec 13 00:20:06 2010 @@ -89,3 +89,9 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?view=revisionrevision=1044266 +1: markt, kkolinko -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43960 + Expose available property of StandardWrapper via JMX + http://people.apache.org/~markt/patches/2010-12-13-bug43960-tc5.patch + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044972r1=1044971r2=1044972view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Dec 13 00:20:06 2010 @@ -307,3 +307,9 @@ PATCHES PROPOSED TO BACKPORT: http://people.apache.org/~slaurent/patches/2010-12-12_BZ50459_bindThread_tc6.patch +1: slaurent -1: kkolinko: https://issues.apache.org/bugzilla/show_bug.cgi?id=50459#c5 + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43960 + Expose available property of StandardWrapper via JMX + http://people.apache.org/~markt/patches/2010-12-13-bug43960-tc6.patch + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 9852] Odd Digest and Realm Behaviour
https://issues.apache.org/bugzilla/show_bug.cgi?id=9852 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas ma...@apache.org 2010-12-12 19:21:50 EST --- This was fixed several years ago (I think back as far as Tomcat 4, certainly for Tomcat 5) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 21804] Tomcat ignores allowLinking resource on DefaultContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=21804 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #4 from Mark Thomas ma...@apache.org 2010-12-12 19:29:08 EST --- StandardDefaultContext has been removed from all currently supported Tomcat versions (5.5.x onwards) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044987 - in /tomcat/trunk/java/org/apache: jasper/compiler/JspDocumentParser.java naming/resources/ImmutableNameNotFoundException.java
Author: kkolinko
Date: Mon Dec 13 00:58:11 2010
New Revision: 1044987
URL: http://svn.apache.org/viewvc?rev=1044987view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460
Avoid leak caused by using a cached exception instance
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java
tomcat/trunk/java/org/apache/naming/resources/ImmutableNameNotFoundException.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java?rev=1044987r1=1044986r2=1044987view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java Mon Dec
13 00:58:11 2010
@@ -58,11 +58,6 @@ class JspDocumentParser
http://xml.org/sax/properties/lexical-handler;;
private static final String JSP_URI = http://java.sun.com/JSP/Page;;
-private static final EnableDTDValidationException
ENABLE_DTD_VALIDATION_EXCEPTION =
-new EnableDTDValidationException(
-jsp.error.enable_dtd_validation,
-null);
-
private ParserController parserController;
private JspCompilationContext ctxt;
private PageInfo pageInfo;
@@ -757,7 +752,8 @@ class JspDocumentParser
public void startDTD(String name, String publicId, String systemId)
throws SAXException {
if (!isValidating) {
-fatalError(ENABLE_DTD_VALIDATION_EXCEPTION);
+fatalError(new EnableDTDValidationException(
+jsp.error.enable_dtd_validation, null));
}
inDTD = true;
@@ -1459,6 +1455,12 @@ class JspDocumentParser
EnableDTDValidationException(String message, Locator loc) {
super(message, loc);
}
+
+@Override
+public synchronized Throwable fillInStackTrace() {
+// This class does not provide a stack trace
+return this;
+}
}
private static String getBodyType(Node.CustomTag custom) {
Modified:
tomcat/trunk/java/org/apache/naming/resources/ImmutableNameNotFoundException.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/ImmutableNameNotFoundException.java?rev=1044987r1=1044986r2=1044987view=diff
==
---
tomcat/trunk/java/org/apache/naming/resources/ImmutableNameNotFoundException.java
(original)
+++
tomcat/trunk/java/org/apache/naming/resources/ImmutableNameNotFoundException.java
Mon Dec 13 00:58:11 2010
@@ -44,4 +44,9 @@ public class ImmutableNameNotFoundExcept
@Override
public void setRootCause(Throwable e) {/*NOOP*/}
+@Override
+public synchronized Throwable fillInStackTrace() {
+// This class does not provide a stack trace
+return this;
+}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50460] First access to a jspx page causes classloader leak in JspDocumentParser
https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 --- Comment #4 from Konstantin Kolinko knst.koli...@gmail.com 2010-12-12 20:20:49 EST --- Fixed in trunk in r1044987 and will be in 7.0.6. I will propose it for 6.0 and 5.5. I should note, that 3) fixes the issue in my environment. For the JspDocumentParser$EnableDTDValidationException class I am using 2) as the fix and 3) for sake of performance. For the ImmutableNameNotFoundException class I am using 3), as 2) would be too much of a change for me. (In reply to comment #3) But there can be a leak of tomcat's classloader if it is embedded... ProxyDirContext is loaded by the Tomcat's classloader as well, and thus it static field should be GC'able at the same time as the Tomcat classes that might appear in the stacktrace there. So I do not think that there will be an observable leak with ProxyDirContext. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044994 - /tomcat/trunk/webapps/docs/changelog.xml
Author: kkolinko Date: Mon Dec 13 01:21:58 2010 New Revision: 1044994 URL: http://svn.apache.org/viewvc?rev=1044994view=rev Log: changelog for r1044987 Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1044994r1=1044993r2=1044994view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Mon Dec 13 01:21:58 2010 @@ -156,6 +156,11 @@ bug50408/bug: Fix codeNoSuchMethodException/code when using scoped variables with EL method invocation. (markt) /fix + fix +bug50460/bug: Avoid leak caused by using a cached exception +instance in codeJspDocumentParser/code and +codeProxyDirContext/code. (kkolinko) + /fix /changelog /subsection subsection name=Cluster - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1044995 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Dec 13 01:24:23 2010 New Revision: 1044995 URL: http://svn.apache.org/viewvc?rev=1044995view=rev Log: vote and proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1044995r1=1044994r2=1044995view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Dec 13 01:24:23 2010 @@ -93,5 +93,11 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43960 Expose available property of StandardWrapper via JMX http://people.apache.org/~markt/patches/2010-12-13-bug43960-tc5.patch - +1: markt + +1: markt, kkolinko + -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 + Avoid leak caused by using a cached exception instance + http://svn.apache.org/viewvc?rev=1044987view=rev + +1: kkolinko -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1044995r1=1044994r2=1044995view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Dec 13 01:24:23 2010 @@ -311,5 +311,11 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43960 Expose available property of StandardWrapper via JMX http://people.apache.org/~markt/patches/2010-12-13-bug43960-tc6.patch - +1: markt + +1: markt, kkolinko + -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50460 + Avoid leak caused by using a cached exception instance + http://svn.apache.org/viewvc?rev=1044987view=rev + +1: kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1045003 - in /tomcat/trunk: java/org/apache/catalina/core/StandardEngine.java webapps/docs/changelog.xml
Author: kkolinko
Date: Mon Dec 13 02:09:32 2010
New Revision: 1045003
URL: http://svn.apache.org/viewvc?rev=1045003view=rev
Log:
Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50201
- Use AtomicReference to guard against possible duplicate registration of
listeners when logAccess() is called by several threads at the same time.
- Added install() and uninstall() method to AccessLogListener
to help register/unregister the listeners.
- When defaultAccessLog is nulled, always unregister the listener as well.
The listener does not need to be reused, because now we do create a listener
when there is no log and it will take care of things.
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java?rev=1045003r1=1045002r2=1045003view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java Mon Dec 13
02:09:32 2010
@@ -19,6 +19,7 @@ package org.apache.catalina.core;
import java.beans.PropertyChangeEvent;
import java.beans.PropertyChangeListener;
import java.util.Locale;
+import java.util.concurrent.atomic.AtomicReference;
import org.apache.catalina.AccessLog;
import org.apache.catalina.Container;
@@ -115,7 +116,8 @@ public class StandardEngine extends Cont
* Default access log to use for request/response pairs where we can't ID
* the intended host and context.
*/
-private volatile AccessLog defaultAccessLog;
+private final AtomicReferenceAccessLog defaultAccessLog =
+new AtomicReferenceAccessLog();
// - Properties
@@ -321,7 +323,7 @@ public class StandardEngine extends Cont
}
if (!logged useDefault) {
-AccessLog newDefaultAccessLog = defaultAccessLog;
+AccessLog newDefaultAccessLog = defaultAccessLog.get();
if (newDefaultAccessLog == null) {
// If we reached this point, this Engine can't have an
AccessLog
// Look in the defaultHost
@@ -331,22 +333,25 @@ public class StandardEngine extends Cont
newDefaultAccessLog = host.getAccessLog();
if (newDefaultAccessLog != null) {
-AccessLogListener l = new AccessLogListener(this);
-this.addPropertyChangeListener(l);
-host.addContainerListener(l);
-host.addLifecycleListener(l);
+if (defaultAccessLog.compareAndSet(null,
+newDefaultAccessLog)) {
+AccessLogListener l = new AccessLogListener(this,
+host, null);
+l.install();
+}
} else {
// Try the ROOT context of default host
context = (Context) host.findChild();
if (context != null
context.getState().isAvailable()) {
newDefaultAccessLog = context.getAccessLog();
-
if (newDefaultAccessLog != null) {
-AccessLogListener l =
-new AccessLogListener(this);
-this.addPropertyChangeListener(l);
-context.addLifecycleListener(l);
+if (defaultAccessLog.compareAndSet(null,
+newDefaultAccessLog)) {
+AccessLogListener l = new
AccessLogListener(
+this, null, context);
+l.install();
+}
}
}
}
@@ -354,18 +359,13 @@ public class StandardEngine extends Cont
if (newDefaultAccessLog == null) {
newDefaultAccessLog = new NoopAccessLog();
-AccessLogListener l = new AccessLogListener(this);
-this.addPropertyChangeListener(l);
-if (host != null) {
-host.addContainerListener(l);
-host.addLifecycleListener(l);
-}
-if (context != null) {
-context.addLifecycleListener(l);
+if (defaultAccessLog.compareAndSet(null,
+newDefaultAccessLog))
svn commit: r1045004 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Dec 13 02:12:59 2010 New Revision: 1045004 URL: http://svn.apache.org/viewvc?rev=1045004view=rev Log: update comment and vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1045004r1=1045003r2=1045004view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Dec 13 02:12:59 2010 @@ -254,12 +254,10 @@ PATCHES PROPOSED TO BACKPORT: duplicate listeners (a fix for 4)). See the patch. 10) I added install() and uninstall() method to AccessLogListener to help register/unregister the listeners. - Here is an amended version of Mark's patch that includes 7),8),9),10). - I have not applied those changes to TC7 yet, and it might need some more - testing: + 8),9),10) were applied to trunk in r1045003 http://people.apache.org/~kkolinko/patches/2010-12-07_tc6_bug50201.patch - markt: +1 to making these changes in TC7 - + +1: kkolinko + -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48973 Avoid creating file SESSIONS.ser if there's no session. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50461] New: out tag's escapeXml attribute should be set as true by default
https://issues.apache.org/bugzilla/show_bug.cgi?id=50461 Summary: out tag's escapeXml attribute should be set as true by default Product: Taglibs Version: 1.2.0 Platform: PC OS/Version: Windows XP Status: NEW Severity: blocker Priority: P2 Component: Standard Taglib AssignedTo: dev@tomcat.apache.org ReportedBy: rwo...@gmail.com According to Page 4-26 of jstl spec, escapeXml should be set true by default. To prove that, the current snapshot is failed in the tck tests from the Geronimo side. Will provide a patch. -Rex -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50461] out tag's escapeXml attribute should be set as true by default
https://issues.apache.org/bugzilla/show_bug.cgi?id=50461 --- Comment #1 from Rex Wang rwo...@gmail.com 2010-12-12 21:32:37 EST --- Created an attachment (id=26395) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26395) fix escapeXml patch -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50462] New: xalan import should not be optional in maven-bundle-plugin
https://issues.apache.org/bugzilla/show_bug.cgi?id=50462 Summary: xalan import should not be optional in maven-bundle-plugin Product: Taglibs Version: 1.2.0 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Standard Taglib AssignedTo: dev@tomcat.apache.org ReportedBy: rwo...@gmail.com I know the Xalan might be removed in future due to the performance issue: http://www.mail-archive.com/dev@tomcat.apache.org/msg43586.html But so far, this seems still a hard dependency. So I should not made it as optional in maven bundle plugin.. Will provide a patch. -Rex -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50462] xalan import should not be optional in maven-bundle-plugin
https://issues.apache.org/bugzilla/show_bug.cgi?id=50462 --- Comment #1 from Rex Wang rwo...@gmail.com 2010-12-12 21:46:47 EST --- Created an attachment (id=26396) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26396) remove optional xalan import -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
