Re: RemoteIpValve advices
On 25/01/2011 23:31, Henri Gomez wrote:
I've got a very basic valve for now to handle this kind of X-Forwarded
situation :
public class ForwardedValve extends ValveBase {
public void invoke(Request paramRequest, Response paramResponse)
throws IOException, ServletException {
String header = paramRequest.getHeader(X-Forwarded-Host);
if (header != null)
paramRequest.setServerName(header);
int header1 = paramRequest.getIntHeader(X-Forwarded-Port);
if (header1 0)
paramRequest.setServerPort(header1);
getNext().invoke(paramRequest, paramResponse);
}
}
Any comments about this valve ?
My concerns regarding the host part remain, specifically that any
forwarded host will be ignored during the mapping process so virtual
hosting can never work. If there is only ever a single host then
Connector.proxyName / Connector.proxyPort is probably a better solution.
FYI, it's the kind of valve required by a Tomcat behind Amazon AWS
Load Balancer.
I'll detail more later but the current ForwardedValve only handle
remote (browser) information and not the local (server) address.
More details would be good. I don't see the use case for this at the moment.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [taglibs] Time to release 1.2.0?
On 01/23/2011 09:41 PM, Jeremy Boynes wrote: The only bug remaining that impact the JSTL libraries is #46052 (locale performance on 1.6). Henri suggested releasing in its current form which sounds reasonable. Should we release this as 1.2.0? Is this a good version number - should we use something like 1.2.0-beta? This will be the first release in a long time and the first since the switch to a Maven based build. The process is described here http://www.apache.org/dev/publishing-maven-artifacts.html I think we need to release the parent POM first to get it in the central repo, and then the artifacts that depend on it. I'd volunteer to RM this but: 1) I'm not a PMC member (which I don't think matters if we get enough votes from PMC members) 2) I'd need to update my PGP key in the WoT (somehow) 3) I've not done the above process before so will likely mess things up. If we're ready to do this I'd suggest going for it this week. Thoughts? +1 Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50660] New: Improve validationQuery error handling
https://issues.apache.org/bugzilla/show_bug.cgi?id=50660 Summary: Improve validationQuery error handling Product: Tomcat Modules Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: minor Priority: P2 Component: jdbc-pool AssignedTo: dev@tomcat.apache.org ReportedBy: dmik...@vmware.com If an invalid validationQuery is specified, the SQL Exception is logged at the DEBUG log level. Example: 2011-01-25 18:32:56,139 DEBUG [org.apache.tomcat.jdbc.pool.PooledConnection] Unable to validate object: com.ibm.db2.jcc.c.SqlException: DB2 SQL error: SQLCODE: -104, SQLSTATE: 42601, SQLERRMC: END-OF-STATEMENT;SELECT 1;table_expr Since an invalid validationQuery can cause problems with the data source, it would be nice to see this message logged at a different log level, such as WARN or ERROR. If that would create too much noise then I would suggest instead to add a check during the initialization of the data source that would test the validation query. Then this single check could log at WARN or ERROR. Thanks Dan -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: RemoteIpValve advices
Mark and Henri, On 1/26/2011 4:09 AM, Mark Thomas wrote: On 25/01/2011 23:31, Henri Gomez wrote: FYI, it's the kind of valve required by a Tomcat behind Amazon AWS Load Balancer. I'll detail more later but the current ForwardedValve only handle remote (browser) information and not the local (server) address. More details would be good. I don't see the use case for this at the moment. FWIW, Paul Fremantle gave a talk at ApacheCon NA this year where he demonstrated Tomcat running behind AWSLB. I'm sure they have figured out what changes are necessary to Tomcat to get it running in that environment. Perhaps he's got some code he would be willing to share. Or, perhaps he's not thought if this and would love to hear about this discussion. -chris signature.asc Description: OpenPGP digital signature
svn commit: r1063774 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProtocol.java java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml
Author: markt
Date: Wed Jan 26 16:11:46 2011
New Revision: 1063774
URL: http://svn.apache.org/viewvc?rev=1063774view=rev
Log:
Don't assume servlet 3+ async when processing long poll connections (it might
be comet)
Use socket rather than socket wrapper as key in connection list else comet
sockets may be lost
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java?rev=1063774r1=1063773r2=1063774view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java Wed Jan
26 16:11:46 2011
@@ -204,8 +204,8 @@ public class Http11AprProtocol extends A
protected AtomicLong registerCount = new AtomicLong(0);
protected RequestGroupInfo global = new RequestGroupInfo();
-protected ConcurrentHashMapSocketWrapperLong, Http11AprProcessor
connections =
-new ConcurrentHashMapSocketWrapperLong, Http11AprProcessor();
+protected ConcurrentHashMapLong, Http11AprProcessor connections =
+new ConcurrentHashMapLong, Http11AprProcessor();
protected ConcurrentLinkedQueueHttp11AprProcessor recycledProcessors
=
new ConcurrentLinkedQueueHttp11AprProcessor() {
@@ -264,7 +264,7 @@ public class Http11AprProtocol extends A
@Override
public SocketState event(SocketWrapperLong socket, SocketStatus
status) {
-Http11AprProcessor processor = connections.get(socket);
+Http11AprProcessor processor = connections.get(socket.getSocket());
SocketState state = SocketState.CLOSED;
if (processor != null) {
@@ -294,7 +294,7 @@ public class Http11AprProtocol extends A
http11protocol.proto.error), e);
} finally {
if (state != SocketState.LONG) {
-connections.remove(socket);
+connections.remove(socket.getSocket());
socket.setAsync(false);
recycledProcessors.offer(processor);
if (state == SocketState.OPEN) {
@@ -329,8 +329,13 @@ public class Http11AprProtocol extends A
if (state == SocketState.LONG || state ==
SocketState.ASYNC_END) {
// Need to make socket available for next processing cycle
// but no need for the poller
-connections.put(socket, processor);
-socket.setAsync(true);
+connections.put(socket.getSocket(), processor);
+if (processor.isAsync()) {
+socket.setAsync(true);
+} else if (processor.comet) {
+((AprEndpoint) proto.endpoint).getCometPoller().add(
+socket.getSocket().longValue());
+}
} else {
recycledProcessors.offer(processor);
}
@@ -362,7 +367,7 @@ public class Http11AprProtocol extends A
@Override
public SocketState asyncDispatch(SocketWrapperLong socket,
SocketStatus status) {
-Http11AprProcessor result = connections.get(socket);
+Http11AprProcessor result = connections.get(socket.getSocket());
SocketState state = SocketState.CLOSED;
if (result != null) {
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1063774r1=1063773r2=1063774view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Wed Jan 26
16:11:46 2011
@@ -1688,7 +1688,9 @@ public class AprEndpoint extends Abstrac
socket = null;
} else if (state == Handler.SocketState.LONG) {
socket.access();
-waitingRequests.add(socket);
+if (socket.async) {
+waitingRequests.add(socket);
+}
} else if (state == Handler.SocketState.ASYNC_END) {
socket.access();
SocketProcessor proc = new SocketProcessor(socket,
SocketStatus.OPEN);
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
DO NOT REPLY [Bug 50650] Connector#setProperty(String, String) does not set explicit property values
https://issues.apache.org/bugzilla/show_bug.cgi?id=50650 --- Comment #5 from Mark Thomas ma...@apache.org 2011-01-26 11:14:12 EST --- Agree with Konstantin, this is a WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1063776 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Jan 26 16:17:57 2011 New Revision: 1063776 URL: http://svn.apache.org/viewvc?rev=1063776view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1063776r1=1063775r2=1063776view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jan 26 16:17:57 2011 @@ -118,5 +118,5 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 NPE in InternalNioOutputBuffer.recycle() https://issues.apache.org/bugzilla/attachment.cgi?id=26549 - +1: kkolinko + +1: kkolinko, markt -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1063779 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Jan 26 16:24:08 2011 New Revision: 1063779 URL: http://svn.apache.org/viewvc?rev=1063779view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1063779r1=1063778r2=1063779view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jan 26 16:24:08 2011 @@ -105,14 +105,14 @@ PATCHES PROPOSED TO BACKPORT: Include context name in reload and stop log statements. Based on the patch by Marc Guillemot. http://people.apache.org/~kkolinko/patches/2011-01-23_tc6_48822.patch - +1: kkolinko + +1: kkolinko, markt -1: * Followup to r1061433 Be consistent with locks on sessionCreationTiming, sessionExpirationTiming in DeltaManager.resetStatistics(): use the same lock as elsewhere. http://svn.apache.org/viewvc?rev=1062398view=rev - +1: kkolinko + +1: kkolinko, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1063782 - in /tomcat: tc6.0.x/trunk/webapps/docs/config/context.xml trunk/webapps/docs/config/context.xml
Author: kkolinko Date: Wed Jan 26 16:35:48 2011 New Revision: 1063782 URL: http://svn.apache.org/viewvc?rev=1063782view=rev Log: Correct some old typo in context docs: move comment about docBase bahaviour with symlinks to where it belongs. No need to update 5.5 ones: they are OK already. CTR: docs Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/context.xml tomcat/trunk/webapps/docs/config/context.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/context.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/context.xml?rev=1063782r1=1063781r2=1063782view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/config/context.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/config/context.xml Wed Jan 26 16:35:48 2011 @@ -189,6 +189,10 @@ pThe value of this field must not be set when the Context is configured using a codeMETA-INF/context.xml/code file as it will be inferred by the automatic deployment process./p +pIf a symbolic link is used for docBase then changes to the +symbolic link will only be effective after a Tomcat restart or +by undeploying and redeploying the context. A context reload is not +sufficient./p /attribute attribute name=override required=false @@ -196,10 +200,6 @@ Context element override any corresponding settings in either the global or a href=host.htmlHost/a default contexts. By default, settings from a default context will be used./p -pIf a symbolic link is used for docBase then changes to the -symbolic link will only be effective after a Tomcat restart or -by undeploying and redeploying the context. A context reload is not -sufficient./p /attribute attribute name=privileged required=false Modified: tomcat/trunk/webapps/docs/config/context.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/context.xml?rev=1063782r1=1063781r2=1063782view=diff == --- tomcat/trunk/webapps/docs/config/context.xml (original) +++ tomcat/trunk/webapps/docs/config/context.xml Wed Jan 26 16:35:48 2011 @@ -234,6 +234,10 @@ pThe value of this field must not be set unless the Context element is defined in server.xml or the codedocBase/code is not located under the a href=host.htmlHost/aapos;s codeappBase/code./p +pIf a symbolic link is used for docBase then changes to the +symbolic link will only be effective after a Tomcat restart or +by undeploying and redeploying the context. A context reload is not +sufficient./p /attribute attribute name=logEffectiveWebXml required=false @@ -250,10 +254,6 @@ or a href=host.htmlHost/a default contexts. By default, settings from a default context will be used but may be overridden by a setting the same attribute explicitly for the Context./p -pIf a symbolic link is used for docBase then changes to the -symbolic link will only be effective after a Tomcat restart or -by undeploying and redeploying the context. A context reload is not -sufficient./p /attribute attribute name=privileged required=false - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1063791 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/RpcChannel.java webapps/docs/changelog.xml
Author: markt
Date: Wed Jan 26 16:53:23 2011
New Revision: 1063791
URL: http://svn.apache.org/viewvc?rev=1063791view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50648
Correctly set the interrupt status if a thread using RpcChannel is interrupted
waiting for a message reply.
Based on a patch by Olivier Costet.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1063791r1=1063790r2=1063791view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Wed Jan
26 16:53:23 2011
@@ -95,8 +95,7 @@ public class RpcChannel implements Chann
if ( rpcOptions != NO_REPLY ) collector.wait(timeout);
}
} catch ( InterruptedException ix ) {
-Thread.interrupted();
-//throw new ChannelException(ix);
+Thread.currentThread().interrupt();
}finally {
responseMap.remove(key);
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1063791r1=1063790r2=1063791view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 26 16:53:23 2011
@@ -158,6 +158,11 @@
Be consistent with locks on sessionCreationTiming,
sessionExpirationTiming in DeltaManager.resetStatistics(). (kkolinko)
/fix
+ fix
+bug50648/bug: Correctly set the interrupt status if a thread using
+codeRpcChannel/code is interrupted waiting for a message reply.
+Based on a patch by Olivier Costet. (markt)
+ /fix
/changelog
/subsection
subsection name=Web applications
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50648] RpcChannel improvements
https://issues.apache.org/bugzilla/show_bug.cgi?id=50648 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas ma...@apache.org 2011-01-26 11:53:45 EST --- (In reply to comment #0) This enhancement proposal addresses three separate issues with the RpcChannel tribes component. Separate issues should have separate Bugzilla entries and separate patches. Trying to manage multiple issues with a single Bugzilla entry quickly gets to be a pain. 1. There is a minor bug in a catch(InterruptedException) clause, in which a call to Thread#interrupted() is made, as opposed to Thread#interrupt(), as it should be. Fixed in 7.0.x and will be included in 7.0.7 onwards. 2. The RpcChannel API user registers an RpcCallback to be notified of communication events. However, there is no callback method for the case where the sending of a response message fails. This proposal includes the addition of a corresponding callback for such cases. To ensure backwards-compatibility, the additional callback method has been declared in a sub-interface of RpcCallback, named RpcCallback2 for the time being. Please open a new issue for this enhancement. The API isn't fixed for 7.0.x so just add the method to the RpcCallback interface. Patches should be the minimum to address the issue and should use the same style as the existing code. 3. Since the tribes classes are loaded by the tomcat loader, if the messages sent through tribes are instances of classes defined in the webapp, attemps to deserialize them will fail. AbstractReplicatedMap includes a mechanism for the API user to specify class loaders to be used when deserializing map entries. This enhancement proposal includes a similar mechanism for the RpcChannel. Please open a new issue for this enhancement request. Patches should be the minimum to address the issue and should use the same style as the existing code. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50660] Improve validationQuery error handling
https://issues.apache.org/bugzilla/show_bug.cgi?id=50660 --- Comment #1 from Filip Hanik fha...@apache.org 2011-01-26 12:05:16 EST --- hi Dan, this is a tricky one. Cause, we'd also be logging a lot of false positive. Connections that have gone stale and simply need to be reconnected. So WARN log level would not be good in that case. However, I agree that initially you would want to know that the query is invalid. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1063791 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/RpcChannel.java webapps/docs/changelog.xml
hmm, it should probably throw the commented out channel exception
instead of simply bailing out with the flag set.
After all the timeout has not been reached, so the caller should not be
tricked into thinking that it has, since no one ever checks the
interrupted flag
Filip
On 01/26/2011 09:53 AM, ma...@apache.org wrote:
Author: markt
Date: Wed Jan 26 16:53:23 2011
New Revision: 1063791
URL: http://svn.apache.org/viewvc?rev=1063791view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50648
Correctly set the interrupt status if a thread using RpcChannel is interrupted
waiting for a message reply.
Based on a patch by Olivier Costet.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1063791r1=1063790r2=1063791view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Wed Jan
26 16:53:23 2011
@@ -95,8 +95,7 @@ public class RpcChannel implements Chann
if ( rpcOptions != NO_REPLY ) collector.wait(timeout);
}
} catch ( InterruptedException ix ) {
-Thread.interrupted();
-//throw new ChannelException(ix);
+Thread.currentThread().interrupt();
}finally {
responseMap.remove(key);
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1063791r1=1063790r2=1063791view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 26 16:53:23 2011
@@ -158,6 +158,11 @@
Be consistent with locks on sessionCreationTiming,
sessionExpirationTiming in DeltaManager.resetStatistics(). (kkolinko)
/fix
+fix
+bug50648/bug: Correctly set the interrupt status if a thread using
+codeRpcChannel/code is interrupted waiting for a message reply.
+Based on a patch by Olivier Costet. (markt)
+/fix
/changelog
/subsection
subsection name=Web applications
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50648] RpcChannel improvements
https://issues.apache.org/bugzilla/show_bug.cgi?id=50648 --- Comment #2 from Filip Hanik fha...@apache.org 2011-01-26 12:39:40 EST --- 2. What type of exceptions have you seen here? Reply failed callback, is a strange callback, since the receiver, not the sender would receive that callback. That would make for some confusing programming logic. The sender will simply timeout, and not get the reply, and has to act accordingly. But I'm not sure the receiver needs to be notified. 3. The external loaders IMHO don't belong here. For the applications that wish to provide custom class loading, I would simply send messages using the ByteMessage class. That way you have full control over what is happening. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50660] Improve validationQuery error handling
https://issues.apache.org/bugzilla/show_bug.cgi?id=50660 --- Comment #2 from Daniel Mikusa dmik...@vmware.com 2011-01-26 12:48:21 EST --- Created an attachment (id=26553) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26553) proposed interceptor -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50660] Improve validationQuery error handling
https://issues.apache.org/bugzilla/show_bug.cgi?id=50660 --- Comment #3 from Daniel Mikusa dmik...@vmware.com 2011-01-26 12:49:46 EST --- What about adding an Interceptor to do the validation? The attached interceptor would take the validation query and run it when the pool is created. If there is a problem with the query it would report just that one time. Dan -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 5.5.32 Build
On Jan 22, 2011, at 1:01 PM, Jim Jagielski wrote: The builds for Tomcat 5.5.32 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.32 build corresponding to the tag TOMCAT_5_5_32 [1] is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable +++ 1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_32/ +1: STABLE - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 6.0.31
On Jan 24, 2011, at 4:51 PM, jean-frederic clere wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.31/ According to the release process, the 6.0.31 build corresponding to the tag TOMCAT_6_0_31 is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable +1: Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50660] Improve validationQuery error handling
https://issues.apache.org/bugzilla/show_bug.cgi?id=50660 --- Comment #4 from Filip Hanik fha...@apache.org 2011-01-26 13:23:24 EST --- If the connection to the database fails here, the interceptor will print out validationQuery has failed. and that is not correct I think the pool itself needs to do some validations upon startup 1. validation query 2. transaction isolation level 3. schema/catalog 4. default read only this is a valid bug, just needs to encompass the correct solution best Filip -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1063816 - in /tomcat/trunk: java/org/apache/catalina/tribes/ByteMessage.java webapps/docs/changelog.xml
Author: markt
Date: Wed Jan 26 18:28:31 2011
New Revision: 1063816
URL: http://svn.apache.org/viewvc?rev=1063816view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50646
Ensure larger Tribes messages are fully read.
Patch provided by Olivier Costet.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/ByteMessage.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/tribes/ByteMessage.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/ByteMessage.java?rev=1063816r1=1063815r2=1063816view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/ByteMessage.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/ByteMessage.java Wed Jan 26
18:28:31 2011
@@ -86,7 +86,7 @@ public class ByteMessage implements Exte
public void readExternal(ObjectInput in ) throws IOException {
int length = in.readInt();
message = new byte[length];
-in.read(message,0,length);
+in.readFully(message);
}
/**
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1063816r1=1063815r2=1063816view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 26 18:28:31 2011
@@ -163,6 +163,10 @@
codeRpcChannel/code is interrupted waiting for a message reply.
Based on a patch by Olivier Costet. (markt)
/fix
+ fix
+bug50646/bug: Ensure larger Tribes messages are fully read. Patch
+provided by Olivier Costet. (markt)
+ /fix
/changelog
/subsection
subsection name=Web applications
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50646] Tribes ByteMessage will get corrupted if message size exceeds the underlying buffer size
https://issues.apache.org/bugzilla/show_bug.cgi?id=50646 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas ma...@apache.org 2011-01-26 13:28:56 EST --- Thanks for the patch. It has been applied to 7.0.x and will be included in 7.0.7 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #7 from Filip Hanik fha...@apache.org 2011-01-26 14:20:26 EST --- (In reply to comment #6) (In reply to comment #4) Repeated calls to recycle() should succeed. Shouldn't they? Implementation of InternalNioOutputBuffer.recycle() was already broken in this sense earlier, since r428884. not really, calling recycle multiple times is probably just a sign of bad code. Whether the recycle method should be idempotent is a separate discussion. I agree that it should, but it doesn't mean it should be called multiple times. Cause the bugs that come up from coding like that, is way harder to track down. What is different in 6.0.30 is that several new calls to recycle() appeared -- I remember of the one in [1], and thus this issue became apparent. The reproduction recipe in comment 2 is based on [1]. [1] http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?r1=1030188r2=1030187pathrev=1030188 So, why not fix the real problem ? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of PoweredBy by prosch
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Tomcat Wiki for change
notification.
The PoweredBy page has been changed by prosch.
http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=302rev2=303
--
{{http://today.java.net/images/tiles/111-appfuse.gif}} Raible Designs'
[[http://today.java.net/pub/a/today/2004/07/15/thefuse.html|AppFuse]] runs best
on Tomcat. They wrote
[[http://raibledesigns.com/page/rd?anchor=resin_slower_than_tomcat_fails|an
interesting post]] comparing standards-compliance and performance on Tomcat and
other containers.
=== Bonhams ===
- {{http://www.bonhams.com/images/BonLogoGrey.jpg}}
[[http://www.bonhams.com/|Bonhams]] is an auction house founded in 1793,
running Tomcat and other open-source software, as detailed in
[[http://www.cio.com/archive/071506/open_source.html?action=print|this
article]] from [[http://www.cio.com|CIO Magazine]].
+ {{http://www.bonhams.com/images/BonLogoGrey.jpg}}
[[http://www.bonhams.com/|Bonhams]] is an auction house founded in 1793,
running Tomcat and other open-source software, as detailed in
[[http://www.cio.com/archive/071506/open_source.html?action=print|this
article]] from [[http://www.cio.com|CIO Magazine]].
[[http://www.profi-fachuebersetzung.de|Vereidigter Dolmetscher]]
[[http://www.profischnell.com|Übersetzung Deutsch Englisch]]
=== Cardinal Health ===
{{http://www.cardinal.com/images/layout/cardinal_logo_small.gif}}
[[http://www.cardinal.com/|CardinalHealth]] as documented by Sue Hildreth in
[[http://www.awprofessional.com/articles/article.asp?p=100600rl=1|this
article]].
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41128] Reference to java Thread name from RequestProcessor mbean
https://issues.apache.org/bugzilla/show_bug.cgi?id=41128 Mark Lewis malfunctio...@dev.java.net changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||FIXED --- Comment #5 from Mark Lewis malfunctio...@dev.java.net 2011-01-26 16:18:41 EST --- I hope it is not presumptuous of me to close this bug, but this was addressed back in March/April 2007 with r523235 (tc5.5.x) and r526576 (tc6.0.x). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41128] Reference to java Thread name from RequestProcessor mbean
https://issues.apache.org/bugzilla/show_bug.cgi?id=41128 Mark Lewis malfunctio...@dev.java.net changed: What|Removed |Added CC||malfunctio...@dev.java.net -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
PoweredBy reverted to revision 300 on Tomcat Wiki
Dear wiki user,
You have subscribed to a wiki page Tomcat Wiki for change notification.
The page PoweredBy has been reverted to revision 300 by KonstantinKolinko.
The comment on this change is: Reverted to r300 to remove spam.
http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=303rev2=304
--
{{http://today.java.net/images/tiles/111-appfuse.gif}} Raible Designs'
[[http://today.java.net/pub/a/today/2004/07/15/thefuse.html|AppFuse]] runs best
on Tomcat. They wrote
[[http://raibledesigns.com/page/rd?anchor=resin_slower_than_tomcat_fails|an
interesting post]] comparing standards-compliance and performance on Tomcat and
other containers.
=== Bonhams ===
- {{http://www.bonhams.com/images/BonLogoGrey.jpg}}
[[http://www.bonhams.com/|Bonhams]] is an auction house founded in 1793,
running Tomcat and other open-source software, as detailed in
[[http://www.cio.com/archive/071506/open_source.html?action=print|this
article]] from [[http://www.cio.com|CIO Magazine]].
[[http://www.profi-fachuebersetzung.de|Vereidigter Dolmetscher]]
[[http://www.profischnell.com|Übersetzung Deutsch Englisch]]
+ {{http://www.bonhams.com/images/BonLogoGrey.jpg}}
[[http://www.bonhams.com/|Bonhams]] is an auction house founded in 1793,
running Tomcat and other open-source software, as detailed in
[[http://www.cio.com/archive/071506/open_source.html?action=print|this
article]] from [[http://www.cio.com|CIO Magazine]].
=== Cardinal Health ===
{{http://www.cardinal.com/images/layout/cardinal_logo_small.gif}}
[[http://www.cardinal.com/|CardinalHealth]] as documented by Sue Hildreth in
[[http://www.awprofessional.com/articles/article.asp?p=100600rl=1|this
article]].
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #8 from Konstantin Kolinko knst.koli...@gmail.com 2011-01-26 19:45:54 EST --- Created an attachment (id=26554) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26554) catalina.2011-01-27.log (In reply to comment #7) Whether the recycle method should be idempotent is a separate discussion. I agree that it should, but it doesn't mean it should be called multiple times. Cause the bugs that come up from coding like that, is way harder to track down. I am sure that if we skip recycling the processor before its reuse in some case, the consequences will be harder than if we recycle it twice. The code is already hard to follow at some places. So, why not fix the real problem ? I think the bug in recycle() is the real problem. Though I do not mind patching CoyoteAdapter.log() as well. Part of the necessary changes is in r1059548 [2] [2] http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?r1=1059548r2=1059547pathrev=1059548 Here is one more occurrence of the issue, just using the browser (Firefox 3.6.13): 1. Using Tomcat 6.0.31. Configure Tomcat with Http11NioProtocol connector and AccessLogValve in Host 2. Clear cache of the browser 3. Access http://localhost:8080/examples/jsp/plugin/plugin.jsp 4. Wait for more than 10 seconds. 5. The pair of exceptions occur: 27.01.2011 3:09:37 org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler process SEVERE: Error reading request, ignored java.lang.NullPointerException at org.apache.coyote.http11.InternalNioOutputBuffer.recycle(InternalNioOutputBuffer.java:351) at org.apache.coyote.http11.Http11NioProcessor.recycle(Http11NioProcessor.java:1007) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.release(Http11NioProtocol.java:655) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:751) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2262) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 27.01.2011 3:09:37 org.apache.tomcat.util.net.NioEndpoint$SocketProcessor run SEVERE: java.lang.NullPointerException at org.apache.coyote.http11.InternalNioOutputBuffer.recycle(InternalNioOutputBuffer.java:351) at org.apache.coyote.http11.Http11NioProcessor.recycle(Http11NioProcessor.java:1007) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.release(Http11NioProtocol.java:655) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:776) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2262) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) -- see attachment. Access log: 127.0.0.1 - - [27/Jan/2011:03:09:26 +0300] GET /examples/jsp/plugin/plugin.jsp HTTP/1.1 200 1655 127.0.0.1 - - [27/Jan/2011:03:09:26 +0300] GET /favicon.ico HTTP/1.1 200 21630 127.0.0.1 - - [27/Jan/2011:03:09:27 +0300] GET /examples/jsp/plugin/applet/Clock2.class HTTP/1.1 304 - I am not able to reproduce this with usual static or JSP pages. I suspect that some cause is that Http11NioProtocol#process(NioChannel) there are calls to release(socket, processor) in if (state == SocketState.OPEN) and in else branches -- Http11NioProtocol.java:751 is where the exception occurs, but Http11NioProcessor#process(NioChannel) called from there already calls recycle() by itself. I think this comes from r1030613. There were later changes in Http11NioProcessor to add to this. The second exception in the pair, at (Http11NioProtocol.java:776) occurs after a catch block. This comes from r1033341. In this place it is hard to guess whether recycle() call already happened or not. The reproduction recipe in comment 5 is different from the both of mine ones. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50651] NPE in InternalNioOutputBuffer.recycle
https://issues.apache.org/bugzilla/show_bug.cgi?id=50651 --- Comment #9 from Konstantin Kolinko knst.koli...@gmail.com 2011-01-26 20:38:58 EST --- Created an attachment (id=26557) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26557) 2011-01-27_tc6_50651_CoyoteAdapter.patch Patch, in addition to the previous one: Recycle request and response in CoyoteAdapter#log() only if they were created there. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1063952 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Thu Jan 27 01:41:21 2011 New Revision: 1063952 URL: http://svn.apache.org/viewvc?rev=1063952view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1063952r1=1063951r2=1063952view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan 27 01:41:21 2011 @@ -120,3 +120,10 @@ PATCHES PROPOSED TO BACKPORT: https://issues.apache.org/bugzilla/attachment.cgi?id=26549 +1: kkolinko, markt -1: + + Additional patch: + Recycle request and response in CoyoteAdapter#log() only if they were + created there. + https://issues.apache.org/bugzilla/attachment.cgi?id=26557 + +1: kkolinko + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50664] New: connectUsingDriver should use thread context classloader to load driver
https://issues.apache.org/bugzilla/show_bug.cgi?id=50664
Summary: connectUsingDriver should use thread context
classloader to load driver
Product: Tomcat Modules
Version: unspecified
Platform: PC
Status: NEW
Severity: major
Priority: P2
Component: jdbc-pool
AssignedTo: dev@tomcat.apache.org
ReportedBy: bal...@gmail.com
The issue is described in this Stackoverflow question:
http://stackoverflow.com/questions/4790589/sqlexception-w-tomcat-7-0-jdbc-connection-pool-and-mysql
Summarized, in a situation where Spring is been used to manage the
`org.apache.tomcat.jdbc.pool.DataSource`, the JDBC driver class is not found,
even though it was placed in `${catalina.home}/lib`. The Tomcat JDBC throws the
following exception:
java.sql.SQLException: com.mysql.jdbc.Driver
at
org.apache.tomcat.jdbc.pool.PooledConnection.connectUsingDriver(PooledConnection.java:243)
at
org.apache.tomcat.jdbc.pool.PooledConnection.connect(PooledConnection.java:176)
The source code of `PooledConnection` learns me that it is attempting to load
the driver by the same classloader as the `PooledConnection` class itself is
been loaded. This should rather have been the thread context classloader as
follows.
driver = (java.sql.Driver) Class.forName(poolProperties.getDriverClassName(),
true, Thread.currentThread().getContextClassLoader()).newInstance();
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 5.5.32 Build
On 01/22/2011 07:01 PM, Jim Jagielski wrote: According to the release process, the 5.5.32 build corresponding to the tag TOMCAT_5_5_32 [1] is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 6.0.31
On 01/24/2011 10:51 PM, jean-frederic clere wrote: According to the release process, the 6.0.31 build corresponding to the tag TOMCAT_6_0_31 is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50661] c:forEach tag doesn't release his list - it causes temporary memory leak
https://issues.apache.org/bugzilla/show_bug.cgi?id=50661 Jeremy Boynes jboy...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #1 from Jeremy Boynes jboy...@apache.org 2011-01-27 02:57:56 EST --- As discussed in the related issue, the items cannot be released in doEndTag() as the tag is required by the spec to retain its attribute values until release() is called. *** This bug has been marked as a duplicate of bug 25623 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 25623] The forEach JSTL tag doesn't release items
https://issues.apache.org/bugzilla/show_bug.cgi?id=25623 Jeremy Boynes jboy...@apache.org changed: What|Removed |Added CC||Sergiusz.Brzezinski@supersy ||stem.pl --- Comment #7 from Jeremy Boynes jboy...@apache.org 2011-01-27 02:57:58 EST --- *** Bug 50661 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
