New connector sandbox
Hi, I plan to create a sandbox/connectors/native/iis7 for a native IIS7 C++ connector (since Microsoft deprecated ISAPI) Any objections? Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New connector sandbox
2011/4/11 Mladen Turk mt...@apache.org: Hi, I plan to create a sandbox/connectors/native/iis7 for a native IIS7 C++ connector (since Microsoft deprecated ISAPI) Any objections? I do not mind. Though 1) Do you need those immediate levels? Will there be anything in them? I guess the code will go into https://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis7/ when it becomes mature? 2) Just noticed that there is a readme in sandbox, https://svn.apache.org/viewvc/tomcat/sandbox/README.txt?view=markup Based on that I would prefer some more explicit name of a component rather than some nested connectors sandbox inside sandbox. Maybe sandbox/jk_iis7 ? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New connector sandbox
On Mon, Apr 11, 2011 at 6:17 PM, Mladen Turk mt...@apache.org wrote: Hi, I plan to create a sandbox/connectors/native/iis7 for a native IIS7 C++ connector (since Microsoft deprecated ISAPI) Any objections? We're only just getting the ISAPI one working properly ;) +1 from me - let me know if you want help. cheers tim - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1090958 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
Author: timw
Date: Mon Apr 11 07:49:28 2011
New Revision: 1090958
URL: http://svn.apache.org/viewvc?rev=1090958view=rev
Log:
Some debug logging and comments for transfer-encoding: chunked requests
Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=1090958r1=1090957r2=1090958view=diff
==
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Mon Apr 11 07:49:28 2011
@@ -1180,6 +1180,8 @@ static int JK_METHOD iis_read(jk_ws_serv
Attempting to read %d bytes from client, l);
}
if (p-lpEcb-ReadClient(p-lpEcb-ConnID, buf, (LPDWORD)l)) {
+/* ReadClient will succeed with dwSize == 0 for last chunk
+ if request chunk encoded */
*a += l;
}
else {
@@ -3024,8 +3026,12 @@ static int init_ws_service(isapi_private
HTTP_TRANSFER_ENCODING,
temp_buf,
(DWORD)sizeof(temp_buf))) {
-if (strcasecmp(temp_buf, TRANSFER_ENCODING_CHUNKED_VALUE) == 0)
+if (strcasecmp(temp_buf, TRANSFER_ENCODING_CHUNKED_VALUE) == 0) {
s-is_chunked = JK_TRUE;
+if (JK_IS_DEBUG_LEVEL(logger)) {
+jk_log(logger, JK_LOG_DEBUG, Request is Transfer-Encoding:
chunked);
+}
+}
else {
/* XXX: What to do with non chunked T-E ?
*/
@@ -3277,6 +3283,10 @@ static int init_ws_service(isapi_private
if (real_header) {
i++;
+if (JK_IS_DEBUG_LEVEL(logger)) {
+jk_log(logger, JK_LOG_DEBUG, Forwarding request
header %s : %s,
+ s-headers_names[i], s-headers_values[i]);
+}
}
}
/* Add a content-length = 0 header if needed.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50975] IIS connector times out on Transfer Encoded content, never sending the chunked content
https://issues.apache.org/bugzilla/show_bug.cgi?id=50975 Tim Whittington t...@apache.org changed: What|Removed |Added CC||bgstew...@covad.net --- Comment #6 from Tim Whittington t...@apache.org 2011-04-11 04:17:53 EDT --- *** Bug 48940 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1090973 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
Author: timw
Date: Mon Apr 11 08:23:46 2011
New Revision: 1090973
URL: http://svn.apache.org/viewvc?rev=1090973view=rev
Log:
Suppressing sending of Content-Length header at all times that it shouldn't be
sent (Content-Length 4GB and Transfer-Encoding:chunked).
IIS appears to provide a Content-Length header under some circumstances when
the chunk encoded request can be entirely decoded into the available buffer.
Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=50975
Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=1090973r1=1090972r2=1090973view=diff
==
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Mon Apr 11 08:23:46 2011
@@ -3209,22 +3209,27 @@ static int init_ws_service(isapi_private
}
else if (!strnicmp(tmp, CONTENT_LENGTH,
sizeof(CONTENT_LENGTH) - 1)) {
-if (need_content_length_header) {
-need_content_length_header = FALSE;
-/* If the content-length is unknown
- * or larger then 4Gb do not send it.
- */
-if (unknown_content_length || s-is_chunked) {
-if (JK_IS_DEBUG_LEVEL(logger)) {
-jk_log(logger, JK_LOG_DEBUG,
- Header Content-Length is %s,
- s-is_chunked ? chunked : unknown);
-}
-real_header = JK_FALSE;
+need_content_length_header = FALSE;
+
+/* If the content-length is unknown
+ * or larger then 4Gb do not send it.
+ * IIS can also create a synthetic Content-Length header
to make
+ * lpcbTotalBytes and the CONTENT_LENGTH server variable
agree
+ * on small requests where the entire chunk encoded
message is
+ * read into the available buffer.
+ */
+if (unknown_content_length || s-is_chunked) {
+if (JK_IS_DEBUG_LEVEL(logger)) {
+jk_log(logger, JK_LOG_DEBUG,
+ Disregarding Content-Length in request -
content is %s,
+ s-is_chunked ? chunked : unknown
length);
}
+cnt--;
+real_header = JK_FALSE;
}
-if (real_header)
+else {
s-headers_names[i] = tmp;
+}
}
else if (!strnicmp(tmp, TOMCAT_TRANSLATE_HEADER_NAME,
strlen(TOMCAT_TRANSLATE_HEADER_NAME))) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1090984 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
Author: timw
Date: Mon Apr 11 09:13:47 2011
New Revision: 1090984
URL: http://svn.apache.org/viewvc?rev=1090984view=rev
Log:
Fixing debug logging for forwarded headers to not crash, and to include
explicit Content-Length: 0 added for AJP13.
Modified:
tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=1090984r1=1090983r2=1090984view=diff
==
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Mon Apr 11 09:13:47 2011
@@ -3276,11 +3276,11 @@ static int init_ws_service(isapi_private
}
if (real_header) {
-i++;
if (JK_IS_DEBUG_LEVEL(logger)) {
jk_log(logger, JK_LOG_DEBUG, Forwarding request
header %s : %s,
s-headers_names[i], s-headers_values[i]);
}
+i++;
}
}
/* Add a content-length = 0 header if needed.
@@ -3288,6 +3288,9 @@ static int init_ws_service(isapi_private
* but non-zero length body.
*/
if (need_content_length_header) {
+if (JK_IS_DEBUG_LEVEL(logger)) {
+jk_log(logger, JK_LOG_DEBUG, Incoming request needs
explicit Content-Length: 0 in AJP13);
+}
s-headers_names[cnt] = Content-Length;
s-headers_values[cnt] = 0;
cnt++;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New connector sandbox
On 04/11/2011 09:00 AM, Konstantin Kolinko wrote: 2011/4/11 Mladen Turkmt...@apache.org: Hi, I plan to create a sandbox/connectors/native/iis7 for a native IIS7 C++ connector (since Microsoft deprecated ISAPI) Any objections? I do not mind. Though 1) Do you need those immediate levels? Will there be anything in them? Yes. Java part of the connector. IIS7 offers much more then just passing http requests. I guess the code will go into https://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis7/ when it becomes mature? Not sure. Httpd has mod_proxy_http/mod_proxy_ajp. Having a full (without normalizing functionality) IIS connector would cover MS world. Other servers are irrelevant IMHO (we only had former SunOne supported which is now named Oracle something ...) IMHO mod_jk has reached state where any further functionality improvement is limited by the protocol, and since there is no desire/need to invent a new protocol, and since initial mod_jk premise (runs in any web server) makes no sense in today's real world, mixing that with jk connectors makes no sense as well. Idea is to make a simple and robust connector that will work well inside IIS7 and allow .NET interoperability, working both standalone and probably inside Windows Azure. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47679] Not all headers get passed to Tomcat server from isapi_redirect.dll
https://issues.apache.org/bugzilla/show_bug.cgi?id=47679 Tim Whittington t...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #4 from Tim Whittington t...@apache.org 2011-04-11 05:36:20 EDT --- I've committed a fix for this. The ISAPI Redirector was assuming that it was always running in 'redirector' mode, where the filter part of the redirector was determining whether an incoming URL matched and forwarding that match to the extension part via magic HTTP headers. The extension code was not accounting for the 'legacy' mode of operation, where those headers were not present. The downside is an insignificant memory overhead on each request. Fix will be in 1.2.32 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50975] IIS connector times out on Transfer Encoded content, never sending the chunked content
https://issues.apache.org/bugzilla/show_bug.cgi?id=50975 Tim Whittington t...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #7 from Tim Whittington t...@apache.org 2011-04-11 05:39:19 EDT --- I've committed a fix similar to the one provided - thanks for providing a patch. Bug 48940 reported what I think is the same issue, with a similar analysis. I can't replicate the actual error case in my systems, although the analysis seems fairly conclusive, and the fix implemented is correct wrt interpretation of the HTTP RFC in any case. I've verified everything works fine if the Content-Length is (invalidly) included in the original request to IIS - e.g. the header is dropped before forwarding to Tomcat. Fix as implemented will be in 1.2.32. If anyone can reproduce the issue and is able to test, that'd be appreciated. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1090995 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Author: timw Date: Mon Apr 11 09:51:55 2011 New Revision: 1090995 URL: http://svn.apache.org/viewvc?rev=1090995view=rev Log: Updating changelog with fixes for 47679 and 50975 Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1090995r1=1090994r2=1090995view=diff == --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Mon Apr 11 09:51:55 2011 @@ -70,6 +70,18 @@ bug50339/bug: Fix whitespace trimming when parsing attribute lists. (rjung) /fix + fix +bug50975/bug: IIS: Fix hanging of Transfer-Encoding: chunked +requests when Content-Length header is present in request as well. +Also addresses situation where IIS appears to create a Content-Length +header for a small chunk encoded request when none was present in the +original request. (timw) + /fix + fix +bug47679/bug: IIS: stop truncation of request headers when +ISAPI redirector used as an extension without the corresponding +filter installed. (timw) + /fix /changelog /subsection /section - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51050] New: MIME types for m4a m4v files
https://issues.apache.org/bugzilla/show_bug.cgi?id=51050 Summary: MIME types for m4a m4v files Product: Tomcat 7 Version: 7.0.12 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: cedrik.l...@gmail.com Created an attachment (id=26874) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26874) Patch for additional common mpeg 4 mime types Tomcat correctly serves MPEG 4 files with a standardized file extension of .mp4, as video/mp4. Common but non-standard mpeg4 files also use of the extensions .m4a and .m4v, which are unknown to Tomcat and are therefore served without any Content-Type header. This behaviour leads Internet Explorer to display garbage when following a link to such a file. This patch adds the correct MIME type for MPEG 4 files with extensions m4a, m4b, m4r and m4v. (It omits the m4p extension, which is both not widely used, and of limited interest since the data is encrypted.) References: http://tools.ietf.org/html/rfc4337 http://en.wikipedia.org/wiki/MPEG-4_Part_14#.MP4_versus_.M4A_filename_extensions -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1086706 - in /tomcat/trunk/java/org/apache/catalina: Realm.java authenticator/SpnegoAuthenticator.java realm/CombinedRealm.java realm/LocalStrings.properties realm/LockOutRealm.java r
On 4/7/2011 7:14 PM, Konstantin Kolinko wrote:
2011/4/8 Filip Hanik - Dev Listsdevli...@hanik.com:
On 3/29/2011 2:05 PM, ma...@apache.org wrote:
+ * @param certs The gssContext processed by the {@link
Authenticator}.
+ */
+public Principal authenticate(GSSContext gssContext);
+
+
we can continue to add methods and changing the interface, or we can do what
most other systems do
public Principal authenticate(Object auth);
Good idea.
Just Object, or some marker interface?
I'd do just object,
Filip
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1209 / Virus Database: 1500/3560 - Release Date: 04/08/11
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 36155] tomcat chooses wrong host if using mod_jk
https://issues.apache.org/bugzilla/show_bug.cgi?id=36155 Tim Whittington t...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #26 from Tim Whittington t...@apache.org 2011-04-11 16:23:08 EDT --- I think this is as fixed as it's ever going to get (and the connectors have moved on a lot since this was raised). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 36362] missing check for Java reserved keywords in tag file processing
https://issues.apache.org/bugzilla/show_bug.cgi?id=36362 --- Comment #2 from erickso...@yahoo.com 2011-04-11 16:43:20 EDT --- I couldn't find anything in the specification that requires attribute names to be valid Java identifiers, or prohibits them from being reserved Java keywords. I believe reserved words should be mangled to become valid Java identifiers, rather than resulting in a compilation error. A test case would be that a tag with an attribute named default should compile. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 36362] missing check for Java reserved keywords in tag file processing
https://issues.apache.org/bugzilla/show_bug.cgi?id=36362 --- Comment #3 from Mark Thomas ma...@apache.org 2011-04-11 18:32:08 EDT --- Yep, I was reading JSP.8.3 too quickly. I'll revert the 7.0.x fix and withdraw the patch proposals while I take a second look at this. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1091236 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
Author: markt
Date: Mon Apr 11 22:33:50 2011
New Revision: 1091236
URL: http://svn.apache.org/viewvc?rev=1091236view=rev
Log:
Revert fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36362
JSP.8.3 does not limit the name of attributes defined in tag files
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Parser.java?rev=1091236r1=1091235r2=1091236view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Parser.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Parser.java Mon Apr 11
22:33:50 2011
@@ -593,18 +593,6 @@ class Parser implements TagConstants {
*/
private void parseAttributeDirective(Node parent) throws JasperException {
Attributes attrs = parseAttributes();
-// JSP.8.3 says the variable created for each attribute must have the
-// same name as the attribute. Therefore, the names must be valid Java
-// identifiers
-if (attrs != null attrs.getLength() 0) {
-for (int i = 0; i attrs.getLength(); i++) {
-if (name.equals(attrs.getLocalName(i))
-!JspUtil.isJavaIdentifier(attrs.getValue(i))) {
-err.jspError(start, jsp.error.identifier,
-attrs.getValue(i));
-}
-}
-}
new Node.AttributeDirective(attrs, start, parent);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1091237 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Mon Apr 11 22:35:01 2011 New Revision: 1091237 URL: http://svn.apache.org/viewvc?rev=1091237view=rev Log: Withdraw invalid fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1091237r1=1091236r2=1091237view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Apr 11 22:35:01 2011 @@ -198,17 +198,3 @@ PATCHES PROPOSED TO BACKPORT: * Add StuckThreadDetectionValve https://github.com/sylvainlaurent/tomcat60/commit/252334f958877221ecb2dc64ee0fd12bb77e360b +1: slaurent - -* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36362 - Check that tag file attribute names use valid Java identifiers - http://svn.apache.org/viewvc?rev=1090766view=rev - +1: markt, kkolinko - -1: - kkolinko: 1) Message key jsp.error.identifier is too broad while the - message says about attributes only. What about %@variable% directives, - if we would implement the same check for their name-given or alias? - 2) By the way, one more restriction in JSP.11.1.1.1: The JSP - specification reserves names for methods and variables starting with - jsp, _jsp, jspx, and _jspx, in any combination of upper and lower case. - 3) I am OK with enabling this specific check unconditionally, because I - think it is already enforced when compiling a tag file. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1091238 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: markt Date: Mon Apr 11 22:35:36 2011 New Revision: 1091238 URL: http://svn.apache.org/viewvc?rev=1091238view=rev Log: Withdraw invalid fix Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1091238r1=1091237r2=1091238view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Apr 11 22:35:36 2011 @@ -62,14 +62,3 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=1088179view=rev +1: kkolinko, markt -1: - -* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=36362 - Check that tag file attribute names use valid Java identifiers - http://svn.apache.org/viewvc?rev=1090766view=rev - +1: markt - -1: kkolinko: - 1) It depends on JRE version. enum is not a keyword when running - with Java 1.4 - 2) I think it is already enforced, e.g. by java compiler when - compiling the generated java code. Thus I see no need for this - improvement in 5.5. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1091244 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Mon Apr 11 22:48:22 2011 New Revision: 1091244 URL: http://svn.apache.org/viewvc?rev=1091244view=rev Log: Needs re-thinking Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1091244r1=1091243r2=1091244view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Mon Apr 11 22:48:22 2011 @@ -77,10 +77,6 @@ Label JSP/tag file line and column numbers when reporting errors since it may not be immediately obvious what the numbers represent. (markt) /add - fix -bug36362/bug: Check that tag file attribute names are valid Java -identifiers. (markt) - /fix /changelog /subsection subsection name=Web applications - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 19 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.3-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-12042011.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-12042011.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-12042011.jar:/srv/gump/public/workspace/junit/dist/junit-12042011.jar:/srv/gump/public/workspace/junit/dist/junit-dep-12042011.ja r:/srv/gump/public/workspace/google-guava/target/guava-*[0-9T].jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.3-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:429: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.init(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:163) at org.apache.tools.ant.Task.perform(Task.java:347) at org.apache.tools.ant.Target.execute(Target.java:392) at org.apache.tools.ant.Target.performTasks(Target.java:413) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.Project.executeTarget(Project.java:1368) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at
